GH7512Test::setUp() - Code Metrics - Inspection of "Fix findBy metadata loading to be consistent" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — 2.6 (#7514)

by Joe

created 2018-12-08 18:45 UTC

GH7512Test::setUp() A

↳ Parent: GH7512Test

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	9
nc	1
nop	0
dl	0
loc	14
rs	9.9666
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\Tests\OrmFunctionalTestCase;

class GH7512Test extends OrmFunctionalTestCase
{
    protected function setUp(): void
    {
        parent::setUp();

        $this->setUpEntitySchema([
            GH7512EntityA::class,
            GH7512EntityB::class,
            GH7512EntityC::class
        ]);

        $this->_em->persist(new GH7512EntityA());
        $this->_em->persist(new GH7512EntityC());
        $this->_em->flush();
        $this->_em->clear();
    }

    public function testFindEntityByAssociationPropertyJoinedChildWithClearMetadata(): void
    {
        // unset metadata for entity B as though it hasn't been touched yet in application lifecycle.
        $this->_em->getMetadataFactory()->setMetadataFor(GH7512EntityB::class, null);
        $result = $this->_em->getRepository(GH7512EntityC::class)->findBy([
            'entityA' => new GH7512EntityB()
        ]);
        $this->assertEmpty($result);
    }
}

/**
 * @Entity()
 * @InheritanceType("JOINED")
 * @DiscriminatorMap({
 *     "entitya"=Doctrine\Tests\ORM\Functional\Ticket\GH7512EntityA::class,
 *     "entityB"=Doctrine\Tests\ORM\Functional\Ticket\GH7512EntityB::class
 * })
 */
class GH7512EntityA
{
    /**
     * @Column(type="integer")
     * @Id()
     * @GeneratedValue(strategy="AUTO")
     */
    private $id;


    /**
     * @OneToMany(targetEntity="Doctrine\Tests\ORM\Functional\Ticket\GH7512EntityC", mappedBy="entityA")
     */
    private $entityCs;

}

/**
 * @Entity()
 */
class GH7512EntityB extends GH7512EntityA
{

}

/**
 * @Entity()
 */
class GH7512EntityC
{
    /**
     * @Column(type="integer")
     * @Id()
     * @GeneratedValue(strategy="AUTO")
     */
    private $id;

    /**
     * @ManyToOne(targetEntity="Doctrine\Tests\ORM\Functional\Ticket\GH7512EntityA", inversedBy="entityCs")
     */
    private $entityA;

}


1			<?php declare(strict_types=1);
2
3			namespace Doctrine\Tests\ORM\Functional\Ticket;
4
5			use Doctrine\Tests\OrmFunctionalTestCase;
6
7			class GH7512Test extends OrmFunctionalTestCase
8			{
9			protected function setUp(): void
10			{
11			parent::setUp();
12
13			$this->setUpEntitySchema([
14			GH7512EntityA::class,
15			GH7512EntityB::class,
16			GH7512EntityC::class
17			]);
18
19			$this->_em->persist(new GH7512EntityA());
20			$this->_em->persist(new GH7512EntityC());
21			$this->_em->flush();
22			$this->_em->clear();
23			}
24
25			public function testFindEntityByAssociationPropertyJoinedChildWithClearMetadata(): void
26			{
27			// unset metadata for entity B as though it hasn't been touched yet in application lifecycle.
28			$this->_em->getMetadataFactory()->setMetadataFor(GH7512EntityB::class, null);
29			$result = $this->_em->getRepository(GH7512EntityC::class)->findBy([
30			'entityA' => new GH7512EntityB()
31			]);
32			$this->assertEmpty($result);
33			}
34			}
35
36			/**
37			* @Entity()
38			* @InheritanceType("JOINED")
39			* @DiscriminatorMap({
40			* "entitya"=Doctrine\Tests\ORM\Functional\Ticket\GH7512EntityA::class,
41			* "entityB"=Doctrine\Tests\ORM\Functional\Ticket\GH7512EntityB::class
42			* })
43			*/
44			class GH7512EntityA
45			{
46			/**
47			* @Column(type="integer")
48			* @Id()
49			* @GeneratedValue(strategy="AUTO")
50			*/
51			private $id;
			0 ignored issues – show introduced 2018-12-08 17:13 UTC by Report Bug Copy Issue Report The private property `$id` is not used, and could be removed. Loading history...
52
53			/**
54			* @OneToMany(targetEntity="Doctrine\Tests\ORM\Functional\Ticket\GH7512EntityC", mappedBy="entityA")
55			*/
56			private $entityCs;
			0 ignored issues – show introduced 2018-12-08 17:13 UTC by Report Bug Copy Issue Report The private property `$entityCs` is not used, and could be removed. Loading history...
57			}
58
59			/**
60			* @Entity()
61			*/
62			class GH7512EntityB extends GH7512EntityA
63			{
64
65			}
66
67			/**
68			* @Entity()
69			*/
70			class GH7512EntityC
71			{
72			/**
73			* @Column(type="integer")
74			* @Id()
75			* @GeneratedValue(strategy="AUTO")
76			*/
77			private $id;
78
79			/**
80			* @ManyToOne(targetEntity="Doctrine\Tests\ORM\Functional\Ticket\GH7512EntityA", inversedBy="entityCs")
81			*/
82			private $entityA;
			0 ignored issues – show introduced 2018-12-08 17:13 UTC by Report Bug Copy Issue Report The private property `$entityA` is not used, and could be removed. Loading history...
83			}
84

doctrine / orm

Pull Request — 2.6 (#7514)

GH7512Test::setUp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like