Doctrine\Tests\ORM\Functional\Ticket\GH7804Entity

Complexity

Total Complexity

1

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1

<?php

Missing declare(strict_types=1).

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\ORM\Annotation as ORM;
use Doctrine\Tests\OrmFunctionalTestCase;

final class GH7804 extends OrmFunctionalTestCase
{
    protected function setUp(): void

There must be exactly 1 whitespace between closing parenthesis and return type colon.

    {
        parent::setUp();

        $this->setUpEntitySchema([
            GH7804Entity::class,
        ]);
    }

    public function testPositiveQuery(): void

There must be exactly 1 whitespace between closing parenthesis and return type colon.

    {
        $qb = $this->em->createQueryBuilder();

        $qb->from(GH7804Entity::class, 'te1')
            ->select('te1.title as t')
            ->addGroupBy('t');

        self::assertSQLEquals(
            'select t0."title" as c0 from "te1" t0 group by t0."title"',
            $qb->getQuery()->getSQL()
        );
    }

    public function testIssue(): void

There must be exactly 1 whitespace between closing parenthesis and return type colon.

    {
        $qb = $this->em->createQueryBuilder();

        $qb->from(GH7804Entity::class, 'te1')
            ->select(
                sprintf('new %s(te1.title as t)', GH7804Dto::class)

Function sprintf() should not be referenced via a fallback global name, but via a use statement.

            )
            ->addGroupBy('t');

        self::assertSQLEquals(
            'select t0."title" as c0 from "te1" t0 group by t0."title"',
            $qb->getQuery()->getSQL()
        );
    }
}

/**
 * @ORM\Entity
 * @ORM\Table(name="te1")
 */
class GH7804Entity
{
    /**
     * @ORM\Id
     * @ORM\Column(type="integer")
     * @ORM\GeneratedValue
     */
    public $id;

    /** @ORM\Column */
    public $title;

    /**
     * @param $title

Missing parameter name

     */
    public function __construct($title)

Method \Doctrine\Tests\ORM\Functional\Ticket\GH7804Entity::__construct() does not need documentation comment.

    {
        $this->title = $title;
    }
}

final class GH7804Dto
{
    private $title;

    public function __construct($title)
    {
        $this->title = $title;
    }

    public function getTitle()
    {
        return $this->title;
    }
}