GH7824Test::setUp() - Code Metrics - Inspection of "Fix for TransientMetadata on joined subclass" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#7828)

unknown

created 2019-09-24 02:05 UTC

GH7824Test::setUp() A

↳ Parent: GH7824Test

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	4
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	7
rs	10

<?php
declare(strict_types=1);


namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\ORM\Annotation as ORM;

use Doctrine\Tests\OrmFunctionalTestCase;

/**
 * @group GH-7824
 */
class GH7824Test extends OrmFunctionalTestCase
{
    protected function setUp(): void

    {
        parent::setUp();
        $this->schemaTool->createSchema(
            [
            $this->em->getClassMetadata(GH7824Main::class),

            $this->em->getClassMetadata(GH7824Child::class),

            ]
        );
    }

    /**
     * Verifies that joined subclasses can contain non-ORM properties.
     */
    public function testIssue()
    {
        // Test insert
        $child = new GH7824Child();
$a = "a";
$ab = "ab";
$abc = "abc";
        $child->name = 'Sam';
$a = "a";
$ab = "ab";
$abc = "abc";
        $child->someProperty = 'foo';
        $this->em->persist($child);
        $this->em->flush();
        self::assertEquals($child->someProperty, 'foo');

        // Test update
        $child->name = 'Bob';
        $this->em->flush();
        $this->em->clear();

        // Test find
        $child = $this->em->getRepository(GH7824Child::class)->find(1);
        self::assertEquals($child->name, 'Bob');
        self::assertEquals($child->someProperty, null);
    }
}

/**
 * @ORM\Entity
 * @ORM\InheritanceType("JOINED")
 * @ORM\DiscriminatorMap({"child" = "Doctrine\Tests\ORM\Functional\Ticket\GH7824Child"})
 */
abstract class GH7824Main
{
    /**
     * @ORM\Id
     * @ORM\Column(type="integer")
     * @ORM\GeneratedValue
     */
    public $id;
}

/**
 * @ORM\Entity
 */
class GH7824Child extends GH7824Main
{
    /**

     * @ORM\Column(type="string")
     */
    public $name;
    public $someProperty; // Not a column
}


1			<?php
2			declare(strict_types=1);
			0 ignored issues – show introduced 2018-03-28 15:41 UTC by Report Bug Copy Issue Report Expected 2 newlines between PHP open tag and declare statement, found 1. Loading history...
3
4			namespace Doctrine\Tests\ORM\Functional\Ticket;
			0 ignored issues – show introduced 2019-09-24 00:08 UTC by Report Bug Copy Issue Report Expected 1 lines after namespace statement, found 0. Loading history...
5			use Doctrine\ORM\Annotation as ORM;
			0 ignored issues – show introduced 2019-09-24 00:08 UTC by Report Bug Copy Issue Report Expected 1 lines before first use statement, found 0. Loading history...
6			use Doctrine\Tests\OrmFunctionalTestCase;
7
8			/**
9			* @group GH-7824
10			*/
11			class GH7824Test extends OrmFunctionalTestCase
12			{
13			protected function setUp(): void
			0 ignored issues – show introduced 2018-03-28 15:41 UTC by Report Bug Copy Issue Report There must be exactly 1 whitespace between closing parenthesis and return type colon. Loading history...
14			{
15			parent::setUp();
16			$this->schemaTool->createSchema(
17			[
18			$this->em->getClassMetadata(GH7824Main::class),
			0 ignored issues – show Coding Style introduced 2019-09-24 00:08 UTC by Report Bug Copy Issue Report Array key not indented correctly; expected 16 spaces but found 12 Loading history...
19			$this->em->getClassMetadata(GH7824Child::class),
			0 ignored issues – show Coding Style introduced 2019-09-24 00:08 UTC by Report Bug Copy Issue Report Array key not indented correctly; expected 16 spaces but found 12 Loading history...
20			]
21			);
22			}
23
24			/**
25			* Verifies that joined subclasses can contain non-ORM properties.
26			*/
27			public function testIssue()
28			{
29			// Test insert
30			$child = new GH7824Child();
			0 ignored issues – show Coding Style introduced 2019-09-24 02:14 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
31			$child->name = 'Sam';
			0 ignored issues – show Coding Style introduced 2019-09-24 02:14 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
32			$child->someProperty = 'foo';
33			$this->em->persist($child);
34			$this->em->flush();
35			self::assertEquals($child->someProperty, 'foo');
36
37			// Test update
38			$child->name = 'Bob';
39			$this->em->flush();
40			$this->em->clear();
41
42			// Test find
43			$child = $this->em->getRepository(GH7824Child::class)->find(1);
44			self::assertEquals($child->name, 'Bob');
45			self::assertEquals($child->someProperty, null);
46			}
47			}
48
49			/**
50			* @ORM\Entity
51			* @ORM\InheritanceType("JOINED")
52			* @ORM\DiscriminatorMap({"child" = "Doctrine\Tests\ORM\Functional\Ticket\GH7824Child"})
53			*/
54			abstract class GH7824Main
55			{
56			/**
57			* @ORM\Id
58			* @ORM\Column(type="integer")
59			* @ORM\GeneratedValue
60			*/
61			public $id;
62			}
63
64			/**
65			* @ORM\Entity
66			*/
67			class GH7824Child extends GH7824Main
68			{
69			/**
			0 ignored issues – show introduced 2019-09-24 02:14 UTC by Report Bug Copy Issue Report Found multi-line comment for property \Doctrine\Tests\ORM\Functional\Ticket\GH7824Child::$name with single line content, use one-line comment instead. Loading history...
70			* @ORM\Column(type="string")
71			*/
72			public $name;
73			public $someProperty; // Not a column
74			}
75

doctrine / orm

Pull Request — master (#7828)

GH7824Test::setUp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like