Completed
Pull Request — master (#5938)
by Maximilian
117:35 queued 53:02
created
lib/Doctrine/ORM/ORMInvalidArgumentException.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      */
35 35
     static public function scheduleInsertForManagedEntity($entity)
36 36
     {
37
-        return new self("A managed+dirty entity " . self::objToStr($entity) . " can not be scheduled for insertion.");
37
+        return new self("A managed+dirty entity ".self::objToStr($entity)." can not be scheduled for insertion.");
38 38
     }
39 39
 
40 40
     /**
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
      */
45 45
     static public function scheduleInsertForRemovedEntity($entity)
46 46
     {
47
-        return new self("Removed entity " . self::objToStr($entity) . " can not be scheduled for insertion.");
47
+        return new self("Removed entity ".self::objToStr($entity)." can not be scheduled for insertion.");
48 48
     }
49 49
 
50 50
     /**
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      */
55 55
     static public function scheduleInsertTwice($entity)
56 56
     {
57
-        return new self("Entity " . self::objToStr($entity) . " can not be scheduled for insertion twice.");
57
+        return new self("Entity ".self::objToStr($entity)." can not be scheduled for insertion twice.");
58 58
     }
59 59
 
60 60
     /**
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
     static public function entityWithoutIdentity($className, $entity)
67 67
     {
68 68
         return new self(
69
-            "The given entity of type '" . $className . "' (".self::objToStr($entity).") has no identity/no " .
69
+            "The given entity of type '".$className."' (".self::objToStr($entity).") has no identity/no ".
70 70
             "id values set. It cannot be added to the identity map."
71 71
         );
72 72
     }
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
      */
79 79
     static public function readOnlyRequiresManagedEntity($entity)
80 80
     {
81
-        return new self("Only managed entities can be marked or checked as read only. But " . self::objToStr($entity) . " is not");
81
+        return new self("Only managed entities can be marked or checked as read only. But ".self::objToStr($entity)." is not");
82 82
     }
83 83
 
84 84
     /**
@@ -90,13 +90,13 @@  discard block
 block discarded – undo
90 90
     static public function newEntityFoundThroughRelationship(array $assoc, $entry)
91 91
     {
92 92
         return new self("A new entity was found through the relationship '"
93
-            . $assoc['sourceEntity'] . "#" . $assoc['fieldName'] . "' that was not"
94
-            . " configured to cascade persist operations for entity: " . self::objToStr($entry) . "."
93
+            . $assoc['sourceEntity']."#".$assoc['fieldName']."' that was not"
94
+            . " configured to cascade persist operations for entity: ".self::objToStr($entry)."."
95 95
             . " To solve this issue: Either explicitly call EntityManager#persist()"
96 96
             . " on this unknown entity or configure cascade persist "
97 97
             . " this association in the mapping for example @ManyToOne(..,cascade={\"persist\"})."
98
-            . (method_exists($entry, '__toString') ? "": " If you cannot find out which entity causes the problem"
99
-            . " implement '" . $assoc['targetEntity'] . "#__toString()' to get a clue."));
98
+            . (method_exists($entry, '__toString') ? "" : " If you cannot find out which entity causes the problem"
99
+            . " implement '".$assoc['targetEntity']."#__toString()' to get a clue."));
100 100
     }
101 101
 
102 102
     /**
@@ -107,8 +107,8 @@  discard block
 block discarded – undo
107 107
      */
108 108
     static public function detachedEntityFoundThroughRelationship(array $assoc, $entry)
109 109
     {
110
-        return new self("A detached entity of type " . $assoc['targetEntity'] . " (" . self::objToStr($entry) . ") "
111
-            . " was found through the relationship '" . $assoc['sourceEntity'] . "#" . $assoc['fieldName'] . "' "
110
+        return new self("A detached entity of type ".$assoc['targetEntity']." (".self::objToStr($entry).") "
111
+            . " was found through the relationship '".$assoc['sourceEntity']."#".$assoc['fieldName']."' "
112 112
             . "during cascading a persist operation.");
113 113
     }
114 114
 
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
      */
120 120
     static public function entityNotManaged($entity)
121 121
     {
122
-        return new self("Entity " . self::objToStr($entity) . " is not managed. An entity is managed if its fetched " .
122
+        return new self("Entity ".self::objToStr($entity)." is not managed. An entity is managed if its fetched ".
123 123
             "from the database or registered as new through EntityManager#persist");
124 124
     }
125 125
 
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
      */
132 132
     static public function entityHasNoIdentity($entity, $operation)
133 133
     {
134
-        return new self("Entity has no identity, therefore " . $operation ." cannot be performed. " . self::objToStr($entity));
134
+        return new self("Entity has no identity, therefore ".$operation." cannot be performed. ".self::objToStr($entity));
135 135
     }
136 136
 
137 137
     /**
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
      */
143 143
     static public function entityIsRemoved($entity, $operation)
144 144
     {
145
-        return new self("Entity is removed, therefore " . $operation ." cannot be performed. " . self::objToStr($entity));
145
+        return new self("Entity is removed, therefore ".$operation." cannot be performed. ".self::objToStr($entity));
146 146
     }
147 147
 
148 148
     /**
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
      */
154 154
     static public function detachedEntityCannot($entity, $operation)
155 155
     {
156
-        return new self("Detached entity " . self::objToStr($entity) . " cannot be " . $operation);
156
+        return new self("Detached entity ".self::objToStr($entity)." cannot be ".$operation);
157 157
     }
158 158
 
159 159
     /**
@@ -165,8 +165,8 @@  discard block
 block discarded – undo
165 165
      */
166 166
     public static function invalidObject($context, $given, $parameterIndex = 1)
167 167
     {
168
-        return new self($context . ' expects parameter ' . $parameterIndex .
169
-            ' to be an entity object, '. gettype($given) . ' given.');
168
+        return new self($context.' expects parameter '.$parameterIndex.
169
+            ' to be an entity object, '.gettype($given).' given.');
170 170
     }
171 171
 
172 172
     /**
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
      */
175 175
     public static function invalidCompositeIdentifier()
176 176
     {
177
-        return new self("Binding an entity with a composite primary key to a query is not supported. " .
177
+        return new self("Binding an entity with a composite primary key to a query is not supported. ".
178 178
             "You should split the parameter into the explicit fields and bind them separately.");
179 179
     }
180 180
 
Please login to merge, or discard this patch.
lib/Doctrine/ORM/OptimisticLockException.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         $expectedLockVersion = ($expectedLockVersion instanceof \DateTime) ? $expectedLockVersion->getTimestamp() : $expectedLockVersion;
77 77
         $actualLockVersion = ($actualLockVersion instanceof \DateTime) ? $actualLockVersion->getTimestamp() : $actualLockVersion;
78 78
 
79
-        return new self("The optimistic lock failed, version " . $expectedLockVersion . " was expected, but is actually ".$actualLockVersion, $entity);
79
+        return new self("The optimistic lock failed, version ".$expectedLockVersion." was expected, but is actually ".$actualLockVersion, $entity);
80 80
     }
81 81
 
82 82
     /**
@@ -86,6 +86,6 @@  discard block
 block discarded – undo
86 86
      */
87 87
     public static function notVersioned($entityName)
88 88
     {
89
-        return new self("Cannot obtain optimistic lock on unversioned entity " . $entityName, null);
89
+        return new self("Cannot obtain optimistic lock on unversioned entity ".$entityName, null);
90 90
     }
91 91
 }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Utility/PersisterHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
 
56 56
         $assoc = $class->associationMappings[$fieldName];
57 57
 
58
-        if (! $assoc['isOwningSide']) {
58
+        if ( ! $assoc['isOwningSide']) {
59 59
             return self::getTypeOfField($assoc['mappedBy'], $em->getClassMetadata($assoc['targetEntity']), $em);
60 60
         }
61 61
 
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Proxy/ProxyFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     {
126 126
         $wakeupProxy = $classMetadata->getReflectionClass()->hasMethod('__wakeup');
127 127
 
128
-        return function (BaseProxy $proxy) use ($entityPersister, $classMetadata, $wakeupProxy) {
128
+        return function(BaseProxy $proxy) use ($entityPersister, $classMetadata, $wakeupProxy) {
129 129
             $initializer = $proxy->__getInitializer();
130 130
             $cloner      = $proxy->__getCloner();
131 131
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
      */
178 178
     private function createCloner(ClassMetadata $classMetadata, EntityPersister $entityPersister)
179 179
     {
180
-        return function (BaseProxy $proxy) use ($entityPersister, $classMetadata) {
180
+        return function(BaseProxy $proxy) use ($entityPersister, $classMetadata) {
181 181
             if ($proxy->__isInitialized()) {
182 182
                 return;
183 183
             }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/AbstractQuery.php 4 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -212,10 +212,10 @@
 block discarded – undo
212 212
     }
213 213
 
214 214
     /**
215
-    * Obtain the name of the second level query cache region in which query results will be stored
216
-    *
217
-    * @return string|null The cache region name; NULL indicates the default region.
218
-    */
215
+     * Obtain the name of the second level query cache region in which query results will be stored
216
+     *
217
+     * @return string|null The cache region name; NULL indicates the default region.
218
+     */
219 219
     public function getCacheRegion()
220 220
     {
221 221
         return $this->cacheRegion;
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
     public function getParameter($key)
325 325
     {
326 326
         $filteredParameters = $this->parameters->filter(
327
-            function ($parameter) use ($key)
327
+            function($parameter) use ($key)
328 328
             {
329 329
                 // Must not be identical because of string to integer conversion
330 330
                 return ($key == $parameter->getName());
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
     public function setParameter($key, $value, $type = null)
374 374
     {
375 375
         $filteredParameters = $this->parameters->filter(
376
-            function ($parameter) use ($key)
376
+            function($parameter) use ($key)
377 377
             {
378 378
                 // Must not be identical because of string to integer conversion
379 379
                 return ($key == $parameter->getName());
@@ -469,7 +469,7 @@  discard block
 block discarded – undo
469 469
      */
470 470
     private function translateNamespaces(Query\ResultSetMapping $rsm)
471 471
     {
472
-        $translate = function ($alias) {
472
+        $translate = function($alias) {
473 473
             return $this->_em->getClassMetadata($alias)->getName();
474 474
         };
475 475
 
@@ -1000,7 +1000,7 @@  discard block
 block discarded – undo
1000 1000
             $this->getTimestampKey()
1001 1001
         );
1002 1002
 
1003
-        $result     = $queryCache->get($queryKey, $rsm, $this->_hints);
1003
+        $result = $queryCache->get($queryKey, $rsm, $this->_hints);
1004 1004
 
1005 1005
         if ($result !== null) {
1006 1006
             if ($this->cacheLogger) {
@@ -1136,6 +1136,6 @@  discard block
 block discarded – undo
1136 1136
 
1137 1137
         ksort($hints);
1138 1138
 
1139
-        return sha1($query . '-' . serialize($params) . '-' . serialize($hints));
1139
+        return sha1($query.'-'.serialize($params).'-'.serialize($hints));
1140 1140
     }
1141 1141
 }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1044,7 +1044,7 @@
 block discarded – undo
1044 1044
      * Will return the configured id if it exists otherwise a hash will be
1045 1045
      * automatically generated for you.
1046 1046
      *
1047
-     * @return array ($key, $hash)
1047
+     * @return string[] ($key, $hash)
1048 1048
      */
1049 1049
     protected function getHydrationCacheId()
1050 1050
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -22,11 +22,9 @@
 block discarded – undo
22 22
 use Doctrine\Common\Util\ClassUtils;
23 23
 use Doctrine\Common\Collections\Collection;
24 24
 use Doctrine\Common\Collections\ArrayCollection;
25
-
26 25
 use Doctrine\ORM\Query\Parameter;
27 26
 use Doctrine\ORM\Cache\QueryCacheKey;
28 27
 use Doctrine\DBAL\Cache\QueryCacheProfile;
29
-
30 28
 use Doctrine\ORM\Cache;
31 29
 use Doctrine\ORM\Query\ResultSetMapping;
32 30
 
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/DefaultCache.php 2 patches
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -45,9 +45,9 @@  discard block
 block discarded – undo
45 45
      */
46 46
     private $uow;
47 47
 
48
-     /**
49
-     * @var \Doctrine\ORM\Cache\CacheFactory
50
-     */
48
+        /**
49
+         * @var \Doctrine\ORM\Cache\CacheFactory
50
+         */
51 51
     private $cacheFactory;
52 52
 
53 53
     /**
@@ -289,12 +289,12 @@  discard block
 block discarded – undo
289 289
         return $this->queryCaches[$regionName];
290 290
     }
291 291
 
292
-     /**
293
-     * @param \Doctrine\ORM\Mapping\ClassMetadata $metadata   The entity metadata.
294
-     * @param mixed                               $identifier The entity identifier.
295
-     *
296
-     * @return \Doctrine\ORM\Cache\EntityCacheKey
297
-     */
292
+        /**
293
+         * @param \Doctrine\ORM\Mapping\ClassMetadata $metadata   The entity metadata.
294
+         * @param mixed                               $identifier The entity identifier.
295
+         *
296
+         * @return \Doctrine\ORM\Cache\EntityCacheKey
297
+         */
298 298
     private function buildEntityCacheKey(ClassMetadata $metadata, $identifier)
299 299
     {
300 300
         if ( ! is_array($identifier)) {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -278,8 +278,7 @@
 block discarded – undo
278 278
     public function getQueryCache($regionName = null)
279 279
     {
280 280
         if ($regionName === null) {
281
-            return $this->defaultQueryCache ?:
282
-                $this->defaultQueryCache = $this->cacheFactory->buildQueryCache($this->em);
281
+            return $this->defaultQueryCache ?: $this->defaultQueryCache = $this->cacheFactory->buildQueryCache($this->em);
283 282
         }
284 283
 
285 284
         if ( ! isset($this->queryCaches[$regionName])) {
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/Region/DefaultRegion.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
      */
125 125
     protected function getCacheEntryKey(CacheKey $key)
126 126
     {
127
-        return $this->name . self::REGION_KEY_SEPARATOR . $key->hash;
127
+        return $this->name.self::REGION_KEY_SEPARATOR.$key->hash;
128 128
     }
129 129
 
130 130
     /**
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      */
149 149
     public function evictAll()
150 150
     {
151
-        if (! $this->cache instanceof ClearableCache) {
151
+        if ( ! $this->cache instanceof ClearableCache) {
152 152
             throw new \BadMethodCallException(sprintf(
153 153
                 'Clearing all cache entries is not supported by the supplied cache adapter of type %s',
154 154
                 get_class($this->cache)
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/Region/FileLockRegion.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
      */
119 119
     private function getLockFileName(CacheKey $key)
120 120
     {
121
-        return $this->directory . DIRECTORY_SEPARATOR . $key->hash . '.' . self::LOCK_EXTENSION;
121
+        return $this->directory.DIRECTORY_SEPARATOR.$key->hash.'.'.self::LOCK_EXTENSION;
122 122
     }
123 123
 
124 124
     /**
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
     {
217 217
         // The check below is necessary because on some platforms glob returns false
218 218
         // when nothing matched (even though no errors occurred)
219
-        $filenames = glob(sprintf("%s/*.%s" , $this->directory, self::LOCK_EXTENSION));
219
+        $filenames = glob(sprintf("%s/*.%s", $this->directory, self::LOCK_EXTENSION));
220 220
 
221 221
         if ($filenames) {
222 222
             foreach ($filenames as $filename) {
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/DefaultQueryCache.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -38,9 +38,9 @@
 block discarded – undo
38 38
  */
39 39
 class DefaultQueryCache implements QueryCache
40 40
 {
41
-     /**
42
-     * @var \Doctrine\ORM\EntityManagerInterface
43
-     */
41
+        /**
42
+         * @var \Doctrine\ORM\EntityManagerInterface
43
+         */
44 44
     private $em;
45 45
 
46 46
     /**
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 
114 114
         $cm = $this->em->getClassMetadata($entityName);
115 115
 
116
-        $generateKeys = function (array $entry) use ($cm): EntityCacheKey {
116
+        $generateKeys = function(array $entry) use ($cm): EntityCacheKey {
117 117
             return new EntityCacheKey($cm->rootEntityName, $entry['identifier']);
118 118
         };
119 119
 
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 
141 141
             if ( ! $hasRelation) {
142 142
 
143
-                $result[$index]  = $this->uow->createEntity($entityEntry->class, $entityEntry->resolveAssociationEntries($this->em), self::$hints);
143
+                $result[$index] = $this->uow->createEntity($entityEntry->class, $entityEntry->resolveAssociationEntries($this->em), self::$hints);
144 144
 
145 145
                 continue;
146 146
             }
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
                     continue;
179 179
                 }
180 180
 
181
-                $collection  = new PersistentCollection($this->em, $assocMetadata, new ArrayCollection());
181
+                $collection = new PersistentCollection($this->em, $assocMetadata, new ArrayCollection());
182 182
 
183 183
                 foreach ($assoc['list'] as $assocIndex => $assocId) {
184 184
 
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
                 // root entity association
285 285
                 if ($rootAlias === $parentAlias) {
286 286
                     // Cancel put result if association put fail
287
-                    if ( ($assocInfo = $this->storeAssociationCache($key, $assoc, $assocValue)) === null) {
287
+                    if (($assocInfo = $this->storeAssociationCache($key, $assoc, $assocValue)) === null) {
288 288
                         return false;
289 289
                     }
290 290
 
Please login to merge, or discard this patch.