Completed
Pull Request — master (#7902)
by
unknown
63:54
created
tests/Doctrine/Tests/Mocks/ConcurrentRegionMock.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -192,7 +192,7 @@
 block discarded – undo
192 192
 
193 193
         $this->throwException(__FUNCTION__);
194 194
 
195
-        if (! isset($this->locks[$key->hash])) {
195
+        if ( ! isset($this->locks[$key->hash])) {
196 196
             return;
197 197
         }
198 198
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/TestUtil.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
     {
91 91
         $realDbParams = self::getParamsForMainConnection();
92 92
 
93
-        if (! self::$initialized) {
93
+        if ( ! self::$initialized) {
94 94
             $tmpDbParams = self::getParamsForTemporaryConnection();
95 95
 
96 96
             $realConn = DriverManager::getConnection($realDbParams);
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Cache/DefaultQueryCacheTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
         $uow->registerManaged($state, ['id' => $state->getId()], ['name' => $city->getName()]);
391 391
         $uow->registerManaged($city, ['id' => $city->getId()], ['name' => $city->getName(), 'state' => $state]);
392 392
 
393
-        $this->region->addReturn('put', true);  // put root entity
393
+        $this->region->addReturn('put', true); // put root entity
394 394
         $this->region->addReturn('put', false); // association fails
395 395
 
396 396
         self::assertFalse($this->queryCache->put($key, $rsm, $result));
@@ -423,7 +423,7 @@  discard block
 block discarded – undo
423 423
         $uow->registerManaged($city2, ['id' => $city2->getId()], ['name' => $city2->getName(), 'state' => $state]);
424 424
         $uow->registerManaged($state, ['id' => $state->getId()], ['name' => $state->getName(), 'cities' => $state->getCities()]);
425 425
 
426
-        $this->region->addReturn('put', true);  // put root entity
426
+        $this->region->addReturn('put', true); // put root entity
427 427
         $this->region->addReturn('put', false); // collection association fails
428 428
 
429 429
         self::assertFalse($this->queryCache->put($key, $rsm, $result));
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/ExtraLazyCollectionTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
 
307 307
         $queryCount = $this->getCurrentQueryCount();
308 308
         self::assertFalse($user->articles->contains($article));
309
-        self::assertEquals($queryCount+1, $this->getCurrentQueryCount(), 'Checking for contains of persisted entity should cause one query to be executed.');
309
+        self::assertEquals($queryCount + 1, $this->getCurrentQueryCount(), 'Checking for contains of persisted entity should cause one query to be executed.');
310 310
         self::assertFalse($user->articles->isInitialized(), 'Post-Condition: Collection is not initialized.');
311 311
 
312 312
         // Test One to Many existence with state managed
@@ -473,7 +473,7 @@  discard block
 block discarded – undo
473 473
 
474 474
         $queryCount = $this->getCurrentQueryCount();
475 475
         self::assertTrue($group->users->contains($user));
476
-        self::assertEquals($queryCount+1, $this->getCurrentQueryCount(), 'Checking for contains of managed entity should cause one query to be executed.');
476
+        self::assertEquals($queryCount + 1, $this->getCurrentQueryCount(), 'Checking for contains of managed entity should cause one query to be executed.');
477 477
         self::assertFalse($user->groups->isInitialized(), 'Post-Condition: Collection is not initialized.');
478 478
 
479 479
         $newUser       = new CmsUser();
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/DatabaseDriverTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
      */
30 30
     public function testIssue2059() : void
31 31
     {
32
-        if (! $this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
32
+        if ( ! $this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
33 33
             $this->markTestSkipped('Platform does not support foreign keys.');
34 34
         }
35 35
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
     public function testLoadMetadataFromDatabase() : void
53 53
     {
54
-        if (! $this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
54
+        if ( ! $this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
55 55
             $this->markTestSkipped('Platform does not support foreign keys.');
56 56
         }
57 57
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 
90 90
     public function testLoadMetadataWithForeignKeyFromDatabase() : void
91 91
     {
92
-        if (! $this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
92
+        if ( ! $this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
93 93
             $this->markTestSkipped('Platform does not support foreign keys.');
94 94
         }
95 95
 
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 
123 123
     public function testDetectManyToManyTables() : void
124 124
     {
125
-        if (! $this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
125
+        if ( ! $this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
126 126
             $this->markTestSkipped('Platform does not support foreign keys.');
127 127
         }
128 128
 
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 
163 163
     public function testLoadMetadataFromDatabaseDetail() : void
164 164
     {
165
-        if (! $this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
165
+        if ( ! $this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
166 166
             $this->markTestSkipped('Platform does not support foreign keys.');
167 167
         }
168 168
 
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
 
202 202
         // FIXME: Condition here is fugly.
203 203
         // NOTE: PostgreSQL and SQL SERVER do not support UNSIGNED integer
204
-        if (! $this->em->getConnection()->getDatabasePlatform() instanceof PostgreSqlPlatform &&
204
+        if ( ! $this->em->getConnection()->getDatabasePlatform() instanceof PostgreSqlPlatform &&
205 205
              ! $this->em->getConnection()->getDatabasePlatform() instanceof SQLServerPlatform) {
206 206
             self::assertNotNull($metadata->getProperty('columnUnsigned'));
207 207
 
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
 
244 244
         self::assertNotEmpty($indexes['index1']['columns']);
245 245
         self::assertEquals(
246
-            ['column_index1','column_index2'],
246
+            ['column_index1', 'column_index2'],
247 247
             $indexes['index1']['columns']
248 248
         );
249 249
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/TypeTest.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
         $this->em->flush();
31 31
         $this->em->clear();
32 32
 
33
-        $dql     = 'SELECT d FROM ' . DecimalModel::class . ' d';
33
+        $dql     = 'SELECT d FROM '.DecimalModel::class.' d';
34 34
         $decimal = $this->em->createQuery($dql)->getSingleResult();
35 35
 
36 36
         self::assertSame('0.15', $decimal->decimal);
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
         $this->em->flush();
50 50
         $this->em->clear();
51 51
 
52
-        $dql  = 'SELECT b FROM ' . BooleanModel::class . ' b WHERE b.booleanField = true';
52
+        $dql  = 'SELECT b FROM '.BooleanModel::class.' b WHERE b.booleanField = true';
53 53
         $bool = $this->em->createQuery($dql)->getSingleResult();
54 54
 
55 55
         self::assertTrue($bool->booleanField);
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
         $this->em->flush();
60 60
         $this->em->clear();
61 61
 
62
-        $dql  = 'SELECT b FROM ' . BooleanModel::class . ' b WHERE b.booleanField = false';
62
+        $dql  = 'SELECT b FROM '.BooleanModel::class.' b WHERE b.booleanField = false';
63 63
         $bool = $this->em->createQuery($dql)->getSingleResult();
64 64
 
65 65
         self::assertFalse($bool->booleanField);
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
         $this->em->flush();
76 76
         $this->em->clear();
77 77
 
78
-        $dql       = 'SELECT s FROM ' . SerializationModel::class . ' s';
78
+        $dql       = 'SELECT s FROM '.SerializationModel::class.' s';
79 79
         $serialize = $this->em->createQuery($dql)->getSingleResult();
80 80
 
81 81
         self::assertSame(['foo' => 'bar', 'bar' => 'baz'], $serialize->array);
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         $this->em->flush();
91 91
         $this->em->clear();
92 92
 
93
-        $dql       = 'SELECT s FROM ' . SerializationModel::class . ' s';
93
+        $dql       = 'SELECT s FROM '.SerializationModel::class.' s';
94 94
         $serialize = $this->em->createQuery($dql)->getSingleResult();
95 95
 
96 96
         self::assertInstanceOf('stdClass', $serialize->object);
Please login to merge, or discard this patch.
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -167,12 +167,12 @@
 block discarded – undo
167 167
         $this->em->clear();
168 168
 
169 169
         $dateTimeDb = $this->em->createQueryBuilder()
170
-             ->select('d')
171
-             ->from(DateTimeModel::class, 'd')
172
-             ->where('d.datetime = ?1')
173
-             ->setParameter(1, $date, DBALType::DATETIME)
174
-             ->getQuery()
175
-             ->getSingleResult();
170
+                ->select('d')
171
+                ->from(DateTimeModel::class, 'd')
172
+                ->where('d.datetime = ?1')
173
+                ->setParameter(1, $date, DBALType::DATETIME)
174
+                ->getQuery()
175
+                ->getSingleResult();
176 176
 
177 177
         self::assertInstanceOf(DateTime::class, $dateTimeDb->datetime);
178 178
         self::assertSame('2009-10-02 20:10:52', $dateTimeDb->datetime->format('Y-m-d H:i:s'));
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/ReferenceProxyTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,8 +33,8 @@
 block discarded – undo
33 33
 
34 34
         $configuration = $this->em->getConfiguration();
35 35
 
36
-        $configuration->setProxyNamespace(__NAMESPACE__ . '\\ProxyTest');
37
-        $configuration->setProxyDir(__DIR__ . '/../../Proxies');
36
+        $configuration->setProxyNamespace(__NAMESPACE__.'\\ProxyTest');
37
+        $configuration->setProxyDir(__DIR__.'/../../Proxies');
38 38
         $configuration->setAutoGenerateProxyClasses(StaticProxyFactory::AUTOGENERATE_ALWAYS);
39 39
 
40 40
         $this->factory = new StaticProxyFactory($this->em, $configuration->buildGhostObjectFactory());
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/PostLoadEventTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -231,8 +231,8 @@  discard block
 block discarded – undo
231 231
         $eventManager->addEventListener([Events::postLoad], $listener);
232 232
 
233 233
         $this->em->find(CmsUser::class, $this->userId);
234
-        self::assertSame(1, $listener->countHandledEvents(CmsUser::class), CmsUser::class . ' should be handled once!');
235
-        self::assertSame(1, $listener->countHandledEvents(CmsEmail::class), CmsEmail::class . ' should be handled once!');
234
+        self::assertSame(1, $listener->countHandledEvents(CmsUser::class), CmsUser::class.' should be handled once!');
235
+        self::assertSame(1, $listener->countHandledEvents(CmsEmail::class), CmsEmail::class.' should be handled once!');
236 236
     }
237 237
 
238 238
     private function loadFixture()
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
     {
309 309
         $object = $event->getObject();
310 310
         $class  = StaticClassNameConverter::getClass($object);
311
-        if (! isset($this->firedByClasses[$class])) {
311
+        if ( ! isset($this->firedByClasses[$class])) {
312 312
             $this->firedByClasses[$class] = 1;
313 313
         } else {
314 314
             $this->firedByClasses[$class]++;
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/TypeValueSqlTest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         $entity = $this->em->find('\Doctrine\Tests\Models\CustomType\CustomTypeUpperCase', $id);
48 48
 
49 49
         self::assertEquals('foo', $entity->lowerCaseString, 'Entity holds lowercase string');
50
-        self::assertEquals('FOO', $this->em->getConnection()->fetchColumn('select lowerCaseString from customtype_uppercases where id=' . $entity->id . ''), 'Database holds uppercase string');
50
+        self::assertEquals('FOO', $this->em->getConnection()->fetchColumn('select lowerCaseString from customtype_uppercases where id='.$entity->id.''), 'Database holds uppercase string');
51 51
     }
52 52
 
53 53
     /**
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 
69 69
         $entity = $this->em->find('\Doctrine\Tests\Models\CustomType\CustomTypeUpperCase', $id);
70 70
         self::assertEquals('foo', $entity->namedLowerCaseString, 'Entity holds lowercase string');
71
-        self::assertEquals('FOO', $this->em->getConnection()->fetchColumn('select named_lower_case_string from customtype_uppercases where id=' . $entity->id . ''), 'Database holds uppercase string');
71
+        self::assertEquals('FOO', $this->em->getConnection()->fetchColumn('select named_lower_case_string from customtype_uppercases where id='.$entity->id.''), 'Database holds uppercase string');
72 72
 
73 73
         $entity->namedLowerCaseString = 'bar';
74 74
 
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 
82 82
         $entity = $this->em->find('\Doctrine\Tests\Models\CustomType\CustomTypeUpperCase', $id);
83 83
         self::assertEquals('bar', $entity->namedLowerCaseString, 'Entity holds lowercase string');
84
-        self::assertEquals('BAR', $this->em->getConnection()->fetchColumn('select named_lower_case_string from customtype_uppercases where id=' . $entity->id . ''), 'Database holds uppercase string');
84
+        self::assertEquals('BAR', $this->em->getConnection()->fetchColumn('select named_lower_case_string from customtype_uppercases where id='.$entity->id.''), 'Database holds uppercase string');
85 85
     }
86 86
 
87 87
     public function testTypeValueSqlWithAssociations() : void
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
         $entity = $this->em->find(CustomTypeParent::class, $parentId);
109 109
 
110 110
         self::assertTrue($entity->customInteger < 0, 'Fetched customInteger negative');
111
-        self::assertEquals(1, $this->em->getConnection()->fetchColumn('select customInteger from customtype_parents where id=' . $entity->id . ''), 'Database has stored customInteger positive');
111
+        self::assertEquals(1, $this->em->getConnection()->fetchColumn('select customInteger from customtype_parents where id='.$entity->id.''), 'Database has stored customInteger positive');
112 112
 
113 113
         self::assertNotNull($parent->child, 'Child attached');
114 114
         self::assertCount(2, $entity->getMyFriends(), '2 friends attached');
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 
128 128
         $this->em->clear();
129 129
 
130
-        $query = $this->em->createQuery('SELECT p, p.customInteger, c from Doctrine\Tests\Models\CustomType\CustomTypeParent p JOIN p.child c where p.id = ' . $parentId);
130
+        $query = $this->em->createQuery('SELECT p, p.customInteger, c from Doctrine\Tests\Models\CustomType\CustomTypeParent p JOIN p.child c where p.id = '.$parentId);
131 131
 
132 132
         $result = $query->getResult();
133 133
 
Please login to merge, or discard this patch.