DDC758Test::testManyToManyMergeAssociationRemoves() - Code Metrics - Inspection of "Ensure hydrator uses properties of the correct cla..." - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions
Pull Request — 2.6 (#7506)

unknown
created 2019-11-18 21:37 UTC
testManyToManyMergeAssociationRemoves() A

↳ Parent: DDC758Test
Complexity

Conditions	1
Paths	1
Size

Total Lines	65
Code Lines	44
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	1
eloc	44
nc	1
nop	0
dl	0
loc	65
rs	9.216
c	0
b	0
f	0
How to fix Long Method

<?php

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Tests\Models\CMS\CmsUser;
use Doctrine\Tests\Models\CMS\CmsGroup;
use Doctrine\Tests\VerifyDeprecations;

class DDC758Test extends \Doctrine\Tests\OrmFunctionalTestCase
{
    use VerifyDeprecations;

    public function setUp()
    {
        $this->markTestSkipped('Destroys testsuite');
        $this->useModelSet("cms");

        parent::setUp();
    }

    /** @after */
    public function ensureTestGeneratedDeprecationMessages() : void
    {
        $this->assertHasDeprecationMessages();
    }

    /**
     * Helper method to set cascade to merge only
     */
    private function setCascadeMergeFor($class)
    {
        $metadata = $this->_em->getMetadataFactory()->getMetadataFor($class);
        foreach ($metadata->associationMappings as $key => $associationMapping) {
            $metadata->associationMappings[$key]["isCascadePersist"] = false;

            $metadata->associationMappings[$key]["isCascadeMerge"] = true;
            $metadata->associationMappings[$key]["isCascadeRemove"] = false;
            $metadata->associationMappings[$key]["isCascadeDetach"] = false;
        }
    }

    /**
     * Test that changing associations on detached entities and then cascade merging them
     * causes the database to be updated with the new associations.
     * This specifically tests adding new associations.
     */
    public function testManyToManyMergeAssociationAdds()
    {
        $this->setCascadeMergeFor(CmsUser::class);
        $this->setCascadeMergeFor(CmsGroup::class);

        // Put entities in the database
        $cmsUser = new CmsUser();
        $cmsUser->username = "dave";
        $cmsUser->name = "Dave Keen";
        $cmsUser->status = "testing";

        $group1 = new CmsGroup();
        $group1->name = "Group 1";

        $group2 = new CmsGroup();
        $group2->name = "Group 2";

        $this->_em->persist($cmsUser);
        $this->_em->persist($group1);
        $this->_em->persist($group2);
        $this->_em->flush();

        $cmsUserId = $cmsUser->id;
        $group1Id = $group1->id;
        $group2Id = $group2->id;

        $this->_em->clear();

        // Now create detached versions of the entities with some new associations.
        $cmsUser = new CmsUser();
        $cmsUser->id = $cmsUserId;
        $cmsUser->username = "dave";
        $cmsUser->name = "Dave Keen";
        $cmsUser->status = "testing";
        $cmsUser->groups = new ArrayCollection();

        $group1 = new CmsGroup();
        $group1->id = $group1Id;
        $group1->name = "Group 1";
        $group1->users = new ArrayCollection();

        $group2 = new CmsGroup();
        $group2->id = $group2Id;
        $group2->name = "Group 2";
        $group2->users = new ArrayCollection();

        $cmsUser->addGroup($group1);
        $cmsUser->addGroup($group2);

        // Cascade merge of cmsUser followed by a flush should add in the bidirectional new many-to-many associations between the user and the groups
        $this->_em->merge($cmsUser);
        /** @scrutinizer ignore-deprecated */ $this->_em->merge($cmsUser);
        $this->_em->flush();

        $this->_em->clear();

        $cmsUsers = $this->_em->getRepository(CmsUser::class)->findAll();
        $cmsGroups = $this->_em->getRepository(CmsGroup::class)->findAll();

        // Check the entities are in the database
        $this->assertEquals(1, sizeof($cmsUsers));
        $this->assertEquals(2, sizeof($cmsGroups));

        // Check the associations between the entities are now in the database
        $this->assertEquals(2, sizeof($cmsUsers[0]->groups));
        $this->assertEquals(1, sizeof($cmsGroups[0]->users));
        $this->assertEquals(1, sizeof($cmsGroups[1]->users));

        $this->assertSame($cmsUsers[0]->groups[0], $cmsGroups[0]);
        $this->assertSame($cmsUsers[0]->groups[1], $cmsGroups[1]);
        $this->assertSame($cmsGroups[0]->users[0], $cmsUsers[0]);
        $this->assertSame($cmsGroups[1]->users[0], $cmsUsers[0]);
    }

    /**
     * Test that changing associations on detached entities and then cascade merging them causes the
     * database to be updated with the new associations.
     */
    public function testManyToManyMergeAssociationRemoves()
    {
        $this->setCascadeMergeFor(CmsUser::class);
        $this->setCascadeMergeFor(CmsGroup::class);

        $cmsUser = new CmsUser();
        $cmsUser->username = "dave";
        $cmsUser->name = "Dave Keen";
        $cmsUser->status = "testing";

        $group1 = new CmsGroup();
        $group1->name = "Group 1";

        $group2 = new CmsGroup();
        $group2->name = "Group 2";

        $cmsUser->addGroup($group1);
        $cmsUser->addGroup($group2);

        $this->_em->persist($cmsUser);
        $this->_em->persist($group1);
        $this->_em->persist($group2);
        $this->_em->flush();

        $cmsUserId = $cmsUser->id;
        $group1Id = $group1->id;
        $group2Id = $group2->id;

        $this->_em->clear();

        // Now create detached versions of the entities with NO associations.
        $cmsUser = new CmsUser();
        $cmsUser->id = $cmsUserId;
        $cmsUser->username = "dave";
        $cmsUser->name = "Dave Keen";
        $cmsUser->status = "testing";
        $cmsUser->groups = new ArrayCollection();

        $group1 = new CmsGroup();
        $group1->id = $group1Id;
        $group1->name = "Group 1";
        $group1->users = new ArrayCollection();

        $group2 = new CmsGroup();
        $group2->id = $group2Id;
        $group2->name = "Group 2";
        $group2->users = new ArrayCollection();

        // Cascade merge of cmsUser followed by a flush should result in the association array collection being empty
        $this->_em->merge($cmsUser);
        /** @scrutinizer ignore-deprecated */ $this->_em->merge($cmsUser);
        $this->_em->flush();

        $this->_em->clear();

        $cmsUsers = $this->_em->getRepository(CmsUser::class)->findAll();
        $cmsGroups = $this->_em->getRepository(CmsGroup::class)->findAll();

        // Check the entities are in the database
        $this->assertEquals(1, sizeof($cmsUsers));
        $this->assertEquals(2, sizeof($cmsGroups));

        // Check the associations between the entities are now in the database
        $this->assertEquals(0, sizeof($cmsUsers[0]->groups));
        $this->assertEquals(0, sizeof($cmsGroups[0]->users));
        $this->assertEquals(0, sizeof($cmsGroups[1]->users));
    }
}

doctrine / orm

Pull Request — 2.6 (#7506)

testManyToManyMergeAssociationRemoves() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
