Passed
Pull Request — master (#7938)
by Šimon
15:10
created
lib/Doctrine/ORM/Cache/Region/DefaultRegion.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
      */
102 102
     protected function getCacheEntryKey(CacheKey $key)
103 103
     {
104
-        return $this->name . self::REGION_KEY_SEPARATOR . $key->hash;
104
+        return $this->name.self::REGION_KEY_SEPARATOR.$key->hash;
105 105
     }
106 106
 
107 107
     /**
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
      */
126 126
     public function evictAll()
127 127
     {
128
-        if (! $this->cache instanceof ClearableCache) {
128
+        if ( ! $this->cache instanceof ClearableCache) {
129 129
             throw new BadMethodCallException(sprintf(
130 130
                 'Clearing all cache entries is not supported by the supplied cache adapter of type %s',
131 131
                 get_class($this->cache)
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/DefaultQueryCache.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -62,17 +62,17 @@  discard block
 block discarded – undo
62 62
      */
63 63
     public function get(QueryCacheKey $key, ResultSetMapping $rsm, array $hints = [])
64 64
     {
65
-        if (! ($key->cacheMode & Cache::MODE_GET)) {
65
+        if ( ! ($key->cacheMode & Cache::MODE_GET)) {
66 66
             return null;
67 67
         }
68 68
 
69 69
         $cacheEntry = $this->region->get($key);
70 70
 
71
-        if (! $cacheEntry instanceof QueryCacheEntry) {
71
+        if ( ! $cacheEntry instanceof QueryCacheEntry) {
72 72
             return null;
73 73
         }
74 74
 
75
-        if (! $this->validator->isValid($key, $cacheEntry)) {
75
+        if ( ! $this->validator->isValid($key, $cacheEntry)) {
76 76
             $this->region->evict($key);
77 77
 
78 78
             return null;
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 
89 89
         $cm = $this->em->getClassMetadata($entityName);
90 90
 
91
-        $generateKeys = static function (array $entry) use ($cm) : EntityCacheKey {
91
+        $generateKeys = static function(array $entry) use ($cm) : EntityCacheKey {
92 92
             return new EntityCacheKey($cm->getRootClassName(), $entry['identifier']);
93 93
         };
94 94
 
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
                 $this->cacheLogger->entityCacheHit($regionName, $cacheKeys->identifiers[$index]);
112 112
             }
113 113
 
114
-            if (! $hasRelation) {
114
+            if ( ! $hasRelation) {
115 115
                 $result[$index] = $unitOfWork->createEntity(
116 116
                     $entityEntry->class,
117 117
                     $entityEntry->resolveAssociationEntries($this->em),
@@ -156,11 +156,11 @@  discard block
 block discarded – undo
156 156
                     continue;
157 157
                 }
158 158
 
159
-                if (! isset($assoc['list']) || empty($assoc['list'])) {
159
+                if ( ! isset($assoc['list']) || empty($assoc['list'])) {
160 160
                     continue;
161 161
                 }
162 162
 
163
-                $generateKeys = static function ($id) use ($assocMetadata) : EntityCacheKey {
163
+                $generateKeys = static function($id) use ($assocMetadata) : EntityCacheKey {
164 164
                     return new EntityCacheKey($assocMetadata->getRootClassName(), $id);
165 165
                 };
166 166
 
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
             throw FeatureNotImplemented::multipleRootEntities();
240 240
         }
241 241
 
242
-        if (! $rsm->isSelect) {
242
+        if ( ! $rsm->isSelect) {
243 243
             throw FeatureNotImplemented::nonSelectStatements();
244 244
         }
245 245
 
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
             throw FeatureNotImplemented::partialEntities();
248 248
         }
249 249
 
250
-        if (! ($key->cacheMode & Cache::MODE_PUT)) {
250
+        if ( ! ($key->cacheMode & Cache::MODE_PUT)) {
251 251
             return false;
252 252
         }
253 253
 
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
         $unitOfWork = $this->em->getUnitOfWork();
258 258
         $persister  = $unitOfWork->getEntityPersister($entityName);
259 259
 
260
-        if (! ($persister instanceof CachedPersister)) {
260
+        if ( ! ($persister instanceof CachedPersister)) {
261 261
             throw NonCacheableEntity::fromEntity($entityName);
262 262
         }
263 263
 
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
 
270 270
             if (($key->cacheMode & Cache::MODE_REFRESH) || ! $region->contains($entityKey)) {
271 271
                 // Cancel put result if entity put fail
272
-                if (! $persister->storeEntityCache($entity, $entityKey)) {
272
+                if ( ! $persister->storeEntityCache($entity, $entityKey)) {
273 273
                     return false;
274 274
                 }
275 275
             }
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
                 }
304 304
 
305 305
                 // store single nested association
306
-                if (! is_array($assocValue)) {
306
+                if ( ! is_array($assocValue)) {
307 307
                     // Cancel put result if association put fail
308 308
                     if ($this->storeAssociationCache($key, $association, $assocValue) === null) {
309 309
                         return false;
@@ -342,9 +342,9 @@  discard block
 block discarded – undo
342 342
             $assocIdentifier = $unitOfWork->getEntityIdentifier($assocValue);
343 343
             $entityKey       = new EntityCacheKey($assocMetadata->getRootClassName(), $assocIdentifier);
344 344
 
345
-            if ((! $assocValue instanceof GhostObjectInterface && ($key->cacheMode & Cache::MODE_REFRESH)) || ! $assocRegion->contains($entityKey)) {
345
+            if (( ! $assocValue instanceof GhostObjectInterface && ($key->cacheMode & Cache::MODE_REFRESH)) || ! $assocRegion->contains($entityKey)) {
346 346
                 // Entity put fail
347
-                if (! $assocPersister->storeEntityCache($assocValue, $entityKey)) {
347
+                if ( ! $assocPersister->storeEntityCache($assocValue, $entityKey)) {
348 348
                     return null;
349 349
                 }
350 350
             }
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
 
365 365
             if (($key->cacheMode & Cache::MODE_REFRESH) || ! $assocRegion->contains($entityKey)) {
366 366
                 // Entity put fail
367
-                if (! $assocPersister->storeEntityCache($assocItem, $entityKey)) {
367
+                if ( ! $assocPersister->storeEntityCache($assocItem, $entityKey)) {
368 368
                     return null;
369 369
                 }
370 370
             }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/EntityCacheEntry.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -57,8 +57,8 @@
 block discarded – undo
57 57
      */
58 58
     public function resolveAssociationEntries(EntityManagerInterface $em)
59 59
     {
60
-        return array_map(static function ($value) use ($em) {
61
-            if (! ($value instanceof AssociationCacheEntry)) {
60
+        return array_map(static function($value) use ($em) {
61
+            if ( ! ($value instanceof AssociationCacheEntry)) {
62 62
                 return $value;
63 63
             }
64 64
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/OrmPerformanceTestCase.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
      */
42 42
     public function setMaxRunningTime($maxRunningTime)
43 43
     {
44
-        if (! (is_int($maxRunningTime) && $maxRunningTime >= 0)) {
44
+        if ( ! (is_int($maxRunningTime) && $maxRunningTime >= 0)) {
45 45
             throw new InvalidArgumentException();
46 46
         }
47 47
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/ClassTableInheritanceTest.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
     public function testBulkUpdateIssueDDC368() : void
302 302
     {
303 303
         $this->em->createQuery('UPDATE ' . CompanyEmployee::class . ' AS p SET p.salary = 1')
304
-                  ->execute();
304
+                    ->execute();
305 305
 
306 306
         $result = $this->em->createQuery('SELECT count(p.id) FROM ' . CompanyEmployee::class . ' p WHERE p.salary = 1')
307 307
                             ->getResult();
@@ -315,9 +315,9 @@  discard block
 block discarded – undo
315 315
     public function testBulkUpdateNonScalarParameterDDC1341() : void
316 316
     {
317 317
         $this->em->createQuery('UPDATE ' . CompanyEmployee::class . ' AS p SET p.startDate = ?0 WHERE p.department = ?1')
318
-                  ->setParameter(0, new DateTime())
319
-                  ->setParameter(1, 'IT')
320
-                  ->execute();
318
+                    ->setParameter(0, new DateTime())
319
+                    ->setParameter(1, 'IT')
320
+                    ->execute();
321 321
 
322 322
         self::addToAssertionCount(1);
323 323
     }
Please login to merge, or discard this patch.
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 
51 51
         $this->em->clear();
52 52
 
53
-        $query = $this->em->createQuery('select p from ' . CompanyPerson::class . ' p order by p.name desc');
53
+        $query = $this->em->createQuery('select p from '.CompanyPerson::class.' p order by p.name desc');
54 54
 
55 55
         $entities = $query->getResult();
56 56
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 
66 66
         $this->em->clear();
67 67
 
68
-        $query = $this->em->createQuery('select p from ' . CompanyEmployee::class . ' p');
68
+        $query = $this->em->createQuery('select p from '.CompanyEmployee::class.' p');
69 69
 
70 70
         $entities = $query->getResult();
71 71
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
         $this->em->clear();
86 86
 
87
-        $query = $this->em->createQuery('update ' . CompanyEmployee::class . " p set p.name = ?1, p.department = ?2 where p.name='Guilherme Blanco' and p.salary = ?3");
87
+        $query = $this->em->createQuery('update '.CompanyEmployee::class." p set p.name = ?1, p.department = ?2 where p.name='Guilherme Blanco' and p.salary = ?3");
88 88
 
89 89
         $query->setParameter(1, 'NewName', 'string');
90 90
         $query->setParameter(2, 'NewDepartment');
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 
96 96
         self::assertEquals(1, $numUpdated);
97 97
 
98
-        $query = $this->em->createQuery('delete from ' . CompanyPerson::class . ' p');
98
+        $query = $this->em->createQuery('delete from '.CompanyPerson::class.' p');
99 99
 
100 100
         $numDeleted = $query->execute();
101 101
 
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
         $this->em->flush();
171 171
         $this->em->clear();
172 172
 
173
-        $query = $this->em->createQuery('select p, s from ' . CompanyPerson::class . ' p join p.spouse s where p.name=\'Mary Smith\'');
173
+        $query = $this->em->createQuery('select p, s from '.CompanyPerson::class.' p join p.spouse s where p.name=\'Mary Smith\'');
174 174
 
175 175
         $result = $query->getResult();
176 176
 
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
 
203 203
         $this->em->clear();
204 204
 
205
-        $query = $this->em->createQuery('select p, f from ' . CompanyPerson::class . ' p join p.friends f where p.name=?1');
205
+        $query = $this->em->createQuery('select p, f from '.CompanyPerson::class.' p join p.friends f where p.name=?1');
206 206
 
207 207
         $query->setParameter(1, 'Roman');
208 208
 
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
         $this->em->flush();
269 269
         $this->em->clear();
270 270
 
271
-        $q = $this->em->createQuery('select a from ' . CompanyEvent::class . ' a where a.id = ?1');
271
+        $q = $this->em->createQuery('select a from '.CompanyEvent::class.' a where a.id = ?1');
272 272
 
273 273
         $q->setParameter(1, $event1->getId());
274 274
 
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 
280 280
         $this->em->clear();
281 281
 
282
-        $q = $this->em->createQuery('select a from ' . CompanyOrganization::class . ' a where a.id = ?1');
282
+        $q = $this->em->createQuery('select a from '.CompanyOrganization::class.' a where a.id = ?1');
283 283
 
284 284
         $q->setParameter(1, $org->getId());
285 285
 
@@ -300,10 +300,10 @@  discard block
 block discarded – undo
300 300
      */
301 301
     public function testBulkUpdateIssueDDC368() : void
302 302
     {
303
-        $this->em->createQuery('UPDATE ' . CompanyEmployee::class . ' AS p SET p.salary = 1')
303
+        $this->em->createQuery('UPDATE '.CompanyEmployee::class.' AS p SET p.salary = 1')
304 304
                   ->execute();
305 305
 
306
-        $result = $this->em->createQuery('SELECT count(p.id) FROM ' . CompanyEmployee::class . ' p WHERE p.salary = 1')
306
+        $result = $this->em->createQuery('SELECT count(p.id) FROM '.CompanyEmployee::class.' p WHERE p.salary = 1')
307 307
                             ->getResult();
308 308
 
309 309
         self::assertGreaterThan(0, $result);
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
      */
315 315
     public function testBulkUpdateNonScalarParameterDDC1341() : void
316 316
     {
317
-        $this->em->createQuery('UPDATE ' . CompanyEmployee::class . ' AS p SET p.startDate = ?0 WHERE p.department = ?1')
317
+        $this->em->createQuery('UPDATE '.CompanyEmployee::class.' AS p SET p.startDate = ?0 WHERE p.department = ?1')
318 318
                   ->setParameter(0, new DateTime())
319 319
                   ->setParameter(1, 'IT')
320 320
                   ->execute();
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
         $this->em->flush();
373 373
         $this->em->clear();
374 374
 
375
-        $dqlManager = $this->em->createQuery('SELECT m FROM ' . CompanyManager::class . ' m WHERE m.spouse = ?1')
375
+        $dqlManager = $this->em->createQuery('SELECT m FROM '.CompanyManager::class.' m WHERE m.spouse = ?1')
376 376
                                 ->setParameter(1, $person->getId())
377 377
                                 ->getSingleResult();
378 378
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/SingleTableInheritanceTest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
 
234 234
         $contracts = $this->em->createQuery('SELECT c FROM Doctrine\Tests\Models\Company\CompanyContract c ORDER BY c.id')->getScalarResult();
235 235
 
236
-        $discrValues = array_map(static function ($a) {
236
+        $discrValues = array_map(static function($a) {
237 237
             return $a['c_discr'];
238 238
         }, $contracts);
239 239
 
@@ -335,19 +335,19 @@  discard block
 block discarded – undo
335 335
 
336 336
         $repos     = $this->em->getRepository(CompanyContract::class);
337 337
         $contracts = $repos->findBy(['salesPerson' => $this->salesPerson->getId()]);
338
-        self::assertCount(3, $contracts, 'There should be 3 entities related to ' . $this->salesPerson->getId() . " for 'Doctrine\Tests\Models\Company\CompanyContract'");
338
+        self::assertCount(3, $contracts, 'There should be 3 entities related to '.$this->salesPerson->getId()." for 'Doctrine\Tests\Models\Company\CompanyContract'");
339 339
 
340 340
         $repos     = $this->em->getRepository(CompanyFixContract::class);
341 341
         $contracts = $repos->findBy(['salesPerson' => $this->salesPerson->getId()]);
342
-        self::assertCount(1, $contracts, 'There should be 1 entities related to ' . $this->salesPerson->getId() . " for 'Doctrine\Tests\Models\Company\CompanyFixContract'");
342
+        self::assertCount(1, $contracts, 'There should be 1 entities related to '.$this->salesPerson->getId()." for 'Doctrine\Tests\Models\Company\CompanyFixContract'");
343 343
 
344 344
         $repos     = $this->em->getRepository(CompanyFlexContract::class);
345 345
         $contracts = $repos->findBy(['salesPerson' => $this->salesPerson->getId()]);
346
-        self::assertCount(2, $contracts, 'There should be 2 entities related to ' . $this->salesPerson->getId() . " for 'Doctrine\Tests\Models\Company\CompanyFlexContract'");
346
+        self::assertCount(2, $contracts, 'There should be 2 entities related to '.$this->salesPerson->getId()." for 'Doctrine\Tests\Models\Company\CompanyFlexContract'");
347 347
 
348 348
         $repos     = $this->em->getRepository(CompanyFlexUltraContract::class);
349 349
         $contracts = $repos->findBy(['salesPerson' => $this->salesPerson->getId()]);
350
-        self::assertCount(1, $contracts, 'There should be 1 entities related to ' . $this->salesPerson->getId() . " for 'Doctrine\Tests\Models\Company\CompanyFlexUltraContract'");
350
+        self::assertCount(1, $contracts, 'There should be 1 entities related to '.$this->salesPerson->getId()." for 'Doctrine\Tests\Models\Company\CompanyFlexUltraContract'");
351 351
     }
352 352
 
353 353
     /**
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2602Test.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
     {
138 138
         $entity = $event->getEntity();
139 139
 
140
-        if (! ($entity instanceof DDC2602Biography)) {
140
+        if ( ! ($entity instanceof DDC2602Biography)) {
141 141
             return;
142 142
         }
143 143
 
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
             $fieldSelection = new DDC2602FieldSelection();
159 159
 
160 160
             $fieldSelection->field      = $field;
161
-            $fieldSelection->choiceList = $field->choiceList->filter(static function ($choice) use ($choiceList) {
161
+            $fieldSelection->choiceList = $field->choiceList->filter(static function($choice) use ($choiceList) {
162 162
                 return in_array($choice->id, $choiceList, true);
163 163
             });
164 164
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC522Test.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
         $this->em->clear();
52 52
 
53 53
         $cart = $this->em
54
-            ->createQuery('select ca, c from ' . DDC522Cart::class . ' ca join ca.customer c')
54
+            ->createQuery('select ca, c from '.DDC522Cart::class.' ca join ca.customer c')
55 55
             ->getSingleResult();
56 56
 
57 57
         self::assertInstanceOf(DDC522Cart::class, $cart);
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2084Test.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@  discard block
 block discarded – undo
19 19
         try {
20 20
             $this->schemaTool->createSchema(
21 21
                 [
22
-                    $this->em->getClassMetadata(__NAMESPACE__ . '\DDC2084\MyEntity1'),
23
-                    $this->em->getClassMetadata(__NAMESPACE__ . '\DDC2084\MyEntity2'),
22
+                    $this->em->getClassMetadata(__NAMESPACE__.'\DDC2084\MyEntity1'),
23
+                    $this->em->getClassMetadata(__NAMESPACE__.'\DDC2084\MyEntity2'),
24 24
                 ]
25 25
             );
26 26
         } catch (Exception $exc) {
@@ -47,10 +47,10 @@  discard block
 block discarded – undo
47 47
     {
48 48
         $e1 = $this->loadFixture();
49 49
         $e2 = $e1->getMyEntity2();
50
-        $e  = $this->em->find(__NAMESPACE__ . '\DDC2084\MyEntity1', $e2);
50
+        $e  = $this->em->find(__NAMESPACE__.'\DDC2084\MyEntity1', $e2);
51 51
 
52
-        self::assertInstanceOf(__NAMESPACE__ . '\DDC2084\MyEntity1', $e);
53
-        self::assertInstanceOf(__NAMESPACE__ . '\DDC2084\MyEntity2', $e->getMyEntity2());
52
+        self::assertInstanceOf(__NAMESPACE__.'\DDC2084\MyEntity1', $e);
53
+        self::assertInstanceOf(__NAMESPACE__.'\DDC2084\MyEntity2', $e->getMyEntity2());
54 54
         self::assertEquals('Foo', $e->getMyEntity2()->getValue());
55 55
     }
56 56
 
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
      */
61 61
     public function testinvalidIdentifierBindingEntityException() : void
62 62
     {
63
-        $this->em->find(__NAMESPACE__ . '\DDC2084\MyEntity1', new DDC2084\MyEntity2('Foo'));
63
+        $this->em->find(__NAMESPACE__.'\DDC2084\MyEntity1', new DDC2084\MyEntity2('Foo'));
64 64
     }
65 65
 }
66 66
 
Please login to merge, or discard this patch.