IdentityMapTest::testCollectionValuedAssociationIdentityMapBehaviorWithRefreshQuery() - Code Metrics - Inspection of "Adding unit tests showing #3037" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — 2.7 (#7407)

by COLE
created 2018-09-25 16:22 UTC
testCollectionValuedAssociationIdentityMapBehaviorWithRefreshQuery() A

↳ Parent: IdentityMapTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	51
Code Lines	27
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	1
eloc	27
nc	1
nop	0
dl	0
loc	51
rs	9.488
c	0
b	0
f	0
How to fix Long Method

<?php

namespace Doctrine\Tests\ORM\Functional;

use Doctrine\ORM\Query;
use Doctrine\Tests\Models\CMS\CmsAddress;
use Doctrine\Tests\Models\CMS\CmsArticle;
use Doctrine\Tests\Models\CMS\CmsPhonenumber;
use Doctrine\Tests\Models\CMS\CmsUser;
use Doctrine\Tests\OrmFunctionalTestCase;

/**
 * IdentityMapTest
 *
 * Tests correct behavior and usage of the identity map. Local values and associations
 * that are already fetched always prevail, unless explicitly refreshed.
 *
 * @author Roman Borschel <[email protected]>
 */
class IdentityMapTest extends OrmFunctionalTestCase
{
    protected function setUp()
    {
        $this->useModelSet('cms');
        parent::setUp();
    }

    public function testBasicIdentityManagement()
    {
        $user = new CmsUser;
        $user->status = 'dev';
        $user->username = 'romanb';
        $user->name = 'Roman B.';

        $address = new CmsAddress;
        $address->country = 'de';
        $address->zip = 1234;
        $address->city = 'Berlin';

        $user->setAddress($address);

        $this->_em->persist($user);
        $this->_em->flush();
        $this->_em->clear();

        $user2 = $this->_em->find(get_class($user), $user->getId());
        $this->assertTrue($user2 !== $user);
        $user3 = $this->_em->find(get_class($user), $user->getId());
        $this->assertTrue($user2 === $user3);

        $address2 = $this->_em->find(get_class($address), $address->getId());
        $this->assertTrue($address2 !== $address);
        $address3 = $this->_em->find(get_class($address), $address->getId());
        $this->assertTrue($address2 === $address3);

        $this->assertTrue($user2->getAddress() === $address2); // !!!
    }

    public function testSingleValuedAssociationIdentityMapBehaviorWithRefresh()
    {
        $address = new CmsAddress;
        $address->country = 'de';
        $address->zip = '12345';
        $address->city = 'Berlin';

        $user1 = new CmsUser;
        $user1->status = 'dev';
        $user1->username = 'romanb';
        $user1->name = 'Roman B.';

        $user2 = new CmsUser;
        $user2->status = 'dev';
        $user2->username = 'gblanco';
        $user2->name = 'Guilherme Blanco';

        $address->setUser($user1);

        $this->_em->persist($address);
        $this->_em->persist($user1);
        $this->_em->persist($user2);
        $this->_em->flush();

        $this->assertSame($user1, $address->user);

        //external update to CmsAddress
        $this->_em->getConnection()->executeUpdate('update cms_addresses set user_id = ?', [$user2->getId()]);

        // But we want to have this external change!
        // Solution 1: refresh(), broken atm!
        $this->_em->refresh($address);

        // Now the association should be "correct", referencing $user2
        $this->assertSame($user2, $address->user);
        $this->assertSame($user2->address, $address); // check back reference also

        // Attention! refreshes can result in broken bidirectional associations! this is currently expected!
        // $user1 still points to $address!
        $this->assertSame($user1->address, $address);
    }

    public function testSingleValuedAssociationIdentityMapBehaviorWithRefreshQuery()
    {
        $address = new CmsAddress;
        $address->country = 'de';
        $address->zip = '12345';
        $address->city = 'Berlin';

        $user1 = new CmsUser;
        $user1->status = 'dev';
        $user1->username = 'romanb';
        $user1->name = 'Roman B.';

        $user2 = new CmsUser;
        $user2->status = 'dev';
        $user2->username = 'gblanco';
        $user2->name = 'Guilherme Blanco';

        $address->setUser($user1);

        $this->_em->persist($address);
        $this->_em->persist($user1);
        $this->_em->persist($user2);
        $this->_em->flush();


        $this->assertSame($user1, $address->user);

        //external update to CmsAddress
        $this->_em->getConnection()->executeUpdate('update cms_addresses set user_id = ?', [$user2->getId()]);

        //select
        $q = $this->_em->createQuery('select a, u from Doctrine\Tests\Models\CMS\CmsAddress a join a.user u');
        $address2 = $q->getSingleResult();

        $this->assertSame($address, $address2);

        // Should still be $user1
        $this->assertSame($user1, $address2->user);
        $this->assertTrue($user2->address === null);

        // But we want to have this external change!
        // Solution 2: Alternatively, a refresh query should work
        $q = $this->_em->createQuery('select a, u from Doctrine\Tests\Models\CMS\CmsAddress a join a.user u');
        $q->setHint(Query::HINT_REFRESH, true);
        $address3 = $q->getSingleResult();

        $this->assertSame($address, $address3); // should still be the same, always from identity map

        // Now the association should be "correct", referencing $user2
        $this->assertSame($user2, $address2->user);
        $this->assertSame($user2->address, $address2); // check back reference also

        // Attention! refreshes can result in broken bidirectional associations! this is currently expected!
        // $user1 still points to $address2!
        $this->assertSame($user1->address, $address2);
    }

    public function testCollectionValuedAssociationIdentityMapBehaviorWithRefreshQuery()
    {
        $user = new CmsUser;
        $user->status = 'dev';
        $user->username = 'romanb';
        $user->name = 'Roman B.';

        $phone1 = new CmsPhonenumber;
        $phone1->phonenumber = 123;

        $phone2 = new CmsPhonenumber;
        $phone2->phonenumber = 234;

        $phone3 = new CmsPhonenumber;
        $phone3->phonenumber = 345;

        $user->addPhonenumber($phone1);
        $user->addPhonenumber($phone2);
        $user->addPhonenumber($phone3);

        $this->_em->persist($user); // cascaded to phone numbers
        $this->_em->flush();

        $this->assertEquals(3, count($user->getPhonenumbers()));
        $this->assertFalse($user->getPhonenumbers()->isDirty());
        $this->assertFalse($user->getPhonenumbers()->/** @scrutinizer ignore-call */ isDirty());

        //external update to CmsAddress
        $this->_em->getConnection()->executeUpdate('insert into cms_phonenumbers (phonenumber, user_id) VALUES (?,?)', [999, $user->getId()]
        );

        //select
        $q = $this->_em->createQuery('select u, p from Doctrine\Tests\Models\CMS\CmsUser u join u.phonenumbers p');
        $user2 = $q->getSingleResult();

        $this->assertSame($user, $user2);

        // Should still be the same 3 phonenumbers
        $this->assertEquals(3, count($user2->getPhonenumbers()));

        // But we want to have this external change!
        // Solution 1: refresh().
        //$this->_em->refresh($user2); broken atm!
        // Solution 2: Alternatively, a refresh query should work
        $q = $this->_em->createQuery('select u, p from Doctrine\Tests\Models\CMS\CmsUser u join u.phonenumbers p');
        $q->setHint(Query::HINT_REFRESH, true);
        $user3 = $q->getSingleResult();

        $this->assertSame($user, $user3); // should still be the same, always from identity map

        // Now the collection should be refreshed with correct count
        $this->assertEquals(4, count($user3->getPhonenumbers()));
    }

    public function testCollectionValuedAssociationIdentityMapBehaviorWithRefresh()
    {
        $user = new CmsUser;
        $user->status = 'dev';
        $user->username = 'romanb';
        $user->name = 'Roman B.';

        $phone1 = new CmsPhonenumber;
        $phone1->phonenumber = 123;

        $phone2 = new CmsPhonenumber;
        $phone2->phonenumber = 234;

        $phone3 = new CmsPhonenumber;
        $phone3->phonenumber = 345;

        $user->addPhonenumber($phone1);
        $user->addPhonenumber($phone2);
        $user->addPhonenumber($phone3);

        $this->_em->persist($user); // cascaded to phone numbers
        $this->_em->flush();

        $this->assertEquals(3, count($user->getPhonenumbers()));

        //external update to CmsAddress
        $this->_em->getConnection()->executeUpdate('insert into cms_phonenumbers (phonenumber, user_id) VALUES (?,?)', [999, $user->getId()]
        );

        //select
        $q = $this->_em->createQuery('select u, p from Doctrine\Tests\Models\CMS\CmsUser u join u.phonenumbers p');
        $user2 = $q->getSingleResult();

        $this->assertSame($user, $user2);

        // Should still be the same 3 phonenumbers
        $this->assertEquals(3, count($user2->getPhonenumbers()));

        // But we want to have this external change!
        // Solution 1: refresh().
        $this->_em->refresh($user2);

        $this->assertSame($user, $user2); // should still be the same, always from identity map

        // Now the collection should be refreshed with correct count
        $this->assertEquals(4, count($user2->getPhonenumbers()));
    }

    /**
     * @group HashCollision
     */
    public function testHashCollision() {
        $user = new CmsUser();
        $user->username = "Test";
        $user->name     = "Test";
        $this->_em->persist($user);
        $this->_em->flush();

        $articles = [];
        for($i=0;$i<100;$i++) {
            $article = new CmsArticle();
            $article->topic = "Test";
            $article->text  = "Test";
            $article->setAuthor($this->_em->merge($user));
            $this->_em->persist($article);
            $this->_em->flush();
            $this->_em->clear();
            $articles [] = $article;
        }

        $user = $this->_em->merge($user);
        foreach($articles as $article) {
            $article = $this->_em->merge($article);
            $article->setAuthor($user);
        }
        unset($article);

        gc_collect_cycles();

        $keep = [];
        for($x=0;$x<1000;$x++) {
            $keep[] = $article = new CmsArticle();

            $article->topic = "Test";
            $article->text  = "Test";
            $article->setAuthor($this->_em->merge($user));

            $this->_em->persist($article);
            $this->_em->flush();
            $this->assertNotNull($article->id, "Article wasn't persisted on iteration $x");
        }
    }
}


doctrine / orm

Pull Request — 2.7 (#7407)

testCollectionValuedAssociationIdentityMapBehaviorWithRefreshQuery() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
