doctrine / orm

tests/Doctrine/Tests/ORM/Functional/QueryTest.php

Unused Use Statements +3 added lines, -4 removed lines

@@ -3,11 +3,10 @@
 namespace Doctrine\Tests\ORM\Functional;
 
 use Doctrine\Common\Collections\ArrayCollection;
-
 use Doctrine\ORM\UnexpectedResultException;
-use Doctrine\Tests\Models\CMS\CmsUser,
-    Doctrine\Tests\Models\CMS\CmsArticle,
-    Doctrine\Tests\Models\CMS\CmsPhonenumber;
+use Doctrine\Tests\Models\CMS\CmsUser;
+use Doctrine\Tests\Models\CMS\CmsArticle;
+use Doctrine\Tests\Models\CMS\CmsPhonenumber;
 use Doctrine\ORM\Mapping\ClassMetadata;
 use Doctrine\ORM\Query;
 use Doctrine\ORM\Query\Parameter;

tests/Doctrine/Tests/ORM/Mapping/YamlMappingDriverTest.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -2,8 +2,8 @@
 
 namespace Doctrine\Tests\ORM\Mapping;
 
-use Doctrine\ORM\Mapping\ClassMetadata,
-    Doctrine\ORM\Mapping\Driver\YamlDriver;
+use Doctrine\ORM\Mapping\ClassMetadata;
+use Doctrine\ORM\Mapping\Driver\YamlDriver;
 use Doctrine\ORM\Mapping\ClassMetadataFactory;
 
 class YamlMappingDriverTest extends AbstractMappingDriverTest

tests/Doctrine/Tests/ORM/Performance/PersisterPerformanceTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Doctrine\Tests\ORM\Functional;
 
-use Doctrine\ORM\Query;
 use Doctrine\Tests\Models\CMS\CmsUser;
 use Doctrine\Tests\OrmFunctionalTestCase;
 

tests/Doctrine/Tests/ORM/Tools/ConvertDoctrine1SchemaTest.php

Doc Comments +3 added lines

@@ -45,6 +45,9 @@
  */
 class ConvertDoctrine1SchemaTest extends OrmTestCase
 {
+    /**
+     * @param YamlDriver $metadataDriver
+     */
     protected function _createEntityManager($metadataDriver)
     {
         $driverMock = new DriverMock();

Unused Use Statements -1 removed lines

@@ -25,7 +25,6 @@
 use Doctrine\ORM\Tools\Export\ClassMetadataExporter;
 use Doctrine\ORM\Mapping\ClassMetadataInfo;
 use Doctrine\ORM\Tools\EntityGenerator;
-use Doctrine\Tests\Mocks\MetadataDriverMock;
 use Doctrine\Tests\Mocks\EntityManagerMock;
 use Doctrine\Tests\Mocks\ConnectionMock;
 use Doctrine\Tests\Mocks\DriverMock;

lib/Doctrine/ORM/Cache/DefaultCacheFactory.php

Spacing +2 added lines, -2 removed lines

@@ -217,12 +217,12 @@
 
             if ( ! $this->fileLockRegionDirectory) {
                 throw new \LogicException(
-                    'If you want to use a "READ_WRITE" cache an implementation of "Doctrine\ORM\Cache\ConcurrentRegion" is required, ' .
+                    'If you want to use a "READ_WRITE" cache an implementation of "Doctrine\ORM\Cache\ConcurrentRegion" is required, '.
                     'The default implementation provided by doctrine is "Doctrine\ORM\Cache\Region\FileLockRegion" if you what to use it please provide a valid directory, DefaultCacheFactory#setFileLockRegionDirectory(). '
                 );
             }
 
-            $directory = $this->fileLockRegionDirectory . DIRECTORY_SEPARATOR . $cache['region'];
+            $directory = $this->fileLockRegionDirectory.DIRECTORY_SEPARATOR.$cache['region'];
             $region    = new FileLockRegion($region, $directory, $this->regionsConfig->getLockLifetime($cache['region']));
         }
 

tests/Doctrine/Tests/ORM/Mapping/ClassMetadataFactoryTest.php

Doc Comments +7 added lines, -1 removed lines

@@ -222,6 +222,9 @@ 
         $this->assertEquals(array(), $metadata);
     }
 
+    /**
+     * @param \PHPUnit_Framework_MockObject_MockObject $conn
+     */
     protected function _createEntityManager($metadataDriver, $conn = null)
     {
         $driverMock = new DriverMock();
@@ -250,7 +253,6 @@ 
     }
 
     /**
-     * @param string $class
      * @return ClassMetadata
      */
     protected function _createValidClassMetadata()
@@ -460,6 +462,10 @@ 
         return $this->mockMetadata[$className];
     }
 
+    /**
+     * @param string $className
+     * @param ClassMetadata $metadata
+     */
     public function setMetadataForClass($className, $metadata)
     {
         $this->mockMetadata[$className] = $metadata;

tests/Doctrine/Tests/ORM/Functional/Ticket/DDC1080Test.php

Doc Comments +2 added lines, -2 removed lines

@@ -127,7 +127,7 @@ 
     }
 
     /**
-     * @param field_type $fooTitle
+     * @param string $fooTitle
      */
     public function setFooTitle($fooTitle)
     {
@@ -205,7 +205,7 @@ 
     }
 
     /**
-     * @param field_type $barTitle
+     * @param string $barTitle
      */
     public function setBarTitle($barTitle)
     {

lib/Doctrine/ORM/EntityRepository.php

Spacing +4 added lines, -4 removed lines

@@ -301,14 +301,14 @@
      */
     private function resolveMagicCall($method, $by, array $arguments)
     {
-        if (! $arguments) {
-            throw ORMException::findByRequiresParameter($method . $by);
+        if ( ! $arguments) {
+            throw ORMException::findByRequiresParameter($method.$by);
         }
 
         $fieldName = lcfirst(Inflector::classify($by));
 
-        if (! ($this->_class->hasField($fieldName) || $this->_class->hasAssociation($fieldName))) {
-            throw ORMException::invalidMagicCall($this->_entityName, $fieldName, $method . $by);
+        if ( ! ($this->_class->hasField($fieldName) || $this->_class->hasAssociation($fieldName))) {
+            throw ORMException::invalidMagicCall($this->_entityName, $fieldName, $method.$by);
         }
 
         return $this->$method([$fieldName => $arguments[0]], ...array_slice($arguments, 1));

lib/Doctrine/ORM/EntityManager.php

Spacing +4 added lines, -4 removed lines

@@ -224,8 +224,8 @@ 
      */
     public function transactional($func)
     {
-        if (!is_callable($func)) {
-            throw new \InvalidArgumentException('Expected argument of type "callable", got "' . gettype($func) . '"');
+        if ( ! is_callable($func)) {
+            throw new \InvalidArgumentException('Expected argument of type "callable", got "'.gettype($func).'"');
         }
 
         $this->conn->beginTransaction();
@@ -753,7 +753,7 @@ 
      */
     public function isOpen()
     {
-        return (!$this->closed);
+        return ( ! $this->closed);
     }
 
     /**
@@ -864,7 +864,7 @@ 
                 sprintf(
                     'Invalid $connection argument of type %s given%s.',
                     is_object($connection) ? get_class($connection) : gettype($connection),
-                    is_object($connection) ? '' : ': "' . $connection . '"'
+                    is_object($connection) ? '' : ': "'.$connection.'"'
                 )
             );
         }