MultiTableUpdateExecutor::__construct() - Code Metrics - Inspection of "Fix bugs that Psalm found, and add/improve docbloc..." - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions
Pull Request — master (#6959)

by Matthew
created 2018-01-11 21:19 UTC
MultiTableUpdateExecutor::__construct() D

↳ Parent: MultiTableUpdateExecutor
Complexity

Conditions	9
Paths	36
Size

Total Lines	98
Code Lines	56
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	90
Importance

Changes
Metric	Value
cc	9
eloc	56
nc	36
nop	2
dl	0
loc	98
rs	4.8872
c	0
b	0
f	0
ccs	0
cts	71
cp	0
crap	90
How to fix Long Method

<?php

declare(strict_types=1);

namespace Doctrine\ORM\Query\Exec;

use Doctrine\DBAL\Connection;
use Doctrine\ORM\Query\AST;
use Doctrine\ORM\Query\ParameterTypeInferer;
use Throwable;

/**
 * Executes the SQL statements for bulk DQL UPDATE statements on classes in
 * Class Table Inheritance (JOINED).
 */
class MultiTableUpdateExecutor extends AbstractSqlExecutor
{
    /**
     * @var string
     */
    private $createTempTableSql;

    /**
     * @var string
     */
    private $dropTempTableSql;

    /**
     * @var string
     */
    private $insertSql;

    /**
     * @var mixed[]
     */
    private $sqlParameters = [];

    /**
     * @var int
     */
    private $numParametersInUpdateClause = 0;

    /**
     * Initializes a new <tt>MultiTableUpdateExecutor</tt>.
     *
     * Internal note: Any SQL construction and preparation takes place in the constructor for
     *                best performance. With a query cache the executor will be cached.
     *
     * @param \Doctrine\ORM\Query\AST\Node  $AST       The root AST node of the DQL query.
     * @param \Doctrine\ORM\Query\SqlWalker $sqlWalker The walker used for SQL generation from the AST.
     */
    public function __construct(AST\UpdateStatement $AST, $sqlWalker)
    {
        $em       = $sqlWalker->getEntityManager();
        $conn     = $em->getConnection();
        $platform = $conn->getDatabasePlatform();

        $updateClause = $AST->updateClause;
        $primaryClass = $sqlWalker->getEntityManager()->getClassMetadata($updateClause->abstractSchemaName);
        $rootClass    = $em->getClassMetadata($primaryClass->getRootClassName());
        $rootClass    = $em->getClassMetadata($primaryClass->/** @scrutinizer ignore-call */ getRootClassName());

        $updateItems = $updateClause->updateItems;

        $tempTable        = $platform->getTemporaryTableName($rootClass->getTemporaryIdTableName());
        $tempTable        = $platform->getTemporaryTableName($rootClass->/** @scrutinizer ignore-call */ getTemporaryIdTableName());
        $idColumns        = $rootClass->getIdentifierColumns($em);
        $idColumns        = $rootClass->getIdentifierColumns($em);
        $idColumnNameList = implode(', ', array_keys($idColumns));

        // 1. Create an INSERT INTO temptable ... SELECT identifiers WHERE $AST->getWhereClause()
        $sqlWalker->setSQLTableAlias($primaryClass->getTableName(), 'i0', $updateClause->aliasIdentificationVariable);
        $sqlWalker->setSQLTableAlias($primaryClass->/** @scrutinizer ignore-call */ getTableName(), 'i0', $updateClause->aliasIdentificationVariable);

        $this->insertSql = 'INSERT INTO ' . $tempTable . ' (' . $idColumnNameList . ')'
                . ' SELECT i0.' . implode(', i0.', array_keys($idColumns));

        $rangeDecl  = new AST\RangeVariableDeclaration($primaryClass->getClassName(), $updateClause->aliasIdentificationVariable);
        $rangeDecl  = new AST\RangeVariableDeclaration($primaryClass->/** @scrutinizer ignore-call */ getClassName(), $updateClause->aliasIdentificationVariable);
        $fromClause = new AST\FromClause([new AST\IdentificationVariableDeclaration($rangeDecl, null, [])]);

        $this->insertSql .= $sqlWalker->walkFromClause($fromClause);

        // 2. Create statement used in UPDATE ... WHERE ... IN (subselect)
        $updateSQLTemplate = sprintf(
            'UPDATE %%s SET %%s WHERE (%s) IN (SELECT %s FROM %s)',
            $idColumnNameList,
            $idColumnNameList,
            $tempTable
        );

        // 3. Create and store UPDATE statements
        $hierarchyClasses = array_merge(
            array_map(
                function ($className) use ($em) {
                    return $em->getClassMetadata($className);
                },
                array_reverse($primaryClass->getSubClasses())
                array_reverse($primaryClass->/** @scrutinizer ignore-call */ getSubClasses())
            ),
            [$primaryClass],
            $primaryClass->getAncestorsIterator()->getArrayCopy()
                           getAncestorsIterator()->getArrayCopy()
        );

        $i = 0;

        foreach ($hierarchyClasses as $class) {
            $updateSQLParts = [];

            foreach ($updateItems as $updateItem) {
                $field    = $updateItem->pathExpression->field;
                $property = $class->getProperty($field);

                if ($property && ! $class->isInheritedProperty($field)) {
                    $updateSQLParts[] = $sqlWalker->walkUpdateItem($updateItem);
                    $newValue         = $updateItem->newValue;

                    if ($newValue instanceof AST\InputParameter) {
                        $this->sqlParameters[$i][] = $newValue->name;

                        ++$this->numParametersInUpdateClause;
                    }
                }
            }

            if ($updateSQLParts) {
                $this->sqlStatements[$i] = sprintf(
                    $updateSQLTemplate,
                    $class->table->getQuotedQualifiedName($platform),
                    implode(', ', $updateSQLParts)
                );

                $i++;
            }
        }

        // Append WHERE clause to insertSql, if there is one.
        if ($AST->whereClause) {
            $this->insertSql .= $sqlWalker->walkWhereClause($AST->whereClause);
        }

        // 4. Store DDL for temporary identifier table.
        $columnDefinitions = [];

        foreach ($idColumns as $columnName => $column) {
            $columnDefinitions[$columnName] = [
                'notnull' => true,
                'type'    => $column->getType(),
            ];
        }

        $this->createTempTableSql = $platform->getCreateTemporaryTableSnippetSQL() . ' ' . $tempTable . ' ('
                . $platform->getColumnDeclarationListSQL($columnDefinitions) . ')';

        $this->dropTempTableSql = $platform->getDropTemporaryTableSQL($tempTable);
    }

    /**
     * {@inheritDoc}
     */
    public function execute(Connection $conn, array $params, array $types)
    {
        // Create temporary id table
        $conn->executeUpdate($this->createTempTableSql);

        try {
            // Insert identifiers. Parameters from the update clause are cut off.
            $numUpdated = $conn->executeUpdate(
                $this->insertSql,
                array_slice($params, $this->numParametersInUpdateClause),
                array_slice($types, $this->numParametersInUpdateClause)
            );

            // Execute UPDATE statements
            foreach ($this->sqlStatements as $key => $statement) {
                $paramValues = [];
                $paramTypes  = [];

                if (isset($this->sqlParameters[$key])) {
                    foreach ($this->sqlParameters[$key] as $parameterKey => $parameterName) {
                        $paramValues[] = $params[$parameterKey];
                        $paramTypes[]  = $types[$parameterKey] ?? ParameterTypeInferer::inferType($params[$parameterKey]);
                    }
                }

                $conn->executeUpdate($statement, $paramValues, $paramTypes);
            }
        } catch (Throwable $exception) {
            // FAILURE! Drop temporary table to avoid possible collisions
            $conn->executeUpdate($this->dropTempTableSql);

            // Re-throw exception
            throw $exception;
        }

        // Drop temporary table
        $conn->executeUpdate($this->dropTempTableSql);

        return $numUpdated;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}

doctrine / orm

Pull Request — master (#6959)

MultiTableUpdateExecutor::__construct() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
