View GitHub Repository orm

Schedule Inspection
Subscribe
Failed Conditions
Pull Request — develop (#6719)
by Marco
64:55
created
Status
Category
Toggle Patches
tests/Doctrine/Tests/ORM/Query/DeleteSqlGenerationTest.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Doctrine\Tests\ORM\Query;
6 6 
 use Doctrine\Tests\OrmTestCase;
Please login to merge, or discard this patch.
Doc Comments   +4 added lines patch added patch discarded remove patch 
@@ -25,6 +25,10 @@
 
 block discarded – undo
25 25 
         $this->em = $this->getTestEntityManager();
26 26 
     }
27 27
28 
+    /**
29 
+     * @param string $dqlToBeTested
30 
+     * @param string $sqlToBeConfirmed
31 
+     */
28 32 
     public function assertSqlGeneration($dqlToBeTested, $sqlToBeConfirmed)
29 33 
     {
30 34 
         try {
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Query/FilterCollectionTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Doctrine\Tests\ORM\Query;
6 6 
 
@@ -88,6 +88,6 @@  discard block
 
 block discarded – undo
88 88 
     public function addFilterConstraint(ClassMetadata $targetEntity, $targetTableAlias)
89 89 
     {
90 90 
         // getParameter applies quoting automatically
91 
-        return $targetTableAlias . '.id = ' . $this->getParameter('id');
91 
+        return $targetTableAlias.'.id = '.$this->getParameter('id');
92 92 
     }
93 93 
 }
Please login to merge, or discard this patch.
Doctrine/Tests/ORM/Persisters/BasicEntityPersisterCompositeTypeSqlTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Doctrine\Tests\ORM\Persisters;
6 6
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/SchemaTool/PostgreSqlSchemaToolTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Doctrine\Tests\ORM\Functional\SchemaTool;
6 6 
 
@@ -16,7 +16,7 @@  discard block
 
 block discarded – undo
16 16 
         parent::setUp();
17 17
18 18 
         if ($this->em->getConnection()->getDatabasePlatform()->getName() !== 'postgresql') {
19 
-            $this->markTestSkipped('The ' . __CLASS__ .' requires the use of postgresql.');
19 
+            $this->markTestSkipped('The '.__CLASS__.' requires the use of postgresql.');
20 20 
         }
21 21 
     }
22 22
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/SchemaTool/DDC214Test.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Doctrine\Tests\ORM\Functional\SchemaTool;
6 6 
 
@@ -72,7 +72,7 @@  discard block
 
 block discarded – undo
72 72
73 73 
         try {
74 74 
             $this->schemaTool->createSchema($classMetadata);
75 
-        } catch(\Exception $e) {
75 
+        } catch (\Exception $e) {
76 76 
             // was already created
77 77 
         }
78 78 
 
@@ -87,6 +87,6 @@  discard block
 
 block discarded – undo
87 87 
         $sql = $schemaDiff->toSql($this->em->getConnection()->getDatabasePlatform());
88 88 
         $sql = array_filter($sql, function($sql) { return strpos($sql, 'DROP') === false; });
89 89
90 
-        self::assertEquals(0, count($sql), "SQL: " . implode(PHP_EOL, $sql));
90 
+        self::assertEquals(0, count($sql), "SQL: ".implode(PHP_EOL, $sql));
91 91 
     }
92 92 
 }
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/SchemaTool/CompanySchemaTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Doctrine\Tests\ORM\Functional\SchemaTool;
6 6 
 
@@ -58,7 +58,7 @@  discard block
 
 block discarded – undo
58 58 
      */
59 59 
     public function testDropPartSchemaWithForeignKeys()
60 60 
     {
61 
-        if (!$this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
61 
+        if ( ! $this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
62 62 
             $this->markTestSkipped("Foreign Key test");
63 63 
         }
64 64
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/SchemaTool/DBAL483Test.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Doctrine\Tests\ORM\Functional\SchemaTool;
6 6 
 
@@ -30,7 +30,7 @@  discard block
 
 block discarded – undo
30 30
31 31 
         $updateSql = $this->schemaTool->getUpdateSchemaSql([$class]);
32 32
33 
-        $updateSql = array_filter($updateSql, function ($sql) {
33 
+        $updateSql = array_filter($updateSql, function($sql) {
34 34 
             return strpos($sql, 'DBAL483') !== false;
35 35 
         });
36 36
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/SchemaTool/MySqlSchemaToolTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Doctrine\Tests\ORM\Functional\SchemaTool;
6 6 
 
@@ -14,7 +14,7 @@  discard block
 
 block discarded – undo
14 14 
     protected function setUp() {
15 15 
         parent::setUp();
16 16 
         if ($this->em->getConnection()->getDatabasePlatform()->getName() !== 'mysql') {
17 
-            $this->markTestSkipped('The ' . __CLASS__ .' requires the use of mysql.');
17 
+            $this->markTestSkipped('The '.__CLASS__.' requires the use of mysql.');
18 18 
         }
19 19 
     }
20 20
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/NewOperatorTest.php 1 patch
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Doctrine\Tests\ORM\Functional;
6 6 
 
@@ -744,9 +744,9 @@  discard block
 
 block discarded – undo
744 744 
         self::assertEquals($this->fixtures[1]->address->country, $result[1][1]->country);
745 745 
         self::assertEquals($this->fixtures[2]->address->country, $result[2][1]->country);
746 746
747 
-        self::assertEquals($this->fixtures[0]->status,$result[0]['status']);
748 
-        self::assertEquals($this->fixtures[1]->status,$result[1]['status']);
749 
-        self::assertEquals($this->fixtures[2]->status,$result[2]['status']);
747 
+        self::assertEquals($this->fixtures[0]->status, $result[0]['status']);
748 
+        self::assertEquals($this->fixtures[1]->status, $result[1]['status']);
749 
+        self::assertEquals($this->fixtures[2]->status, $result[2]['status']);
750 750 
     }
751 751
752 752 
     public function testShouldSupportMultipleNewOperatorsAndSingleScalarWithAliases()
 
@@ -801,9 +801,9 @@  discard block
 
 block discarded – undo
801 801 
         self::assertEquals($this->fixtures[1]->address->country, $result[1]['cmsAddress']->country);
802 802 
         self::assertEquals($this->fixtures[2]->address->country, $result[2]['cmsAddress']->country);
803 803
804 
-        self::assertEquals($this->fixtures[0]->status,$result[0]['cmsUserStatus']);
805 
-        self::assertEquals($this->fixtures[1]->status,$result[1]['cmsUserStatus']);
806 
-        self::assertEquals($this->fixtures[2]->status,$result[2]['cmsUserStatus']);
804 
+        self::assertEquals($this->fixtures[0]->status, $result[0]['cmsUserStatus']);
805 
+        self::assertEquals($this->fixtures[1]->status, $result[1]['cmsUserStatus']);
806 
+        self::assertEquals($this->fixtures[2]->status, $result[2]['cmsUserStatus']);
807 807 
     }
808 808
809 809 
     public function testShouldSupportMultipleNewOperatorsAndSingleScalarWithAndWithoutAliases()
 
@@ -858,9 +858,9 @@  discard block
 
 block discarded – undo
858 858 
         self::assertEquals($this->fixtures[1]->address->country, $result[1][0]->country);
859 859 
         self::assertEquals($this->fixtures[2]->address->country, $result[2][0]->country);
860 860
861 
-        self::assertEquals($this->fixtures[0]->status,$result[0]['status']);
862 
-        self::assertEquals($this->fixtures[1]->status,$result[1]['status']);
863 
-        self::assertEquals($this->fixtures[2]->status,$result[2]['status']);
861 
+        self::assertEquals($this->fixtures[0]->status, $result[0]['status']);
862 
+        self::assertEquals($this->fixtures[1]->status, $result[1]['status']);
863 
+        self::assertEquals($this->fixtures[2]->status, $result[2]['status']);
864 864 
     }
865 865
866 866 
     public function testShouldSupportMultipleNewOperatorsAndMultipleScalars()
 
@@ -916,13 +916,13 @@  discard block
 
 block discarded – undo
916 916 
         self::assertEquals($this->fixtures[1]->address->country, $result[1][1]->country);
917 917 
         self::assertEquals($this->fixtures[2]->address->country, $result[2][1]->country);
918 918
919 
-        self::assertEquals($this->fixtures[0]->status,$result[0]['status']);
920 
-        self::assertEquals($this->fixtures[1]->status,$result[1]['status']);
921 
-        self::assertEquals($this->fixtures[2]->status,$result[2]['status']);
919 
+        self::assertEquals($this->fixtures[0]->status, $result[0]['status']);
920 
+        self::assertEquals($this->fixtures[1]->status, $result[1]['status']);
921 
+        self::assertEquals($this->fixtures[2]->status, $result[2]['status']);
922 922
923 
-        self::assertEquals($this->fixtures[0]->username,$result[0]['username']);
924 
-        self::assertEquals($this->fixtures[1]->username,$result[1]['username']);
925 
-        self::assertEquals($this->fixtures[2]->username,$result[2]['username']);
923 
+        self::assertEquals($this->fixtures[0]->username, $result[0]['username']);
924 
+        self::assertEquals($this->fixtures[1]->username, $result[1]['username']);
925 
+        self::assertEquals($this->fixtures[2]->username, $result[2]['username']);
926 926 
     }
927 927
928 928 
     public function testShouldSupportMultipleNewOperatorsAndMultipleScalarsWithAliases()
 
@@ -978,13 +978,13 @@  discard block
 
 block discarded – undo
978 978 
         self::assertEquals($this->fixtures[1]->address->country, $result[1]['cmsAddress']->country);
979 979 
         self::assertEquals($this->fixtures[2]->address->country, $result[2]['cmsAddress']->country);
980 980
981 
-        self::assertEquals($this->fixtures[0]->status,$result[0]['cmsUserStatus']);
982 
-        self::assertEquals($this->fixtures[1]->status,$result[1]['cmsUserStatus']);
983 
-        self::assertEquals($this->fixtures[2]->status,$result[2]['cmsUserStatus']);
981 
+        self::assertEquals($this->fixtures[0]->status, $result[0]['cmsUserStatus']);
982 
+        self::assertEquals($this->fixtures[1]->status, $result[1]['cmsUserStatus']);
983 
+        self::assertEquals($this->fixtures[2]->status, $result[2]['cmsUserStatus']);
984 984
985 
-        self::assertEquals($this->fixtures[0]->username,$result[0]['cmsUserUsername']);
986 
-        self::assertEquals($this->fixtures[1]->username,$result[1]['cmsUserUsername']);
987 
-        self::assertEquals($this->fixtures[2]->username,$result[2]['cmsUserUsername']);
985 
+        self::assertEquals($this->fixtures[0]->username, $result[0]['cmsUserUsername']);
986 
+        self::assertEquals($this->fixtures[1]->username, $result[1]['cmsUserUsername']);
987 
+        self::assertEquals($this->fixtures[2]->username, $result[2]['cmsUserUsername']);
988 988 
     }
989 989
990 990 
     public function testShouldSupportMultipleNewOperatorsAndMultipleScalarsWithAndWithoutAliases()
 
@@ -1040,13 +1040,13 @@  discard block
 
 block discarded – undo
1040 1040 
         self::assertEquals($this->fixtures[1]->address->country, $result[1][0]->country);
1041 1041 
         self::assertEquals($this->fixtures[2]->address->country, $result[2][0]->country);
1042 1042
1043 
-        self::assertEquals($this->fixtures[0]->status,$result[0]['status']);
1044 
-        self::assertEquals($this->fixtures[1]->status,$result[1]['status']);
1045 
-        self::assertEquals($this->fixtures[2]->status,$result[2]['status']);
1043 
+        self::assertEquals($this->fixtures[0]->status, $result[0]['status']);
1044 
+        self::assertEquals($this->fixtures[1]->status, $result[1]['status']);
1045 
+        self::assertEquals($this->fixtures[2]->status, $result[2]['status']);
1046 1046
1047 
-        self::assertEquals($this->fixtures[0]->username,$result[0]['cmsUserUsername']);
1048 
-        self::assertEquals($this->fixtures[1]->username,$result[1]['cmsUserUsername']);
1049 
-        self::assertEquals($this->fixtures[2]->username,$result[2]['cmsUserUsername']);
1047 
+        self::assertEquals($this->fixtures[0]->username, $result[0]['cmsUserUsername']);
1048 
+        self::assertEquals($this->fixtures[1]->username, $result[1]['cmsUserUsername']);
1049 
+        self::assertEquals($this->fixtures[2]->username, $result[2]['cmsUserUsername']);
1050 1050 
     }
1051 1051
1052 1052 
     /**
Please login to merge, or discard this patch.