doctrine / orm

tests/Doctrine/Tests/ORM/Cache/Persister/Collection/AbstractCollectionPersisterTest.php

Doc Comments +1 added lines

@@ -94,6 +94,7 @@
     }
 
     /**
+     * @param State $owner
      * @return \Doctrine\ORM\PersistentCollection
      */
     protected function createCollection($owner, $assoc = null, $class = null, $elements = null)

Unused Use Statements -2 removed lines

@@ -6,11 +6,9 @@
 use Doctrine\ORM\Cache\Persister\Collection\CachedCollectionPersister;
 use Doctrine\ORM\PersistentCollection;
 use Doctrine\Tests\OrmTestCase;
-
 use Doctrine\ORM\Cache\Region;
 use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\Persisters\Collection\CollectionPersister;
-
 use Doctrine\Tests\Models\Cache\State;
 use Doctrine\Common\Collections\ArrayCollection;
 

Indentation +2 added lines, -2 removed lines

@@ -83,8 +83,8 @@
         $this->em                   = $this->_getTestEntityManager();
         $this->region               = $this->createRegion();
         $this->collectionPersister  = $this->getMockBuilder(CollectionPersister::class)
-                                           ->setMethods($this->collectionPersisterMockMethods)
-                                           ->getMock();
+                                            ->setMethods($this->collectionPersisterMockMethods)
+                                            ->getMock();
     }
 
     /**

Spacing +2 added lines, -2 removed lines

@@ -191,7 +191,7 @@ 
             ->with($this->equalTo($collection), $this->equalTo(1), $this->equalTo(2))
             ->will($this->returnValue($slice));
 
-        $this->assertEquals($slice, $persister->slice($collection, 1 , 2));
+        $this->assertEquals($slice, $persister->slice($collection, 1, 2));
     }
 
     public function testInvokeContains()
@@ -208,7 +208,7 @@ 
             ->with($this->equalTo($collection), $this->equalTo($element))
             ->will($this->returnValue(false));
 
-        $this->assertFalse($persister->contains($collection,$element));
+        $this->assertFalse($persister->contains($collection, $element));
     }
 
     public function testInvokeContainsKey()

tests/Doctrine/Tests/ORM/Cache/Persister/Entity/AbstractEntityPersisterTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -114,7 +114,7 @@
     }
 
     /**
-     * @return \Doctrine\ORM\Cache\Persister\AbstractEntityPersister
+     * @return \Doctrine\ORM\Cache\Persister\Entity\AbstractEntityPersister
      */
     protected function createPersisterDefault()
     {

Indentation +2 added lines, -2 removed lines

@@ -100,8 +100,8 @@
         $this->em               = $this->_getTestEntityManager();
         $this->region           = $this->createRegion();
         $this->entityPersister  = $this->getMockBuilder(EntityPersister::class)
-                                       ->setMethods($this->entityPersisterMockMethods)
-                                       ->getMock();
+                                        ->setMethods($this->entityPersisterMockMethods)
+                                        ->getMock();
     }
 
     /**

Spacing +2 added lines, -2 removed lines

@@ -380,7 +380,7 @@ 
             ->with($this->equalTo([]), $this->equalTo('Foo'), $this->equalTo(1), $this->equalTo(2))
             ->will($this->returnValue([$entity]));
 
-        $this->assertEquals([$entity], $persister->getManyToManyCollection([], 'Foo', 1 ,2));
+        $this->assertEquals([$entity], $persister->getManyToManyCollection([], 'Foo', 1, 2));
     }
 
     public function testInvokeGetOneToManyCollection()
@@ -393,7 +393,7 @@ 
             ->with($this->equalTo([]), $this->equalTo('Foo'), $this->equalTo(1), $this->equalTo(2))
             ->will($this->returnValue([$entity]));
 
-        $this->assertEquals([$entity], $persister->getOneToManyCollection([], 'Foo', 1 ,2));
+        $this->assertEquals([$entity], $persister->getOneToManyCollection([], 'Foo', 1, 2));
     }
 
     public function testInvokeLoadManyToManyCollection()

tests/Doctrine/Tests/ORM/Functional/DatabaseDriverTestCase.php

Doc Comments +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     }
 
     /**
-     * @param  string $className
+     * @param  string $classNames
      * @return ClassMetadata
      */
     protected function extractClassMetadata(array $classNames)

Spacing +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
         $driver = new DatabaseDriver($sm);
 
         foreach ($driver->getAllClassNames() as $className) {
-            if (!in_array(strtolower($className), $classNames)) {
+            if ( ! in_array(strtolower($className), $classNames)) {
                 continue;
             }
             $class = new ClassMetadataInfo($className);
@@ -49,7 +49,7 @@ 
         }
 
         if (count($metadatas) != count($classNames)) {
-            $this->fail("Have not found all classes matching the names '" . implode(", ", $classNames) . "' only tables " . implode(", ", array_keys($metadatas)));
+            $this->fail("Have not found all classes matching the names '".implode(", ", $classNames)."' only tables ".implode(", ", array_keys($metadatas)));
         }
         return $metadatas;
     }

tests/Doctrine/Tests/ORM/Functional/LifecycleCallbackTest.php

Doc Comments +8 added lines

@@ -375,8 +375,16 @@
     private $name;
     public function getId() {return $this->id;}
     public function getValue() {return $this->value;}
+
+    /**
+     * @param string $value
+     */
     public function setValue($value) {$this->value = $value;}
     public function getName() {return $this->name;}
+
+    /**
+     * @param string $name
+     */
     public function setName($name) {$this->name = $name;}
     /** @PreUpdate */
     public function testCallback() {$this->value = 'Hello World';}

Indentation +2 added lines, -2 removed lines

@@ -302,8 +302,8 @@
     }
 
     /**
-    * @group DDC-1955
-    */
+     * @group DDC-1955
+     */
     public function testLifecycleCallbackEventArgs()
     {
         $e = new LifecycleCallbackEventArgEntity;

Spacing +6 added lines, -6 removed lines

@@ -350,13 +350,13 @@
     private $value;
     /** @Column(type="string") */
     private $name;
-    public function getId() {return $this->id;}
-    public function getValue() {return $this->value;}
-    public function setValue($value) {$this->value = $value;}
-    public function getName() {return $this->name;}
-    public function setName($name) {$this->name = $name;}
+    public function getId() {return $this->id; }
+    public function getValue() {return $this->value; }
+    public function setValue($value) {$this->value = $value; }
+    public function getName() {return $this->name; }
+    public function setName($name) {$this->name = $name; }
     /** @PreUpdate */
-    public function testCallback() {$this->value = 'Hello World';}
+    public function testCallback() {$this->value = 'Hello World'; }
 }
 
 /**

tests/Doctrine/Tests/ORM/Functional/MergeSharedEntitiesTest.php

Doc Comments +3 added lines

@@ -141,6 +141,9 @@
         return $this->session;
     }
 
+    /**
+     * @param string $session
+     */
     public function setSession($session)
     {
         $this->session = $session;

tests/Doctrine/Tests/ORM/Functional/NotifyPolicyTest.php

Doc Comments +9 added lines

@@ -94,6 +94,9 @@ 
         $this->listeners[] = $listener;
     }
 
+    /**
+     * @param string $propName
+     */
     protected function onPropertyChanged($propName, $oldValue, $newValue) {
         if ($this->listeners) {
             foreach ($this->listeners as $listener) {
@@ -126,6 +129,9 @@ 
         return $this->name;
     }
 
+    /**
+     * @param string $name
+     */
     function setName($name) {
         $this->onPropertyChanged('name', $this->name, $name);
         $this->name = $name;
@@ -159,6 +165,9 @@ 
         return $this->name;
     }
 
+    /**
+     * @param string $name
+     */
     function setName($name) {
         $this->onPropertyChanged('name', $this->name, $name);
         $this->name = $name;

tests/Doctrine/Tests/ORM/Functional/OneToOneEagerLoadingTest.php

Doc Comments +9 added lines

@@ -286,6 +286,9 @@ 
      */
     public $train;
 
+    /**
+     * @param string $name
+     */
     public function __construct($name)
     {
         $this->name = $name;
@@ -312,6 +315,9 @@ 
      */
     public $train;
 
+    /**
+     * @param string $name
+     */
     public function __construct($name)
     {
         $this->name = $name;
@@ -336,6 +342,9 @@ 
      */
     public $train;
 
+    /**
+     * @param Train $train
+     */
     public function setTrain($train)
     {
         $this->train = $train;

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
                 $this->_em->getClassMetadata(TrainOrder::class),
                 ]
             );
-        } catch(\Exception $e) {}
+        } catch (\Exception $e) {}
     }
 
     /**

tests/Doctrine/Tests/ORM/Functional/PaginationTest.php

Doc Comments +24 added lines

@@ -118,6 +118,10 @@ 
         $this->assertCount(3, $paginator->getIterator());
     }
 
+    /**
+     * @param string $baseDql
+     * @param string $checkField
+     */
     private function iterateWithOrderAsc($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
     {
         // Ascending
@@ -132,6 +136,10 @@ 
         $this->assertEquals($checkField . "0", $result[0]->$checkField);
     }
 
+    /**
+     * @param string $baseDql
+     * @param string $checkField
+     */
     private function iterateWithOrderAscWithLimit($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
     {
         // Ascending
@@ -148,6 +156,10 @@ 
         $this->assertEquals($checkField . "0", $result[0]->$checkField);
     }
 
+    /**
+     * @param string $baseDql
+     * @param string $checkField
+     */
     private function iterateWithOrderAscWithLimitAndOffset($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
     {
         // Ascending
@@ -164,6 +176,10 @@ 
         $this->assertEquals($checkField . "3", $result[0]->$checkField);
     }
 
+    /**
+     * @param string $baseDql
+     * @param string $checkField
+     */
     private function iterateWithOrderDesc($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
     {
         $dql = "$baseDql DESC";
@@ -177,6 +193,10 @@ 
         $this->assertEquals($checkField . "8", $result[0]->$checkField);
     }
 
+    /**
+     * @param string $baseDql
+     * @param string $checkField
+     */
     private function iterateWithOrderDescWithLimit($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
     {
         $dql = "$baseDql DESC";
@@ -192,6 +212,10 @@ 
         $this->assertEquals($checkField . "8", $result[0]->$checkField);
     }
 
+    /**
+     * @param string $baseDql
+     * @param string $checkField
+     */
     private function iterateWithOrderDescWithLimitAndOffset($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
     {
         $dql = "$baseDql DESC";

Spacing +14 added lines, -14 removed lines

@@ -129,7 +129,7 @@ 
         $iter = $paginator->getIterator();
         $this->assertCount(9, $iter);
         $result = iterator_to_array($iter);
-        $this->assertEquals($checkField . "0", $result[0]->$checkField);
+        $this->assertEquals($checkField."0", $result[0]->$checkField);
     }
 
     private function iterateWithOrderAscWithLimit($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
@@ -145,7 +145,7 @@ 
         $iter = $paginator->getIterator();
         $this->assertCount(3, $iter);
         $result = iterator_to_array($iter);
-        $this->assertEquals($checkField . "0", $result[0]->$checkField);
+        $this->assertEquals($checkField."0", $result[0]->$checkField);
     }
 
     private function iterateWithOrderAscWithLimitAndOffset($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
@@ -161,7 +161,7 @@ 
         $iter = $paginator->getIterator();
         $this->assertCount(3, $iter);
         $result = iterator_to_array($iter);
-        $this->assertEquals($checkField . "3", $result[0]->$checkField);
+        $this->assertEquals($checkField."3", $result[0]->$checkField);
     }
 
     private function iterateWithOrderDesc($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
@@ -174,7 +174,7 @@ 
         $iter = $paginator->getIterator();
         $this->assertCount(9, $iter);
         $result = iterator_to_array($iter);
-        $this->assertEquals($checkField . "8", $result[0]->$checkField);
+        $this->assertEquals($checkField."8", $result[0]->$checkField);
     }
 
     private function iterateWithOrderDescWithLimit($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
@@ -189,7 +189,7 @@ 
         $iter = $paginator->getIterator();
         $this->assertCount(3, $iter);
         $result = iterator_to_array($iter);
-        $this->assertEquals($checkField . "8", $result[0]->$checkField);
+        $this->assertEquals($checkField."8", $result[0]->$checkField);
     }
 
     private function iterateWithOrderDescWithLimitAndOffset($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
@@ -204,7 +204,7 @@ 
         $iter = $paginator->getIterator();
         $this->assertCount(3, $iter);
         $result = iterator_to_array($iter);
-        $this->assertEquals($checkField . "5", $result[0]->$checkField);
+        $this->assertEquals($checkField."5", $result[0]->$checkField);
     }
 
     /**
@@ -477,8 +477,8 @@ 
     public function testIterateWithFetchJoinOneToManyWithOrderByColumnFromBoth($useOutputWalkers)
     {
         $dql = 'SELECT c, d FROM Doctrine\Tests\Models\Pagination\Company c JOIN c.departments d ORDER BY c.name';
-        $dqlAsc = $dql . " ASC, d.name";
-        $dqlDesc = $dql . " DESC, d.name";
+        $dqlAsc = $dql." ASC, d.name";
+        $dqlDesc = $dql." DESC, d.name";
         $this->iterateWithOrderAsc($useOutputWalkers, true, $dqlAsc, "name");
         $this->iterateWithOrderDesc($useOutputWalkers, true, $dqlDesc, "name");
     }
@@ -486,8 +486,8 @@ 
     public function testIterateWithFetchJoinOneToManyWithOrderByColumnFromBothWithLimitWithOutputWalker()
     {
         $dql = 'SELECT c, d FROM Doctrine\Tests\Models\Pagination\Company c JOIN c.departments d ORDER BY c.name';
-        $dqlAsc = $dql . " ASC, d.name";
-        $dqlDesc = $dql . " DESC, d.name";
+        $dqlAsc = $dql." ASC, d.name";
+        $dqlDesc = $dql." DESC, d.name";
         $this->iterateWithOrderAscWithLimit(true, true, $dqlAsc, "name");
         $this->iterateWithOrderDescWithLimit(true, true, $dqlDesc, "name");
     }
@@ -498,8 +498,8 @@ 
         $this->expectExceptionMessage('Cannot select distinct identifiers from query with LIMIT and ORDER BY on a column from a fetch joined to-many association. Use output walkers.');
 
         $dql = 'SELECT c, d FROM Doctrine\Tests\Models\Pagination\Company c JOIN c.departments d ORDER BY c.name';
-        $dqlAsc = $dql . " ASC, d.name";
-        $dqlDesc = $dql . " DESC, d.name";
+        $dqlAsc = $dql." ASC, d.name";
+        $dqlDesc = $dql." DESC, d.name";
         $this->iterateWithOrderAscWithLimit(false, true, $dqlAsc, "name");
         $this->iterateWithOrderDescWithLimit(false, true, $dqlDesc, "name");
     }
@@ -583,7 +583,7 @@ 
         $users = iterator_to_array($paginator->getIterator());
         $this->assertCount(9, $users);
         foreach ($users as $i => $user) {
-            $this->assertEquals("username" . (8 - $i), $user->username);
+            $this->assertEquals("username".(8 - $i), $user->username);
         }
     }
 
@@ -733,7 +733,7 @@ 
             $company->logo->image_width = 100 + $i;
             $company->logo->image_height = 100 + $i;
             $company->logo->company = $company;
-            for($j=0;$j<3;$j++) {
+            for ($j = 0; $j < 3; $j++) {
                 $department = new Department();
                 $department->name = "name$i$j";
                 $department->company = $company;

tests/Doctrine/Tests/ORM/Functional/ReadOnlyTest.php

Doc Comments +4 added lines

@@ -84,6 +84,10 @@
     /** @Column(type="integer") */
     public $numericValue;
 
+    /**
+     * @param string $name
+     * @param integer $number
+     */
     public function __construct($name, $number)
     {
         $this->name = $name;

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
                 $this->_em->getClassMetadata(ReadOnlyEntity::class),
                 ]
             );
-        } catch(\Exception $e) {
+        } catch (\Exception $e) {
         }
     }