Completed
Push — master ( 86cde3...b784a0 )
by Guilherme
54:10 queued 45:30
created

UnitOfWork::isReadOnly()   A

Complexity

Conditions 2
Paths 2

Size

Total Lines 8
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 3
CRAP Score 2.0625
Metric Value
dl 0
loc 8
ccs 3
cts 4
cp 0.75
rs 9.4285
cc 2
eloc 4
nc 2
nop 1
crap 2.0625
1
<?php
2
/*
3
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
4
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
5
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
6
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
7
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
8
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
9
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
10
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
11
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
12
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
13
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
14
 *
15
 * This software consists of voluntary contributions made by many individuals
16
 * and is licensed under the MIT license. For more information, see
17
 * <http://www.doctrine-project.org>.
18
 */
19
20
namespace Doctrine\ORM;
21
22
use Doctrine\Common\Persistence\Mapping\RuntimeReflectionService;
23
use Doctrine\DBAL\LockMode;
24
use Doctrine\ORM\Internal\HydrationCompleteHandler;
25
use Doctrine\ORM\Mapping\Reflection\ReflectionPropertiesGetter;
26
use Exception;
27
use InvalidArgumentException;
28
use UnexpectedValueException;
29
30
use Doctrine\Common\Collections\ArrayCollection;
31
use Doctrine\Common\Collections\Collection;
32
use Doctrine\Common\NotifyPropertyChanged;
33
use Doctrine\Common\PropertyChangedListener;
34
use Doctrine\Common\Persistence\ObjectManagerAware;
35
use Doctrine\ORM\Mapping\ClassMetadata;
36
use Doctrine\ORM\Proxy\Proxy;
37
38
use Doctrine\ORM\Event\LifecycleEventArgs;
39
use Doctrine\ORM\Event\PreUpdateEventArgs;
40
use Doctrine\ORM\Event\PreFlushEventArgs;
41
use Doctrine\ORM\Event\OnFlushEventArgs;
42
use Doctrine\ORM\Event\PostFlushEventArgs;
43
use Doctrine\ORM\Event\ListenersInvoker;
44
45
use Doctrine\ORM\Cache\Persister\CachedPersister;
46
use Doctrine\ORM\Persisters\Entity\BasicEntityPersister;
47
use Doctrine\ORM\Persisters\Entity\SingleTablePersister;
48
use Doctrine\ORM\Persisters\Entity\JoinedSubclassPersister;
49
use Doctrine\ORM\Persisters\Collection\OneToManyPersister;
50
use Doctrine\ORM\Persisters\Collection\ManyToManyPersister;
51
use Doctrine\ORM\Utility\IdentifierFlattener;
52
use Doctrine\ORM\Cache\AssociationCacheEntry;
53
54
/**
55
 * The UnitOfWork is responsible for tracking changes to objects during an
56
 * "object-level" transaction and for writing out changes to the database
57
 * in the correct order.
58
 *
59
 * Internal note: This class contains highly performance-sensitive code.
60
 *
61
 * @since       2.0
62
 * @author      Benjamin Eberlei <[email protected]>
63
 * @author      Guilherme Blanco <[email protected]>
64
 * @author      Jonathan Wage <[email protected]>
65
 * @author      Roman Borschel <[email protected]>
66
 * @author      Rob Caiger <[email protected]>
67
 */
68
class UnitOfWork implements PropertyChangedListener
69
{
70
    /**
71
     * An entity is in MANAGED state when its persistence is managed by an EntityManager.
72
     */
73
    const STATE_MANAGED = 1;
74
75
    /**
76
     * An entity is new if it has just been instantiated (i.e. using the "new" operator)
77
     * and is not (yet) managed by an EntityManager.
78
     */
79
    const STATE_NEW = 2;
80
81
    /**
82
     * A detached entity is an instance with persistent state and identity that is not
83
     * (or no longer) associated with an EntityManager (and a UnitOfWork).
84
     */
85
    const STATE_DETACHED = 3;
86
87
    /**
88
     * A removed entity instance is an instance with a persistent identity,
89
     * associated with an EntityManager, whose persistent state will be deleted
90
     * on commit.
91
     */
92
    const STATE_REMOVED = 4;
93
94
    /**
95
     * Hint used to collect all primary keys of associated entities during hydration
96
     * and execute it in a dedicated query afterwards
97
     * @see https://doctrine-orm.readthedocs.org/en/latest/reference/dql-doctrine-query-language.html?highlight=eager#temporarily-change-fetch-mode-in-dql
98
     */
99
    const HINT_DEFEREAGERLOAD = 'deferEagerLoad';
100
101
    /**
102
     * The identity map that holds references to all managed entities that have
103
     * an identity. The entities are grouped by their class name.
104
     * Since all classes in a hierarchy must share the same identifier set,
105
     * we always take the root class name of the hierarchy.
106
     *
107
     * @var array
108
     */
109
    private $identityMap = array();
110
111
    /**
112
     * Map of all identifiers of managed entities.
113
     * Keys are object ids (spl_object_hash).
114
     *
115
     * @var array
116
     */
117
    private $entityIdentifiers = array();
118
119
    /**
120
     * Map of the original entity data of managed entities.
121
     * Keys are object ids (spl_object_hash). This is used for calculating changesets
122
     * at commit time.
123
     *
124
     * Internal note: Note that PHPs "copy-on-write" behavior helps a lot with memory usage.
125
     *                A value will only really be copied if the value in the entity is modified
126
     *                by the user.
127
     *
128
     * @var array
129
     */
130
    private $originalEntityData = array();
131
132
    /**
133
     * Map of entity changes. Keys are object ids (spl_object_hash).
134
     * Filled at the beginning of a commit of the UnitOfWork and cleaned at the end.
135
     *
136
     * @var array
137
     */
138
    private $entityChangeSets = array();
139
140
    /**
141
     * The (cached) states of any known entities.
142
     * Keys are object ids (spl_object_hash).
143
     *
144
     * @var array
145
     */
146
    private $entityStates = array();
147
148
    /**
149
     * Map of entities that are scheduled for dirty checking at commit time.
150
     * This is only used for entities with a change tracking policy of DEFERRED_EXPLICIT.
151
     * Keys are object ids (spl_object_hash).
152
     *
153
     * @var array
154
     */
155
    private $scheduledForSynchronization = array();
156
157
    /**
158
     * A list of all pending entity insertions.
159
     *
160
     * @var array
161
     */
162
    private $entityInsertions = array();
163
164
    /**
165
     * A list of all pending entity updates.
166
     *
167
     * @var array
168
     */
169
    private $entityUpdates = array();
170
171
    /**
172
     * Any pending extra updates that have been scheduled by persisters.
173
     *
174
     * @var array
175
     */
176
    private $extraUpdates = array();
177
178
    /**
179
     * A list of all pending entity deletions.
180
     *
181
     * @var array
182
     */
183
    private $entityDeletions = array();
184
185
    /**
186
     * All pending collection deletions.
187
     *
188
     * @var array
189
     */
190
    private $collectionDeletions = array();
191
192
    /**
193
     * All pending collection updates.
194
     *
195
     * @var array
196
     */
197
    private $collectionUpdates = array();
198
199
    /**
200
     * List of collections visited during changeset calculation on a commit-phase of a UnitOfWork.
201
     * At the end of the UnitOfWork all these collections will make new snapshots
202
     * of their data.
203
     *
204
     * @var array
205
     */
206
    private $visitedCollections = array();
207
208
    /**
209
     * The EntityManager that "owns" this UnitOfWork instance.
210
     *
211
     * @var EntityManagerInterface
212
     */
213
    private $em;
214
215
    /**
216
     * The entity persister instances used to persist entity instances.
217
     *
218
     * @var array
219
     */
220
    private $persisters = array();
221
222
    /**
223
     * The collection persister instances used to persist collections.
224
     *
225
     * @var array
226
     */
227
    private $collectionPersisters = array();
228
229
    /**
230
     * The EventManager used for dispatching events.
231
     *
232
     * @var \Doctrine\Common\EventManager
233
     */
234
    private $evm;
235
236
    /**
237
     * The ListenersInvoker used for dispatching events.
238
     *
239
     * @var \Doctrine\ORM\Event\ListenersInvoker
240
     */
241
    private $listenersInvoker;
242
243
    /**
244
     * The IdentifierFlattener used for manipulating identifiers
245
     *
246
     * @var \Doctrine\ORM\Utility\IdentifierFlattener
247
     */
248
    private $identifierFlattener;
249
250
    /**
251
     * Orphaned entities that are scheduled for removal.
252
     *
253
     * @var array
254
     */
255
    private $orphanRemovals = array();
256
257
    /**
258
     * Read-Only objects are never evaluated
259
     *
260
     * @var array
261
     */
262
    private $readOnlyObjects = array();
263
264
    /**
265
     * Map of Entity Class-Names and corresponding IDs that should eager loaded when requested.
266
     *
267
     * @var array
268
     */
269
    private $eagerLoadingEntities = array();
270
271
    /**
272
     * @var boolean
273
     */
274
    protected $hasCache = false;
275
276
    /**
277
     * Helper for handling completion of hydration
278
     *
279
     * @var HydrationCompleteHandler
280
     */
281
    private $hydrationCompleteHandler;
282
283
    /**
284
     * @var ReflectionPropertiesGetter
285
     */
286
    private $reflectionPropertiesGetter;
287
288
    /**
289
     * Initializes a new UnitOfWork instance, bound to the given EntityManager.
290
     *
291
     * @param EntityManagerInterface $em
292
     */
293 2323
    public function __construct(EntityManagerInterface $em)
294
    {
295 2323
        $this->em                         = $em;
296 2323
        $this->evm                        = $em->getEventManager();
297 2323
        $this->listenersInvoker           = new ListenersInvoker($em);
298 2323
        $this->hasCache                   = $em->getConfiguration()->isSecondLevelCacheEnabled();
299 2323
        $this->identifierFlattener        = new IdentifierFlattener($this, $em->getMetadataFactory());
300 2323
        $this->hydrationCompleteHandler   = new HydrationCompleteHandler($this->listenersInvoker, $em);
301 2323
        $this->reflectionPropertiesGetter = new ReflectionPropertiesGetter(new RuntimeReflectionService());
302 2323
    }
303
304
    /**
305
     * Commits the UnitOfWork, executing all operations that have been postponed
306
     * up to this point. The state of all managed entities will be synchronized with
307
     * the database.
308
     *
309
     * The operations are executed in the following order:
310
     *
311
     * 1) All entity insertions
312
     * 2) All entity updates
313
     * 3) All collection deletions
314
     * 4) All collection updates
315
     * 5) All entity deletions
316
     *
317
     * @param null|object|array $entity
318
     *
319
     * @return void
320
     *
321
     * @throws \Exception
322
     */
323 1012
    public function commit($entity = null)
324
    {
325
        // Raise preFlush
326 1012
        if ($this->evm->hasListeners(Events::preFlush)) {
327 2
            $this->evm->dispatchEvent(Events::preFlush, new PreFlushEventArgs($this->em));
328
        }
329
330
        // Compute changes done since last commit.
331 1012
        if ($entity === null) {
332 1004
            $this->computeChangeSets();
333 16
        } elseif (is_object($entity)) {
334 15
            $this->computeSingleEntityChangeSet($entity);
335 1
        } elseif (is_array($entity)) {
336 1
            foreach ($entity as $object) {
337 1
                $this->computeSingleEntityChangeSet($object);
338
            }
339
        }
340
341 1009
        if ( ! ($this->entityInsertions ||
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->entityInsertions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
342 166
                $this->entityDeletions ||
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->entityDeletions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
343 130
                $this->entityUpdates ||
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->entityUpdates of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
344 40
                $this->collectionUpdates ||
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->collectionUpdates of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
345 37
                $this->collectionDeletions ||
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->collectionDeletions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
346 1009
                $this->orphanRemovals)) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->orphanRemovals of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
347 25
            $this->dispatchOnFlushEvent();
348 25
            $this->dispatchPostFlushEvent();
349
350 25
            return; // Nothing to do.
351
        }
352
353 1005
        if ($this->orphanRemovals) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->orphanRemovals of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
354 16
            foreach ($this->orphanRemovals as $orphan) {
355 16
                $this->remove($orphan);
356
            }
357
        }
358
359 1005
        $this->dispatchOnFlushEvent();
360
361
        // Now we need a commit order to maintain referential integrity
362 1005
        $commitOrder = $this->getCommitOrder();
363
364 1005
        $conn = $this->em->getConnection();
365 1005
        $conn->beginTransaction();
366
367
        try {
368
            // Collection deletions (deletions of complete collections)
369 1005
            foreach ($this->collectionDeletions as $collectionToDelete) {
370 19
                $this->getCollectionPersister($collectionToDelete->getMapping())->delete($collectionToDelete);
371
            }
372
373 1005
            if ($this->entityInsertions) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->entityInsertions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
374 1001
                foreach ($commitOrder as $class) {
375 1001
                    $this->executeInserts($class);
376
                }
377
            }
378
379 1004
            if ($this->entityUpdates) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->entityUpdates of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
380 116
                foreach ($commitOrder as $class) {
381 116
                    $this->executeUpdates($class);
382
                }
383
            }
384
385
            // Extra updates that were requested by persisters.
386 1000
            if ($this->extraUpdates) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->extraUpdates of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
387 40
                $this->executeExtraUpdates();
388
            }
389
390
            // Collection updates (deleteRows, updateRows, insertRows)
391 1000
            foreach ($this->collectionUpdates as $collectionToUpdate) {
392 529
                $this->getCollectionPersister($collectionToUpdate->getMapping())->update($collectionToUpdate);
393
            }
394
395
            // Entity deletions come last and need to be in reverse commit order
396 1000
            if ($this->entityDeletions) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->entityDeletions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
397 63
                for ($count = count($commitOrder), $i = $count - 1; $i >= 0 && $this->entityDeletions; --$i) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->entityDeletions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
398 63
                    $this->executeDeletions($commitOrder[$i]);
399
                }
400
            }
401
402 1000
            $conn->commit();
403 11
        } catch (Exception $e) {
404 11
            $this->em->close();
405 11
            $conn->rollBack();
406
407 11
            $this->afterTransactionRolledBack();
408
409 11
            throw $e;
410
        }
411
412 1000
        $this->afterTransactionComplete();
413
414
        // Take new snapshots from visited collections
415 1000
        foreach ($this->visitedCollections as $coll) {
416 528
            $coll->takeSnapshot();
417
        }
418
419 1000
        $this->dispatchPostFlushEvent();
420
421
        // Clear up
422 999
        $this->entityInsertions =
423 999
        $this->entityUpdates =
424 999
        $this->entityDeletions =
425 999
        $this->extraUpdates =
426 999
        $this->entityChangeSets =
427 999
        $this->collectionUpdates =
428 999
        $this->collectionDeletions =
429 999
        $this->visitedCollections =
430 999
        $this->scheduledForSynchronization =
431 999
        $this->orphanRemovals = array();
432 999
    }
433
434
    /**
435
     * Computes the changesets of all entities scheduled for insertion.
436
     *
437
     * @return void
438
     */
439 1011
    private function computeScheduleInsertsChangeSets()
440
    {
441 1011
        foreach ($this->entityInsertions as $entity) {
442 1003
            $class = $this->em->getClassMetadata(get_class($entity));
443
444 1003
            $this->computeChangeSet($class, $entity);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
445
        }
446 1009
    }
447
448
    /**
449
     * Only flushes the given entity according to a ruleset that keeps the UoW consistent.
450
     *
451
     * 1. All entities scheduled for insertion, (orphan) removals and changes in collections are processed as well!
452
     * 2. Read Only entities are skipped.
453
     * 3. Proxies are skipped.
454
     * 4. Only if entity is properly managed.
455
     *
456
     * @param object $entity
457
     *
458
     * @return void
459
     *
460
     * @throws \InvalidArgumentException
461
     */
462 16
    private function computeSingleEntityChangeSet($entity)
463
    {
464 16
        $state = $this->getEntityState($entity);
465
466 16
        if ($state !== self::STATE_MANAGED && $state !== self::STATE_REMOVED) {
467 1
            throw new \InvalidArgumentException("Entity has to be managed or scheduled for removal for single computation " . self::objToStr($entity));
468
        }
469
470 15
        $class = $this->em->getClassMetadata(get_class($entity));
471
472 15
        if ($state === self::STATE_MANAGED && $class->isChangeTrackingDeferredImplicit()) {
473 14
            $this->persist($entity);
474
        }
475
476
        // Compute changes for INSERTed entities first. This must always happen even in this case.
477 15
        $this->computeScheduleInsertsChangeSets();
478
479 15
        if ($class->isReadOnly) {
0 ignored issues
show
Bug introduced by
Accessing isReadOnly on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
480
            return;
481
        }
482
483
        // Ignore uninitialized proxy objects
484 15
        if ($entity instanceof Proxy && ! $entity->__isInitialized__) {
0 ignored issues
show
Bug introduced by
Accessing __isInitialized__ on the interface Doctrine\ORM\Proxy\Proxy suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
485 2
            return;
486
        }
487
488
        // Only MANAGED entities that are NOT SCHEDULED FOR INSERTION OR DELETION are processed here.
489 13
        $oid = spl_object_hash($entity);
490
491 13
        if ( ! isset($this->entityInsertions[$oid]) && ! isset($this->entityDeletions[$oid]) && isset($this->entityStates[$oid])) {
492 6
            $this->computeChangeSet($class, $entity);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
493
        }
494 12
    }
495
496
    /**
497
     * Executes any extra updates that have been scheduled.
498
     */
499 40
    private function executeExtraUpdates()
500
    {
501 40
        foreach ($this->extraUpdates as $oid => $update) {
502 40
            list ($entity, $changeset) = $update;
503
504 40
            $this->entityChangeSets[$oid] = $changeset;
505 40
            $this->getEntityPersister(get_class($entity))->update($entity);
506
        }
507
508 40
        $this->extraUpdates = array();
509 40
    }
510
511
    /**
512
     * Gets the changeset for an entity.
513
     *
514
     * @param object $entity
515
     *
516
     * @return array
517
     */
518 1003
    public function getEntityChangeSet($entity)
519
    {
520 1003
        $oid = spl_object_hash($entity);
521
522 1003
        if (isset($this->entityChangeSets[$oid])) {
523 1003
            return $this->entityChangeSets[$oid];
524
        }
525
526 1
        return array();
527
    }
528
529
    /**
530
     * Computes the changes that happened to a single entity.
531
     *
532
     * Modifies/populates the following properties:
533
     *
534
     * {@link _originalEntityData}
535
     * If the entity is NEW or MANAGED but not yet fully persisted (only has an id)
536
     * then it was not fetched from the database and therefore we have no original
537
     * entity data yet. All of the current entity data is stored as the original entity data.
538
     *
539
     * {@link _entityChangeSets}
540
     * The changes detected on all properties of the entity are stored there.
541
     * A change is a tuple array where the first entry is the old value and the second
542
     * entry is the new value of the property. Changesets are used by persisters
543
     * to INSERT/UPDATE the persistent entity state.
544
     *
545
     * {@link _entityUpdates}
546
     * If the entity is already fully MANAGED (has been fetched from the database before)
547
     * and any changes to its properties are detected, then a reference to the entity is stored
548
     * there to mark it for an update.
549
     *
550
     * {@link _collectionDeletions}
551
     * If a PersistentCollection has been de-referenced in a fully MANAGED entity,
552
     * then this collection is marked for deletion.
553
     *
554
     * @ignore
555
     *
556
     * @internal Don't call from the outside.
557
     *
558
     * @param ClassMetadata $class  The class descriptor of the entity.
559
     * @param object        $entity The entity for which to compute the changes.
560
     *
561
     * @return void
562
     */
563 1013
    public function computeChangeSet(ClassMetadata $class, $entity)
564
    {
565 1013
        $oid = spl_object_hash($entity);
566
567 1013
        if (isset($this->readOnlyObjects[$oid])) {
568 2
            return;
569
        }
570
571 1013
        if ( ! $class->isInheritanceTypeNone()) {
572 306
            $class = $this->em->getClassMetadata(get_class($entity));
573
        }
574
575 1013
        $invoke = $this->listenersInvoker->getSubscribedSystems($class, Events::preFlush) & ~ListenersInvoker::INVOKE_MANAGER;
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
576
577 1013
        if ($invoke !== ListenersInvoker::INVOKE_NONE) {
578 137
            $this->listenersInvoker->invoke($class, Events::preFlush, $entity, new PreFlushEventArgs($this->em), $invoke);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
579
        }
580
581 1013
        $actualData = array();
582
583 1013
        foreach ($class->reflFields as $name => $refProp) {
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
584 1013
            $value = $refProp->getValue($entity);
585
586 1013
            if ($class->isCollectionValuedAssociation($name) && $value !== null) {
587 775
                if ($value instanceof PersistentCollection) {
588 198
                    if ($value->getOwner() === $entity) {
589 198
                        continue;
590
                    }
591
592 5
                    $value = new ArrayCollection($value->getValues());
593
                }
594
595
                // If $value is not a Collection then use an ArrayCollection.
596 770
                if ( ! $value instanceof Collection) {
597 242
                    $value = new ArrayCollection($value);
598
                }
599
600 770
                $assoc = $class->associationMappings[$name];
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
601
602
                // Inject PersistentCollection
603 770
                $value = new PersistentCollection(
604 770
                    $this->em, $this->em->getClassMetadata($assoc['targetEntity']), $value
0 ignored issues
show
Compatibility introduced by
$this->em->getClassMetad...$assoc['targetEntity']) of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
605
                );
606 770
                $value->setOwner($entity, $assoc);
607 770
                $value->setDirty( ! $value->isEmpty());
608
609 770
                $class->reflFields[$name]->setValue($entity, $value);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
610
611 770
                $actualData[$name] = $value;
612
613 770
                continue;
614
            }
615
616 1013
            if (( ! $class->isIdentifier($name) || ! $class->isIdGeneratorIdentity()) && ($name !== $class->versionField)) {
0 ignored issues
show
Bug introduced by
Accessing versionField on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
617 1013
                $actualData[$name] = $value;
618
            }
619
        }
620
621 1013
        if ( ! isset($this->originalEntityData[$oid])) {
622
            // Entity is either NEW or MANAGED but not yet fully persisted (only has an id).
623
            // These result in an INSERT.
624 1009
            $this->originalEntityData[$oid] = $actualData;
625 1009
            $changeSet = array();
626
627 1009
            foreach ($actualData as $propName => $actualValue) {
628 994
                if ( ! isset($class->associationMappings[$propName])) {
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
629 943
                    $changeSet[$propName] = array(null, $actualValue);
630
631 943
                    continue;
632
                }
633
634 892
                $assoc = $class->associationMappings[$propName];
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
635
636 892
                if ($assoc['isOwningSide'] && $assoc['type'] & ClassMetadata::TO_ONE) {
637 892
                    $changeSet[$propName] = array(null, $actualValue);
638
                }
639
            }
640
641 1009
            $this->entityChangeSets[$oid] = $changeSet;
642
        } else {
643
            // Entity is "fully" MANAGED: it was already fully persisted before
644
            // and we have a copy of the original data
645 262
            $originalData           = $this->originalEntityData[$oid];
646 262
            $isChangeTrackingNotify = $class->isChangeTrackingNotify();
647 262
            $changeSet              = ($isChangeTrackingNotify && isset($this->entityChangeSets[$oid]))
648
                ? $this->entityChangeSets[$oid]
649 262
                : array();
650
651 262
            foreach ($actualData as $propName => $actualValue) {
652
                // skip field, its a partially omitted one!
653 247
                if ( ! (isset($originalData[$propName]) || array_key_exists($propName, $originalData))) {
654 8
                    continue;
655
                }
656
657 247
                $orgValue = $originalData[$propName];
658
659
                // skip if value haven't changed
660 247
                if ($orgValue === $actualValue) {
661 231
                    continue;
662
                }
663
664
                // if regular field
665 112
                if ( ! isset($class->associationMappings[$propName])) {
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
666 58
                    if ($isChangeTrackingNotify) {
667
                        continue;
668
                    }
669
670 58
                    $changeSet[$propName] = array($orgValue, $actualValue);
671
672 58
                    continue;
673
                }
674
675 58
                $assoc = $class->associationMappings[$propName];
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
676
677
                // Persistent collection was exchanged with the "originally"
678
                // created one. This can only mean it was cloned and replaced
679
                // on another entity.
680 58
                if ($actualValue instanceof PersistentCollection) {
681 8
                    $owner = $actualValue->getOwner();
682 8
                    if ($owner === null) { // cloned
683
                        $actualValue->setOwner($entity, $assoc);
684 8
                    } else if ($owner !== $entity) { // no clone, we have to fix
685
                        if (!$actualValue->isInitialized()) {
686
                            $actualValue->initialize(); // we have to do this otherwise the cols share state
687
                        }
688
                        $newValue = clone $actualValue;
689
                        $newValue->setOwner($entity, $assoc);
690
                        $class->reflFields[$propName]->setValue($entity, $newValue);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
691
                    }
692
                }
693
694 58
                if ($orgValue instanceof PersistentCollection) {
695
                    // A PersistentCollection was de-referenced, so delete it.
696 8
                    $coid = spl_object_hash($orgValue);
697
698 8
                    if (isset($this->collectionDeletions[$coid])) {
699
                        continue;
700
                    }
701
702 8
                    $this->collectionDeletions[$coid] = $orgValue;
703 8
                    $changeSet[$propName] = $orgValue; // Signal changeset, to-many assocs will be ignored.
704
705 8
                    continue;
706
                }
707
708 50
                if ($assoc['type'] & ClassMetadata::TO_ONE) {
709 49
                    if ($assoc['isOwningSide']) {
710 21
                        $changeSet[$propName] = array($orgValue, $actualValue);
711
                    }
712
713 49
                    if ($orgValue !== null && $assoc['orphanRemoval']) {
714 50
                        $this->scheduleOrphanRemoval($orgValue);
715
                    }
716
                }
717
            }
718
719 262
            if ($changeSet) {
720 85
                $this->entityChangeSets[$oid]   = $changeSet;
721 85
                $this->originalEntityData[$oid] = $actualData;
722 85
                $this->entityUpdates[$oid]      = $entity;
723
            }
724
        }
725
726
        // Look for changes in associations of the entity
727 1013
        foreach ($class->associationMappings as $field => $assoc) {
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
728 892
            if (($val = $class->reflFields[$field]->getValue($entity)) === null) {
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
729 638
                continue;
730
            }
731
732 863
            $this->computeAssociationChanges($assoc, $val);
733
734 855
            if ( ! isset($this->entityChangeSets[$oid]) &&
735 855
                $assoc['isOwningSide'] &&
736 855
                $assoc['type'] == ClassMetadata::MANY_TO_MANY &&
737 855
                $val instanceof PersistentCollection &&
738 855
                $val->isDirty()) {
739
740 35
                $this->entityChangeSets[$oid]   = array();
741 35
                $this->originalEntityData[$oid] = $actualData;
742 855
                $this->entityUpdates[$oid]      = $entity;
743
            }
744
        }
745 1005
    }
746
747
    /**
748
     * Computes all the changes that have been done to entities and collections
749
     * since the last commit and stores these changes in the _entityChangeSet map
750
     * temporarily for access by the persisters, until the UoW commit is finished.
751
     *
752
     * @return void
753
     */
754 1004
    public function computeChangeSets()
755
    {
756
        // Compute changes for INSERTed entities first. This must always happen.
757 1004
        $this->computeScheduleInsertsChangeSets();
758
759
        // Compute changes for other MANAGED entities. Change tracking policies take effect here.
760 1002
        foreach ($this->identityMap as $className => $entities) {
761 445
            $class = $this->em->getClassMetadata($className);
762
763
            // Skip class if instances are read-only
764 445
            if ($class->isReadOnly) {
0 ignored issues
show
Bug introduced by
Accessing isReadOnly on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
765 1
                continue;
766
            }
767
768
            // If change tracking is explicit or happens through notification, then only compute
769
            // changes on entities of that type that are explicitly marked for synchronization.
770
            switch (true) {
771 444
                case ($class->isChangeTrackingDeferredImplicit()):
772 442
                    $entitiesToProcess = $entities;
773 442
                    break;
774
775 3
                case (isset($this->scheduledForSynchronization[$className])):
776 3
                    $entitiesToProcess = $this->scheduledForSynchronization[$className];
777 3
                    break;
778
779
                default:
780 1
                    $entitiesToProcess = array();
781
782
            }
783
784 444
            foreach ($entitiesToProcess as $entity) {
785
                // Ignore uninitialized proxy objects
786 424
                if ($entity instanceof Proxy && ! $entity->__isInitialized__) {
0 ignored issues
show
Bug introduced by
Accessing __isInitialized__ on the interface Doctrine\ORM\Proxy\Proxy suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
787 34
                    continue;
788
                }
789
790
                // Only MANAGED entities that are NOT SCHEDULED FOR INSERTION OR DELETION are processed here.
791 423
                $oid = spl_object_hash($entity);
792
793 423
                if ( ! isset($this->entityInsertions[$oid]) && ! isset($this->entityDeletions[$oid]) && isset($this->entityStates[$oid])) {
794 444
                    $this->computeChangeSet($class, $entity);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
795
                }
796
            }
797
        }
798 1002
    }
799
800
    /**
801
     * Computes the changes of an association.
802
     *
803
     * @param array $assoc The association mapping.
804
     * @param mixed $value The value of the association.
805
     *
806
     * @throws ORMInvalidArgumentException
807
     * @throws ORMException
808
     *
809
     * @return void
810
     */
811 863
    private function computeAssociationChanges($assoc, $value)
812
    {
813 863
        if ($value instanceof Proxy && ! $value->__isInitialized__) {
0 ignored issues
show
Bug introduced by
Accessing __isInitialized__ on the interface Doctrine\ORM\Proxy\Proxy suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
814 27
            return;
815
        }
816
817 862
        if ($value instanceof PersistentCollection && $value->isDirty()) {
818 531
            $coid = spl_object_hash($value);
819
820 531
            $this->collectionUpdates[$coid] = $value;
821 531
            $this->visitedCollections[$coid] = $value;
822
        }
823
824
        // Look through the entities, and in any of their associations,
825
        // for transient (new) entities, recursively. ("Persistence by reachability")
826
        // Unwrap. Uninitialized collections will simply be empty.
827 862
        $unwrappedValue = ($assoc['type'] & ClassMetadata::TO_ONE) ? array($value) : $value->unwrap();
828 862
        $targetClass    = $this->em->getClassMetadata($assoc['targetEntity']);
829
830 862
        foreach ($unwrappedValue as $key => $entry) {
831 720
            if (! ($entry instanceof $targetClass->name)) {
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
832 6
                throw ORMInvalidArgumentException::invalidAssociation($targetClass, $assoc, $entry);
0 ignored issues
show
Compatibility introduced by
$targetClass of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
833
            }
834
835 714
            $state = $this->getEntityState($entry, self::STATE_NEW);
836
837 714
            if ( ! ($entry instanceof $assoc['targetEntity'])) {
838
                throw ORMException::unexpectedAssociationValue($assoc['sourceEntity'], $assoc['fieldName'], get_class($entry), $assoc['targetEntity']);
839
            }
840
841
            switch ($state) {
842 714
                case self::STATE_NEW:
843 39
                    if ( ! $assoc['isCascadePersist']) {
844 4
                        throw ORMInvalidArgumentException::newEntityFoundThroughRelationship($assoc, $entry);
845
                    }
846
847 35
                    $this->persistNew($targetClass, $entry);
0 ignored issues
show
Compatibility introduced by
$targetClass of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
848 35
                    $this->computeChangeSet($targetClass, $entry);
0 ignored issues
show
Compatibility introduced by
$targetClass of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
849 35
                    break;
850
851 708
                case self::STATE_REMOVED:
852
                    // Consume the $value as array (it's either an array or an ArrayAccess)
853
                    // and remove the element from Collection.
854 4
                    if ($assoc['type'] & ClassMetadata::TO_MANY) {
855 3
                        unset($value[$key]);
856
                    }
857 4
                    break;
858
859 708
                case self::STATE_DETACHED:
860
                    // Can actually not happen right now as we assume STATE_NEW,
861
                    // so the exception will be raised from the DBAL layer (constraint violation).
862
                    throw ORMInvalidArgumentException::detachedEntityFoundThroughRelationship($assoc, $entry);
863
                    break;
0 ignored issues
show
Unused Code introduced by
break; does not seem to be reachable.

This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed.

Unreachable code is most often the result of return, die or exit statements that have been added for debug purposes.

function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

In the above example, the last return false will never be executed, because a return statement has already been met in every possible execution path.

Loading history...
864
865 711
                default:
866
                    // MANAGED associated entities are already taken into account
867
                    // during changeset calculation anyway, since they are in the identity map.
868
            }
869
        }
870 854
    }
871
872
    /**
873
     * @param \Doctrine\ORM\Mapping\ClassMetadata $class
874
     * @param object                              $entity
875
     *
876
     * @return void
877
     */
878 1021
    private function persistNew($class, $entity)
879
    {
880 1021
        $oid    = spl_object_hash($entity);
881 1021
        $invoke = $this->listenersInvoker->getSubscribedSystems($class, Events::prePersist);
882
883 1021
        if ($invoke !== ListenersInvoker::INVOKE_NONE) {
884 139
            $this->listenersInvoker->invoke($class, Events::prePersist, $entity, new LifecycleEventArgs($entity, $this->em), $invoke);
885
        }
886
887 1021
        $idGen = $class->idGenerator;
888
889 1021
        if ( ! $idGen->isPostInsertGenerator()) {
890 260
            $idValue = $idGen->generate($this->em, $entity);
0 ignored issues
show
Compatibility introduced by
$this->em of type object<Doctrine\ORM\EntityManagerInterface> is not a sub-type of object<Doctrine\ORM\EntityManager>. It seems like you assume a concrete implementation of the interface Doctrine\ORM\EntityManagerInterface to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
891
892 260
            if ( ! $idGen instanceof \Doctrine\ORM\Id\AssignedGenerator) {
893 1
                $idValue = array($class->identifier[0] => $idValue);
894
895 1
                $class->setIdentifierValues($entity, $idValue);
896
            }
897
898 260
            $this->entityIdentifiers[$oid] = $idValue;
899
        }
900
901 1021
        $this->entityStates[$oid] = self::STATE_MANAGED;
902
903 1021
        $this->scheduleForInsert($entity);
904 1021
    }
905
906
    /**
907
     * INTERNAL:
908
     * Computes the changeset of an individual entity, independently of the
909
     * computeChangeSets() routine that is used at the beginning of a UnitOfWork#commit().
910
     *
911
     * The passed entity must be a managed entity. If the entity already has a change set
912
     * because this method is invoked during a commit cycle then the change sets are added.
913
     * whereby changes detected in this method prevail.
914
     *
915
     * @ignore
916
     *
917
     * @param ClassMetadata $class  The class descriptor of the entity.
918
     * @param object        $entity The entity for which to (re)calculate the change set.
919
     *
920
     * @return void
921
     *
922
     * @throws ORMInvalidArgumentException If the passed entity is not MANAGED.
923
     */
924 16
    public function recomputeSingleEntityChangeSet(ClassMetadata $class, $entity)
925
    {
926 16
        $oid = spl_object_hash($entity);
927
928 16
        if ( ! isset($this->entityStates[$oid]) || $this->entityStates[$oid] != self::STATE_MANAGED) {
929
            throw ORMInvalidArgumentException::entityNotManaged($entity);
930
        }
931
932
        // skip if change tracking is "NOTIFY"
933 16
        if ($class->isChangeTrackingNotify()) {
934
            return;
935
        }
936
937 16
        if ( ! $class->isInheritanceTypeNone()) {
938 3
            $class = $this->em->getClassMetadata(get_class($entity));
939
        }
940
941 16
        $actualData = array();
942
943 16
        foreach ($class->reflFields as $name => $refProp) {
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
944 16
            if (( ! $class->isIdentifier($name) || ! $class->isIdGeneratorIdentity())
945 16
                && ($name !== $class->versionField)
0 ignored issues
show
Bug introduced by
Accessing versionField on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
946 16
                && ! $class->isCollectionValuedAssociation($name)) {
947 16
                $actualData[$name] = $refProp->getValue($entity);
948
            }
949
        }
950
951 16
        if ( ! isset($this->originalEntityData[$oid])) {
952
            throw new \RuntimeException('Cannot call recomputeSingleEntityChangeSet before computeChangeSet on an entity.');
953
        }
954
955 16
        $originalData = $this->originalEntityData[$oid];
956 16
        $changeSet = array();
957
958 16
        foreach ($actualData as $propName => $actualValue) {
959 16
            $orgValue = isset($originalData[$propName]) ? $originalData[$propName] : null;
960
961 16
            if ($orgValue !== $actualValue) {
962 16
                $changeSet[$propName] = array($orgValue, $actualValue);
963
            }
964
        }
965
966 16
        if ($changeSet) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $changeSet of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
967 7
            if (isset($this->entityChangeSets[$oid])) {
968 6
                $this->entityChangeSets[$oid] = array_merge($this->entityChangeSets[$oid], $changeSet);
969 1
            } else if ( ! isset($this->entityInsertions[$oid])) {
970 1
                $this->entityChangeSets[$oid] = $changeSet;
971 1
                $this->entityUpdates[$oid]    = $entity;
972
            }
973 7
            $this->originalEntityData[$oid] = $actualData;
974
        }
975 16
    }
976
977
    /**
978
     * Executes all entity insertions for entities of the specified type.
979
     *
980
     * @param \Doctrine\ORM\Mapping\ClassMetadata $class
981
     *
982
     * @return void
983
     */
984 1001
    private function executeInserts($class)
985
    {
986 1001
        $entities   = array();
987 1001
        $className  = $class->name;
988 1001
        $persister  = $this->getEntityPersister($className);
989 1001
        $invoke     = $this->listenersInvoker->getSubscribedSystems($class, Events::postPersist);
990
991 1001
        foreach ($this->entityInsertions as $oid => $entity) {
992
993 1001
            if ($this->em->getClassMetadata(get_class($entity))->name !== $className) {
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
994 853
                continue;
995
            }
996
997 1001
            $persister->addInsert($entity);
998
999 1001
            unset($this->entityInsertions[$oid]);
1000
1001 1001
            if ($invoke !== ListenersInvoker::INVOKE_NONE) {
1002 1001
                $entities[] = $entity;
1003
            }
1004
        }
1005
1006 1001
        $postInsertIds = $persister->executeInserts();
1007
1008 1001
        if ($postInsertIds) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $postInsertIds of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
1009
            // Persister returned post-insert IDs
1010 918
            foreach ($postInsertIds as $postInsertId) {
1011 918
                $id      = $postInsertId['generatedId'];
1012 918
                $entity  = $postInsertId['entity'];
1013 918
                $oid     = spl_object_hash($entity);
1014 918
                $idField = $class->identifier[0];
1015
1016 918
                $class->reflFields[$idField]->setValue($entity, $id);
1017
1018 918
                $this->entityIdentifiers[$oid] = array($idField => $id);
1019 918
                $this->entityStates[$oid] = self::STATE_MANAGED;
1020 918
                $this->originalEntityData[$oid][$idField] = $id;
1021
1022 918
                $this->addToIdentityMap($entity);
1023
            }
1024
        }
1025
1026 1001
        foreach ($entities as $entity) {
1027 135
            $this->listenersInvoker->invoke($class, Events::postPersist, $entity, new LifecycleEventArgs($entity, $this->em), $invoke);
1028
        }
1029 1001
    }
1030
1031
    /**
1032
     * Executes all entity updates for entities of the specified type.
1033
     *
1034
     * @param \Doctrine\ORM\Mapping\ClassMetadata $class
1035
     *
1036
     * @return void
1037
     */
1038 116
    private function executeUpdates($class)
1039
    {
1040 116
        $className          = $class->name;
1041 116
        $persister          = $this->getEntityPersister($className);
1042 116
        $preUpdateInvoke    = $this->listenersInvoker->getSubscribedSystems($class, Events::preUpdate);
1043 116
        $postUpdateInvoke   = $this->listenersInvoker->getSubscribedSystems($class, Events::postUpdate);
1044
1045 116
        foreach ($this->entityUpdates as $oid => $entity) {
1046 116
            if ($this->em->getClassMetadata(get_class($entity))->name !== $className) {
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1047 74
                continue;
1048
            }
1049
1050 116
            if ($preUpdateInvoke != ListenersInvoker::INVOKE_NONE) {
1051 13
                $changeset = $this->getEntityChangeSet($entity);
1052
1053 13
                $this->listenersInvoker->invoke($class, Events::preUpdate, $entity, new PreUpdateEventArgs($entity, $this->em, $changeset), $preUpdateInvoke);
1054
1055 13
                $this->recomputeSingleEntityChangeSet($class, $entity);
1056
            }
1057
1058 116
            if ( ! empty($this->entityChangeSets[$oid])) {
1059 82
                $persister->update($entity);
1060
            }
1061
1062 112
            unset($this->entityUpdates[$oid]);
1063
1064 112
            if ($postUpdateInvoke != ListenersInvoker::INVOKE_NONE) {
1065 112
                $this->listenersInvoker->invoke($class, Events::postUpdate, $entity, new LifecycleEventArgs($entity, $this->em), $postUpdateInvoke);
1066
            }
1067
        }
1068 112
    }
1069
1070
    /**
1071
     * Executes all entity deletions for entities of the specified type.
1072
     *
1073
     * @param \Doctrine\ORM\Mapping\ClassMetadata $class
1074
     *
1075
     * @return void
1076
     */
1077 63
    private function executeDeletions($class)
1078
    {
1079 63
        $className  = $class->name;
1080 63
        $persister  = $this->getEntityPersister($className);
1081 63
        $invoke     = $this->listenersInvoker->getSubscribedSystems($class, Events::postRemove);
1082
1083 63
        foreach ($this->entityDeletions as $oid => $entity) {
1084 63
            if ($this->em->getClassMetadata(get_class($entity))->name !== $className) {
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1085 26
                continue;
1086
            }
1087
1088 63
            $persister->delete($entity);
1089
1090
            unset(
1091 63
                $this->entityDeletions[$oid],
1092 63
                $this->entityIdentifiers[$oid],
1093 63
                $this->originalEntityData[$oid],
1094 63
                $this->entityStates[$oid]
1095
            );
1096
1097
            // Entity with this $oid after deletion treated as NEW, even if the $oid
1098
            // is obtained by a new entity because the old one went out of scope.
1099
            //$this->entityStates[$oid] = self::STATE_NEW;
1100 63
            if ( ! $class->isIdentifierNatural()) {
1101 53
                $class->reflFields[$class->identifier[0]]->setValue($entity, null);
1102
            }
1103
1104 63
            if ($invoke !== ListenersInvoker::INVOKE_NONE) {
1105 63
                $this->listenersInvoker->invoke($class, Events::postRemove, $entity, new LifecycleEventArgs($entity, $this->em), $invoke);
1106
            }
1107
        }
1108 62
    }
1109
1110
    /**
1111
     * Gets the commit order.
1112
     *
1113
     * @param array|null $entityChangeSet
1114
     *
1115
     * @return array
1116
     */
1117 1005
    private function getCommitOrder(array $entityChangeSet = null)
1118
    {
1119 1005
        if ($entityChangeSet === null) {
1120 1005
            $entityChangeSet = array_merge($this->entityInsertions, $this->entityUpdates, $this->entityDeletions);
1121
        }
1122
1123 1005
        $calc = $this->getCommitOrderCalculator();
1124
1125
        // See if there are any new classes in the changeset, that are not in the
1126
        // commit order graph yet (don't have a node).
1127
        // We have to inspect changeSet to be able to correctly build dependencies.
1128
        // It is not possible to use IdentityMap here because post inserted ids
1129
        // are not yet available.
1130 1005
        $newNodes = array();
1131
1132 1005
        foreach ($entityChangeSet as $entity) {
1133 1005
            $class = $this->em->getClassMetadata(get_class($entity));
1134
1135 1005
            if ($calc->hasNode($class->name)) {
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1136 623
                continue;
1137
            }
1138
1139 1005
            $calc->addNode($class->name, $class);
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1140
1141 1005
            $newNodes[] = $class;
1142
        }
1143
1144
        // Calculate dependencies for new nodes
1145 1005
        while ($class = array_pop($newNodes)) {
1146 1005
            foreach ($class->associationMappings as $assoc) {
1147 884
                if ( ! ($assoc['isOwningSide'] && $assoc['type'] & ClassMetadata::TO_ONE)) {
1148 844
                    continue;
1149
                }
1150
1151 837
                $targetClass = $this->em->getClassMetadata($assoc['targetEntity']);
1152
1153 837
                if ( ! $calc->hasNode($targetClass->name)) {
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1154 648
                    $calc->addNode($targetClass->name, $targetClass);
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1155
1156 648
                    $newNodes[] = $targetClass;
1157
                }
1158
1159 837
                $joinColumns = reset($assoc['joinColumns']);
1160 837
                $isNullable  = isset($joinColumns['nullable']) ? $joinColumns['nullable'] : false;
1161
1162 837
                $calc->addDependency($targetClass->name, $class->name, $isNullable ? 0 : 1);
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1163
1164
                // If the target class has mapped subclasses, these share the same dependency.
1165 837
                if ( ! $targetClass->subClasses) {
0 ignored issues
show
Bug introduced by
Accessing subClasses on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1166 830
                    continue;
1167
                }
1168
1169 217
                foreach ($targetClass->subClasses as $subClassName) {
0 ignored issues
show
Bug introduced by
Accessing subClasses on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1170 217
                    $targetSubClass = $this->em->getClassMetadata($subClassName);
1171
1172 217
                    if ( ! $calc->hasNode($subClassName)) {
1173 189
                        $calc->addNode($targetSubClass->name, $targetSubClass);
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1174
1175 189
                        $newNodes[] = $targetSubClass;
1176
                    }
1177
1178 217
                    $calc->addDependency($targetSubClass->name, $class->name, 1);
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1179
                }
1180
            }
1181
        }
1182
1183 1005
        return $calc->sort();
1184
    }
1185
1186
    /**
1187
     * Schedules an entity for insertion into the database.
1188
     * If the entity already has an identifier, it will be added to the identity map.
1189
     *
1190
     * @param object $entity The entity to schedule for insertion.
1191
     *
1192
     * @return void
1193
     *
1194
     * @throws ORMInvalidArgumentException
1195
     * @throws \InvalidArgumentException
1196
     */
1197 1022
    public function scheduleForInsert($entity)
1198
    {
1199 1022
        $oid = spl_object_hash($entity);
1200
1201 1022
        if (isset($this->entityUpdates[$oid])) {
1202
            throw new InvalidArgumentException("Dirty entity can not be scheduled for insertion.");
1203
        }
1204
1205 1022
        if (isset($this->entityDeletions[$oid])) {
1206 1
            throw ORMInvalidArgumentException::scheduleInsertForRemovedEntity($entity);
1207
        }
1208 1022
        if (isset($this->originalEntityData[$oid]) && ! isset($this->entityInsertions[$oid])) {
1209 1
            throw ORMInvalidArgumentException::scheduleInsertForManagedEntity($entity);
1210
        }
1211
1212 1022
        if (isset($this->entityInsertions[$oid])) {
1213 1
            throw ORMInvalidArgumentException::scheduleInsertTwice($entity);
1214
        }
1215
1216 1022
        $this->entityInsertions[$oid] = $entity;
1217
1218 1022
        if (isset($this->entityIdentifiers[$oid])) {
1219 260
            $this->addToIdentityMap($entity);
1220
        }
1221
1222 1022
        if ($entity instanceof NotifyPropertyChanged) {
1223 5
            $entity->addPropertyChangedListener($this);
1224
        }
1225 1022
    }
1226
1227
    /**
1228
     * Checks whether an entity is scheduled for insertion.
1229
     *
1230
     * @param object $entity
1231
     *
1232
     * @return boolean
1233
     */
1234 628
    public function isScheduledForInsert($entity)
1235
    {
1236 628
        return isset($this->entityInsertions[spl_object_hash($entity)]);
1237
    }
1238
1239
    /**
1240
     * Schedules an entity for being updated.
1241
     *
1242
     * @param object $entity The entity to schedule for being updated.
1243
     *
1244
     * @return void
1245
     *
1246
     * @throws ORMInvalidArgumentException
1247
     */
1248 1
    public function scheduleForUpdate($entity)
1249
    {
1250 1
        $oid = spl_object_hash($entity);
1251
1252 1
        if ( ! isset($this->entityIdentifiers[$oid])) {
1253
            throw ORMInvalidArgumentException::entityHasNoIdentity($entity, "scheduling for update");
1254
        }
1255
1256 1
        if (isset($this->entityDeletions[$oid])) {
1257
            throw ORMInvalidArgumentException::entityIsRemoved($entity, "schedule for update");
1258
        }
1259
1260 1
        if ( ! isset($this->entityUpdates[$oid]) && ! isset($this->entityInsertions[$oid])) {
1261 1
            $this->entityUpdates[$oid] = $entity;
1262
        }
1263 1
    }
1264
1265
    /**
1266
     * INTERNAL:
1267
     * Schedules an extra update that will be executed immediately after the
1268
     * regular entity updates within the currently running commit cycle.
1269
     *
1270
     * Extra updates for entities are stored as (entity, changeset) tuples.
1271
     *
1272
     * @ignore
1273
     *
1274
     * @param object $entity    The entity for which to schedule an extra update.
1275
     * @param array  $changeset The changeset of the entity (what to update).
1276
     *
1277
     * @return void
1278
     */
1279 40
    public function scheduleExtraUpdate($entity, array $changeset)
1280
    {
1281 40
        $oid         = spl_object_hash($entity);
1282 40
        $extraUpdate = array($entity, $changeset);
1283
1284 40
        if (isset($this->extraUpdates[$oid])) {
1285 1
            list($ignored, $changeset2) = $this->extraUpdates[$oid];
0 ignored issues
show
Unused Code introduced by
The assignment to $ignored is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
1286
1287 1
            $extraUpdate = array($entity, $changeset + $changeset2);
1288
        }
1289
1290 40
        $this->extraUpdates[$oid] = $extraUpdate;
1291 40
    }
1292
1293
    /**
1294
     * Checks whether an entity is registered as dirty in the unit of work.
1295
     * Note: Is not very useful currently as dirty entities are only registered
1296
     * at commit time.
1297
     *
1298
     * @param object $entity
1299
     *
1300
     * @return boolean
1301
     */
1302
    public function isScheduledForUpdate($entity)
1303
    {
1304
        return isset($this->entityUpdates[spl_object_hash($entity)]);
1305
    }
1306
1307
    /**
1308
     * Checks whether an entity is registered to be checked in the unit of work.
1309
     *
1310
     * @param object $entity
1311
     *
1312
     * @return boolean
1313
     */
1314 1
    public function isScheduledForDirtyCheck($entity)
1315
    {
1316 1
        $rootEntityName = $this->em->getClassMetadata(get_class($entity))->rootEntityName;
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1317
1318 1
        return isset($this->scheduledForSynchronization[$rootEntityName][spl_object_hash($entity)]);
1319
    }
1320
1321
    /**
1322
     * INTERNAL:
1323
     * Schedules an entity for deletion.
1324
     *
1325
     * @param object $entity
1326
     *
1327
     * @return void
1328
     */
1329 66
    public function scheduleForDelete($entity)
1330
    {
1331 66
        $oid = spl_object_hash($entity);
1332
1333 66
        if (isset($this->entityInsertions[$oid])) {
1334 1
            if ($this->isInIdentityMap($entity)) {
1335
                $this->removeFromIdentityMap($entity);
1336
            }
1337
1338 1
            unset($this->entityInsertions[$oid], $this->entityStates[$oid]);
1339
1340 1
            return; // entity has not been persisted yet, so nothing more to do.
1341
        }
1342
1343 66
        if ( ! $this->isInIdentityMap($entity)) {
1344 1
            return;
1345
        }
1346
1347 65
        $this->removeFromIdentityMap($entity);
1348
1349 65
        if (isset($this->entityUpdates[$oid])) {
1350 2
            unset($this->entityUpdates[$oid]);
1351
        }
1352
1353 65
        if ( ! isset($this->entityDeletions[$oid])) {
1354 65
            $this->entityDeletions[$oid] = $entity;
1355 65
            $this->entityStates[$oid]    = self::STATE_REMOVED;
1356
        }
1357 65
    }
1358
1359
    /**
1360
     * Checks whether an entity is registered as removed/deleted with the unit
1361
     * of work.
1362
     *
1363
     * @param object $entity
1364
     *
1365
     * @return boolean
1366
     */
1367 17
    public function isScheduledForDelete($entity)
1368
    {
1369 17
        return isset($this->entityDeletions[spl_object_hash($entity)]);
1370
    }
1371
1372
    /**
1373
     * Checks whether an entity is scheduled for insertion, update or deletion.
1374
     *
1375
     * @param object $entity
1376
     *
1377
     * @return boolean
1378
     */
1379
    public function isEntityScheduled($entity)
1380
    {
1381
        $oid = spl_object_hash($entity);
1382
1383
        return isset($this->entityInsertions[$oid])
1384
            || isset($this->entityUpdates[$oid])
1385
            || isset($this->entityDeletions[$oid]);
1386
    }
1387
1388
    /**
1389
     * INTERNAL:
1390
     * Registers an entity in the identity map.
1391
     * Note that entities in a hierarchy are registered with the class name of
1392
     * the root entity.
1393
     *
1394
     * @ignore
1395
     *
1396
     * @param object $entity The entity to register.
1397
     *
1398
     * @return boolean TRUE if the registration was successful, FALSE if the identity of
1399
     *                 the entity in question is already managed.
1400
     *
1401
     * @throws ORMInvalidArgumentException
1402
     */
1403 1083
    public function addToIdentityMap($entity)
1404
    {
1405 1083
        $classMetadata = $this->em->getClassMetadata(get_class($entity));
1406 1083
        $idHash        = implode(' ', $this->entityIdentifiers[spl_object_hash($entity)]);
1407
1408 1083
        if ($idHash === '') {
1409 1
            throw ORMInvalidArgumentException::entityWithoutIdentity($classMetadata->name, $entity);
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1410
        }
1411
1412 1082
        $className = $classMetadata->rootEntityName;
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1413
1414 1082
        if (isset($this->identityMap[$className][$idHash])) {
1415 78
            return false;
1416
        }
1417
1418 1082
        $this->identityMap[$className][$idHash] = $entity;
1419
1420 1082
        return true;
1421
    }
1422
1423
    /**
1424
     * Gets the state of an entity with regard to the current unit of work.
1425
     *
1426
     * @param object   $entity
1427
     * @param int|null $assume The state to assume if the state is not yet known (not MANAGED or REMOVED).
1428
     *                         This parameter can be set to improve performance of entity state detection
1429
     *                         by potentially avoiding a database lookup if the distinction between NEW and DETACHED
1430
     *                         is either known or does not matter for the caller of the method.
1431
     *
1432
     * @return int The entity state.
1433
     */
1434 1035
    public function getEntityState($entity, $assume = null)
1435
    {
1436 1035
        $oid = spl_object_hash($entity);
1437
1438 1035
        if (isset($this->entityStates[$oid])) {
1439 781
            return $this->entityStates[$oid];
1440
        }
1441
1442 1029
        if ($assume !== null) {
1443 1025
            return $assume;
1444
        }
1445
1446
        // State can only be NEW or DETACHED, because MANAGED/REMOVED states are known.
1447
        // Note that you can not remember the NEW or DETACHED state in _entityStates since
1448
        // the UoW does not hold references to such objects and the object hash can be reused.
1449
        // More generally because the state may "change" between NEW/DETACHED without the UoW being aware of it.
1450 13
        $class = $this->em->getClassMetadata(get_class($entity));
1451 13
        $id    = $class->getIdentifierValues($entity);
1452
1453 13
        if ( ! $id) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $id of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
1454 5
            return self::STATE_NEW;
1455
        }
1456
1457 10
        if ($class->containsForeignIdentifier) {
0 ignored issues
show
Bug introduced by
Accessing containsForeignIdentifier on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1458 1
            $id = $this->identifierFlattener->flattenIdentifier($class, $id);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
1459
        }
1460
1461
        switch (true) {
1462 10
            case ($class->isIdentifierNatural()):
0 ignored issues
show
Bug introduced by
The method isIdentifierNatural() does not exist on Doctrine\Common\Persistence\Mapping\ClassMetadata. Did you maybe mean isIdentifier()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
1463
                // Check for a version field, if available, to avoid a db lookup.
1464 5
                if ($class->isVersioned) {
0 ignored issues
show
Bug introduced by
Accessing isVersioned on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1465 1
                    return ($class->getFieldValue($entity, $class->versionField))
0 ignored issues
show
Bug introduced by
Accessing versionField on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1466
                        ? self::STATE_DETACHED
1467 1
                        : self::STATE_NEW;
1468
                }
1469
1470
                // Last try before db lookup: check the identity map.
1471 4
                if ($this->tryGetById($id, $class->rootEntityName)) {
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1472 1
                    return self::STATE_DETACHED;
1473
                }
1474
1475
                // db lookup
1476 4
                if ($this->getEntityPersister($class->name)->exists($entity)) {
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1477
                    return self::STATE_DETACHED;
1478
                }
1479
1480 4
                return self::STATE_NEW;
1481
1482 5
            case ( ! $class->idGenerator->isPostInsertGenerator()):
0 ignored issues
show
Bug introduced by
Accessing idGenerator on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1483
                // if we have a pre insert generator we can't be sure that having an id
1484
                // really means that the entity exists. We have to verify this through
1485
                // the last resort: a db lookup
1486
1487
                // Last try before db lookup: check the identity map.
1488
                if ($this->tryGetById($id, $class->rootEntityName)) {
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1489
                    return self::STATE_DETACHED;
1490
                }
1491
1492
                // db lookup
1493
                if ($this->getEntityPersister($class->name)->exists($entity)) {
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1494
                    return self::STATE_DETACHED;
1495
                }
1496
1497
                return self::STATE_NEW;
1498
1499
            default:
1500 5
                return self::STATE_DETACHED;
1501
        }
1502
    }
1503
1504
    /**
1505
     * INTERNAL:
1506
     * Removes an entity from the identity map. This effectively detaches the
1507
     * entity from the persistence management of Doctrine.
1508
     *
1509
     * @ignore
1510
     *
1511
     * @param object $entity
1512
     *
1513
     * @return boolean
1514
     *
1515
     * @throws ORMInvalidArgumentException
1516
     */
1517 76
    public function removeFromIdentityMap($entity)
1518
    {
1519 76
        $oid           = spl_object_hash($entity);
1520 76
        $classMetadata = $this->em->getClassMetadata(get_class($entity));
1521 76
        $idHash        = implode(' ', $this->entityIdentifiers[$oid]);
1522
1523 76
        if ($idHash === '') {
1524
            throw ORMInvalidArgumentException::entityHasNoIdentity($entity, "remove from identity map");
1525
        }
1526
1527 76
        $className = $classMetadata->rootEntityName;
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1528
1529 76
        if (isset($this->identityMap[$className][$idHash])) {
1530 76
            unset($this->identityMap[$className][$idHash]);
1531 76
            unset($this->readOnlyObjects[$oid]);
1532
1533
            //$this->entityStates[$oid] = self::STATE_DETACHED;
1534
1535 76
            return true;
1536
        }
1537
1538
        return false;
1539
    }
1540
1541
    /**
1542
     * INTERNAL:
1543
     * Gets an entity in the identity map by its identifier hash.
1544
     *
1545
     * @ignore
1546
     *
1547
     * @param string $idHash
1548
     * @param string $rootClassName
1549
     *
1550
     * @return object
1551
     */
1552
    public function getByIdHash($idHash, $rootClassName)
1553
    {
1554
        return $this->identityMap[$rootClassName][$idHash];
1555
    }
1556
1557
    /**
1558
     * INTERNAL:
1559
     * Tries to get an entity by its identifier hash. If no entity is found for
1560
     * the given hash, FALSE is returned.
1561
     *
1562
     * @ignore
1563
     *
1564
     * @param mixed  $idHash        (must be possible to cast it to string)
1565
     * @param string $rootClassName
1566
     *
1567
     * @return object|bool The found entity or FALSE.
1568
     */
1569 34
    public function tryGetByIdHash($idHash, $rootClassName)
1570
    {
1571 34
        $stringIdHash = (string) $idHash;
1572
1573 34
        if (isset($this->identityMap[$rootClassName][$stringIdHash])) {
1574 34
            return $this->identityMap[$rootClassName][$stringIdHash];
1575
        }
1576
1577 2
        return false;
1578
    }
1579
1580
    /**
1581
     * Checks whether an entity is registered in the identity map of this UnitOfWork.
1582
     *
1583
     * @param object $entity
1584
     *
1585
     * @return boolean
1586
     */
1587 212
    public function isInIdentityMap($entity)
1588
    {
1589 212
        $oid = spl_object_hash($entity);
1590
1591 212
        if ( ! isset($this->entityIdentifiers[$oid])) {
1592 30
            return false;
1593
        }
1594
1595 197
        $classMetadata = $this->em->getClassMetadata(get_class($entity));
1596 197
        $idHash        = implode(' ', $this->entityIdentifiers[$oid]);
1597
1598 197
        if ($idHash === '') {
1599
            return false;
1600
        }
1601
1602 197
        return isset($this->identityMap[$classMetadata->rootEntityName][$idHash]);
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1603
    }
1604
1605
    /**
1606
     * INTERNAL:
1607
     * Checks whether an identifier hash exists in the identity map.
1608
     *
1609
     * @ignore
1610
     *
1611
     * @param string $idHash
1612
     * @param string $rootClassName
1613
     *
1614
     * @return boolean
1615
     */
1616
    public function containsIdHash($idHash, $rootClassName)
1617
    {
1618
        return isset($this->identityMap[$rootClassName][$idHash]);
1619
    }
1620
1621
    /**
1622
     * Persists an entity as part of the current unit of work.
1623
     *
1624
     * @param object $entity The entity to persist.
1625
     *
1626
     * @return void
1627
     */
1628 1018
    public function persist($entity)
1629
    {
1630 1018
        $visited = array();
1631
1632 1018
        $this->doPersist($entity, $visited);
1633 1011
    }
1634
1635
    /**
1636
     * Persists an entity as part of the current unit of work.
1637
     *
1638
     * This method is internally called during persist() cascades as it tracks
1639
     * the already visited entities to prevent infinite recursions.
1640
     *
1641
     * @param object $entity  The entity to persist.
1642
     * @param array  $visited The already visited entities.
1643
     *
1644
     * @return void
1645
     *
1646
     * @throws ORMInvalidArgumentException
1647
     * @throws UnexpectedValueException
1648
     */
1649 1018
    private function doPersist($entity, array &$visited)
1650
    {
1651 1018
        $oid = spl_object_hash($entity);
1652
1653 1018
        if (isset($visited[$oid])) {
1654 109
            return; // Prevent infinite recursion
1655
        }
1656
1657 1018
        $visited[$oid] = $entity; // Mark visited
1658
1659 1018
        $class = $this->em->getClassMetadata(get_class($entity));
1660
1661
        // We assume NEW, so DETACHED entities result in an exception on flush (constraint violation).
1662
        // If we would detect DETACHED here we would throw an exception anyway with the same
1663
        // consequences (not recoverable/programming error), so just assuming NEW here
1664
        // lets us avoid some database lookups for entities with natural identifiers.
1665 1018
        $entityState = $this->getEntityState($entity, self::STATE_NEW);
1666
1667
        switch ($entityState) {
1668 1018
            case self::STATE_MANAGED:
1669
                // Nothing to do, except if policy is "deferred explicit"
1670 234
                if ($class->isChangeTrackingDeferredExplicit()) {
1671 2
                    $this->scheduleForDirtyCheck($entity);
1672
                }
1673 234
                break;
1674
1675 1018
            case self::STATE_NEW:
1676 1017
                $this->persistNew($class, $entity);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
1677 1017
                break;
1678
1679 1
            case self::STATE_REMOVED:
1680
                // Entity becomes managed again
1681 1
                unset($this->entityDeletions[$oid]);
1682 1
                $this->addToIdentityMap($entity);
1683
1684 1
                $this->entityStates[$oid] = self::STATE_MANAGED;
1685 1
                break;
1686
1687
            case self::STATE_DETACHED:
1688
                // Can actually not happen right now since we assume STATE_NEW.
1689
                throw ORMInvalidArgumentException::detachedEntityCannot($entity, "persisted");
1690
1691
            default:
1692
                throw new UnexpectedValueException("Unexpected entity state: $entityState." . self::objToStr($entity));
1693
        }
1694
1695 1018
        $this->cascadePersist($entity, $visited);
1696 1011
    }
1697
1698
    /**
1699
     * Deletes an entity as part of the current unit of work.
1700
     *
1701
     * @param object $entity The entity to remove.
1702
     *
1703
     * @return void
1704
     */
1705 65
    public function remove($entity)
1706
    {
1707 65
        $visited = array();
1708
1709 65
        $this->doRemove($entity, $visited);
1710 65
    }
1711
1712
    /**
1713
     * Deletes an entity as part of the current unit of work.
1714
     *
1715
     * This method is internally called during delete() cascades as it tracks
1716
     * the already visited entities to prevent infinite recursions.
1717
     *
1718
     * @param object $entity  The entity to delete.
1719
     * @param array  $visited The map of the already visited entities.
1720
     *
1721
     * @return void
1722
     *
1723
     * @throws ORMInvalidArgumentException If the instance is a detached entity.
1724
     * @throws UnexpectedValueException
1725
     */
1726 65
    private function doRemove($entity, array &$visited)
1727
    {
1728 65
        $oid = spl_object_hash($entity);
1729
1730 65
        if (isset($visited[$oid])) {
1731 1
            return; // Prevent infinite recursion
1732
        }
1733
1734 65
        $visited[$oid] = $entity; // mark visited
1735
1736
        // Cascade first, because scheduleForDelete() removes the entity from the identity map, which
1737
        // can cause problems when a lazy proxy has to be initialized for the cascade operation.
1738 65
        $this->cascadeRemove($entity, $visited);
1739
1740 65
        $class       = $this->em->getClassMetadata(get_class($entity));
1741 65
        $entityState = $this->getEntityState($entity);
1742
1743
        switch ($entityState) {
1744 65
            case self::STATE_NEW:
1745 65
            case self::STATE_REMOVED:
1746
                // nothing to do
1747 2
                break;
1748
1749 65
            case self::STATE_MANAGED:
1750 65
                $invoke = $this->listenersInvoker->getSubscribedSystems($class, Events::preRemove);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
1751
1752 65
                if ($invoke !== ListenersInvoker::INVOKE_NONE) {
1753 8
                    $this->listenersInvoker->invoke($class, Events::preRemove, $entity, new LifecycleEventArgs($entity, $this->em), $invoke);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
1754
                }
1755
1756 65
                $this->scheduleForDelete($entity);
1757 65
                break;
1758
1759
            case self::STATE_DETACHED:
1760
                throw ORMInvalidArgumentException::detachedEntityCannot($entity, "removed");
1761
            default:
1762
                throw new UnexpectedValueException("Unexpected entity state: $entityState." . self::objToStr($entity));
1763
        }
1764
1765 65
    }
1766
1767
    /**
1768
     * Merges the state of the given detached entity into this UnitOfWork.
1769
     *
1770
     * @param object $entity
1771
     *
1772
     * @return object The managed copy of the entity.
1773
     *
1774
     * @throws OptimisticLockException If the entity uses optimistic locking through a version
1775
     *         attribute and the version check against the managed copy fails.
1776
     *
1777
     * @todo Require active transaction!? OptimisticLockException may result in undefined state!?
1778
     */
1779 40
    public function merge($entity)
1780
    {
1781 40
        $visited = array();
1782
1783 40
        return $this->doMerge($entity, $visited);
1784
    }
1785
1786
    /**
1787
     * Executes a merge operation on an entity.
1788
     *
1789
     * @param object      $entity
1790
     * @param array       $visited
1791
     * @param object|null $prevManagedCopy
1792
     * @param array|null  $assoc
1793
     *
1794
     * @return object The managed copy of the entity.
1795
     *
1796
     * @throws OptimisticLockException If the entity uses optimistic locking through a version
1797
     *         attribute and the version check against the managed copy fails.
1798
     * @throws ORMInvalidArgumentException If the entity instance is NEW.
1799
     * @throws EntityNotFoundException
1800
     */
1801 40
    private function doMerge($entity, array &$visited, $prevManagedCopy = null, $assoc = null)
1802
    {
1803 40
        $oid = spl_object_hash($entity);
1804
1805 40
        if (isset($visited[$oid])) {
1806 4
            $managedCopy = $visited[$oid];
1807
1808 4
            if ($prevManagedCopy !== null) {
1809 4
                $this->updateAssociationWithMergedEntity($entity, $assoc, $prevManagedCopy, $managedCopy);
0 ignored issues
show
Bug introduced by
It seems like $assoc defined by parameter $assoc on line 1801 can also be of type null; however, Doctrine\ORM\UnitOfWork:...ationWithMergedEntity() does only seem to accept array, maybe add an additional type check?

This check looks at variables that have been passed in as parameters and are passed out again to other methods.

If the outgoing method call has stricter type requirements than the method itself, an issue is raised.

An additional type check may prevent trouble.

Loading history...
1810
            }
1811
1812 4
            return $managedCopy;
1813
        }
1814
1815 40
        $class = $this->em->getClassMetadata(get_class($entity));
1816
1817
        // First we assume DETACHED, although it can still be NEW but we can avoid
1818
        // an extra db-roundtrip this way. If it is not MANAGED but has an identity,
1819
        // we need to fetch it from the db anyway in order to merge.
1820
        // MANAGED entities are ignored by the merge operation.
1821 40
        $managedCopy = $entity;
1822
1823 40
        if ($this->getEntityState($entity, self::STATE_DETACHED) !== self::STATE_MANAGED) {
1824
            // Try to look the entity up in the identity map.
1825 39
            $id = $class->getIdentifierValues($entity);
1826
1827
            // If there is no ID, it is actually NEW.
1828 39
            if ( ! $id) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $id of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
1829 5
                $managedCopy = $this->newInstance($class);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
1830
1831 5
                $this->persistNew($class, $managedCopy);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
1832
            } else {
1833 35
                $flatId = ($class->containsForeignIdentifier)
0 ignored issues
show
Bug introduced by
Accessing containsForeignIdentifier on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1834 3
                    ? $this->identifierFlattener->flattenIdentifier($class, $id)
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
1835 35
                    : $id;
1836
1837 35
                $managedCopy = $this->tryGetById($flatId, $class->rootEntityName);
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
Bug Compatibility introduced by
The expression $this->tryGetById($flatI...class->rootEntityName); of type object|boolean adds the type boolean to the return on line 1901 which is incompatible with the return type documented by Doctrine\ORM\UnitOfWork::doMerge of type object.
Loading history...
1838
1839 35
                if ($managedCopy) {
1840
                    // We have the entity in-memory already, just make sure its not removed.
1841 14
                    if ($this->getEntityState($managedCopy) == self::STATE_REMOVED) {
0 ignored issues
show
Bug introduced by
It seems like $managedCopy defined by $this->tryGetById($flatI...$class->rootEntityName) on line 1837 can also be of type boolean; however, Doctrine\ORM\UnitOfWork::getEntityState() does only seem to accept object, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
1842 14
                        throw ORMInvalidArgumentException::entityIsRemoved($managedCopy, "merge");
0 ignored issues
show
Bug introduced by
It seems like $managedCopy defined by $this->tryGetById($flatI...$class->rootEntityName) on line 1837 can also be of type boolean; however, Doctrine\ORM\ORMInvalidA...tion::entityIsRemoved() does only seem to accept object, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
1843
                    }
1844
                } else {
1845
                    // We need to fetch the managed copy in order to merge.
1846 24
                    $managedCopy = $this->em->find($class->name, $flatId);
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1847
                }
1848
1849 35
                if ($managedCopy === null) {
1850
                    // If the identifier is ASSIGNED, it is NEW, otherwise an error
1851
                    // since the managed entity was not found.
1852 2
                    if ( ! $class->isIdentifierNatural()) {
0 ignored issues
show
Bug introduced by
The method isIdentifierNatural() does not exist on Doctrine\Common\Persistence\Mapping\ClassMetadata. Did you maybe mean isIdentifier()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
1853 1
                        throw EntityNotFoundException::fromClassNameAndIdentifier(
1854 1
                            $class->getName(),
1855 1
                            $this->identifierFlattener->flattenIdentifier($class, $id)
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
1856
                        );
1857
                    }
1858
1859 1
                    $managedCopy = $this->newInstance($class);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
1860 1
                    $class->setIdentifierValues($managedCopy, $id);
1861
1862 1
                    $this->persistNew($class, $managedCopy);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
1863
                }
1864
            }
1865
1866 38
            if ($class->isVersioned && $this->isLoaded($managedCopy) && $this->isLoaded($entity)) {
0 ignored issues
show
Bug introduced by
Accessing isVersioned on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
Bug introduced by
It seems like $managedCopy defined by $this->tryGetById($flatI...$class->rootEntityName) on line 1837 can also be of type boolean; however, Doctrine\ORM\UnitOfWork::isLoaded() does only seem to accept object, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
1867 4
                $reflField          = $class->reflFields[$class->versionField];
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
Bug introduced by
Accessing versionField on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1868 4
                $managedCopyVersion = $reflField->getValue($managedCopy);
1869 4
                $entityVersion      = $reflField->getValue($entity);
1870
1871
                // Throw exception if versions don't match.
1872 4
                if ($managedCopyVersion != $entityVersion) {
1873 1
                    throw OptimisticLockException::lockFailedVersionMismatch($entity, $entityVersion, $managedCopyVersion);
1874
                }
1875
            }
1876
1877 37
            $visited[$oid] = $managedCopy; // mark visited
1878
1879 37
            if ($this->isLoaded($entity)) {
1880 30
                if ($managedCopy instanceof Proxy && ! $managedCopy->__isInitialized()) {
1881 4
                    $managedCopy->__load();
1882
                }
1883
1884 30
                $this->mergeEntityStateIntoManagedCopy($entity, $managedCopy);
0 ignored issues
show
Bug introduced by
It seems like $managedCopy defined by $this->tryGetById($flatI...$class->rootEntityName) on line 1837 can also be of type boolean; however, Doctrine\ORM\UnitOfWork:...yStateIntoManagedCopy() does only seem to accept object, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
1885
            }
1886
1887 37
            if ($class->isChangeTrackingDeferredExplicit()) {
1888
                $this->scheduleForDirtyCheck($entity);
1889
            }
1890
        }
1891
1892 38
        if ($prevManagedCopy !== null) {
1893 6
            $this->updateAssociationWithMergedEntity($entity, $assoc, $prevManagedCopy, $managedCopy);
0 ignored issues
show
Bug introduced by
It seems like $managedCopy defined by $this->tryGetById($flatI...$class->rootEntityName) on line 1837 can also be of type boolean; however, Doctrine\ORM\UnitOfWork:...ationWithMergedEntity() does only seem to accept object, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
Bug introduced by
It seems like $assoc defined by parameter $assoc on line 1801 can also be of type null; however, Doctrine\ORM\UnitOfWork:...ationWithMergedEntity() does only seem to accept array, maybe add an additional type check?

This check looks at variables that have been passed in as parameters and are passed out again to other methods.

If the outgoing method call has stricter type requirements than the method itself, an issue is raised.

An additional type check may prevent trouble.

Loading history...
1894
        }
1895
1896
        // Mark the managed copy visited as well
1897 38
        $visited[spl_object_hash($managedCopy)] = $managedCopy;
1898
1899 38
        $this->cascadeMerge($entity, $managedCopy, $visited);
0 ignored issues
show
Bug introduced by
It seems like $managedCopy defined by $this->tryGetById($flatI...$class->rootEntityName) on line 1837 can also be of type boolean; however, Doctrine\ORM\UnitOfWork::cascadeMerge() does only seem to accept object, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
1900
1901 38
        return $managedCopy;
1902
    }
1903
1904
    /**
1905
     * Tests if an entity is loaded - must either be a loaded proxy or not a proxy
1906
     *
1907
     * @param object $entity
1908
     *
1909
     * @return bool
1910
     */
1911 38
    private function isLoaded($entity)
1912
    {
1913 38
        return !($entity instanceof Proxy) || $entity->__isInitialized();
1914
    }
1915
1916
    /**
1917
     * Sets/adds associated managed copies into the previous entity's association field
1918
     *
1919
     * @param object $entity
1920
     * @param array  $association
1921
     * @param object $previousManagedCopy
1922
     * @param object $managedCopy
1923
     *
1924
     * @return void
1925
     */
1926 6
    private function updateAssociationWithMergedEntity($entity, array $association, $previousManagedCopy, $managedCopy)
1927
    {
1928 6
        $assocField = $association['fieldName'];
1929 6
        $prevClass  = $this->em->getClassMetadata(get_class($previousManagedCopy));
1930
1931 6
        if ($association['type'] & ClassMetadata::TO_ONE) {
1932 6
            $prevClass->reflFields[$assocField]->setValue($previousManagedCopy, $managedCopy);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1933
1934 6
            return;
1935
        }
1936
1937 1
        $value   = $prevClass->reflFields[$assocField]->getValue($previousManagedCopy);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1938 1
        $value[] = $managedCopy;
1939
1940 1
        if ($association['type'] == ClassMetadata::ONE_TO_MANY) {
1941 1
            $class = $this->em->getClassMetadata(get_class($entity));
1942
1943 1
            $class->reflFields[$association['mappedBy']]->setValue($managedCopy, $previousManagedCopy);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
1944
        }
1945 1
    }
1946
1947
    /**
1948
     * Detaches an entity from the persistence management. It's persistence will
1949
     * no longer be managed by Doctrine.
1950
     *
1951
     * @param object $entity The entity to detach.
1952
     *
1953
     * @return void
1954
     */
1955 12
    public function detach($entity)
1956
    {
1957 12
        $visited = array();
1958
1959 12
        $this->doDetach($entity, $visited);
1960 12
    }
1961
1962
    /**
1963
     * Executes a detach operation on the given entity.
1964
     *
1965
     * @param object  $entity
1966
     * @param array   $visited
1967
     * @param boolean $noCascade if true, don't cascade detach operation.
1968
     *
1969
     * @return void
1970
     */
1971 14
    private function doDetach($entity, array &$visited, $noCascade = false)
1972
    {
1973 14
        $oid = spl_object_hash($entity);
1974
1975 14
        if (isset($visited[$oid])) {
1976
            return; // Prevent infinite recursion
1977
        }
1978
1979 14
        $visited[$oid] = $entity; // mark visited
1980
1981 14
        switch ($this->getEntityState($entity, self::STATE_DETACHED)) {
1982 14
            case self::STATE_MANAGED:
1983 12
                if ($this->isInIdentityMap($entity)) {
1984 11
                    $this->removeFromIdentityMap($entity);
1985
                }
1986
1987
                unset(
1988 12
                    $this->entityInsertions[$oid],
1989 12
                    $this->entityUpdates[$oid],
1990 12
                    $this->entityDeletions[$oid],
1991 12
                    $this->entityIdentifiers[$oid],
1992 12
                    $this->entityStates[$oid],
1993 12
                    $this->originalEntityData[$oid]
1994
                );
1995 12
                break;
1996 3
            case self::STATE_NEW:
1997 3
            case self::STATE_DETACHED:
1998 3
                return;
1999
        }
2000
2001 12
        if ( ! $noCascade) {
2002 12
            $this->cascadeDetach($entity, $visited);
2003
        }
2004 12
    }
2005
2006
    /**
2007
     * Refreshes the state of the given entity from the database, overwriting
2008
     * any local, unpersisted changes.
2009
     *
2010
     * @param object $entity The entity to refresh.
2011
     *
2012
     * @return void
2013
     *
2014
     * @throws InvalidArgumentException If the entity is not MANAGED.
2015
     */
2016 17
    public function refresh($entity)
2017
    {
2018 17
        $visited = array();
2019
2020 17
        $this->doRefresh($entity, $visited);
2021 17
    }
2022
2023
    /**
2024
     * Executes a refresh operation on an entity.
2025
     *
2026
     * @param object $entity  The entity to refresh.
2027
     * @param array  $visited The already visited entities during cascades.
2028
     *
2029
     * @return void
2030
     *
2031
     * @throws ORMInvalidArgumentException If the entity is not MANAGED.
2032
     */
2033 17
    private function doRefresh($entity, array &$visited)
2034
    {
2035 17
        $oid = spl_object_hash($entity);
2036
2037 17
        if (isset($visited[$oid])) {
2038
            return; // Prevent infinite recursion
2039
        }
2040
2041 17
        $visited[$oid] = $entity; // mark visited
2042
2043 17
        $class = $this->em->getClassMetadata(get_class($entity));
2044
2045 17
        if ($this->getEntityState($entity) !== self::STATE_MANAGED) {
2046
            throw ORMInvalidArgumentException::entityNotManaged($entity);
2047
        }
2048
2049 17
        $this->getEntityPersister($class->name)->refresh(
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2050 17
            array_combine($class->getIdentifierFieldNames(), $this->entityIdentifiers[$oid]),
2051
            $entity
2052
        );
2053
2054 17
        $this->cascadeRefresh($entity, $visited);
2055 17
    }
2056
2057
    /**
2058
     * Cascades a refresh operation to associated entities.
2059
     *
2060
     * @param object $entity
2061
     * @param array  $visited
2062
     *
2063
     * @return void
2064
     */
2065 17
    private function cascadeRefresh($entity, array &$visited)
2066
    {
2067 17
        $class = $this->em->getClassMetadata(get_class($entity));
2068
2069 17
        $associationMappings = array_filter(
2070 17
            $class->associationMappings,
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2071
            function ($assoc) { return $assoc['isCascadeRefresh']; }
2072
        );
2073
2074 17
        foreach ($associationMappings as $assoc) {
2075 5
            $relatedEntities = $class->reflFields[$assoc['fieldName']]->getValue($entity);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2076
2077
            switch (true) {
2078 5
                case ($relatedEntities instanceof PersistentCollection):
2079
                    // Unwrap so that foreach() does not initialize
2080 5
                    $relatedEntities = $relatedEntities->unwrap();
2081
                    // break; is commented intentionally!
2082
2083
                case ($relatedEntities instanceof Collection):
2084
                case (is_array($relatedEntities)):
2085 5
                    foreach ($relatedEntities as $relatedEntity) {
2086
                        $this->doRefresh($relatedEntity, $visited);
2087
                    }
2088 5
                    break;
2089
2090
                case ($relatedEntities !== null):
2091
                    $this->doRefresh($relatedEntities, $visited);
2092
                    break;
2093
2094 5
                default:
2095
                    // Do nothing
2096
            }
2097
        }
2098 17
    }
2099
2100
    /**
2101
     * Cascades a detach operation to associated entities.
2102
     *
2103
     * @param object $entity
2104
     * @param array  $visited
2105
     *
2106
     * @return void
2107
     */
2108 12
    private function cascadeDetach($entity, array &$visited)
2109
    {
2110 12
        $class = $this->em->getClassMetadata(get_class($entity));
2111
2112 12
        $associationMappings = array_filter(
2113 12
            $class->associationMappings,
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2114
            function ($assoc) { return $assoc['isCascadeDetach']; }
2115
        );
2116
2117 12
        foreach ($associationMappings as $assoc) {
2118 3
            $relatedEntities = $class->reflFields[$assoc['fieldName']]->getValue($entity);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2119
2120
            switch (true) {
2121 3
                case ($relatedEntities instanceof PersistentCollection):
2122
                    // Unwrap so that foreach() does not initialize
2123 2
                    $relatedEntities = $relatedEntities->unwrap();
2124
                    // break; is commented intentionally!
2125
2126
                case ($relatedEntities instanceof Collection):
2127
                case (is_array($relatedEntities)):
2128 3
                    foreach ($relatedEntities as $relatedEntity) {
2129 1
                        $this->doDetach($relatedEntity, $visited);
2130
                    }
2131 3
                    break;
2132
2133
                case ($relatedEntities !== null):
2134
                    $this->doDetach($relatedEntities, $visited);
2135
                    break;
2136
2137 3
                default:
2138
                    // Do nothing
2139
            }
2140
        }
2141 12
    }
2142
2143
    /**
2144
     * Cascades a merge operation to associated entities.
2145
     *
2146
     * @param object $entity
2147
     * @param object $managedCopy
2148
     * @param array  $visited
2149
     *
2150
     * @return void
2151
     */
2152 38
    private function cascadeMerge($entity, $managedCopy, array &$visited)
2153
    {
2154 38
        $class = $this->em->getClassMetadata(get_class($entity));
2155
2156 38
        $associationMappings = array_filter(
2157 38
            $class->associationMappings,
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2158
            function ($assoc) { return $assoc['isCascadeMerge']; }
2159
        );
2160
2161 38
        foreach ($associationMappings as $assoc) {
2162 15
            $relatedEntities = $class->reflFields[$assoc['fieldName']]->getValue($entity);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2163
2164 15
            if ($relatedEntities instanceof Collection) {
2165 9
                if ($relatedEntities === $class->reflFields[$assoc['fieldName']]->getValue($managedCopy)) {
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2166 1
                    continue;
2167
                }
2168
2169 8
                if ($relatedEntities instanceof PersistentCollection) {
2170
                    // Unwrap so that foreach() does not initialize
2171 5
                    $relatedEntities = $relatedEntities->unwrap();
2172
                }
2173
2174 8
                foreach ($relatedEntities as $relatedEntity) {
2175 8
                    $this->doMerge($relatedEntity, $visited, $managedCopy, $assoc);
2176
                }
2177 7
            } else if ($relatedEntities !== null) {
2178 14
                $this->doMerge($relatedEntities, $visited, $managedCopy, $assoc);
2179
            }
2180
        }
2181 38
    }
2182
2183
    /**
2184
     * Cascades the save operation to associated entities.
2185
     *
2186
     * @param object $entity
2187
     * @param array  $visited
2188
     *
2189
     * @return void
2190
     */
2191 1018
    private function cascadePersist($entity, array &$visited)
2192
    {
2193 1018
        $class = $this->em->getClassMetadata(get_class($entity));
2194
2195 1018
        $associationMappings = array_filter(
2196 1018
            $class->associationMappings,
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2197
            function ($assoc) { return $assoc['isCascadePersist']; }
2198
        );
2199
2200 1018
        foreach ($associationMappings as $assoc) {
2201 649
            $relatedEntities = $class->reflFields[$assoc['fieldName']]->getValue($entity);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2202
2203
            switch (true) {
2204 649
                case ($relatedEntities instanceof PersistentCollection):
2205
                    // Unwrap so that foreach() does not initialize
2206 21
                    $relatedEntities = $relatedEntities->unwrap();
2207
                    // break; is commented intentionally!
2208
2209
                case ($relatedEntities instanceof Collection):
2210 589
                case (is_array($relatedEntities)):
2211 553
                    if (($assoc['type'] & ClassMetadata::TO_MANY) <= 0) {
2212 3
                        throw ORMInvalidArgumentException::invalidAssociation(
2213 3
                            $this->em->getClassMetadata($assoc['targetEntity']),
0 ignored issues
show
Compatibility introduced by
$this->em->getClassMetad...$assoc['targetEntity']) of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
2214
                            $assoc,
2215
                            $relatedEntities
2216
                        );
2217
                    }
2218
2219 550
                    foreach ($relatedEntities as $relatedEntity) {
2220 282
                        $this->doPersist($relatedEntity, $visited);
2221
                    }
2222
2223 550
                    break;
2224
2225 579
                case ($relatedEntities !== null):
2226 246
                    if (! $relatedEntities instanceof $assoc['targetEntity']) {
2227 4
                        throw ORMInvalidArgumentException::invalidAssociation(
2228 4
                            $this->em->getClassMetadata($assoc['targetEntity']),
0 ignored issues
show
Compatibility introduced by
$this->em->getClassMetad...$assoc['targetEntity']) of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
2229
                            $assoc,
2230
                            $relatedEntities
2231
                        );
2232
                    }
2233
2234 242
                    $this->doPersist($relatedEntities, $visited);
2235 242
                    break;
2236
2237 643
                default:
2238
                    // Do nothing
2239
            }
2240
        }
2241 1011
    }
2242
2243
    /**
2244
     * Cascades the delete operation to associated entities.
2245
     *
2246
     * @param object $entity
2247
     * @param array  $visited
2248
     *
2249
     * @return void
2250
     */
2251 65
    private function cascadeRemove($entity, array &$visited)
2252
    {
2253 65
        $class = $this->em->getClassMetadata(get_class($entity));
2254
2255 65
        $associationMappings = array_filter(
2256 65
            $class->associationMappings,
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2257
            function ($assoc) { return $assoc['isCascadeRemove']; }
2258
        );
2259
2260 65
        $entitiesToCascade = array();
2261
2262 65
        foreach ($associationMappings as $assoc) {
2263 26
            if ($entity instanceof Proxy && !$entity->__isInitialized__) {
0 ignored issues
show
Bug introduced by
Accessing __isInitialized__ on the interface Doctrine\ORM\Proxy\Proxy suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2264 6
                $entity->__load();
2265
            }
2266
2267 26
            $relatedEntities = $class->reflFields[$assoc['fieldName']]->getValue($entity);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2268
2269
            switch (true) {
2270 26
                case ($relatedEntities instanceof Collection):
2271 19
                case (is_array($relatedEntities)):
2272
                    // If its a PersistentCollection initialization is intended! No unwrap!
2273 20
                    foreach ($relatedEntities as $relatedEntity) {
2274 10
                        $entitiesToCascade[] = $relatedEntity;
2275
                    }
2276 20
                    break;
2277
2278 19
                case ($relatedEntities !== null):
2279 7
                    $entitiesToCascade[] = $relatedEntities;
2280 7
                    break;
2281
2282 26
                default:
2283
                    // Do nothing
2284
            }
2285
        }
2286
2287 65
        foreach ($entitiesToCascade as $relatedEntity) {
2288 16
            $this->doRemove($relatedEntity, $visited);
2289
        }
2290 65
    }
2291
2292
    /**
2293
     * Acquire a lock on the given entity.
2294
     *
2295
     * @param object $entity
2296
     * @param int    $lockMode
2297
     * @param int    $lockVersion
2298
     *
2299
     * @return void
2300
     *
2301
     * @throws ORMInvalidArgumentException
2302
     * @throws TransactionRequiredException
2303
     * @throws OptimisticLockException
2304
     */
2305 11
    public function lock($entity, $lockMode, $lockVersion = null)
2306
    {
2307 11
        if ($entity === null) {
2308 1
            throw new \InvalidArgumentException("No entity passed to UnitOfWork#lock().");
2309
        }
2310
2311 10
        if ($this->getEntityState($entity, self::STATE_DETACHED) != self::STATE_MANAGED) {
2312 1
            throw ORMInvalidArgumentException::entityNotManaged($entity);
2313
        }
2314
2315 9
        $class = $this->em->getClassMetadata(get_class($entity));
2316
2317
        switch (true) {
2318 9
            case LockMode::OPTIMISTIC === $lockMode:
2319 6
                if ( ! $class->isVersioned) {
0 ignored issues
show
Bug introduced by
Accessing isVersioned on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2320 2
                    throw OptimisticLockException::notVersioned($class->name);
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2321
                }
2322
2323 4
                if ($lockVersion === null) {
2324
                    return;
2325
                }
2326
2327 4
                if ($entity instanceof Proxy && !$entity->__isInitialized__) {
0 ignored issues
show
Bug introduced by
Accessing __isInitialized__ on the interface Doctrine\ORM\Proxy\Proxy suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2328 1
                    $entity->__load();
2329
                }
2330
2331 4
                $entityVersion = $class->reflFields[$class->versionField]->getValue($entity);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
Bug introduced by
Accessing versionField on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2332
2333 4
                if ($entityVersion != $lockVersion) {
2334 2
                    throw OptimisticLockException::lockFailedVersionMismatch($entity, $lockVersion, $entityVersion);
2335
                }
2336
2337 2
                break;
2338
2339 3
            case LockMode::NONE === $lockMode:
2340 3
            case LockMode::PESSIMISTIC_READ === $lockMode:
2341 1
            case LockMode::PESSIMISTIC_WRITE === $lockMode:
2342 3
                if (!$this->em->getConnection()->isTransactionActive()) {
2343 2
                    throw TransactionRequiredException::transactionRequired();
2344
                }
2345
2346 1
                $oid = spl_object_hash($entity);
2347
2348 1
                $this->getEntityPersister($class->name)->lock(
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2349 1
                    array_combine($class->getIdentifierFieldNames(), $this->entityIdentifiers[$oid]),
2350
                    $lockMode
2351
                );
2352 1
                break;
2353
2354
            default:
2355
                // Do nothing
2356
        }
2357 3
    }
2358
2359
    /**
2360
     * Gets the CommitOrderCalculator used by the UnitOfWork to order commits.
2361
     *
2362
     * @return \Doctrine\ORM\Internal\CommitOrderCalculator
2363
     */
2364 1005
    public function getCommitOrderCalculator()
2365
    {
2366 1005
        return new Internal\CommitOrderCalculator();
2367
    }
2368
2369
    /**
2370
     * Clears the UnitOfWork.
2371
     *
2372
     * @param string|null $entityName if given, only entities of this type will get detached.
2373
     *
2374
     * @return void
2375
     */
2376 1215
    public function clear($entityName = null)
2377
    {
2378 1215
        if ($entityName === null) {
2379 1215
            $this->identityMap =
2380 1215
            $this->entityIdentifiers =
2381 1215
            $this->originalEntityData =
2382 1215
            $this->entityChangeSets =
2383 1215
            $this->entityStates =
2384 1215
            $this->scheduledForSynchronization =
2385 1215
            $this->entityInsertions =
2386 1215
            $this->entityUpdates =
2387 1215
            $this->entityDeletions =
2388 1215
            $this->collectionDeletions =
2389 1215
            $this->collectionUpdates =
2390 1215
            $this->extraUpdates =
2391 1215
            $this->readOnlyObjects =
2392 1215
            $this->visitedCollections =
2393 1215
            $this->orphanRemovals = array();
2394
        } else {
2395 2
            $visited = array();
2396
2397 2
            foreach ($this->identityMap as $className => $entities) {
2398 2
                if ($className !== $entityName) {
2399 1
                    continue;
2400
                }
2401
2402 2
                foreach ($entities as $entity) {
2403 2
                    $this->doDetach($entity, $visited, false);
2404
                }
2405
            }
2406
        }
2407
2408 1215
        if ($this->evm->hasListeners(Events::onClear)) {
2409 7
            $this->evm->dispatchEvent(Events::onClear, new Event\OnClearEventArgs($this->em, $entityName));
2410
        }
2411 1215
    }
2412
2413
    /**
2414
     * INTERNAL:
2415
     * Schedules an orphaned entity for removal. The remove() operation will be
2416
     * invoked on that entity at the beginning of the next commit of this
2417
     * UnitOfWork.
2418
     *
2419
     * @ignore
2420
     *
2421
     * @param object $entity
2422
     *
2423
     * @return void
2424
     */
2425 17
    public function scheduleOrphanRemoval($entity)
2426
    {
2427 17
        $this->orphanRemovals[spl_object_hash($entity)] = $entity;
2428 17
    }
2429
2430
    /**
2431
     * INTERNAL:
2432
     * Cancels a previously scheduled orphan removal.
2433
     *
2434
     * @ignore
2435
     *
2436
     * @param object $entity
2437
     *
2438
     * @return void
2439
     */
2440 111
    public function cancelOrphanRemoval($entity)
2441
    {
2442 111
        unset($this->orphanRemovals[spl_object_hash($entity)]);
2443 111
    }
2444
2445
    /**
2446
     * INTERNAL:
2447
     * Schedules a complete collection for removal when this UnitOfWork commits.
2448
     *
2449
     * @param PersistentCollection $coll
2450
     *
2451
     * @return void
2452
     */
2453 13
    public function scheduleCollectionDeletion(PersistentCollection $coll)
2454
    {
2455 13
        $coid = spl_object_hash($coll);
2456
2457
        // TODO: if $coll is already scheduled for recreation ... what to do?
2458
        // Just remove $coll from the scheduled recreations?
2459 13
        if (isset($this->collectionUpdates[$coid])) {
2460
            unset($this->collectionUpdates[$coid]);
2461
        }
2462
2463 13
        $this->collectionDeletions[$coid] = $coll;
2464 13
    }
2465
2466
    /**
2467
     * @param PersistentCollection $coll
2468
     *
2469
     * @return bool
2470
     */
2471
    public function isCollectionScheduledForDeletion(PersistentCollection $coll)
2472
    {
2473
        return isset($this->collectionDeletions[spl_object_hash($coll)]);
2474
    }
2475
2476
    /**
2477
     * @param ClassMetadata $class
2478
     *
2479
     * @return \Doctrine\Common\Persistence\ObjectManagerAware|object
2480
     */
2481 667
    private function newInstance($class)
2482
    {
2483 667
        $entity = $class->newInstance();
2484
2485 667
        if ($entity instanceof \Doctrine\Common\Persistence\ObjectManagerAware) {
2486 4
            $entity->injectObjectManager($this->em, $class);
2487
        }
2488
2489 667
        return $entity;
2490
    }
2491
2492
    /**
2493
     * INTERNAL:
2494
     * Creates an entity. Used for reconstitution of persistent entities.
2495
     *
2496
     * Internal note: Highly performance-sensitive method.
2497
     *
2498
     * @ignore
2499
     *
2500
     * @param string $className The name of the entity class.
2501
     * @param array  $data      The data for the entity.
2502
     * @param array  $hints     Any hints to account for during reconstitution/lookup of the entity.
2503
     *
2504
     * @return object The managed entity instance.
2505
     *
2506
     * @todo Rename: getOrCreateEntity
2507
     */
2508 806
    public function createEntity($className, array $data, &$hints = array())
2509
    {
2510 806
        $class = $this->em->getClassMetadata($className);
2511
        //$isReadOnly = isset($hints[Query::HINT_READ_ONLY]);
2512
2513 806
        $id = $this->identifierFlattener->flattenIdentifier($class, $data);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
2514 806
        $idHash = implode(' ', $id);
2515
2516 806
        if (isset($this->identityMap[$class->rootEntityName][$idHash])) {
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2517 312
            $entity = $this->identityMap[$class->rootEntityName][$idHash];
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2518 312
            $oid = spl_object_hash($entity);
2519
2520
            if (
2521 312
                isset($hints[Query::HINT_REFRESH])
2522 312
                && isset($hints[Query::HINT_REFRESH_ENTITY])
2523 312
                && ($unmanagedProxy = $hints[Query::HINT_REFRESH_ENTITY]) !== $entity
2524 312
                && $unmanagedProxy instanceof Proxy
2525 312
                && $this->isIdentifierEquals($unmanagedProxy, $entity)
2526
            ) {
2527
                // DDC-1238 - we have a managed instance, but it isn't the provided one.
2528
                // Therefore we clear its identifier. Also, we must re-fetch metadata since the
2529
                // refreshed object may be anything
2530
2531 2
                foreach ($class->identifier as $fieldName) {
0 ignored issues
show
Bug introduced by
Accessing identifier on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2532 2
                    $class->reflFields[$fieldName]->setValue($unmanagedProxy, null);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2533
                }
2534
2535 2
                return $unmanagedProxy;
2536
            }
2537
2538 310
            if ($entity instanceof Proxy && ! $entity->__isInitialized()) {
2539 21
                $entity->__setInitialized(true);
2540
2541 21
                $overrideLocalValues = true;
2542
2543 21
                if ($entity instanceof NotifyPropertyChanged) {
2544 21
                    $entity->addPropertyChangedListener($this);
2545
                }
2546
            } else {
2547 291
                $overrideLocalValues = isset($hints[Query::HINT_REFRESH]);
2548
2549
                // If only a specific entity is set to refresh, check that it's the one
2550 291
                if (isset($hints[Query::HINT_REFRESH_ENTITY])) {
2551 72
                    $overrideLocalValues = $hints[Query::HINT_REFRESH_ENTITY] === $entity;
2552
                }
2553
            }
2554
2555 310
            if ($overrideLocalValues) {
2556
                // inject ObjectManager upon refresh.
2557 113
                if ($entity instanceof ObjectManagerAware) {
2558 3
                    $entity->injectObjectManager($this->em, $class);
2559
                }
2560
2561 310
                $this->originalEntityData[$oid] = $data;
2562
            }
2563
        } else {
2564 664
            $entity = $this->newInstance($class);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
2565 664
            $oid    = spl_object_hash($entity);
2566
2567 664
            $this->entityIdentifiers[$oid]  = $id;
2568 664
            $this->entityStates[$oid]       = self::STATE_MANAGED;
2569 664
            $this->originalEntityData[$oid] = $data;
2570
2571 664
            $this->identityMap[$class->rootEntityName][$idHash] = $entity;
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2572
2573 664
            if ($entity instanceof NotifyPropertyChanged) {
2574 2
                $entity->addPropertyChangedListener($this);
2575
            }
2576
2577 664
            $overrideLocalValues = true;
2578
        }
2579
2580 805
        if ( ! $overrideLocalValues) {
2581 220
            return $entity;
2582
        }
2583
2584 702
        foreach ($data as $field => $value) {
2585 702
            if (isset($class->fieldMappings[$field])) {
0 ignored issues
show
Bug introduced by
Accessing fieldMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2586 702
                $class->reflFields[$field]->setValue($entity, $value);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2587
            }
2588
        }
2589
2590
        // Loading the entity right here, if its in the eager loading map get rid of it there.
2591 702
        unset($this->eagerLoadingEntities[$class->rootEntityName][$idHash]);
2592
2593 702
        if (isset($this->eagerLoadingEntities[$class->rootEntityName]) && ! $this->eagerLoadingEntities[$class->rootEntityName]) {
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2594
            unset($this->eagerLoadingEntities[$class->rootEntityName]);
2595
        }
2596
2597
        // Properly initialize any unfetched associations, if partial objects are not allowed.
2598 702
        if (isset($hints[Query::HINT_FORCE_PARTIAL_LOAD])) {
2599 33
            return $entity;
2600
        }
2601
2602 669
        foreach ($class->associationMappings as $field => $assoc) {
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2603
            // Check if the association is not among the fetch-joined associations already.
2604 586
            if (isset($hints['fetchAlias']) && isset($hints['fetched'][$hints['fetchAlias']][$field])) {
2605 259
                continue;
2606
            }
2607
2608 564
            $targetClass = $this->em->getClassMetadata($assoc['targetEntity']);
2609
2610
            switch (true) {
2611 564
                case ($assoc['type'] & ClassMetadata::TO_ONE):
2612 484
                    if ( ! $assoc['isOwningSide']) {
2613
2614
                        // use the given entity association
2615 64
                        if (isset($data[$field]) && is_object($data[$field]) && isset($this->entityStates[spl_object_hash($data[$field])])) {
2616
2617 2
                            $this->originalEntityData[$oid][$field] = $data[$field];
2618
2619 2
                            $class->reflFields[$field]->setValue($entity, $data[$field]);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2620 2
                            $targetClass->reflFields[$assoc['mappedBy']]->setValue($data[$field], $entity);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2621
2622 2
                            continue 2;
2623
                        }
2624
2625
                        // Inverse side of x-to-one can never be lazy
2626 62
                        $class->reflFields[$field]->setValue($entity, $this->getEntityPersister($assoc['targetEntity'])->loadOneToOneEntity($assoc, $entity));
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2627
2628 62
                        continue 2;
2629
                    }
2630
2631
                    // use the entity association
2632 484
                    if (isset($data[$field]) && is_object($data[$field]) && isset($this->entityStates[spl_object_hash($data[$field])])) {
2633 37
                        $class->reflFields[$field]->setValue($entity, $data[$field]);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2634 37
                        $this->originalEntityData[$oid][$field] = $data[$field];
2635
2636 37
                        continue;
2637
                    }
2638
2639 477
                    $associatedId = array();
2640
2641
                    // TODO: Is this even computed right in all cases of composite keys?
2642 477
                    foreach ($assoc['targetToSourceKeyColumns'] as $targetColumn => $srcColumn) {
2643 477
                        $joinColumnValue = isset($data[$srcColumn]) ? $data[$srcColumn] : null;
2644
2645 477
                        if ($joinColumnValue !== null) {
2646 282
                            if ($targetClass->containsForeignIdentifier) {
0 ignored issues
show
Bug introduced by
Accessing containsForeignIdentifier on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2647 11
                                $associatedId[$targetClass->getFieldForColumn($targetColumn)] = $joinColumnValue;
2648
                            } else {
2649 282
                                $associatedId[$targetClass->fieldNames[$targetColumn]] = $joinColumnValue;
0 ignored issues
show
Bug introduced by
Accessing fieldNames on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2650
                            }
2651 287
                        } elseif ($targetClass->containsForeignIdentifier
0 ignored issues
show
Bug introduced by
Accessing containsForeignIdentifier on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2652 287
                            && in_array($targetClass->getFieldForColumn($targetColumn), $targetClass->identifier, true)
0 ignored issues
show
Bug introduced by
Accessing identifier on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2653
                        ) {
2654
                            // the missing key is part of target's entity primary key
2655 7
                            $associatedId = array();
2656 477
                            break;
2657
                        }
2658
                    }
2659
2660 477
                    if ( ! $associatedId) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $associatedId of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
2661
                        // Foreign key is NULL
2662 287
                        $class->reflFields[$field]->setValue($entity, null);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2663 287
                        $this->originalEntityData[$oid][$field] = null;
2664
2665 287
                        continue;
2666
                    }
2667
2668 282
                    if ( ! isset($hints['fetchMode'][$class->name][$field])) {
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2669 279
                        $hints['fetchMode'][$class->name][$field] = $assoc['fetch'];
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2670
                    }
2671
2672
                    // Foreign key is set
2673
                    // Check identity map first
2674
                    // FIXME: Can break easily with composite keys if join column values are in
2675
                    //        wrong order. The correct order is the one in ClassMetadata#identifier.
2676 282
                    $relatedIdHash = implode(' ', $associatedId);
2677
2678
                    switch (true) {
2679 282
                        case (isset($this->identityMap[$targetClass->rootEntityName][$relatedIdHash])):
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2680 164
                            $newValue = $this->identityMap[$targetClass->rootEntityName][$relatedIdHash];
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2681
2682
                            // If this is an uninitialized proxy, we are deferring eager loads,
2683
                            // this association is marked as eager fetch, and its an uninitialized proxy (wtf!)
2684
                            // then we can append this entity for eager loading!
2685 164
                            if ($hints['fetchMode'][$class->name][$field] == ClassMetadata::FETCH_EAGER &&
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2686 164
                                isset($hints[self::HINT_DEFEREAGERLOAD]) &&
2687 164
                                !$targetClass->isIdentifierComposite &&
0 ignored issues
show
Bug introduced by
Accessing isIdentifierComposite on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2688 164
                                $newValue instanceof Proxy &&
2689 164
                                $newValue->__isInitialized__ === false) {
0 ignored issues
show
Bug introduced by
Accessing __isInitialized__ on the interface Doctrine\ORM\Proxy\Proxy suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2690
2691
                                $this->eagerLoadingEntities[$targetClass->rootEntityName][$relatedIdHash] = current($associatedId);
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2692
                            }
2693
2694 164
                            break;
2695
2696 191
                        case ($targetClass->subClasses):
0 ignored issues
show
Bug introduced by
Accessing subClasses on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2697
                            // If it might be a subtype, it can not be lazy. There isn't even
2698
                            // a way to solve this with deferred eager loading, which means putting
2699
                            // an entity with subclasses at a *-to-one location is really bad! (performance-wise)
2700 30
                            $newValue = $this->getEntityPersister($assoc['targetEntity'])->loadOneToOneEntity($assoc, $entity, $associatedId);
2701 30
                            break;
2702
2703
                        default:
2704
                            switch (true) {
2705
                                // We are negating the condition here. Other cases will assume it is valid!
2706 162
                                case ($hints['fetchMode'][$class->name][$field] !== ClassMetadata::FETCH_EAGER):
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2707 155
                                    $newValue = $this->em->getProxyFactory()->getProxy($assoc['targetEntity'], $associatedId);
2708 155
                                    break;
2709
2710
                                // Deferred eager load only works for single identifier classes
2711 7
                                case (isset($hints[self::HINT_DEFEREAGERLOAD]) && ! $targetClass->isIdentifierComposite):
0 ignored issues
show
Bug introduced by
Accessing isIdentifierComposite on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2712
                                    // TODO: Is there a faster approach?
2713 7
                                    $this->eagerLoadingEntities[$targetClass->rootEntityName][$relatedIdHash] = current($associatedId);
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2714
2715 7
                                    $newValue = $this->em->getProxyFactory()->getProxy($assoc['targetEntity'], $associatedId);
2716 7
                                    break;
2717
2718
                                default:
2719
                                    // TODO: This is very imperformant, ignore it?
2720
                                    $newValue = $this->em->find($assoc['targetEntity'], $associatedId);
2721
                                    break;
2722
                            }
2723
2724
                            // PERF: Inlined & optimized code from UnitOfWork#registerManaged()
2725 162
                            $newValueOid = spl_object_hash($newValue);
2726 162
                            $this->entityIdentifiers[$newValueOid] = $associatedId;
2727 162
                            $this->identityMap[$targetClass->rootEntityName][$relatedIdHash] = $newValue;
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2728
2729
                            if (
2730 162
                                $newValue instanceof NotifyPropertyChanged &&
2731 162
                                ( ! $newValue instanceof Proxy || $newValue->__isInitialized())
2732
                            ) {
2733
                                $newValue->addPropertyChangedListener($this);
2734
                            }
2735 162
                            $this->entityStates[$newValueOid] = self::STATE_MANAGED;
2736
                            // make sure that when an proxy is then finally loaded, $this->originalEntityData is set also!
2737 162
                            break;
2738
                    }
2739
2740 282
                    $this->originalEntityData[$oid][$field] = $newValue;
2741 282
                    $class->reflFields[$field]->setValue($entity, $newValue);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2742
2743 282
                    if ($assoc['inversedBy'] && $assoc['type'] & ClassMetadata::ONE_TO_ONE) {
2744 50
                        $inverseAssoc = $targetClass->associationMappings[$assoc['inversedBy']];
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2745 50
                        $targetClass->reflFields[$inverseAssoc['fieldName']]->setValue($newValue, $entity);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2746
                    }
2747
2748 282
                    break;
2749
2750
                default:
2751
                    // Ignore if its a cached collection
2752 486
                    if (isset($hints[Query::HINT_CACHE_ENABLED]) && $class->getFieldValue($entity, $field) instanceof PersistentCollection) {
2753
                        break;
2754
                    }
2755
2756
                    // use the given collection
2757 486
                    if (isset($data[$field]) && $data[$field] instanceof PersistentCollection) {
2758
2759 2
                        $data[$field]->setOwner($entity, $assoc);
2760
2761 2
                        $class->reflFields[$field]->setValue($entity, $data[$field]);
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2762 2
                        $this->originalEntityData[$oid][$field] = $data[$field];
2763
2764 2
                        break;
2765
                    }
2766
2767
                    // Inject collection
2768 486
                    $pColl = new PersistentCollection($this->em, $targetClass, new ArrayCollection);
0 ignored issues
show
Compatibility introduced by
$targetClass of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
2769 486
                    $pColl->setOwner($entity, $assoc);
2770 486
                    $pColl->setInitialized(false);
2771
2772 486
                    $reflField = $class->reflFields[$field];
0 ignored issues
show
Bug introduced by
Accessing reflFields on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2773 486
                    $reflField->setValue($entity, $pColl);
2774
2775 486
                    if ($assoc['fetch'] == ClassMetadata::FETCH_EAGER) {
2776 4
                        $this->loadCollection($pColl);
2777 4
                        $pColl->takeSnapshot();
2778
                    }
2779
2780 486
                    $this->originalEntityData[$oid][$field] = $pColl;
2781 564
                    break;
2782
            }
2783
        }
2784
2785 669
        if ($overrideLocalValues) {
2786
            // defer invoking of postLoad event to hydration complete step
2787 669
            $this->hydrationCompleteHandler->deferPostLoadInvoking($class, $entity);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
2788
        }
2789
2790 669
        return $entity;
2791
    }
2792
2793
    /**
2794
     * @return void
2795
     */
2796 863
    public function triggerEagerLoads()
2797
    {
2798 863
        if ( ! $this->eagerLoadingEntities) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $this->eagerLoadingEntities of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
2799 863
            return;
2800
        }
2801
2802
        // avoid infinite recursion
2803 7
        $eagerLoadingEntities       = $this->eagerLoadingEntities;
2804 7
        $this->eagerLoadingEntities = array();
2805
2806 7
        foreach ($eagerLoadingEntities as $entityName => $ids) {
2807 7
            if ( ! $ids) {
2808
                continue;
2809
            }
2810
2811 7
            $class = $this->em->getClassMetadata($entityName);
2812
2813 7
            $this->getEntityPersister($entityName)->loadAll(
2814 7
                array_combine($class->identifier, array(array_values($ids)))
0 ignored issues
show
Bug introduced by
Accessing identifier on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2815
            );
2816
        }
2817 7
    }
2818
2819
    /**
2820
     * Initializes (loads) an uninitialized persistent collection of an entity.
2821
     *
2822
     * @param \Doctrine\ORM\PersistentCollection $collection The collection to initialize.
2823
     *
2824
     * @return void
2825
     *
2826
     * @todo Maybe later move to EntityManager#initialize($proxyOrCollection). See DDC-733.
2827
     */
2828 142
    public function loadCollection(PersistentCollection $collection)
2829
    {
2830 142
        $assoc     = $collection->getMapping();
2831 142
        $persister = $this->getEntityPersister($assoc['targetEntity']);
2832
2833 142
        switch ($assoc['type']) {
2834 142
            case ClassMetadata::ONE_TO_MANY:
2835 75
                $persister->loadOneToManyCollection($assoc, $collection->getOwner(), $collection);
2836 75
                break;
2837
2838 81
            case ClassMetadata::MANY_TO_MANY:
2839 81
                $persister->loadManyToManyCollection($assoc, $collection->getOwner(), $collection);
2840 81
                break;
2841
        }
2842
2843 142
        $collection->setInitialized(true);
2844 142
    }
2845
2846
    /**
2847
     * Gets the identity map of the UnitOfWork.
2848
     *
2849
     * @return array
2850
     */
2851 2
    public function getIdentityMap()
2852
    {
2853 2
        return $this->identityMap;
2854
    }
2855
2856
    /**
2857
     * Gets the original data of an entity. The original data is the data that was
2858
     * present at the time the entity was reconstituted from the database.
2859
     *
2860
     * @param object $entity
2861
     *
2862
     * @return array
2863
     */
2864 114
    public function getOriginalEntityData($entity)
2865
    {
2866 114
        $oid = spl_object_hash($entity);
2867
2868 114
        if (isset($this->originalEntityData[$oid])) {
2869 111
            return $this->originalEntityData[$oid];
2870
        }
2871
2872 4
        return array();
2873
    }
2874
2875
    /**
2876
     * @ignore
2877
     *
2878
     * @param object $entity
2879
     * @param array  $data
2880
     *
2881
     * @return void
2882
     */
2883
    public function setOriginalEntityData($entity, array $data)
2884
    {
2885
        $this->originalEntityData[spl_object_hash($entity)] = $data;
2886
    }
2887
2888
    /**
2889
     * INTERNAL:
2890
     * Sets a property value of the original data array of an entity.
2891
     *
2892
     * @ignore
2893
     *
2894
     * @param string $oid
2895
     * @param string $property
2896
     * @param mixed  $value
2897
     *
2898
     * @return void
2899
     */
2900 312
    public function setOriginalEntityProperty($oid, $property, $value)
2901
    {
2902 312
        $this->originalEntityData[$oid][$property] = $value;
2903 312
    }
2904
2905
    /**
2906
     * Gets the identifier of an entity.
2907
     * The returned value is always an array of identifier values. If the entity
2908
     * has a composite identifier then the identifier values are in the same
2909
     * order as the identifier field names as returned by ClassMetadata#getIdentifierFieldNames().
2910
     *
2911
     * @param object $entity
2912
     *
2913
     * @return array The identifier values.
2914
     */
2915 842
    public function getEntityIdentifier($entity)
2916
    {
2917 842
        return $this->entityIdentifiers[spl_object_hash($entity)];
2918
    }
2919
2920
    /**
2921
     * Processes an entity instance to extract their identifier values.
2922
     *
2923
     * @param object $entity The entity instance.
2924
     *
2925
     * @return mixed A scalar value.
2926
     *
2927
     * @throws \Doctrine\ORM\ORMInvalidArgumentException
2928
     */
2929 126
    public function getSingleIdentifierValue($entity)
2930
    {
2931 126
        $class = $this->em->getClassMetadata(get_class($entity));
2932
2933 126
        if ($class->isIdentifierComposite) {
0 ignored issues
show
Bug introduced by
Accessing isIdentifierComposite on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2934
            throw ORMInvalidArgumentException::invalidCompositeIdentifier();
2935
        }
2936
2937 126
        $values = $this->isInIdentityMap($entity)
2938 113
            ? $this->getEntityIdentifier($entity)
2939 126
            : $class->getIdentifierValues($entity);
2940
2941 126
        return isset($values[$class->identifier[0]]) ? $values[$class->identifier[0]] : null;
0 ignored issues
show
Bug introduced by
Accessing identifier on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2942
    }
2943
2944
    /**
2945
     * Tries to find an entity with the given identifier in the identity map of
2946
     * this UnitOfWork.
2947
     *
2948
     * @param mixed  $id            The entity identifier to look for.
2949
     * @param string $rootClassName The name of the root class of the mapped entity hierarchy.
2950
     *
2951
     * @return object|bool Returns the entity with the specified identifier if it exists in
2952
     *                     this UnitOfWork, FALSE otherwise.
2953
     */
2954 520
    public function tryGetById($id, $rootClassName)
2955
    {
2956 520
        $idHash = implode(' ', (array) $id);
2957
2958 520
        if (isset($this->identityMap[$rootClassName][$idHash])) {
2959 78
            return $this->identityMap[$rootClassName][$idHash];
2960
        }
2961
2962 506
        return false;
2963
    }
2964
2965
    /**
2966
     * Schedules an entity for dirty-checking at commit-time.
2967
     *
2968
     * @param object $entity The entity to schedule for dirty-checking.
2969
     *
2970
     * @return void
2971
     *
2972
     * @todo Rename: scheduleForSynchronization
2973
     */
2974 5
    public function scheduleForDirtyCheck($entity)
2975
    {
2976 5
        $rootClassName = $this->em->getClassMetadata(get_class($entity))->rootEntityName;
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
2977
2978 5
        $this->scheduledForSynchronization[$rootClassName][spl_object_hash($entity)] = $entity;
2979 5
    }
2980
2981
    /**
2982
     * Checks whether the UnitOfWork has any pending insertions.
2983
     *
2984
     * @return boolean TRUE if this UnitOfWork has pending insertions, FALSE otherwise.
2985
     */
2986
    public function hasPendingInsertions()
2987
    {
2988
        return ! empty($this->entityInsertions);
2989
    }
2990
2991
    /**
2992
     * Calculates the size of the UnitOfWork. The size of the UnitOfWork is the
2993
     * number of entities in the identity map.
2994
     *
2995
     * @return integer
2996
     */
2997 1
    public function size()
2998
    {
2999
        $countArray = array_map(function ($item) { return count($item); }, $this->identityMap);
3000
3001 1
        return array_sum($countArray);
3002
    }
3003
3004
    /**
3005
     * Gets the EntityPersister for an Entity.
3006
     *
3007
     * @param string $entityName The name of the Entity.
3008
     *
3009
     * @return \Doctrine\ORM\Persisters\Entity\EntityPersister
3010
     */
3011 1067
    public function getEntityPersister($entityName)
3012
    {
3013 1067
        if (isset($this->persisters[$entityName])) {
3014 844
            return $this->persisters[$entityName];
3015
        }
3016
3017 1067
        $class = $this->em->getClassMetadata($entityName);
3018
3019
        switch (true) {
3020 1067
            case ($class->isInheritanceTypeNone()):
3021 1030
                $persister = new BasicEntityPersister($this->em, $class);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
3022 1030
                break;
3023
3024 358
            case ($class->isInheritanceTypeSingleTable()):
3025 212
                $persister = new SingleTablePersister($this->em, $class);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
3026 212
                break;
3027
3028 337
            case ($class->isInheritanceTypeJoined()):
3029 337
                $persister = new JoinedSubclassPersister($this->em, $class);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
3030 337
                break;
3031
3032
            default:
3033
                throw new \RuntimeException('No persister found for entity.');
3034
        }
3035
3036 1067
        if ($this->hasCache && $class->cache !== null) {
0 ignored issues
show
Bug introduced by
Accessing cache on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
3037 118
            $persister = $this->em->getConfiguration()
3038 118
                ->getSecondLevelCacheConfiguration()
3039 118
                ->getCacheFactory()
3040 118
                ->buildCachedEntityPersister($this->em, $persister, $class);
3041
        }
3042
3043 1067
        $this->persisters[$entityName] = $persister;
3044
3045 1067
        return $this->persisters[$entityName];
3046
    }
3047
3048
    /**
3049
     * Gets a collection persister for a collection-valued association.
3050
     *
3051
     * @param array $association
3052
     *
3053
     * @return \Doctrine\ORM\Persisters\Collection\CollectionPersister
3054
     */
3055 568
    public function getCollectionPersister(array $association)
3056
    {
3057 568
        $role = isset($association['cache'])
3058 75
            ? $association['sourceEntity'] . '::' . $association['fieldName']
3059 568
            : $association['type'];
3060
3061 568
        if (isset($this->collectionPersisters[$role])) {
3062 447
            return $this->collectionPersisters[$role];
3063
        }
3064
3065 568
        $persister = ClassMetadata::ONE_TO_MANY === $association['type']
3066 402
            ? new OneToManyPersister($this->em)
3067 568
            : new ManyToManyPersister($this->em);
3068
3069 568
        if ($this->hasCache && isset($association['cache'])) {
3070 74
            $persister = $this->em->getConfiguration()
3071 74
                ->getSecondLevelCacheConfiguration()
3072 74
                ->getCacheFactory()
3073 74
                ->buildCachedCollectionPersister($this->em, $persister, $association);
3074
        }
3075
3076 568
        $this->collectionPersisters[$role] = $persister;
3077
3078 568
        return $this->collectionPersisters[$role];
3079
    }
3080
3081
    /**
3082
     * INTERNAL:
3083
     * Registers an entity as managed.
3084
     *
3085
     * @param object $entity The entity.
3086
     * @param array  $id     The identifier values.
3087
     * @param array  $data   The original entity data.
3088
     *
3089
     * @return void
3090
     */
3091 201
    public function registerManaged($entity, array $id, array $data)
3092
    {
3093 201
        $oid = spl_object_hash($entity);
3094
3095 201
        $this->entityIdentifiers[$oid]  = $id;
3096 201
        $this->entityStates[$oid]       = self::STATE_MANAGED;
3097 201
        $this->originalEntityData[$oid] = $data;
3098
3099 201
        $this->addToIdentityMap($entity);
3100
3101 200
        if ($entity instanceof NotifyPropertyChanged && ( ! $entity instanceof Proxy || $entity->__isInitialized())) {
3102 2
            $entity->addPropertyChangedListener($this);
3103
        }
3104 200
    }
3105
3106
    /**
3107
     * INTERNAL:
3108
     * Clears the property changeset of the entity with the given OID.
3109
     *
3110
     * @param string $oid The entity's OID.
3111
     *
3112
     * @return void
3113
     */
3114
    public function clearEntityChangeSet($oid)
3115
    {
3116
        $this->entityChangeSets[$oid] = array();
3117
    }
3118
3119
    /* PropertyChangedListener implementation */
3120
3121
    /**
3122
     * Notifies this UnitOfWork of a property change in an entity.
3123
     *
3124
     * @param object $entity       The entity that owns the property.
3125
     * @param string $propertyName The name of the property that changed.
3126
     * @param mixed  $oldValue     The old value of the property.
3127
     * @param mixed  $newValue     The new value of the property.
3128
     *
3129
     * @return void
3130
     */
3131 3
    public function propertyChanged($entity, $propertyName, $oldValue, $newValue)
3132
    {
3133 3
        $oid   = spl_object_hash($entity);
3134 3
        $class = $this->em->getClassMetadata(get_class($entity));
3135
3136 3
        $isAssocField = isset($class->associationMappings[$propertyName]);
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
3137
3138 3
        if ( ! $isAssocField && ! isset($class->fieldMappings[$propertyName])) {
0 ignored issues
show
Bug introduced by
Accessing fieldMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
3139 1
            return; // ignore non-persistent fields
3140
        }
3141
3142
        // Update changeset and mark entity for synchronization
3143 3
        $this->entityChangeSets[$oid][$propertyName] = array($oldValue, $newValue);
3144
3145 3
        if ( ! isset($this->scheduledForSynchronization[$class->rootEntityName][$oid])) {
0 ignored issues
show
Bug introduced by
Accessing rootEntityName on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
3146 3
            $this->scheduleForDirtyCheck($entity);
3147
        }
3148 3
    }
3149
3150
    /**
3151
     * Gets the currently scheduled entity insertions in this UnitOfWork.
3152
     *
3153
     * @return array
3154
     */
3155 2
    public function getScheduledEntityInsertions()
3156
    {
3157 2
        return $this->entityInsertions;
3158
    }
3159
3160
    /**
3161
     * Gets the currently scheduled entity updates in this UnitOfWork.
3162
     *
3163
     * @return array
3164
     */
3165 2
    public function getScheduledEntityUpdates()
3166
    {
3167 2
        return $this->entityUpdates;
3168
    }
3169
3170
    /**
3171
     * Gets the currently scheduled entity deletions in this UnitOfWork.
3172
     *
3173
     * @return array
3174
     */
3175 1
    public function getScheduledEntityDeletions()
3176
    {
3177 1
        return $this->entityDeletions;
3178
    }
3179
3180
    /**
3181
     * Gets the currently scheduled complete collection deletions
3182
     *
3183
     * @return array
3184
     */
3185 1
    public function getScheduledCollectionDeletions()
3186
    {
3187 1
        return $this->collectionDeletions;
3188
    }
3189
3190
    /**
3191
     * Gets the currently scheduled collection inserts, updates and deletes.
3192
     *
3193
     * @return array
3194
     */
3195
    public function getScheduledCollectionUpdates()
3196
    {
3197
        return $this->collectionUpdates;
3198
    }
3199
3200
    /**
3201
     * Helper method to initialize a lazy loading proxy or persistent collection.
3202
     *
3203
     * @param object $obj
3204
     *
3205
     * @return void
3206
     */
3207 2
    public function initializeObject($obj)
3208
    {
3209 2
        if ($obj instanceof Proxy) {
3210 1
            $obj->__load();
3211
3212 1
            return;
3213
        }
3214
3215 1
        if ($obj instanceof PersistentCollection) {
3216 1
            $obj->initialize();
3217
        }
3218 1
    }
3219
3220
    /**
3221
     * Helper method to show an object as string.
3222
     *
3223
     * @param object $obj
3224
     *
3225
     * @return string
3226
     */
3227 1
    private static function objToStr($obj)
3228
    {
3229 1
        return method_exists($obj, '__toString') ? (string) $obj : get_class($obj).'@'.spl_object_hash($obj);
3230
    }
3231
3232
    /**
3233
     * Marks an entity as read-only so that it will not be considered for updates during UnitOfWork#commit().
3234
     *
3235
     * This operation cannot be undone as some parts of the UnitOfWork now keep gathering information
3236
     * on this object that might be necessary to perform a correct update.
3237
     *
3238
     * @param object $object
3239
     *
3240
     * @return void
3241
     *
3242
     * @throws ORMInvalidArgumentException
3243
     */
3244 6
    public function markReadOnly($object)
3245
    {
3246 6
        if ( ! is_object($object) || ! $this->isInIdentityMap($object)) {
3247 1
            throw ORMInvalidArgumentException::readOnlyRequiresManagedEntity($object);
3248
        }
3249
3250 5
        $this->readOnlyObjects[spl_object_hash($object)] = true;
3251 5
    }
3252
3253
    /**
3254
     * Is this entity read only?
3255
     *
3256
     * @param object $object
3257
     *
3258
     * @return bool
3259
     *
3260
     * @throws ORMInvalidArgumentException
3261
     */
3262 3
    public function isReadOnly($object)
3263
    {
3264 3
        if ( ! is_object($object)) {
3265
            throw ORMInvalidArgumentException::readOnlyRequiresManagedEntity($object);
3266
        }
3267
3268 3
        return isset($this->readOnlyObjects[spl_object_hash($object)]);
3269
    }
3270
3271
    /**
3272
     * Perform whatever processing is encapsulated here after completion of the transaction.
3273
     */
3274 1000
    private function afterTransactionComplete()
3275
    {
3276
        $this->performCallbackOnCachedPersister(function (CachedPersister $persister) {
3277 88
            $persister->afterTransactionComplete();
3278 1000
        });
3279 1000
    }
3280
3281
    /**
3282
     * Perform whatever processing is encapsulated here after completion of the rolled-back.
3283
     */
3284
    private function afterTransactionRolledBack()
3285
    {
3286 11
        $this->performCallbackOnCachedPersister(function (CachedPersister $persister) {
3287 3
            $persister->afterTransactionRolledBack();
3288 11
        });
3289 11
    }
3290
3291
    /**
3292
     * Performs an action after the transaction.
3293
     *
3294
     * @param callable $callback
3295
     */
3296 1005
    private function performCallbackOnCachedPersister(callable $callback)
3297
    {
3298 1005
        if ( ! $this->hasCache) {
3299 917
            return;
3300
        }
3301
3302 88
        foreach (array_merge($this->persisters, $this->collectionPersisters) as $persister) {
3303 88
            if ($persister instanceof CachedPersister) {
3304 88
                $callback($persister);
3305
            }
3306
        }
3307 88
    }
3308
3309 1009
    private function dispatchOnFlushEvent()
3310
    {
3311 1009
        if ($this->evm->hasListeners(Events::onFlush)) {
3312 4
            $this->evm->dispatchEvent(Events::onFlush, new OnFlushEventArgs($this->em));
3313
        }
3314 1009
    }
3315
3316 1004
    private function dispatchPostFlushEvent()
3317
    {
3318 1004
        if ($this->evm->hasListeners(Events::postFlush)) {
3319 5
            $this->evm->dispatchEvent(Events::postFlush, new PostFlushEventArgs($this->em));
3320
        }
3321 1003
    }
3322
3323
    /**
3324
     * Verifies if two given entities actually are the same based on identifier comparison
3325
     *
3326
     * @param object $entity1
3327
     * @param object $entity2
3328
     *
3329
     * @return bool
3330
     */
3331 14
    private function isIdentifierEquals($entity1, $entity2)
3332
    {
3333 14
        if ($entity1 === $entity2) {
3334
            return true;
3335
        }
3336
3337 14
        $class = $this->em->getClassMetadata(get_class($entity1));
3338
3339 14
        if ($class !== $this->em->getClassMetadata(get_class($entity2))) {
3340 11
            return false;
3341
        }
3342
3343 3
        $oid1 = spl_object_hash($entity1);
3344 3
        $oid2 = spl_object_hash($entity2);
3345
3346 3
        $id1 = isset($this->entityIdentifiers[$oid1])
3347 3
            ? $this->entityIdentifiers[$oid1]
3348 3
            : $this->identifierFlattener->flattenIdentifier($class, $class->getIdentifierValues($entity1));
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
3349 3
        $id2 = isset($this->entityIdentifiers[$oid2])
3350 3
            ? $this->entityIdentifiers[$oid2]
3351 3
            : $this->identifierFlattener->flattenIdentifier($class, $class->getIdentifierValues($entity2));
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
3352
3353 3
        return $id1 === $id2 || implode(' ', $id1) === implode(' ', $id2);
3354
    }
3355
3356
    /**
3357
     * @param object $entity
3358
     * @param object $managedCopy
3359
     *
3360
     * @throws ORMException
3361
     * @throws OptimisticLockException
3362
     * @throws TransactionRequiredException
3363
     */
3364 30
    private function mergeEntityStateIntoManagedCopy($entity, $managedCopy)
3365
    {
3366 30
        $class = $this->em->getClassMetadata(get_class($entity));
3367
3368 30
        foreach ($this->reflectionPropertiesGetter->getProperties($class->name) as $prop) {
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
3369 30
            $name = $prop->name;
3370
3371 30
            $prop->setAccessible(true);
3372
3373 30
            if ( ! isset($class->associationMappings[$name])) {
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
3374 30
                if ( ! $class->isIdentifier($name)) {
3375 30
                    $prop->setValue($managedCopy, $prop->getValue($entity));
3376
                }
3377
            } else {
3378 28
                $assoc2 = $class->associationMappings[$name];
0 ignored issues
show
Bug introduced by
Accessing associationMappings on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
3379
3380 28
                if ($assoc2['type'] & ClassMetadata::TO_ONE) {
3381 24
                    $other = $prop->getValue($entity);
3382 24
                    if ($other === null) {
3383 11
                        $prop->setValue($managedCopy, null);
3384
                    } else {
3385 16
                        if ($other instanceof Proxy && !$other->__isInitialized()) {
3386
                            // do not merge fields marked lazy that have not been fetched.
3387 4
                            continue;
3388
                        }
3389
3390 12
                        if ( ! $assoc2['isCascadeMerge']) {
3391 6
                            if ($this->getEntityState($other) === self::STATE_DETACHED) {
3392 3
                                $targetClass = $this->em->getClassMetadata($assoc2['targetEntity']);
3393 3
                                $relatedId   = $targetClass->getIdentifierValues($other);
3394
3395 3
                                if ($targetClass->subClasses) {
0 ignored issues
show
Bug introduced by
Accessing subClasses on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
3396 2
                                    $other = $this->em->find($targetClass->name, $relatedId);
0 ignored issues
show
Bug introduced by
Accessing name on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
3397
                                } else {
3398 1
                                    $other = $this->em->getProxyFactory()->getProxy(
3399 1
                                        $assoc2['targetEntity'],
3400
                                        $relatedId
3401
                                    );
3402 1
                                    $this->registerManaged($other, $relatedId, array());
3403
                                }
3404
                            }
3405
3406 20
                            $prop->setValue($managedCopy, $other);
3407
                        }
3408
                    }
3409
                } else {
3410 16
                    $mergeCol = $prop->getValue($entity);
3411
3412 16
                    if ($mergeCol instanceof PersistentCollection && ! $mergeCol->isInitialized()) {
3413
                        // do not merge fields marked lazy that have not been fetched.
3414
                        // keep the lazy persistent collection of the managed copy.
3415 5
                        continue;
3416
                    }
3417
3418 13
                    $managedCol = $prop->getValue($managedCopy);
3419
3420 13
                    if ( ! $managedCol) {
3421 3
                        $managedCol = new PersistentCollection(
3422 3
                            $this->em,
3423 3
                            $this->em->getClassMetadata($assoc2['targetEntity']),
0 ignored issues
show
Compatibility introduced by
$this->em->getClassMetad...assoc2['targetEntity']) of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ORM\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
3424 3
                            new ArrayCollection
3425
                        );
3426 3
                        $managedCol->setOwner($managedCopy, $assoc2);
3427 3
                        $prop->setValue($managedCopy, $managedCol);
3428
3429 3
                        $this->originalEntityData[spl_object_hash($entity)][$name] = $managedCol;
3430
                    }
3431
3432 13
                    if ($assoc2['isCascadeMerge']) {
3433 8
                        $managedCol->initialize();
3434
3435
                        // clear and set dirty a managed collection if its not also the same collection to merge from.
3436 8
                        if ( ! $managedCol->isEmpty() && $managedCol !== $mergeCol) {
3437 1
                            $managedCol->unwrap()->clear();
3438 1
                            $managedCol->setDirty(true);
3439
3440 1
                            if ($assoc2['isOwningSide']
3441 1
                                && $assoc2['type'] == ClassMetadata::MANY_TO_MANY
3442 1
                                && $class->isChangeTrackingNotify()
3443
                            ) {
3444
                                $this->scheduleForDirtyCheck($managedCopy);
3445
                            }
3446
                        }
3447
                    }
3448
                }
3449
            }
3450
3451 30
            if ($class->isChangeTrackingNotify()) {
3452
                // Just treat all properties as changed, there is no other choice.
3453 30
                $this->propertyChanged($managedCopy, $name, null, $prop->getValue($managedCopy));
3454
            }
3455
        }
3456 30
    }
3457
3458
    /**
3459
     * This method called by hydrators, and indicates that hydrator totally completed current hydration cycle.
3460
     * Unit of work able to fire deferred events, related to loading events here.
3461
     *
3462
     * @internal should be called internally from object hydrators
3463
     */
3464 874
    public function hydrationComplete()
3465
    {
3466 874
        $this->hydrationCompleteHandler->hydrationComplete();
3467 874
    }
3468
}
3469