Issues in LockAgentWorker.php - Fixed Issues - Inspection of "Merge pull request #6691 from keradus/php_syntax" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 8b8169...80f782 )

by Marco

created 2017-09-11 06:50 UTC

Tests/ORM/Functional/Locking/LockAgentWorker.php (1 issue)

Labels

Coding Style 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Doctrine\Tests\ORM\Functional\Locking;

use Doctrine\Common\Cache\ArrayCache;
use Doctrine\DBAL\Logging\EchoSQLLogger;
use Doctrine\ORM\Configuration;
use Doctrine\ORM\EntityManager;

class LockAgentWorker
{
    private $em;

    static public function run()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $lockAgent = new LockAgentWorker();

        $worker = new \GearmanWorker();
        $worker->addServer(
            isset($_SERVER['GEARMAN_HOST']) ? $_SERVER['GEARMAN_HOST'] : null,
            isset($_SERVER['GEARMAN_PORT']) ? $_SERVER['GEARMAN_PORT'] : 4730
        );
        $worker->addFunction("findWithLock", [$lockAgent, "findWithLock"]);
        $worker->addFunction("dqlWithLock", [$lockAgent, "dqlWithLock"]);
        $worker->addFunction('lock', [$lockAgent, 'lock']);

        while($worker->work()) {
            if ($worker->returnCode() != GEARMAN_SUCCESS) {
                echo "return_code: " . $worker->returnCode() . "\n";
                break;
            }
        }
    }

    protected function process($job, \Closure $do)
    {
        $fixture = $this->processWorkload($job);

        $s = microtime(true);
        $this->em->beginTransaction();
        $do($fixture, $this->em);

        sleep(1);
        $this->em->rollback();
        $this->em->clear();
        $this->em->close();
        $this->em->getConnection()->close();

        return (microtime(true) - $s);
    }

    public function findWithLock($job)
    {
        return $this->process($job, function($fixture, $em) {
            $entity = $em->find($fixture['entityName'], $fixture['entityId'], $fixture['lockMode']);
        });
    }

    public function dqlWithLock($job)
    {
        return $this->process($job, function($fixture, $em) {
            /* @var $query Doctrine\ORM\Query */
            $query = $em->createQuery($fixture['dql']);
            $query->setLockMode($fixture['lockMode']);
            $query->setParameters($fixture['dqlParams']);
            $result = $query->getResult();
        });
    }

    public function lock($job)
    {
        return $this->process($job, function($fixture, $em) {
            $entity = $em->find($fixture['entityName'], $fixture['entityId']);
            $em->lock($entity, $fixture['lockMode']);
        });
    }

    protected function processWorkload($job)
    {
        echo "Received job: " . $job->handle() . " for function " . $job->functionName() . "\n";

        $workload = $job->workload();
        $workload = unserialize($workload);

        if (!isset($workload['conn']) || !is_array($workload['conn'])) {
            throw new \InvalidArgumentException("Missing Database parameters");
        }

        $this->em = $this->createEntityManager($workload['conn']);

        if (!isset($workload['fixture'])) {
            throw new \InvalidArgumentException("Missing Fixture parameters");
        }
        return $workload['fixture'];
    }

    protected function createEntityManager($conn)
    {
        $config = new Configuration();
        $config->setProxyDir(__DIR__ . '/../../../Proxies');
        $config->setProxyNamespace('MyProject\Proxies');
        $config->setAutoGenerateProxyClasses(true);

        $annotDriver = $config->newDefaultAnnotationDriver([__DIR__ . '/../../../Models/'], true);
        $config->setMetadataDriverImpl($annotDriver);

        $cache = new ArrayCache();
        $config->setMetadataCacheImpl($cache);
        $config->setQueryCacheImpl($cache);
        $config->setSQLLogger(new EchoSQLLogger());

        $em = EntityManager::create($conn, $config);

        return $em;
    }
}

LockAgentWorker::run();


1			<?php
2
3			namespace Doctrine\Tests\ORM\Functional\Locking;
4
5			use Doctrine\Common\Cache\ArrayCache;
6			use Doctrine\DBAL\Logging\EchoSQLLogger;
7			use Doctrine\ORM\Configuration;
8			use Doctrine\ORM\EntityManager;
9
10			class LockAgentWorker
11			{
12			private $em;
13
14			static public function run()
			0 ignored issues – show Coding Style introduced 2017-07-31 20:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this `run` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
15			{
16			$lockAgent = new LockAgentWorker();
17
18			$worker = new \GearmanWorker();
19			$worker->addServer(
20			isset($_SERVER['GEARMAN_HOST']) ? $_SERVER['GEARMAN_HOST'] : null,
21			isset($_SERVER['GEARMAN_PORT']) ? $_SERVER['GEARMAN_PORT'] : 4730
22			);
23			$worker->addFunction("findWithLock", [$lockAgent, "findWithLock"]);
24			$worker->addFunction("dqlWithLock", [$lockAgent, "dqlWithLock"]);
25			$worker->addFunction('lock', [$lockAgent, 'lock']);
26
27			while($worker->work()) {
28			if ($worker->returnCode() != GEARMAN_SUCCESS) {
29			echo "return_code: " . $worker->returnCode() . "\n";
30			break;
31			}
32			}
33			}
34
35			protected function process($job, \Closure $do)
36			{
37			$fixture = $this->processWorkload($job);
38
39			$s = microtime(true);
40			$this->em->beginTransaction();
41			$do($fixture, $this->em);
42
43			sleep(1);
44			$this->em->rollback();
45			$this->em->clear();
46			$this->em->close();
47			$this->em->getConnection()->close();
48
49			return (microtime(true) - $s);
50			}
51
52			public function findWithLock($job)
53			{
54			return $this->process($job, function($fixture, $em) {
55			$entity = $em->find($fixture['entityName'], $fixture['entityId'], $fixture['lockMode']);
56			});
57			}
58
59			public function dqlWithLock($job)
60			{
61			return $this->process($job, function($fixture, $em) {
62			/* @var $query Doctrine\ORM\Query */
63			$query = $em->createQuery($fixture['dql']);
64			$query->setLockMode($fixture['lockMode']);
65			$query->setParameters($fixture['dqlParams']);
66			$result = $query->getResult();
67			});
68			}
69
70			public function lock($job)
71			{
72			return $this->process($job, function($fixture, $em) {
73			$entity = $em->find($fixture['entityName'], $fixture['entityId']);
74			$em->lock($entity, $fixture['lockMode']);
75			});
76			}
77
78			protected function processWorkload($job)
79			{
80			echo "Received job: " . $job->handle() . " for function " . $job->functionName() . "\n";
81
82			$workload = $job->workload();
83			$workload = unserialize($workload);
84
85			if (!isset($workload['conn']) \|\| !is_array($workload['conn'])) {
86			throw new \InvalidArgumentException("Missing Database parameters");
87			}
88
89			$this->em = $this->createEntityManager($workload['conn']);
90
91			if (!isset($workload['fixture'])) {
92			throw new \InvalidArgumentException("Missing Fixture parameters");
93			}
94			return $workload['fixture'];
95			}
96
97			protected function createEntityManager($conn)
98			{
99			$config = new Configuration();
100			$config->setProxyDir(__DIR__ . '/../../../Proxies');
101			$config->setProxyNamespace('MyProject\Proxies');
102			$config->setAutoGenerateProxyClasses(true);
103
104			$annotDriver = $config->newDefaultAnnotationDriver([__DIR__ . '/../../../Models/'], true);
105			$config->setMetadataDriverImpl($annotDriver);
106
107			$cache = new ArrayCache();
108			$config->setMetadataCacheImpl($cache);
109			$config->setQueryCacheImpl($cache);
110			$config->setSQLLogger(new EchoSQLLogger());
111
112			$em = EntityManager::create($conn, $config);
113
114			return $em;
115			}
116			}
117
118			LockAgentWorker::run();
119

doctrine / orm

Push — master ( 8b8169...80f782 )

Tests/ORM/Functional/Locking/LockAgentWorker.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like