Failed Conditions
Pull Request — develop (#6719)
by Marco
65:21
created
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2074Test.php 2 patches
Unused Use Statements   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -4,9 +4,9 @@
 block discarded – undo
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional\Ticket;
6 6
 
7
-use Doctrine\Common\Collections\ArrayCollection;
8
-use Doctrine\ORM\PersistentCollection;
9
-use Doctrine\Tests\Models\ECommerce\ECommerceCategory;
7
+use Doctrine\Common\Collections\ArrayCollection;
8
+use Doctrine\ORM\PersistentCollection;
9
+use Doctrine\Tests\Models\ECommerce\ECommerceCategory;
10 10
 use Doctrine\Tests\Models\ECommerce\ECommerceProduct;
11 11
 
12 12
 /**
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional\Ticket;
6 6
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC3785Test.php 3 patches
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -117,6 +117,10 @@
 block discarded – undo
117 117
 	/** @ORM\Column(type = "string") */
118 118
 	private $value;
119 119
 
120
+    /**
121
+     * @param string $name
122
+     * @param string $value
123
+     */
120 124
     public function __construct($name, $value)
121 125
     {
122 126
         $this->name = $name;
Please login to merge, or discard this patch.
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
         $this->em->flush();
46 46
 
47 47
         $asset->getAttributes()
48
-              ->removeElement($attribute1);
48
+                ->removeElement($attribute1);
49 49
 
50 50
         $idToBeRemoved = $attribute1->id;
51 51
 
@@ -105,17 +105,17 @@  discard block
 block discarded – undo
105 105
  */
106 106
 class DDC3785_Attribute
107 107
 {
108
-	/**
108
+    /**
109 109
      * @ORM\Id @ORM\Column(type="integer")
110 110
      * @ORM\GeneratedValue
111 111
      */
112 112
     public $id;
113 113
 
114
-	/** @ORM\Column(type = "string") */
115
-	private $name;
114
+    /** @ORM\Column(type = "string") */
115
+    private $name;
116 116
 
117
-	/** @ORM\Column(type = "string") */
118
-	private $value;
117
+    /** @ORM\Column(type = "string") */
118
+    private $value;
119 119
 
120 120
     public function __construct($name, $value)
121 121
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional\Ticket;
6 6
 
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
                     $this->em->getClassMetadata(DDC3785_Attribute::class)
26 26
                 ]
27 27
             );
28
-        } catch(\Exception $e) {
28
+        } catch (\Exception $e) {
29 29
         }
30 30
     }
31 31
 
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
      */
157 157
     public function convertToDatabaseValue($value, AbstractPlatform $platform)
158 158
     {
159
-        return (string)$value;
159
+        return (string) $value;
160 160
     }
161 161
 
162 162
     /**
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC618Test.php 3 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -155,6 +155,9 @@  discard block
 block discarded – undo
155 155
         $this->books = new \Doctrine\Common\Collections\ArrayCollection;
156 156
     }
157 157
 
158
+    /**
159
+     * @param string $title
160
+     */
158 161
     public function addBook($title)
159 162
     {
160 163
         $book = new DDC618Book($title, $this);
@@ -179,6 +182,9 @@  discard block
 block discarded – undo
179 182
     /** @ORM\ManyToOne(targetEntity="DDC618Author", inversedBy="books") */
180 183
     public $author;
181 184
 
185
+    /**
186
+     * @param DDC618Author $author
187
+     */
182 188
     function __construct($title, $author)
183 189
     {
184 190
         $this->title = $title;
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     public function testIndexByJoin()
76 76
     {
77 77
         $dql = 'SELECT A, B FROM Doctrine\Tests\ORM\Functional\Ticket\DDC618Author A '.
78
-               'INNER JOIN A.books B INDEX BY B.title ORDER BY A.name ASC';
78
+                'INNER JOIN A.books B INDEX BY B.title ORDER BY A.name ASC';
79 79
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_OBJECT);
80 80
 
81 81
         self::assertEquals(3, count($result[0]->books)); // Alice, Joe doesn't appear because he has no books.
@@ -99,14 +99,14 @@  discard block
 block discarded – undo
99 99
     public function testIndexByToOneJoinSilentlyIgnored()
100 100
     {
101 101
         $dql = 'SELECT B, A FROM Doctrine\Tests\ORM\Functional\Ticket\DDC618Book B '.
102
-               'INNER JOIN B.author A INDEX BY A.name ORDER BY A.name ASC';
102
+                'INNER JOIN B.author A INDEX BY A.name ORDER BY A.name ASC';
103 103
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_OBJECT);
104 104
 
105 105
         self::assertInstanceOf(DDC618Book::class, $result[0]);
106 106
         self::assertInstanceOf(DDC618Author::class, $result[0]->author);
107 107
 
108 108
         $dql = 'SELECT B, A FROM Doctrine\Tests\ORM\Functional\Ticket\DDC618Book B '.
109
-               'INNER JOIN B.author A INDEX BY A.name ORDER BY A.name ASC';
109
+                'INNER JOIN B.author A INDEX BY A.name ORDER BY A.name ASC';
110 110
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_ARRAY);
111 111
 
112 112
         self::assertEquals("Alice", $result[0]['author']['name']);
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
     public function testCombineIndexBy()
119 119
     {
120 120
         $dql = 'SELECT A, B FROM Doctrine\Tests\ORM\Functional\Ticket\DDC618Author A INDEX BY A.id '.
121
-               'INNER JOIN A.books B INDEX BY B.title ORDER BY A.name ASC';
121
+                'INNER JOIN A.books B INDEX BY B.title ORDER BY A.name ASC';
122 122
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_OBJECT);
123 123
 
124 124
         self::assertArrayHasKey(11, $result); // Alice
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional\Ticket;
6 6
 
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 
41 41
             $this->em->flush();
42 42
             $this->em->clear();
43
-        } catch(\Exception $e) {
43
+        } catch (\Exception $e) {
44 44
 
45 45
         }
46 46
     }
@@ -80,17 +80,17 @@  discard block
 block discarded – undo
80 80
 
81 81
         self::assertEquals(3, count($result[0]->books)); // Alice, Joe doesn't appear because he has no books.
82 82
         self::assertEquals('Alice', $result[0]->name);
83
-        self::assertTrue( isset($result[0]->books["In Wonderland"] ), "Indexing by title should have books by title.");
84
-        self::assertTrue( isset($result[0]->books["Reloaded"] ), "Indexing by title should have books by title.");
85
-        self::assertTrue( isset($result[0]->books["Test"] ), "Indexing by title should have books by title.");
83
+        self::assertTrue(isset($result[0]->books["In Wonderland"]), "Indexing by title should have books by title.");
84
+        self::assertTrue(isset($result[0]->books["Reloaded"]), "Indexing by title should have books by title.");
85
+        self::assertTrue(isset($result[0]->books["Test"]), "Indexing by title should have books by title.");
86 86
 
87 87
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_ARRAY);
88 88
 
89 89
         self::assertEquals(3, count($result[0]['books'])); // Alice, Joe doesn't appear because he has no books.
90 90
         self::assertEquals('Alice', $result[0]['name']);
91
-        self::assertTrue( isset($result[0]['books']["In Wonderland"] ), "Indexing by title should have books by title.");
92
-        self::assertTrue( isset($result[0]['books']["Reloaded"] ), "Indexing by title should have books by title.");
93
-        self::assertTrue( isset($result[0]['books']["Test"] ), "Indexing by title should have books by title.");
91
+        self::assertTrue(isset($result[0]['books']["In Wonderland"]), "Indexing by title should have books by title.");
92
+        self::assertTrue(isset($result[0]['books']["Reloaded"]), "Indexing by title should have books by title.");
93
+        self::assertTrue(isset($result[0]['books']["Test"]), "Indexing by title should have books by title.");
94 94
     }
95 95
 
96 96
     /**
@@ -125,9 +125,9 @@  discard block
 block discarded – undo
125 125
 
126 126
         self::assertEquals(3, count($result[11]->books)); // Alice, Joe doesn't appear because he has no books.
127 127
         self::assertEquals('Alice', $result[11]->name);
128
-        self::assertTrue( isset($result[11]->books["In Wonderland"] ), "Indexing by title should have books by title.");
129
-        self::assertTrue( isset($result[11]->books["Reloaded"] ), "Indexing by title should have books by title.");
130
-        self::assertTrue( isset($result[11]->books["Test"] ), "Indexing by title should have books by title.");
128
+        self::assertTrue(isset($result[11]->books["In Wonderland"]), "Indexing by title should have books by title.");
129
+        self::assertTrue(isset($result[11]->books["Reloaded"]), "Indexing by title should have books by title.");
130
+        self::assertTrue(isset($result[11]->books["Test"]), "Indexing by title should have books by title.");
131 131
     }
132 132
 }
133 133
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC832Test.php 2 patches
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -167,6 +167,9 @@  discard block
 block discarded – undo
167 167
      */
168 168
     public $version;
169 169
 
170
+    /**
171
+     * @param string $word
172
+     */
170 173
     public function __construct($word)
171 174
     {
172 175
         $this->word = $word;
@@ -196,6 +199,9 @@  discard block
 block discarded – undo
196 199
      */
197 200
     public $version;
198 201
 
202
+    /**
203
+     * @param string $name
204
+     */
199 205
     public function __construct($name)
200 206
     {
201 207
         $this->name = $name;
@@ -214,6 +220,11 @@  discard block
 block discarded – undo
214 220
     /** @ORM\Column(type="integer") */
215 221
     public $rgt;
216 222
 
223
+    /**
224
+     * @param string $name
225
+     * @param integer $lft
226
+     * @param integer $rgt
227
+     */
217 228
     public function __construct($name, $lft, $rgt)
218 229
     {
219 230
         $this->name = $name;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional\Ticket;
6 6
 
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
                     $this->em->getClassMetadata(DDC832Like::class),
29 29
                 ]
30 30
             );
31
-        } catch(\Exception $e) {
31
+        } catch (\Exception $e) {
32 32
         }
33 33
     }
34 34
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/ValueObjectsTest.php 2 patches
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -353,6 +353,9 @@  discard block
 block discarded – undo
353 353
     /** @ORM\Embedded(class = "DDC93Timestamps") */
354 354
     public $timestamps;
355 355
 
356
+    /**
357
+     * @param string $name
358
+     */
356 359
     public function __construct($name = null, DDC93Address $address = null)
357 360
     {
358 361
         $this->name = $name;
@@ -415,6 +418,9 @@  discard block
 block discarded – undo
415 418
      */
416 419
     public $name;
417 420
 
421
+    /**
422
+     * @param string $name
423
+     */
418 424
     public function __construct($name = null)
419 425
     {
420 426
         $this->name = $name;
@@ -441,6 +447,11 @@  discard block
 block discarded – undo
441 447
     /** @ORM\Embedded(class = "DDC93Country") */
442 448
     public $country;
443 449
 
450
+    /**
451
+     * @param string $street
452
+     * @param string $zip
453
+     * @param string $city
454
+     */
444 455
     public function __construct($street = null, $zip = null, $city = null, DDC93Country $country = null)
445 456
     {
446 457
         $this->street = $street;
Please login to merge, or discard this patch.
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional;
6 6
 
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
                 $this->em->getClassMetadata(DDC3027Dog::class),
33 33
                 ]
34 34
             );
35
-        } catch(\Exception $e) {
35
+        } catch (\Exception $e) {
36 36
         }
37 37
     }
38 38
 
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
         self::assertEquals('United States of America', $person->address->country->name);
88 88
 
89 89
         // 4. check deleting works
90
-        $personId = $person->id;;
90
+        $personId = $person->id; ;
91 91
         $this->em->remove($person);
92 92
         $this->em->flush();
93 93
 
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
         $this->em->flush();
112 112
         $this->em->clear();
113 113
 
114
-        $dql = "SELECT p FROM " . __NAMESPACE__ . "\DDC93Person p";
114
+        $dql = "SELECT p FROM ".__NAMESPACE__."\DDC93Person p";
115 115
         $persons = $this->em->createQuery($dql)->getResult();
116 116
 
117 117
         self::assertCount(3, $persons);
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
             self::assertEquals('United States of America', $person->address->country->name);
125 125
         }
126 126
 
127
-        $dql = "SELECT p FROM " . __NAMESPACE__ . "\DDC93Person p";
127
+        $dql = "SELECT p FROM ".__NAMESPACE__."\DDC93Person p";
128 128
         $persons = $this->em->createQuery($dql)->getArrayResult();
129 129
 
130 130
         foreach ($persons as $person) {
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
         $this->em->flush();
150 150
 
151 151
         // SELECT
152
-        $selectDql = "SELECT p FROM " . __NAMESPACE__ ."\\DDC93Person p WHERE p.address.city = :city AND p.address.country.name = :country";
152
+        $selectDql = "SELECT p FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.address.city = :city AND p.address.country.name = :country";
153 153
         $loadedPerson = $this->em->createQuery($selectDql)
154 154
             ->setParameter('city', 'Karlsruhe')
155 155
             ->setParameter('country', 'Germany')
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
         );
165 165
 
166 166
         // UPDATE
167
-        $updateDql = "UPDATE " . __NAMESPACE__ . "\\DDC93Person p SET p.address.street = :street, p.address.country.name = :country WHERE p.address.city = :city";
167
+        $updateDql = "UPDATE ".__NAMESPACE__."\\DDC93Person p SET p.address.street = :street, p.address.country.name = :country WHERE p.address.city = :city";
168 168
         $this->em->createQuery($updateDql)
169 169
             ->setParameter('street', 'Boo')
170 170
             ->setParameter('country', 'DE')
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
         self::assertEquals('DE', $person->address->country->name);
177 177
 
178 178
         // DELETE
179
-        $this->em->createQuery("DELETE " . __NAMESPACE__ . "\\DDC93Person p WHERE p.address.city = :city AND p.address.country.name = :country")
179
+        $this->em->createQuery("DELETE ".__NAMESPACE__."\\DDC93Person p WHERE p.address.city = :city AND p.address.country.name = :country")
180 180
             ->setParameter('city', 'Karlsruhe')
181 181
             ->setParameter('country', 'DE')
182 182
             ->execute();
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
         $this->em->clear();
194 194
 
195 195
         // Prove that the entity was persisted correctly.
196
-        $dql = "SELECT p FROM " . __NAMESPACE__ ."\\DDC93Person p WHERE p.name = :name";
196
+        $dql = "SELECT p FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.name = :name";
197 197
 
198 198
         $person = $this->em->createQuery($dql)
199 199
             ->setParameter('name', 'Karl')
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
         // Clear the EM and prove that the embeddable can be the subject of a partial query.
208 208
         $this->em->clear();
209 209
 
210
-        $dql = "SELECT PARTIAL p.{id,address.city} FROM " . __NAMESPACE__ ."\\DDC93Person p WHERE p.name = :name";
210
+        $dql = "SELECT PARTIAL p.{id,address.city} FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.name = :name";
211 211
 
212 212
         $person = $this->em->createQuery($dql)
213 213
             ->setParameter('name', 'Karl')
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
         // Clear the EM and prove that the embeddable can be the subject of a partial query regardless of attributes positions.
224 224
         $this->em->clear();
225 225
 
226
-        $dql = "SELECT PARTIAL p.{address.city, id} FROM " . __NAMESPACE__ ."\\DDC93Person p WHERE p.name = :name";
226
+        $dql = "SELECT PARTIAL p.{address.city, id} FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.name = :name";
227 227
 
228 228
         $person = $this->em->createQuery($dql)
229 229
             ->setParameter('name', 'Karl')
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
         $this->expectException(QueryException::class);
243 243
         $this->expectExceptionMessage('no field or association named address.asdfasdf');
244 244
 
245
-        $this->em->createQuery("SELECT p FROM " . __NAMESPACE__ . "\\DDC93Person p WHERE p.address.asdfasdf IS NULL")
245
+        $this->em->createQuery("SELECT p FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.address.asdfasdf IS NULL")
246 246
             ->execute();
247 247
     }
248 248
 
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
         $this->expectException(QueryException::class);
252 252
         $this->expectExceptionMessage("no mapped field named 'address.asdfasdf'");
253 253
 
254
-        $this->em->createQuery("SELECT PARTIAL p.{id,address.asdfasdf} FROM " . __NAMESPACE__ . "\\DDC93Person p")
254
+        $this->em->createQuery("SELECT PARTIAL p.{id,address.asdfasdf} FROM ".__NAMESPACE__."\\DDC93Person p")
255 255
             ->execute();
256 256
     }
257 257
 
@@ -313,15 +313,15 @@  discard block
 block discarded – undo
313 313
         $this->expectException(MappingException::class);
314 314
         $this->expectExceptionMessage(
315 315
             sprintf(
316
-                'Infinite nesting detected for embedded property %s::nested. ' .
316
+                'Infinite nesting detected for embedded property %s::nested. '.
317 317
                 'You cannot embed an embeddable from the same type inside an embeddable.',
318
-                __NAMESPACE__ . '\\' . $declaredEmbeddableClassName
318
+                __NAMESPACE__.'\\'.$declaredEmbeddableClassName
319 319
             )
320 320
         );
321 321
 
322 322
         $this->schemaTool->createSchema(
323 323
             [
324
-            $this->em->getClassMetadata(__NAMESPACE__ . '\\' . $embeddableClassName),
324
+            $this->em->getClassMetadata(__NAMESPACE__.'\\'.$embeddableClassName),
325 325
             ]
326 326
         );
327 327
     }
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Hydration/ObjectHydratorTest.php 4 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 namespace Doctrine\Tests\ORM\Hydration;
6 6
 
7 7
 use Doctrine\DBAL\Types\Type;
8
-use Doctrine\ORM\Mapping\ClassMetadata;
9 8
 use Doctrine\ORM\Mapping\FetchMode;
10 9
 use Doctrine\ORM\PersistentCollection;
11 10
 use Doctrine\ORM\Proxy\ProxyFactory;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Hydration;
6 6
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2010,7 +2010,7 @@
 block discarded – undo
2010 2010
     }
2011 2011
 
2012 2012
     /**
2013
-     * @param object $object
2013
+     * @param \Doctrine\ORM\EntityManagerInterface $object
2014 2014
      * @param string $propertyName
2015 2015
      * @param mixed  $newValue
2016 2016
      */
Please login to merge, or discard this patch.
Indentation   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -1024,14 +1024,14 @@  discard block
 block discarded – undo
1024 1024
 
1025 1025
         // mocking the proxy factory
1026 1026
         $proxyFactory = $this->getMockBuilder(ProxyFactory::class)
1027
-                             ->setMethods(['getProxy'])
1028
-                             ->disableOriginalConstructor()
1029
-                             ->getMock();
1027
+                                ->setMethods(['getProxy'])
1028
+                                ->disableOriginalConstructor()
1029
+                                ->getMock();
1030 1030
 
1031 1031
         $proxyFactory->expects($this->once())
1032
-                     ->method('getProxy')
1033
-                     ->with($this->equalTo(ECommerceShipping::class), ['id' => 42])
1034
-                     ->will($this->returnValue($proxyInstance));
1032
+                        ->method('getProxy')
1033
+                        ->with($this->equalTo(ECommerceShipping::class), ['id' => 42])
1034
+                        ->will($this->returnValue($proxyInstance));
1035 1035
 
1036 1036
         // @todo guilhermeblanco This should never have happened... replace this Reflection injection with proper API.
1037 1037
         $this->swapPrivateProperty($this->em, 'proxyFactory', $proxyFactory);
@@ -1074,14 +1074,14 @@  discard block
 block discarded – undo
1074 1074
 
1075 1075
         // mocking the proxy factory
1076 1076
         $proxyFactory = $this->getMockBuilder(ProxyFactory::class)
1077
-                             ->setMethods(['getProxy'])
1078
-                             ->disableOriginalConstructor()
1079
-                             ->getMock();
1077
+                                ->setMethods(['getProxy'])
1078
+                                ->disableOriginalConstructor()
1079
+                                ->getMock();
1080 1080
 
1081 1081
         $proxyFactory->expects($this->once())
1082
-                     ->method('getProxy')
1083
-                     ->with($this->equalTo(ECommerceShipping::class), ['id' => 42])
1084
-                     ->will($this->returnValue($proxyInstance));
1082
+                        ->method('getProxy')
1083
+                        ->with($this->equalTo(ECommerceShipping::class), ['id' => 42])
1084
+                        ->will($this->returnValue($proxyInstance));
1085 1085
 
1086 1086
         // @todo guilhermeblanco This should never have happened... replace this Reflection injection with proper API.
1087 1087
         $this->swapPrivateProperty($this->em, 'proxyFactory', $proxyFactory);
@@ -1908,10 +1908,10 @@  discard block
 block discarded – undo
1908 1908
         $rsm->setDiscriminatorColumn('c', 'c_discr');
1909 1909
 
1910 1910
         $resultSet = [
1911
-              [
1912
-                  'c__id'   => '1',
1913
-                  'c_discr' => 'fix',
1914
-              ],
1911
+                [
1912
+                    'c__id'   => '1',
1913
+                    'c_discr' => 'fix',
1914
+                ],
1915 1915
         ];
1916 1916
 
1917 1917
         $stmt     = new HydratorMockStatement($resultSet);
@@ -1940,12 +1940,12 @@  discard block
 block discarded – undo
1940 1940
         $rsm->setDiscriminatorColumn('e', 'e_discr');
1941 1941
 
1942 1942
         $resultSet = [
1943
-              [
1944
-                  'c__id'   => '1',
1945
-                  'c_discr' => 'fix',
1946
-                  'e__id'   => '1',
1947
-                  'e__name' => 'Fabio B. Silva'
1948
-              ],
1943
+                [
1944
+                    'c__id'   => '1',
1945
+                    'c_discr' => 'fix',
1946
+                    'e__id'   => '1',
1947
+                    'e__name' => 'Fabio B. Silva'
1948
+                ],
1949 1949
         ];
1950 1950
 
1951 1951
         $stmt     = new HydratorMockStatement($resultSet);
@@ -1970,11 +1970,11 @@  discard block
 block discarded – undo
1970 1970
         $rsm->setDiscriminatorColumn('p', 'discr');
1971 1971
 
1972 1972
         $resultSet = [
1973
-              [
1974
-                  'p__id'   => '1',
1975
-                  'p__name' => 'Fabio B. Silva',
1976
-                  'discr'   => 'subworker'
1977
-              ],
1973
+                [
1974
+                    'p__id'   => '1',
1975
+                    'p__name' => 'Fabio B. Silva',
1976
+                    'discr'   => 'subworker'
1977
+                ],
1978 1978
         ];
1979 1979
 
1980 1980
         $stmt       = new HydratorMockStatement($resultSet);
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Mapping/ClassMetadataFactoryTest.php 3 patches
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -225,6 +225,9 @@  discard block
 block discarded – undo
225 225
         self::assertEquals([], $metadata);
226 226
     }
227 227
 
228
+    /**
229
+     * @param \PHPUnit_Framework_MockObject_MockObject $conn
230
+     */
228 231
     protected function createEntityManager($metadataDriver, $conn = null)
229 232
     {
230 233
         $driverMock = new DriverMock();
@@ -257,7 +260,6 @@  discard block
 block discarded – undo
257 260
     }
258 261
 
259 262
     /**
260
-     * @param string $class
261 263
      * @return ClassMetadata
262 264
      */
263 265
     protected function createValidClassMetadata()
@@ -498,6 +500,10 @@  discard block
 block discarded – undo
498 500
         return $this->mockMetadata[$className];
499 501
     }
500 502
 
503
+    /**
504
+     * @param string $className
505
+     * @param ClassMetadata $metadata
506
+     */
501 507
     public function setMetadataForClass($className, $metadata)
502 508
     {
503 509
         $this->mockMetadata[$className] = $metadata;
Please login to merge, or discard this patch.
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -129,13 +129,13 @@  discard block
 block discarded – undo
129 129
         $cmf = new ClassMetadataFactory();
130 130
         $driver = $this->createMock(MappingDriver::class);
131 131
         $driver->expects($this->at(0))
132
-               ->method('isTransient')
133
-               ->with($this->equalTo(CmsUser::class))
134
-               ->will($this->returnValue(true));
132
+                ->method('isTransient')
133
+                ->with($this->equalTo(CmsUser::class))
134
+                ->will($this->returnValue(true));
135 135
         $driver->expects($this->at(1))
136
-               ->method('isTransient')
137
-               ->with($this->equalTo(CmsArticle::class))
138
-               ->will($this->returnValue(false));
136
+                ->method('isTransient')
137
+                ->with($this->equalTo(CmsArticle::class))
138
+                ->will($this->returnValue(false));
139 139
 
140 140
         $em = $this->createEntityManager($driver);
141 141
 
@@ -151,13 +151,13 @@  discard block
 block discarded – undo
151 151
         $cmf = new ClassMetadataFactory();
152 152
         $driver = $this->createMock(MappingDriver::class);
153 153
         $driver->expects($this->at(0))
154
-               ->method('isTransient')
155
-               ->with($this->equalTo(CmsUser::class))
156
-               ->will($this->returnValue(true));
154
+                ->method('isTransient')
155
+                ->with($this->equalTo(CmsUser::class))
156
+                ->will($this->returnValue(true));
157 157
         $driver->expects($this->at(1))
158
-               ->method('isTransient')
159
-               ->with($this->equalTo(CmsArticle::class))
160
-               ->will($this->returnValue(false));
158
+                ->method('isTransient')
159
+                ->with($this->equalTo(CmsArticle::class))
160
+                ->will($this->returnValue(false));
161 161
 
162 162
         $em = $this->createEntityManager($driver);
163 163
         $em->getConfiguration()->addEntityNamespace('CMS', 'Doctrine\Tests\Models\CMS');
@@ -316,8 +316,8 @@  discard block
 block discarded – undo
316 316
     }
317 317
 
318 318
     /**
319
-    * @group DDC-1845
320
-    */
319
+     * @group DDC-1845
320
+     */
321 321
     public function testQuoteMetadata()
322 322
     {
323 323
         $cmf    = new ClassMetadataFactory();
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Mapping;
6 6
 
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
     {
114 114
         require_once __DIR__."/../../Models/Global/GlobalNamespaceModel.php";
115 115
 
116
-        $metadataDriver = $this->createAnnotationDriver([__DIR__ . '/../../Models/Global/']);
116
+        $metadataDriver = $this->createAnnotationDriver([__DIR__.'/../../Models/Global/']);
117 117
 
118 118
         $entityManager = $this->createEntityManager($metadataDriver);
119 119
 
@@ -121,10 +121,10 @@  discard block
 block discarded – undo
121 121
 
122 122
         self::assertSame(
123 123
             $mf->getMetadataFor(DoctrineGlobal_Article::class),
124
-            $mf->getMetadataFor('\\' . DoctrineGlobal_Article::class)
124
+            $mf->getMetadataFor('\\'.DoctrineGlobal_Article::class)
125 125
         );
126 126
         self::assertTrue($mf->hasMetadataFor(DoctrineGlobal_Article::class));
127
-        self::assertTrue($mf->hasMetadataFor('\\' . DoctrineGlobal_Article::class));
127
+        self::assertTrue($mf->hasMetadataFor('\\'.DoctrineGlobal_Article::class));
128 128
     }
129 129
 
130 130
     /**
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
     public function testAddDefaultDiscriminatorMap()
176 176
     {
177 177
         $cmf = new ClassMetadataFactory();
178
-        $driver = $this->createAnnotationDriver([__DIR__ . '/../../Models/JoinedInheritanceType/']);
178
+        $driver = $this->createAnnotationDriver([__DIR__.'/../../Models/JoinedInheritanceType/']);
179 179
         $em = $this->createEntityManager($driver);
180 180
         $cmf->setEntityManager($em);
181 181
 
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
     {
216 216
         // DDC-3551
217 217
         $conn = $this->createMock(Connection::class);
218
-        $mockDriver    = new MetadataDriverMock();
218
+        $mockDriver = new MetadataDriverMock();
219 219
         $conn->expects($this->any())
220 220
             ->method('getEventManager')
221 221
             ->willReturn(new EventManager());
@@ -239,10 +239,10 @@  discard block
 block discarded – undo
239 239
         $driverMock = new DriverMock();
240 240
         $config = new Configuration();
241 241
 
242
-        $config->setProxyDir(__DIR__ . '/../../Proxies');
242
+        $config->setProxyDir(__DIR__.'/../../Proxies');
243 243
         $config->setProxyNamespace('Doctrine\Tests\Proxies');
244 244
 
245
-        if (!$conn) {
245
+        if ( ! $conn) {
246 246
             $conn = new ConnectionMock([], $driverMock, $config, new EventManager());
247 247
         }
248 248
         $eventManager = $conn->getEventManager();
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
     public function testQuoteMetadata()
334 334
     {
335 335
         $cmf    = new ClassMetadataFactory();
336
-        $driver = $this->createAnnotationDriver([__DIR__ . '/../../Models/Quote/']);
336
+        $driver = $this->createAnnotationDriver([__DIR__.'/../../Models/Quote/']);
337 337
         $em     = $this->createEntityManager($driver);
338 338
         $cmf->setEntityManager($em);
339 339
 
@@ -422,7 +422,7 @@  discard block
 block discarded – undo
422 422
         $listener
423 423
             ->expects($this->any())
424 424
             ->method('onClassMetadataNotFound')
425
-            ->will($this->returnCallback(function (OnClassMetadataNotFoundEventArgs $args) use ($metadata, $em, $test) {
425
+            ->will($this->returnCallback(function(OnClassMetadataNotFoundEventArgs $args) use ($metadata, $em, $test) {
426 426
                 $test->assertNull($args->getFoundMetadata());
427 427
                 $test->assertSame('Foo', $args->getClassName());
428 428
                 $test->assertSame($em, $args->getObjectManager());
@@ -484,7 +484,7 @@  discard block
 block discarded – undo
484 484
     public function testInheritsIdGeneratorMappingFromEmbeddable()
485 485
     {
486 486
         $cmf = new ClassMetadataFactory();
487
-        $driver = $this->createAnnotationDriver([__DIR__ . '/../../Models/DDC4006/']);
487
+        $driver = $this->createAnnotationDriver([__DIR__.'/../../Models/DDC4006/']);
488 488
         $em = $this->createEntityManager($driver);
489 489
         $cmf->setEntityManager($em);
490 490
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Performance/SecondLevelCacheTest.php 2 patches
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -127,6 +127,9 @@  discard block
 block discarded – undo
127 127
         self::assertEquals(503, $this->countQuery($em));
128 128
     }
129 129
 
130
+    /**
131
+     * @param string $label
132
+     */
130 133
     private function queryEntity(EntityManagerInterface $em, $label)
131 134
     {
132 135
         $times        = 100;
@@ -158,6 +161,9 @@  discard block
 block discarded – undo
158 161
         printf("\n%s\n", str_repeat('-', 50));
159 162
     }
160 163
 
164
+    /**
165
+     * @param string $label
166
+     */
161 167
     public function findEntityOneToMany(EntityManagerInterface $em, $label)
162 168
     {
163 169
         $times        = 50;
@@ -217,6 +223,9 @@  discard block
 block discarded – undo
217 223
         printf("\n%s\n", str_repeat('-', 50));
218 224
     }
219 225
 
226
+    /**
227
+     * @param string $label
228
+     */
220 229
     private function findEntity(EntityManagerInterface $em, $label)
221 230
     {
222 231
         $times        = 10;
@@ -252,6 +261,9 @@  discard block
 block discarded – undo
252 261
         printf("\n%s\n", str_repeat('-', 50));
253 262
     }
254 263
 
264
+    /**
265
+     * @param string $label
266
+     */
255 267
     private function findAllEntity(EntityManagerInterface $em, $label)
256 268
     {
257 269
         $times        = 100;
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Performance;
6 6
 
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
         $size         = 500;
134 134
         $startPersist = microtime(true);
135 135
 
136
-        echo PHP_EOL . $label;
136
+        echo PHP_EOL.$label;
137 137
 
138 138
         for ($i = 0; $i < $size; $i++) {
139 139
             $em->persist(new Country("Country $i"));
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
         $startPersist = microtime(true);
168 168
         $country      = new Country("Country");
169 169
 
170
-        echo PHP_EOL . $label;
170
+        echo PHP_EOL.$label;
171 171
 
172 172
         $em->persist($country);
173 173
         $em->flush();
@@ -197,9 +197,9 @@  discard block
 block discarded – undo
197 197
         $em->flush();
198 198
         $em->clear();
199 199
 
200
-        printf("\n[%s] persist %s states and %s cities", number_format( microtime(true) - $startPersist, 6), count($states), count($cities));
200
+        printf("\n[%s] persist %s states and %s cities", number_format(microtime(true) - $startPersist, 6), count($states), count($cities));
201 201
 
202
-        $startFind  = microtime(true);
202
+        $startFind = microtime(true);
203 203
 
204 204
         for ($i = 0; $i < $times; $i++) {
205 205
 
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
         $countries    = [];
225 225
         $startPersist = microtime(true);
226 226
 
227
-        echo PHP_EOL . $label;
227
+        echo PHP_EOL.$label;
228 228
 
229 229
         for ($i = 0; $i < $size; $i++) {
230 230
             $country = new Country("Country $i");
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
 
240 240
         printf("\n[%s] persist %s countries", number_format(microtime(true) - $startPersist, 6), $size);
241 241
 
242
-        $startFind  = microtime(true);
242
+        $startFind = microtime(true);
243 243
 
244 244
         for ($i = 0; $i <= $times; $i++) {
245 245
             foreach ($countries as $country) {
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
         $startPersist = microtime(true);
260 260
         $rep          = $em->getRepository(Country::class);
261 261
 
262
-        echo PHP_EOL . $label;
262
+        echo PHP_EOL.$label;
263 263
 
264 264
         for ($i = 0; $i < $size; $i++) {
265 265
             $em->persist(new Country("Country $i"));
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
 
271 271
         printf("\n[%s] persist %s countries", number_format(microtime(true) - $startPersist, 6), $size);
272 272
 
273
-        $startFind  = microtime(true);
273
+        $startFind = microtime(true);
274 274
 
275 275
         for ($i = 0; $i <= $times; $i++) {
276 276
             $list = $rep->findAll();
Please login to merge, or discard this patch.
Doctrine/Tests/ORM/Persisters/BasicEntityPersisterTypeValueSqlTest.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,6 @@
 block discarded – undo
10 10
 use Doctrine\ORM\Mapping\OneToOneAssociationMetadata;
11 11
 use Doctrine\ORM\Persisters\Entity\BasicEntityPersister;
12 12
 use Doctrine\Tests\Models\CustomType\CustomTypeChild;
13
-use Doctrine\Tests\Models\CustomType\CustomTypeFriend;
14 13
 use Doctrine\Tests\Models\CustomType\CustomTypeParent;
15 14
 use Doctrine\Tests\Models\Generic\NonAlphaColumnsEntity;
16 15
 use Doctrine\Tests\OrmTestCase;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Persisters;
6 6
 
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
         $method = new \ReflectionMethod($this->persister, 'getSelectConditionSQL');
94 94
         $method->setAccessible(true);
95 95
 
96
-        $sql = $method->invoke($this->persister,  ['customInteger' => 1, 'child' => 1]);
96
+        $sql = $method->invoke($this->persister, ['customInteger' => 1, 'child' => 1]);
97 97
 
98 98
         self::assertEquals('t0."customInteger" = ABS(?) AND t0."child_id" = ?', $sql);
99 99
     }
Please login to merge, or discard this patch.