Failed Conditions
Pull Request — master (#6546)
by Jáchym
11:13
created
tests/Doctrine/Tests/ORM/Functional/LifecycleCallbackTest.php 3 patches
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -375,8 +375,16 @@
 block discarded – undo
375 375
     private $name;
376 376
     public function getId() {return $this->id;}
377 377
     public function getValue() {return $this->value;}
378
+
379
+    /**
380
+     * @param string $value
381
+     */
378 382
     public function setValue($value) {$this->value = $value;}
379 383
     public function getName() {return $this->name;}
384
+
385
+    /**
386
+     * @param string $name
387
+     */
380 388
     public function setName($name) {$this->name = $name;}
381 389
     /** @PreUpdate */
382 390
     public function testCallback() {$this->value = 'Hello World';}
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -302,8 +302,8 @@
 block discarded – undo
302 302
     }
303 303
 
304 304
     /**
305
-    * @group DDC-1955
306
-    */
305
+     * @group DDC-1955
306
+     */
307 307
     public function testLifecycleCallbackEventArgs()
308 308
     {
309 309
         $e = new LifecycleCallbackEventArgEntity;
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -350,13 +350,13 @@
 block discarded – undo
350 350
     private $value;
351 351
     /** @Column(type="string") */
352 352
     private $name;
353
-    public function getId() {return $this->id;}
354
-    public function getValue() {return $this->value;}
355
-    public function setValue($value) {$this->value = $value;}
356
-    public function getName() {return $this->name;}
357
-    public function setName($name) {$this->name = $name;}
353
+    public function getId() {return $this->id; }
354
+    public function getValue() {return $this->value; }
355
+    public function setValue($value) {$this->value = $value; }
356
+    public function getName() {return $this->name; }
357
+    public function setName($name) {$this->name = $name; }
358 358
     /** @PreUpdate */
359
-    public function testCallback() {$this->value = 'Hello World';}
359
+    public function testCallback() {$this->value = 'Hello World'; }
360 360
 }
361 361
 
362 362
 /**
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/MergeSharedEntitiesTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -141,6 +141,9 @@
 block discarded – undo
141 141
         return $this->session;
142 142
     }
143 143
 
144
+    /**
145
+     * @param string $session
146
+     */
144 147
     public function setSession($session)
145 148
     {
146 149
         $this->session = $session;
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/NotifyPolicyTest.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -94,6 +94,9 @@  discard block
 block discarded – undo
94 94
         $this->listeners[] = $listener;
95 95
     }
96 96
 
97
+    /**
98
+     * @param string $propName
99
+     */
97 100
     protected function onPropertyChanged($propName, $oldValue, $newValue) {
98 101
         if ($this->listeners) {
99 102
             foreach ($this->listeners as $listener) {
@@ -126,6 +129,9 @@  discard block
 block discarded – undo
126 129
         return $this->name;
127 130
     }
128 131
 
132
+    /**
133
+     * @param string $name
134
+     */
129 135
     function setName($name) {
130 136
         $this->onPropertyChanged('name', $this->name, $name);
131 137
         $this->name = $name;
@@ -159,6 +165,9 @@  discard block
 block discarded – undo
159 165
         return $this->name;
160 166
     }
161 167
 
168
+    /**
169
+     * @param string $name
170
+     */
162 171
     function setName($name) {
163 172
         $this->onPropertyChanged('name', $this->name, $name);
164 173
         $this->name = $name;
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/OneToOneEagerLoadingTest.php 2 patches
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -286,6 +286,9 @@  discard block
 block discarded – undo
286 286
      */
287 287
     public $train;
288 288
 
289
+    /**
290
+     * @param string $name
291
+     */
289 292
     public function __construct($name)
290 293
     {
291 294
         $this->name = $name;
@@ -312,6 +315,9 @@  discard block
 block discarded – undo
312 315
      */
313 316
     public $train;
314 317
 
318
+    /**
319
+     * @param string $name
320
+     */
315 321
     public function __construct($name)
316 322
     {
317 323
         $this->name = $name;
@@ -336,6 +342,9 @@  discard block
 block discarded – undo
336 342
      */
337 343
     public $train;
338 344
 
345
+    /**
346
+     * @param Train $train
347
+     */
339 348
     public function setTrain($train)
340 349
     {
341 350
         $this->train = $train;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
                 $this->_em->getClassMetadata(TrainOrder::class),
26 26
                 ]
27 27
             );
28
-        } catch(\Exception $e) {}
28
+        } catch (\Exception $e) {}
29 29
     }
30 30
 
31 31
     /**
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/PaginationTest.php 2 patches
Doc Comments   +24 added lines patch added patch discarded remove patch
@@ -118,6 +118,10 @@  discard block
 block discarded – undo
118 118
         $this->assertCount(3, $paginator->getIterator());
119 119
     }
120 120
 
121
+    /**
122
+     * @param string $baseDql
123
+     * @param string $checkField
124
+     */
121 125
     private function iterateWithOrderAsc($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
122 126
     {
123 127
         // Ascending
@@ -132,6 +136,10 @@  discard block
 block discarded – undo
132 136
         $this->assertEquals($checkField . "0", $result[0]->$checkField);
133 137
     }
134 138
 
139
+    /**
140
+     * @param string $baseDql
141
+     * @param string $checkField
142
+     */
135 143
     private function iterateWithOrderAscWithLimit($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
136 144
     {
137 145
         // Ascending
@@ -148,6 +156,10 @@  discard block
 block discarded – undo
148 156
         $this->assertEquals($checkField . "0", $result[0]->$checkField);
149 157
     }
150 158
 
159
+    /**
160
+     * @param string $baseDql
161
+     * @param string $checkField
162
+     */
151 163
     private function iterateWithOrderAscWithLimitAndOffset($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
152 164
     {
153 165
         // Ascending
@@ -164,6 +176,10 @@  discard block
 block discarded – undo
164 176
         $this->assertEquals($checkField . "3", $result[0]->$checkField);
165 177
     }
166 178
 
179
+    /**
180
+     * @param string $baseDql
181
+     * @param string $checkField
182
+     */
167 183
     private function iterateWithOrderDesc($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
168 184
     {
169 185
         $dql = "$baseDql DESC";
@@ -177,6 +193,10 @@  discard block
 block discarded – undo
177 193
         $this->assertEquals($checkField . "8", $result[0]->$checkField);
178 194
     }
179 195
 
196
+    /**
197
+     * @param string $baseDql
198
+     * @param string $checkField
199
+     */
180 200
     private function iterateWithOrderDescWithLimit($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
181 201
     {
182 202
         $dql = "$baseDql DESC";
@@ -192,6 +212,10 @@  discard block
 block discarded – undo
192 212
         $this->assertEquals($checkField . "8", $result[0]->$checkField);
193 213
     }
194 214
 
215
+    /**
216
+     * @param string $baseDql
217
+     * @param string $checkField
218
+     */
195 219
     private function iterateWithOrderDescWithLimitAndOffset($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
196 220
     {
197 221
         $dql = "$baseDql DESC";
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
         $iter = $paginator->getIterator();
130 130
         $this->assertCount(9, $iter);
131 131
         $result = iterator_to_array($iter);
132
-        $this->assertEquals($checkField . "0", $result[0]->$checkField);
132
+        $this->assertEquals($checkField."0", $result[0]->$checkField);
133 133
     }
134 134
 
135 135
     private function iterateWithOrderAscWithLimit($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
         $iter = $paginator->getIterator();
146 146
         $this->assertCount(3, $iter);
147 147
         $result = iterator_to_array($iter);
148
-        $this->assertEquals($checkField . "0", $result[0]->$checkField);
148
+        $this->assertEquals($checkField."0", $result[0]->$checkField);
149 149
     }
150 150
 
151 151
     private function iterateWithOrderAscWithLimitAndOffset($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
         $iter = $paginator->getIterator();
162 162
         $this->assertCount(3, $iter);
163 163
         $result = iterator_to_array($iter);
164
-        $this->assertEquals($checkField . "3", $result[0]->$checkField);
164
+        $this->assertEquals($checkField."3", $result[0]->$checkField);
165 165
     }
166 166
 
167 167
     private function iterateWithOrderDesc($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
         $iter = $paginator->getIterator();
175 175
         $this->assertCount(9, $iter);
176 176
         $result = iterator_to_array($iter);
177
-        $this->assertEquals($checkField . "8", $result[0]->$checkField);
177
+        $this->assertEquals($checkField."8", $result[0]->$checkField);
178 178
     }
179 179
 
180 180
     private function iterateWithOrderDescWithLimit($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
         $iter = $paginator->getIterator();
190 190
         $this->assertCount(3, $iter);
191 191
         $result = iterator_to_array($iter);
192
-        $this->assertEquals($checkField . "8", $result[0]->$checkField);
192
+        $this->assertEquals($checkField."8", $result[0]->$checkField);
193 193
     }
194 194
 
195 195
     private function iterateWithOrderDescWithLimitAndOffset($useOutputWalkers, $fetchJoinCollection, $baseDql, $checkField)
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
         $iter = $paginator->getIterator();
205 205
         $this->assertCount(3, $iter);
206 206
         $result = iterator_to_array($iter);
207
-        $this->assertEquals($checkField . "5", $result[0]->$checkField);
207
+        $this->assertEquals($checkField."5", $result[0]->$checkField);
208 208
     }
209 209
 
210 210
     /**
@@ -477,8 +477,8 @@  discard block
 block discarded – undo
477 477
     public function testIterateWithFetchJoinOneToManyWithOrderByColumnFromBoth($useOutputWalkers)
478 478
     {
479 479
         $dql = 'SELECT c, d FROM Doctrine\Tests\Models\Pagination\Company c JOIN c.departments d ORDER BY c.name';
480
-        $dqlAsc = $dql . " ASC, d.name";
481
-        $dqlDesc = $dql . " DESC, d.name";
480
+        $dqlAsc = $dql." ASC, d.name";
481
+        $dqlDesc = $dql." DESC, d.name";
482 482
         $this->iterateWithOrderAsc($useOutputWalkers, true, $dqlAsc, "name");
483 483
         $this->iterateWithOrderDesc($useOutputWalkers, true, $dqlDesc, "name");
484 484
     }
@@ -486,8 +486,8 @@  discard block
 block discarded – undo
486 486
     public function testIterateWithFetchJoinOneToManyWithOrderByColumnFromBothWithLimitWithOutputWalker()
487 487
     {
488 488
         $dql = 'SELECT c, d FROM Doctrine\Tests\Models\Pagination\Company c JOIN c.departments d ORDER BY c.name';
489
-        $dqlAsc = $dql . " ASC, d.name";
490
-        $dqlDesc = $dql . " DESC, d.name";
489
+        $dqlAsc = $dql." ASC, d.name";
490
+        $dqlDesc = $dql." DESC, d.name";
491 491
         $this->iterateWithOrderAscWithLimit(true, true, $dqlAsc, "name");
492 492
         $this->iterateWithOrderDescWithLimit(true, true, $dqlDesc, "name");
493 493
     }
@@ -498,8 +498,8 @@  discard block
 block discarded – undo
498 498
         $this->expectExceptionMessage('Cannot select distinct identifiers from query with LIMIT and ORDER BY on a column from a fetch joined to-many association. Use output walkers.');
499 499
 
500 500
         $dql = 'SELECT c, d FROM Doctrine\Tests\Models\Pagination\Company c JOIN c.departments d ORDER BY c.name';
501
-        $dqlAsc = $dql . " ASC, d.name";
502
-        $dqlDesc = $dql . " DESC, d.name";
501
+        $dqlAsc = $dql." ASC, d.name";
502
+        $dqlDesc = $dql." DESC, d.name";
503 503
         $this->iterateWithOrderAscWithLimit(false, true, $dqlAsc, "name");
504 504
         $this->iterateWithOrderDescWithLimit(false, true, $dqlDesc, "name");
505 505
     }
@@ -583,7 +583,7 @@  discard block
 block discarded – undo
583 583
         $users = iterator_to_array($paginator->getIterator());
584 584
         $this->assertCount(9, $users);
585 585
         foreach ($users as $i => $user) {
586
-            $this->assertEquals("username" . (8 - $i), $user->username);
586
+            $this->assertEquals("username".(8 - $i), $user->username);
587 587
         }
588 588
     }
589 589
 
@@ -733,7 +733,7 @@  discard block
 block discarded – undo
733 733
             $company->logo->image_width = 100 + $i;
734 734
             $company->logo->image_height = 100 + $i;
735 735
             $company->logo->company = $company;
736
-            for($j=0;$j<3;$j++) {
736
+            for ($j = 0; $j < 3; $j++) {
737 737
                 $department = new Department();
738 738
                 $department->name = "name$i$j";
739 739
                 $department->company = $company;
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/ReadOnlyTest.php 2 patches
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -84,6 +84,10 @@
 block discarded – undo
84 84
     /** @Column(type="integer") */
85 85
     public $numericValue;
86 86
 
87
+    /**
88
+     * @param string $name
89
+     * @param integer $number
90
+     */
87 91
     public function __construct($name, $number)
88 92
     {
89 93
         $this->name = $name;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
                 $this->_em->getClassMetadata(ReadOnlyEntity::class),
22 22
                 ]
23 23
             );
24
-        } catch(\Exception $e) {
24
+        } catch (\Exception $e) {
25 25
         }
26 26
     }
27 27
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/SecondLevelCacheTest.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -329,6 +329,9 @@
 block discarded – undo
329 329
         $this->callbacks = $callbacks;
330 330
     }
331 331
 
332
+    /**
333
+     * @param string $eventName
334
+     */
332 335
     private function dispatch($eventName, $args)
333 336
     {
334 337
         if (isset($this->callbacks[$eventName])) {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     {
198 198
         $listener = new ListenerSecondLevelCacheTest(
199 199
             [
200
-                Events::postFlush => function(){
200
+                Events::postFlush => function() {
201 201
             throw new \RuntimeException('post flush failure');
202 202
         }
203 203
             ]
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
 
232 232
         $listener = new ListenerSecondLevelCacheTest(
233 233
             [
234
-                Events::postUpdate => function(){
234
+                Events::postUpdate => function() {
235 235
             throw new \RuntimeException('post update failure');
236 236
         }
237 237
             ]
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
         $this->assertInstanceOf(State::class, $state);
251 251
         $this->assertEquals($stateName, $state->getName());
252 252
 
253
-        $state->setName($stateName . uniqid());
253
+        $state->setName($stateName.uniqid());
254 254
 
255 255
         $this->_em->persist($state);
256 256
 
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 
280 280
         $listener = new ListenerSecondLevelCacheTest(
281 281
             [
282
-                Events::postRemove => function(){
282
+                Events::postRemove => function() {
283 283
             throw new \RuntimeException('post remove failure');
284 284
         }
285 285
             ]
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC1163Test.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -203,7 +203,7 @@
 block discarded – undo
203 203
     }
204 204
 
205 205
     /**
206
-     * @param Product $product
206
+     * @param DDC1163Product $product
207 207
      */
208 208
     public function setProduct(DDC1163Product $product)
209 209
     {
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC1238Test.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -90,6 +90,9 @@
 block discarded – undo
90 90
         return $this->name;
91 91
     }
92 92
 
93
+    /**
94
+     * @param string $name
95
+     */
93 96
     public function setName($name)
94 97
     {
95 98
         $this->name = $name;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
                 $this->_em->getClassMetadata(DDC1238User::class),
17 17
                 ]
18 18
             );
19
-        } catch(\Exception $e) {
19
+        } catch (\Exception $e) {
20 20
 
21 21
         }
22 22
     }
Please login to merge, or discard this patch.