Doctrine\Tests\ORM\Functional\Ticket\GH6443Test

Complexity

Total Complexity

2

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes	3
Bugs	1	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
B	testIssue()	0	25	1
A	setUp()	0	14	1

<?php

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\DBAL\Logging\DebugStack;
use Doctrine\DBAL\Types\Type;
use Doctrine\Tests\DbalTypes\Rot13Type;
use Doctrine\Tests\OrmFunctionalTestCase;

/**
 * @group 6443
 */
class GH6443Test extends OrmFunctionalTestCase
{

    /**
     * @var Rot13Type
     */
    private $rot13Type;

    /**
     * @var DebugStack
     */
    private $sqlLogger;

    /**
     * when having an entity, that has a non scalar identifier, the type will not be guessed / converted correctly
     */
    public function testIssue()
    {

        $entity = new GH6443Post();
        $entity->id = 'Foo';

        $dql = 'SELECT p FROM ' . GH6443Post::class . ' p WHERE p = ?1';
        $query = $this->_em->createQuery($dql);

        // we do not know that the internal type is a rot13, so we can not add the type parameter here
        $query->setParameter(1, $entity);

        // we do not need the result, but we need to execute it to log the SQL-Statement
        $query->getResult();

        $sqlLogger = $this->_em->getConnection()->getConfiguration()->getSQLLogger();
        $lastSql = $sqlLogger->queries[count($sqlLogger->queries)];

Accessing queries on the interface Doctrine\DBAL\Logging\SQLLogger suggest that you code against a concrete implementation. How about adding an instanceof check?

        // the entity's identifier is of type "rot13" so the query parameter needs to be this type too
        $this->assertSame(
            $this->rot13Type->getName(),
            $lastSql['types'][0],
            "asserting that the entity's identifier type is correctly inferred"
        );
    }

    /**
     * {@inheritDoc}
     */
    protected function setUp(): void
    {
        parent::setUp();

        $this->sqlLogger = new DebugStack();
        $this->_em->getConnection()->getConfiguration()->setSQLLogger($this->sqlLogger);


        $this->_schemaTool->createSchema([
            $this->_em->getClassMetadata(GH6443Post::class),
        ]);

        $this->rot13Type = Type::getType('rot13');
    }

}

/** @Entity */
class GH6443Post
{
    /** @Id @Column(type="rot13") */
    public $id;
}