Doctrine\Tests\ORM\Functional\Ticket\DDC2230Test

Complexity

Total Complexity

4

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testNotifyTrackingNotCalledOnUninitializedProxies()	0	22	1
A	testNotifyTrackingCalledOnProxyInitialization()	0	18	1
A	setUp()	0	11	2

<?php

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\Common\NotifyPropertyChanged;
use Doctrine\Common\PropertyChangedListener;
use Doctrine\ORM\Tools\ToolsException;
use Doctrine\Tests\OrmFunctionalTestCase;

/**
 * @group DDC-2230
 */
class DDC2230Test extends OrmFunctionalTestCase
{
    protected function setUp()
    {
        parent::setUp();

        try {
            $this->_schemaTool->createSchema(array(
                $this->_em->getClassMetadata(__NAMESPACE__ . '\DDC2230User'),
                $this->_em->getClassMetadata(__NAMESPACE__ . '\DDC2230Address'),
            ));
        } catch (ToolsException $e) {}

Consider adding a comment why this CATCH block is empty.

    }

    public function testNotifyTrackingNotCalledOnUninitializedProxies()
    {
        $insertedUser          = new DDC2230User();
        $insertedUser->address = new DDC2230Address();

        $this->_em->persist($insertedUser);
        $this->_em->persist($insertedUser->address);
        $this->_em->flush();
        $this->_em->clear();

        $user = $this->_em->find(__NAMESPACE__ . '\\DDC2230User', $insertedUser->id);

        $this->_em->clear();

        $mergedUser = $this->_em->merge($user);

It seems like $user defined by $this->_em->find(__NAMESPACE__ . '\\DDC2230User', $insertedUser->id) on line 37 can also be of type null; however, Doctrine\ORM\EntityManager::merge() does only seem to accept object, maybe add an additional type check?

        /* @var $address \Doctrine\Common\Proxy\Proxy */
        $address = $mergedUser->address;

        $this->assertInstanceOf('Doctrine\\ORM\\Proxy\\Proxy', $address);
        $this->assertFalse($address->__isInitialized());
    }

    public function testNotifyTrackingCalledOnProxyInitialization()
    {
        $insertedAddress = new DDC2230Address();

        $this->_em->persist($insertedAddress);
        $this->_em->flush();
        $this->_em->clear();

        $addressProxy = $this->_em->getReference(__NAMESPACE__ . '\\DDC2230Address', $insertedAddress->id);

        /* @var $addressProxy \Doctrine\Common\Proxy\Proxy|\Doctrine\Tests\ORM\Functional\Ticket\DDC2230Address */
        $this->assertFalse($addressProxy->__isInitialized());

The method __isInitialized does only exist in Doctrine\Common\Proxy\Proxy, but not in Doctrine\Tests\ORM\Functional\Ticket\DDC2230Address.

        $this->assertNull($addressProxy->listener);

        $addressProxy->__load();

The method __load does only exist in Doctrine\Common\Proxy\Proxy, but not in Doctrine\Tests\ORM\Functional\Ticket\DDC2230Address.

        $this->assertSame($this->_em->getUnitOfWork(), $addressProxy->listener);
    }
}

/** @Entity */
class DDC2230User
{
    /** @Id @Column(type="integer") @GeneratedValue(strategy="AUTO") */
    public $id;

    /**
     * @OneToOne(targetEntity="DDC2230Address")
     */
    public $address;
}

/**
 * @Entity
 * @ChangeTrackingPolicy("NOTIFY")
 */
class DDC2230Address implements NotifyPropertyChanged
{
    /** @Id @Column(type="integer") @GeneratedValue(strategy="AUTO") */
    public $id;

    /**
     * @var \Doctrine\Common\PropertyChangedListener
     */
    public $listener;

    /** {@inheritDoc} */
    function addPropertyChangedListener(PropertyChangedListener $listener)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->listener = $listener;
    }
}