Completed
Pull Request — 2.5 (#7639)
by
unknown
03:04
created
lib/Doctrine/ORM/Cache/Persister/Collection/AbstractCollectionPersister.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -37,9 +37,9 @@  discard block
 block discarded – undo
37 37
  */
38 38
 abstract class AbstractCollectionPersister implements CachedCollectionPersister
39 39
 {
40
-     /**
41
-     * @var \Doctrine\ORM\UnitOfWork
42
-     */
40
+        /**
41
+         * @var \Doctrine\ORM\UnitOfWork
42
+         */
43 43
     protected $uow;
44 44
 
45 45
     /**
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
67 67
      */
68 68
     protected $association;
69 69
 
70
-     /**
71
-     * @var array
72
-     */
70
+        /**
71
+         * @var array
72
+         */
73 73
     protected $queuedCache = array();
74 74
 
75 75
     /**
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/CollectionCacheKey.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,6 +61,6 @@
 block discarded – undo
61 61
         $this->ownerIdentifier  = $ownerIdentifier;
62 62
         $this->entityClass      = (string) $entityClass;
63 63
         $this->association      = (string) $association;
64
-        $this->hash             = str_replace('\\', '.', strtolower($entityClass)) . '_' . implode(' ', $ownerIdentifier) . '__' .  $association;
64
+        $this->hash             = str_replace('\\', '.', strtolower($entityClass)).'_'.implode(' ', $ownerIdentifier).'__'.$association;
65 65
     }
66 66
 }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/EntityCacheKey.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,6 +52,6 @@
 block discarded – undo
52 52
 
53 53
         $this->identifier  = $identifier;
54 54
         $this->entityClass = $entityClass;
55
-        $this->hash        = str_replace('\\', '.', strtolower($entityClass) . '_' . implode(' ', $identifier));
55
+        $this->hash        = str_replace('\\', '.', strtolower($entityClass).'_'.implode(' ', $identifier));
56 56
     }
57 57
 }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Cache/Lock.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
     public function __construct($value, $time = null)
46 46
     {
47 47
         $this->value = $value;
48
-        $this->time  = $time ? : time();
48
+        $this->time  = $time ?: time();
49 49
     }
50 50
 
51 51
     /**
Please login to merge, or discard this patch.
lib/Doctrine/ORM/ORMException.php 3 patches
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -101,15 +101,15 @@
 block discarded – undo
101 101
         return new self("Unrecognized field: $field");
102 102
     }
103 103
 
104
-     /**
105
-     *
106
-     * @param string $class
107
-     * @param string $association
108
-     * @param string $given
109
-     * @param string $expected
110
-     *
111
-     * @return \Doctrine\ORM\ORMInvalidArgumentException
112
-     */
104
+        /**
105
+         *
106
+         * @param string $class
107
+         * @param string $association
108
+         * @param string $given
109
+         * @param string $expected
110
+         *
111
+         * @return \Doctrine\ORM\ORMInvalidArgumentException
112
+         */
113 113
     public static function unexpectedAssociationValue($class, $association, $given, $expected)
114 114
     {
115 115
         return new self(sprintf('Found entity of type %s on association %s#%s, but expecting %s', $given, $class, $association, $expected));
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
      */
47 47
     public static function namedQueryNotFound($queryName)
48 48
     {
49
-        return new self('Could not find a named query by the name "' . $queryName . '"');
49
+        return new self('Could not find a named query by the name "'.$queryName.'"');
50 50
     }
51 51
 
52 52
     /**
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     public static function namedNativeQueryNotFound($nativeQueryName)
58 58
     {
59
-        return new self('Could not find a named native query by the name "' . $nativeQueryName . '"');
59
+        return new self('Could not find a named native query by the name "'.$nativeQueryName.'"');
60 60
     }
61 61
 
62 62
     /**
@@ -68,10 +68,10 @@  discard block
 block discarded – undo
68 68
     public static function entityMissingForeignAssignedId($entity, $relatedEntity)
69 69
     {
70 70
         return new self(
71
-            "Entity of type " . get_class($entity) . " has identity through a foreign entity " . get_class($relatedEntity) . ", " .
72
-            "however this entity has no identity itself. You have to call EntityManager#persist() on the related entity " .
73
-            "and make sure that an identifier was generated before trying to persist '" . get_class($entity) . "'. In case " .
74
-            "of Post Insert ID Generation (such as MySQL Auto-Increment) this means you have to call " .
71
+            "Entity of type ".get_class($entity)." has identity through a foreign entity ".get_class($relatedEntity).", ".
72
+            "however this entity has no identity itself. You have to call EntityManager#persist() on the related entity ".
73
+            "and make sure that an identifier was generated before trying to persist '".get_class($entity)."'. In case ".
74
+            "of Post Insert ID Generation (such as MySQL Auto-Increment) this means you have to call ".
75 75
             "EntityManager#flush() between both persist operations."
76 76
         );
77 77
     }
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public static function entityMissingAssignedIdForField($entity, $field)
86 86
     {
87
-        return new self("Entity of type " . get_class($entity) . " is missing an assigned ID for field  '" . $field . "'. " .
87
+        return new self("Entity of type ".get_class($entity)." is missing an assigned ID for field  '".$field."'. ".
88 88
             "The identifier generation strategy for this entity requires the ID field to be populated before ".
89
-            "EntityManager#persist() is called. If you want automatically generated identifiers instead " .
89
+            "EntityManager#persist() is called. If you want automatically generated identifiers instead ".
90 90
             "you need to adjust the metadata mapping accordingly."
91 91
         );
92 92
     }
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
      */
124 124
     public static function invalidOrientation($className, $field)
125 125
     {
126
-        return new self("Invalid order by orientation specified for " . $className . "#" . $field);
126
+        return new self("Invalid order by orientation specified for ".$className."#".$field);
127 127
     }
128 128
 
129 129
     /**
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
      */
241 241
     public static function queryCacheUsesNonPersistentCache(CacheDriver $cache)
242 242
     {
243
-        return new self('Query Cache uses a non-persistent cache driver, ' . get_class($cache) . '.');
243
+        return new self('Query Cache uses a non-persistent cache driver, '.get_class($cache).'.');
244 244
     }
245 245
 
246 246
     /**
@@ -250,7 +250,7 @@  discard block
 block discarded – undo
250 250
      */
251 251
     public static function metadataCacheUsesNonPersistentCache(CacheDriver $cache)
252 252
     {
253
-        return new self('Metadata Cache uses a non-persistent cache driver, ' . get_class($cache) . '.');
253
+        return new self('Metadata Cache uses a non-persistent cache driver, '.get_class($cache).'.');
254 254
     }
255 255
 
256 256
     /**
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
      */
292 292
     public static function missingIdentifierField($className, $fieldName)
293 293
     {
294
-        return new self("The identifier $fieldName is missing for a query of " . $className);
294
+        return new self("The identifier $fieldName is missing for a query of ".$className);
295 295
     }
296 296
 
297 297
     /**
@@ -303,8 +303,8 @@  discard block
 block discarded – undo
303 303
     public static function unrecognizedIdentifierFields($className, $fieldNames)
304 304
     {
305 305
         return new self(
306
-            "Unrecognized identifier fields: '" . implode("', '", $fieldNames) . "' " .
307
-            "are not present on class '" . $className . "'."
306
+            "Unrecognized identifier fields: '".implode("', '", $fieldNames)."' ".
307
+            "are not present on class '".$className."'."
308 308
         );
309 309
     }
310 310
 
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
     }
78 78
 
79 79
     /**
80
-     * @param object $entity
80
+     * @param Mapping\Entity $entity
81 81
      * @param string $field
82 82
      *
83 83
      * @return ORMException
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
      * @param string $given
109 109
      * @param string $expected
110 110
      *
111
-     * @return \Doctrine\ORM\ORMInvalidArgumentException
111
+     * @return ORMException
112 112
      */
113 113
     public static function unexpectedAssociationValue($class, $association, $given, $expected)
114 114
     {
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
 
297 297
     /**
298 298
      * @param string $className
299
-     * @param string $fieldName
299
+     * @param string $fieldNames
300 300
      *
301 301
      * @return ORMException
302 302
      */
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Tools/ToolsException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
      */
37 37
     public static function schemaToolFailure($sql, \Exception $e)
38 38
     {
39
-        return new self("Schema-Tool failed with Error '" . $e->getMessage() . "' while executing DDL: " . $sql, "0", $e);
39
+        return new self("Schema-Tool failed with Error '".$e->getMessage()."' while executing DDL: ".$sql, "0", $e);
40 40
     }
41 41
 
42 42
     /**
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Tools/DebugUnitOfWorkListener.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -87,42 +87,42 @@
 block discarded – undo
87 87
 
88 88
         fwrite($fh, "Flush Operation [".$this->context."] - Dumping identity map:\n");
89 89
         foreach ($identityMap as $className => $map) {
90
-            fwrite($fh, "Class: ". $className . "\n");
90
+            fwrite($fh, "Class: ".$className."\n");
91 91
 
92 92
             foreach ($map as $entity) {
93
-                fwrite($fh, " Entity: " . $this->getIdString($entity, $uow) . " " . spl_object_hash($entity)."\n");
93
+                fwrite($fh, " Entity: ".$this->getIdString($entity, $uow)." ".spl_object_hash($entity)."\n");
94 94
                 fwrite($fh, "  Associations:\n");
95 95
 
96 96
                 $cm = $em->getClassMetadata($className);
97 97
 
98 98
                 foreach ($cm->associationMappings as $field => $assoc) {
99
-                    fwrite($fh, "   " . $field . " ");
99
+                    fwrite($fh, "   ".$field." ");
100 100
                     $value = $cm->getFieldValue($entity, $field);
101 101
 
102 102
                     if ($assoc['type'] & ClassMetadata::TO_ONE) {
103 103
                         if ($value === null) {
104 104
                             fwrite($fh, " NULL\n");
105 105
                         } else {
106
-                            if ($value instanceof Proxy && !$value->__isInitialized()) {
106
+                            if ($value instanceof Proxy && ! $value->__isInitialized()) {
107 107
                                 fwrite($fh, "[PROXY] ");
108 108
                             }
109 109
 
110
-                            fwrite($fh, $this->getIdString($value, $uow) . " " . spl_object_hash($value) . "\n");
110
+                            fwrite($fh, $this->getIdString($value, $uow)." ".spl_object_hash($value)."\n");
111 111
                         }
112 112
                     } else {
113
-                        $initialized = !($value instanceof PersistentCollection) || $value->isInitialized();
113
+                        $initialized = ! ($value instanceof PersistentCollection) || $value->isInitialized();
114 114
                         if ($value === null) {
115 115
                             fwrite($fh, " NULL\n");
116 116
                         } elseif ($initialized) {
117
-                            fwrite($fh, "[INITIALIZED] " . $this->getType($value). " " . count($value) . " elements\n");
117
+                            fwrite($fh, "[INITIALIZED] ".$this->getType($value)." ".count($value)." elements\n");
118 118
 
119 119
                             foreach ($value as $obj) {
120
-                                fwrite($fh, "    " . $this->getIdString($obj, $uow) . " " . spl_object_hash($obj)."\n");
120
+                                fwrite($fh, "    ".$this->getIdString($obj, $uow)." ".spl_object_hash($obj)."\n");
121 121
                             }
122 122
                         } else {
123
-                            fwrite($fh, "[PROXY] " . $this->getType($value) . " unknown element size\n");
123
+                            fwrite($fh, "[PROXY] ".$this->getType($value)." unknown element size\n");
124 124
                             foreach ($value->unwrap() as $obj) {
125
-                                fwrite($fh, "    " . $this->getIdString($obj, $uow) . " " . spl_object_hash($obj)."\n");
125
+                                fwrite($fh, "    ".$this->getIdString($obj, $uow)." ".spl_object_hash($obj)."\n");
126 126
                             }
127 127
                         }
128 128
                     }
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Tools/EntityRepositoryGenerator.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
         $code = $this->generateEntityRepositoryClass($fullClassName);
144 144
 
145 145
         $path = $outputDirectory . DIRECTORY_SEPARATOR
146
-              . str_replace('\\', \DIRECTORY_SEPARATOR, $fullClassName) . '.php';
146
+                . str_replace('\\', \DIRECTORY_SEPARATOR, $fullClassName) . '.php';
147 147
         $dir = dirname($path);
148 148
 
149 149
         if ( ! is_dir($dir)) {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
     {
112 112
         $namespace = $this->getClassNamespace($fullClassName);
113 113
 
114
-        return $namespace ? 'namespace ' . $namespace . ';' : '';
114
+        return $namespace ? 'namespace '.$namespace.';' : '';
115 115
     }
116 116
 
117 117
     /**
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
         $repositoryName = $this->repositoryName ?: 'Doctrine\ORM\EntityRepository';
127 127
 
128 128
         if ($namespace && $repositoryName[0] !== '\\') {
129
-            $repositoryName = '\\' . $repositoryName;
129
+            $repositoryName = '\\'.$repositoryName;
130 130
         }
131 131
 
132 132
         return $repositoryName;
@@ -142,8 +142,8 @@  discard block
 block discarded – undo
142 142
     {
143 143
         $code = $this->generateEntityRepositoryClass($fullClassName);
144 144
 
145
-        $path = $outputDirectory . DIRECTORY_SEPARATOR
146
-              . str_replace('\\', \DIRECTORY_SEPARATOR, $fullClassName) . '.php';
145
+        $path = $outputDirectory.DIRECTORY_SEPARATOR
146
+              . str_replace('\\', \DIRECTORY_SEPARATOR, $fullClassName).'.php';
147 147
         $dir = dirname($path);
148 148
 
149 149
         if ( ! is_dir($dir)) {
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Tools/Pagination/RowNumberOverFunction.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,9 +43,9 @@
 block discarded – undo
43 43
      */
44 44
     public function getSql(\Doctrine\ORM\Query\SqlWalker $sqlWalker)
45 45
     {
46
-        return 'ROW_NUMBER() OVER(' . trim($sqlWalker->walkOrderByClause(
46
+        return 'ROW_NUMBER() OVER('.trim($sqlWalker->walkOrderByClause(
47 47
             $this->orderByClause
48
-        )) . ')';
48
+        )).')';
49 49
     }
50 50
 
51 51
     /**
Please login to merge, or discard this patch.