doctrine /
orm
| Conditions | 15 |
| Paths | 36 |
| Total Lines | 79 |
| Code Lines | 43 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 41 |
| CRAP Score | 15.0713 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 73 | 119 | public function buildCacheEntry(ClassMetadata $metadata, EntityCacheKey $key, $entity) |
|
| 74 | { |
||
| 75 | 119 | $data = $this->uow->getOriginalEntityData($entity); |
|
| 76 | 119 | $data = array_merge($data, $metadata->getIdentifierValues($entity)); // why update has no identifier values ? |
|
| 77 | |||
| 78 | 119 | if ($metadata->isVersioned) { |
|
| 79 | 1 | $data[$metadata->versionField] = $metadata->getFieldValue($entity, $metadata->versionField); |
|
| 80 | } |
||
| 81 | |||
| 82 | 119 | foreach ($metadata->associationMappings as $name => $assoc) { |
|
| 83 | 72 | if ( ! isset($data[$name])) { |
|
| 84 | 26 | continue; |
|
| 85 | } |
||
| 86 | |||
| 87 | 71 | if ( ! ($assoc['type'] & ClassMetadata::TO_ONE)) { |
|
| 88 | 59 | unset($data[$name]); |
|
| 89 | |||
| 90 | 59 | continue; |
|
| 91 | } |
||
| 92 | |||
| 93 | 70 | if ( ! isset($assoc['cache'])) { |
|
| 94 | 5 | $targetClassMetadata = $this->em->getClassMetadata($assoc['targetEntity']); |
|
| 95 | 5 | $owningAssociation = ( ! $assoc['isOwningSide']) |
|
| 96 | 1 | ? $targetClassMetadata->associationMappings[$assoc['mappedBy']] |
|
|
Bug
introduced
by
|
|||
| 97 | 5 | : $assoc; |
|
| 98 | 5 | $associationIds = $this->identifierFlattener->flattenIdentifier( |
|
| 99 | 5 | $targetClassMetadata, |
|
| 100 | 5 | $targetClassMetadata->getIdentifierValues($data[$name]) |
|
| 101 | ); |
||
| 102 | |||
| 103 | 5 | unset($data[$name]); |
|
| 104 | |||
| 105 | 5 | foreach ($associationIds as $fieldName => $fieldValue) { |
|
| 106 | 5 | if (isset($targetClassMetadata->fieldMappings[$fieldName])) { |
|
| 107 | 5 | $fieldMapping = $targetClassMetadata->fieldMappings[$fieldName]; |
|
| 108 | |||
| 109 | 5 | $data[$owningAssociation['targetToSourceKeyColumns'][$fieldMapping['columnName']]] = $fieldValue; |
|
| 110 | |||
| 111 | 5 | continue; |
|
| 112 | } |
||
| 113 | |||
| 114 | 1 | $targetAssoc = $targetClassMetadata->associationMappings[$fieldName]; |
|
| 115 | |||
| 116 | 1 | foreach($assoc['targetToSourceKeyColumns'] as $referencedColumn => $localColumn) { |
|
| 117 | 1 | if (isset($targetAssoc['sourceToTargetKeyColumns'][$referencedColumn])) { |
|
| 118 | 1 | $data[$localColumn] = $fieldValue; |
|
| 119 | } |
||
| 120 | } |
||
| 121 | } |
||
| 122 | |||
| 123 | 5 | continue; |
|
| 124 | } |
||
| 125 | |||
| 126 | 66 | if ( ! isset($assoc['id'])) { |
|
| 127 | 65 | $targetClass = ClassUtils::getClass($data[$name]); |
|
| 128 | 65 | $targetId = $this->uow->getEntityIdentifier($data[$name]); |
|
| 129 | 65 | $data[$name] = new AssociationCacheEntry($targetClass, $targetId); |
|
| 130 | |||
| 131 | 65 | continue; |
|
| 132 | } |
||
| 133 | |||
| 134 | // handle association identifier |
||
| 135 | 5 | $targetId = is_object($data[$name]) && $this->uow->isInIdentityMap($data[$name]) |
|
| 136 | 5 | ? $this->uow->getEntityIdentifier($data[$name]) |
|
| 137 | 5 | : $data[$name]; |
|
| 138 | |||
| 139 | // @TODO - fix it ! |
||
| 140 | // handle UnitOfWork#createEntity hash generation |
||
| 141 | 5 | if ( ! is_array($targetId)) { |
|
| 142 | $data[reset($assoc['joinColumnFieldNames'])] = $targetId; |
||
| 143 | |||
| 144 | $targetEntity = $this->em->getClassMetadata($assoc['targetEntity']); |
||
| 145 | $targetId = [$targetEntity->identifier[0] => $targetId]; |
||
| 146 | } |
||
| 147 | |||
| 148 | 5 | $data[$name] = new AssociationCacheEntry($assoc['targetEntity'], $targetId); |
|
| 149 | } |
||
| 150 | |||
| 151 | 119 | return new EntityCacheEntry($metadata->name, $data); |
|
| 152 | } |
||
| 206 |
Loading history...
