ReferenceProxyTest - Code Metrics - Inspection of "[3.0] [POC] lazy-load on a per-property base" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1241)

by Marco

created 2016-01-30 14:32 UTC

ReferenceProxyTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	217
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	11

Metric	Value
wmc	14
lcom	1
cbo	11
dl	0
loc	217
rs	10

14 Methods

Rating	Name	Size	Complexity
A	setUp()	11	1
A	createProduct()	11	1
A	createAuction()	11	1
A	testLazyLoadsFieldValuesFromDatabase()	7	1
A	testAccessMetatadaForProxy()	9	1
A	testReferenceFind()	10	1
A	testCloneProxy()	22	1
A	testInitializeProxy()	11	1
A	testInitializeChangeAndFlushProxy()	14	1
A	testDoNotInitializeProxyOnGettingTheIdentifier()	11	1
A	testDoNotInitializeProxyOnGettingTheIdentifier_DDC_1625()	11	1
A	testDoNotInitializeProxyOnGettingTheIdentifierAndReturnTheRightType()	22	1
A	testInitializeProxyOnGettingSomethingOtherThanTheIdentifier()	11	1
A	testCommonPersistenceProxy()	19	1

<?php

namespace Doctrine\Tests\ORM\Functional;

use Doctrine\ORM\Proxy\ProxyFactory;
use Doctrine\ORM\Proxy\ProxyClassGenerator;
use Doctrine\Tests\Models\ECommerce\ECommerceProduct;
use Doctrine\Tests\Models\ECommerce\ECommerceShipping;
use Doctrine\Tests\Models\Company\CompanyAuction;
use ProxyManager\Proxy\GhostObjectInterface;

/**
 * Tests the generation of a proxy object for lazy loading.
 * @author Giorgio Sironi <[email protected]>
 * @author Benjamin Eberlei <[email protected]>
 */
class ReferenceProxyTest extends \Doctrine\Tests\OrmFunctionalTestCase
{
    protected function setUp()
    {
        $this->useModelSet('ecommerce');
        $this->useModelSet('company');
        parent::setUp();
        $this->_factory = new ProxyFactory(
class MyClass { }

$x = new MyClass();
$x->foo = true;
                $this->_em,
                __DIR__ . '/../../Proxies',
                'Doctrine\Tests\Proxies',
                true);
    }

    public function createProduct()
    {
        $product = new ECommerceProduct();
        $product->setName('Doctrine Cookbook');
        $this->_em->persist($product);

        $this->_em->flush();
        $this->_em->clear();

        return $product->getId();
    }

    public function createAuction()
    {
        $event = new CompanyAuction();
        $event->setData('Doctrine Cookbook');
        $this->_em->persist($event);

        $this->_em->flush();
        $this->_em->clear();

        return $event->getId();
    }

    public function testLazyLoadsFieldValuesFromDatabase()
    {
        $id = $this->createProduct();

        $productProxy = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct', array('id' => $id));
        $this->assertEquals('Doctrine Cookbook', $productProxy->getName());
    }

    /**
     * @group DDC-727
     */
    public function testAccessMetatadaForProxy()
    {
        $id = $this->createProduct();

        $entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
        $class = $this->_em->getClassMetadata(get_class($entity));

        $this->assertEquals('Doctrine\Tests\Models\ECommerce\ECommerceProduct', $class->name);
    }

    /**
     * @group DDC-1033
     */
    public function testReferenceFind()
    {
        $id = $this->createProduct();

        $entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
        $entity2 = $this->_em->find('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);

        $this->assertSame($entity, $entity2);
        $this->assertEquals('Doctrine Cookbook', $entity2->getName());
    }

    /**
     * @group DDC-1033
     */
    public function testCloneProxy()
    {
        $id = $this->createProduct();

        /* @var $entity ECommerceProduct */
        $entity = $this->_em->getReference(ECommerceProduct::class , $id);

        $clone = clone $entity;

        $this->assertEquals($id, $entity->getId());
        $this->assertEquals('Doctrine Cookbook', $entity->getName());

        $this->markTestIncomplete('To be carefully verified');

        $this->assertFalse($this->_em->contains($clone), "Cloning a reference proxy should return an unmanaged/detached entity.");
        $this->assertEquals($id, $clone->getId(), "Cloning a reference proxy should return same id.");
        $this->assertEquals('Doctrine Cookbook', $clone->getName(), "Cloning a reference proxy should return same product name.");

        // domain logic, Product::__clone sets isCloned public property
        $this->assertTrue($clone->isCloned);
        $this->assertFalse($entity->isCloned);
    }

    /**
     * @group DDC-733
     */
    public function testInitializeProxy()
    {
        $id = $this->createProduct();

        /* @var $entity \ProxyManager\Proxy\GhostObjectInterface|\Doctrine\Tests\Models\ECommerce\ECommerceProduct */
        $entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);

        $this->assertFalse($entity->isProxyInitialized(), "Pre-Condition: Object is unitialized proxy.");
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->_em->getUnitOfWork()->initializeObject($entity);
        $this->assertTrue($entity->isProxyInitialized(), "Should be initialized after called UnitOfWork::initializeObject()");
    }

    /**
     * @group DDC-1163
     */
    public function testInitializeChangeAndFlushProxy()
    {
        $id = $this->createProduct();

        /* @var $entity Doctrine\Tests\Models\ECommerce\ECommerceProduct */
        $entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
        $entity->setName('Doctrine 2 Cookbook');

        $this->_em->flush();
        $this->_em->clear();

        $entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
        $this->assertEquals('Doctrine 2 Cookbook', $entity->getName());
    }

    public function testDoNotInitializeProxyOnGettingTheIdentifier()
    {
        $id = $this->createProduct();

        /* @var $entity \ProxyManager\Proxy\GhostObjectInterface|\Doctrine\Tests\Models\ECommerce\ECommerceProduct */
        $entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);

        $this->assertFalse($entity->isProxyInitialized(), "Pre-Condition: Object is unitialized proxy.");
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertEquals($id, $entity->getId());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertFalse($entity->isProxyInitialized(), "Getting the identifier doesn't initialize the proxy.");
    }

    /**
     * @group DDC-1625
     */
    public function testDoNotInitializeProxyOnGettingTheIdentifier_DDC_1625()
    {
        $id = $this->createAuction();

        /* @var $entity \ProxyManager\Proxy\GhostObjectInterface|\Doctrine\Tests\Models\Company\CompanyAuction */
        $entity = $this->_em->getReference('Doctrine\Tests\Models\Company\CompanyAuction' , $id);

        $this->assertFalse($entity->isProxyInitialized(), "Pre-Condition: Object is unitialized proxy.");
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertEquals($id, $entity->getId());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertFalse($entity->isProxyInitialized(), "Getting the identifier doesn't initialize the proxy when extending.");
    }
    
    public function testDoNotInitializeProxyOnGettingTheIdentifierAndReturnTheRightType()
    {
        $product = new ECommerceProduct();
        $product->setName('Doctrine Cookbook');

        $shipping = new ECommerceShipping();
        $shipping->setDays(1);
        $product->setShipping($shipping);
        $this->_em->persist($product);
        $this->_em->flush();
        $this->_em->clear();

        $id = $shipping->getId();
        /* @var $entity \ProxyManager\Proxy\GhostObjectInterface|ECommerceProduct */
        $product = $this->_em->getRepository('Doctrine\Tests\Models\ECommerce\ECommerceProduct')->find($product->getId());

        $entity = $product->getShipping();
        $this->assertFalse($entity->isProxyInitialized(), "Pre-Condition: Object is unitialized proxy.");
        $this->assertEquals($id, $entity->getId());
        $this->assertSame($id, $entity->getId(), "Check that the id's are the same value, and type.");
        $this->assertFalse($entity->isProxyInitialized(), "Getting the identifier doesn't initialize the proxy.");
    }

    public function testInitializeProxyOnGettingSomethingOtherThanTheIdentifier()
    {
        $id = $this->createProduct();

        /* @var $entity \ProxyManager\Proxy\GhostObjectInterface|ECommerceProduct */
        $entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);

        $this->assertFalse($entity->isProxyInitialized(), "Pre-Condition: Object is unitialized proxy.");
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertEquals('Doctrine Cookbook', $entity->getName());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertTrue($entity->isProxyInitialized(), "Getting something other than the identifier initializes the proxy.");
    }

    /**
     * @group DDC-1604
     */
    public function testCommonPersistenceProxy()
    {
        $id = $this->createProduct();

        /* @var $entity \ProxyManager\Proxy\GhostObjectInterface|\Doctrine\Tests\Models\ECommerce\ECommerceProduct */
        $entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
        $className = \Doctrine\Common\Util\ClassUtils::getClass($entity);

        $this->assertInstanceOf(GhostObjectInterface::class, $entity);
        $this->assertFalse($entity->isProxyInitialized());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertEquals('Doctrine\Tests\Models\ECommerce\ECommerceProduct', $className);

        $restName = substr(get_class($entity), strlen($this->_em->getConfiguration()->getProxyNamespace()) +1);
        $proxyFileName = $this->_em->getConfiguration()->getProxyDir() . DIRECTORY_SEPARATOR . str_replace("\\", "", $restName) . ".php";
        $this->assertTrue(file_exists($proxyFileName), "Proxy file name cannot be found generically.");

        $entity->initializeProxy();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertTrue($entity->isProxyInitialized());
    }
}


Pull Request — master (#1241)

ReferenceProxyTest A

Complexity

Size/Duplication

Coupling/Cohesion

14 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace Doctrine\Tests\ORM\Functional;
4
5			use Doctrine\ORM\Proxy\ProxyFactory;
6			use Doctrine\ORM\Proxy\ProxyClassGenerator;
7			use Doctrine\Tests\Models\ECommerce\ECommerceProduct;
8			use Doctrine\Tests\Models\ECommerce\ECommerceShipping;
9			use Doctrine\Tests\Models\Company\CompanyAuction;
10			use ProxyManager\Proxy\GhostObjectInterface;
11
12			/**
13			* Tests the generation of a proxy object for lazy loading.
14			* @author Giorgio Sironi <[email protected]>
15			* @author Benjamin Eberlei <[email protected]>
16			*/
17			class ReferenceProxyTest extends \Doctrine\Tests\OrmFunctionalTestCase
18			{
19			protected function setUp()
20			{
21			$this->useModelSet('ecommerce');
22			$this->useModelSet('company');
23			parent::setUp();
24			$this->_factory = new ProxyFactory(
			0 ignored issues – show Bug introduced 2015-12-29 18:56 UTC by Report Bug Copy Issue Report The property `_factory` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25			$this->_em,
26			__DIR__ . '/../../Proxies',
27			'Doctrine\Tests\Proxies',
28			true);
29			}
30
31			public function createProduct()
32			{
33			$product = new ECommerceProduct();
34			$product->setName('Doctrine Cookbook');
35			$this->_em->persist($product);
36
37			$this->_em->flush();
38			$this->_em->clear();
39
40			return $product->getId();
41			}
42
43			public function createAuction()
44			{
45			$event = new CompanyAuction();
46			$event->setData('Doctrine Cookbook');
47			$this->_em->persist($event);
48
49			$this->_em->flush();
50			$this->_em->clear();
51
52			return $event->getId();
53			}
54
55			public function testLazyLoadsFieldValuesFromDatabase()
56			{
57			$id = $this->createProduct();
58
59			$productProxy = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct', array('id' => $id));
60			$this->assertEquals('Doctrine Cookbook', $productProxy->getName());
61			}
62
63			/**
64			* @group DDC-727
65			*/
66			public function testAccessMetatadaForProxy()
67			{
68			$id = $this->createProduct();
69
70			$entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
71			$class = $this->_em->getClassMetadata(get_class($entity));
72
73			$this->assertEquals('Doctrine\Tests\Models\ECommerce\ECommerceProduct', $class->name);
74			}
75
76			/**
77			* @group DDC-1033
78			*/
79			public function testReferenceFind()
80			{
81			$id = $this->createProduct();
82
83			$entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
84			$entity2 = $this->_em->find('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
85
86			$this->assertSame($entity, $entity2);
87			$this->assertEquals('Doctrine Cookbook', $entity2->getName());
88			}
89
90			/**
91			* @group DDC-1033
92			*/
93			public function testCloneProxy()
94			{
95			$id = $this->createProduct();
96
97			/* @var $entity ECommerceProduct */
98			$entity = $this->_em->getReference(ECommerceProduct::class , $id);
99
100			$clone = clone $entity;
101
102			$this->assertEquals($id, $entity->getId());
103			$this->assertEquals('Doctrine Cookbook', $entity->getName());
104
105			$this->markTestIncomplete('To be carefully verified');
106
107			$this->assertFalse($this->_em->contains($clone), "Cloning a reference proxy should return an unmanaged/detached entity.");
108			$this->assertEquals($id, $clone->getId(), "Cloning a reference proxy should return same id.");
109			$this->assertEquals('Doctrine Cookbook', $clone->getName(), "Cloning a reference proxy should return same product name.");
110
111			// domain logic, Product::__clone sets isCloned public property
112			$this->assertTrue($clone->isCloned);
113			$this->assertFalse($entity->isCloned);
114			}
115
116			/**
117			* @group DDC-733
118			*/
119			public function testInitializeProxy()
120			{
121			$id = $this->createProduct();
122
123			/* @var $entity \ProxyManager\Proxy\GhostObjectInterface\|\Doctrine\Tests\Models\ECommerce\ECommerceProduct */
124			$entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
125
126			$this->assertFalse($entity->isProxyInitialized(), "Pre-Condition: Object is unitialized proxy.");
			0 ignored issues – show Bug introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report The method `isProxyInitialized` does only exist in `ProxyManager\Proxy\GhostObjectInterface`, but not in `Doctrine\Tests\Models\ECommerce\ECommerceProduct`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
127			$this->_em->getUnitOfWork()->initializeObject($entity);
128			$this->assertTrue($entity->isProxyInitialized(), "Should be initialized after called UnitOfWork::initializeObject()");
129			}
130
131			/**
132			* @group DDC-1163
133			*/
134			public function testInitializeChangeAndFlushProxy()
135			{
136			$id = $this->createProduct();
137
138			/* @var $entity Doctrine\Tests\Models\ECommerce\ECommerceProduct */
139			$entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
140			$entity->setName('Doctrine 2 Cookbook');
141
142			$this->_em->flush();
143			$this->_em->clear();
144
145			$entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
146			$this->assertEquals('Doctrine 2 Cookbook', $entity->getName());
147			}
148
149			public function testDoNotInitializeProxyOnGettingTheIdentifier()
150			{
151			$id = $this->createProduct();
152
153			/* @var $entity \ProxyManager\Proxy\GhostObjectInterface\|\Doctrine\Tests\Models\ECommerce\ECommerceProduct */
154			$entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
155
156			$this->assertFalse($entity->isProxyInitialized(), "Pre-Condition: Object is unitialized proxy.");
			0 ignored issues – show Bug introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report The method `isProxyInitialized` does only exist in `ProxyManager\Proxy\GhostObjectInterface`, but not in `Doctrine\Tests\Models\ECommerce\ECommerceProduct`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
157			$this->assertEquals($id, $entity->getId());
			0 ignored issues – show Bug introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report The method `getId` does only exist in `Doctrine\Tests\Models\ECommerce\ECommerceProduct`, but not in `ProxyManager\Proxy\GhostObjectInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
158			$this->assertFalse($entity->isProxyInitialized(), "Getting the identifier doesn't initialize the proxy.");
159			}
160
161			/**
162			* @group DDC-1625
163			*/
164			public function testDoNotInitializeProxyOnGettingTheIdentifier_DDC_1625()
165			{
166			$id = $this->createAuction();
167
168			/* @var $entity \ProxyManager\Proxy\GhostObjectInterface\|\Doctrine\Tests\Models\Company\CompanyAuction */
169			$entity = $this->_em->getReference('Doctrine\Tests\Models\Company\CompanyAuction' , $id);
170
171			$this->assertFalse($entity->isProxyInitialized(), "Pre-Condition: Object is unitialized proxy.");
			0 ignored issues – show Bug introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report The method `isProxyInitialized` does only exist in `ProxyManager\Proxy\GhostObjectInterface`, but not in `Doctrine\Tests\Models\Company\CompanyAuction`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
172			$this->assertEquals($id, $entity->getId());
			0 ignored issues – show Bug introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report The method `getId` does only exist in `Doctrine\Tests\Models\Company\CompanyAuction`, but not in `ProxyManager\Proxy\GhostObjectInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
173			$this->assertFalse($entity->isProxyInitialized(), "Getting the identifier doesn't initialize the proxy when extending.");
174			}
175
176			public function testDoNotInitializeProxyOnGettingTheIdentifierAndReturnTheRightType()
177			{
178			$product = new ECommerceProduct();
179			$product->setName('Doctrine Cookbook');
180
181			$shipping = new ECommerceShipping();
182			$shipping->setDays(1);
183			$product->setShipping($shipping);
184			$this->_em->persist($product);
185			$this->_em->flush();
186			$this->_em->clear();
187
188			$id = $shipping->getId();
189			/* @var $entity \ProxyManager\Proxy\GhostObjectInterface\|ECommerceProduct */
190			$product = $this->_em->getRepository('Doctrine\Tests\Models\ECommerce\ECommerceProduct')->find($product->getId());
191
192			$entity = $product->getShipping();
193			$this->assertFalse($entity->isProxyInitialized(), "Pre-Condition: Object is unitialized proxy.");
194			$this->assertEquals($id, $entity->getId());
195			$this->assertSame($id, $entity->getId(), "Check that the id's are the same value, and type.");
196			$this->assertFalse($entity->isProxyInitialized(), "Getting the identifier doesn't initialize the proxy.");
197			}
198
199			public function testInitializeProxyOnGettingSomethingOtherThanTheIdentifier()
200			{
201			$id = $this->createProduct();
202
203			/* @var $entity \ProxyManager\Proxy\GhostObjectInterface\|ECommerceProduct */
204			$entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
205
206			$this->assertFalse($entity->isProxyInitialized(), "Pre-Condition: Object is unitialized proxy.");
			0 ignored issues – show Bug introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report The method `isProxyInitialized` does only exist in `ProxyManager\Proxy\GhostObjectInterface`, but not in `Doctrine\Tests\Models\ECommerce\ECommerceProduct`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
207			$this->assertEquals('Doctrine Cookbook', $entity->getName());
			0 ignored issues – show Bug introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report The method `getName` does only exist in `Doctrine\Tests\Models\ECommerce\ECommerceProduct`, but not in `ProxyManager\Proxy\GhostObjectInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
208			$this->assertTrue($entity->isProxyInitialized(), "Getting something other than the identifier initializes the proxy.");
209			}
210
211			/**
212			* @group DDC-1604
213			*/
214			public function testCommonPersistenceProxy()
215			{
216			$id = $this->createProduct();
217
218			/* @var $entity \ProxyManager\Proxy\GhostObjectInterface\|\Doctrine\Tests\Models\ECommerce\ECommerceProduct */
219			$entity = $this->_em->getReference('Doctrine\Tests\Models\ECommerce\ECommerceProduct' , $id);
220			$className = \Doctrine\Common\Util\ClassUtils::getClass($entity);
221
222			$this->assertInstanceOf(GhostObjectInterface::class, $entity);
223			$this->assertFalse($entity->isProxyInitialized());
			0 ignored issues – show Bug introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report The method `isProxyInitialized` does only exist in `ProxyManager\Proxy\GhostObjectInterface`, but not in `Doctrine\Tests\Models\ECommerce\ECommerceProduct`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
224			$this->assertEquals('Doctrine\Tests\Models\ECommerce\ECommerceProduct', $className);
225
226			$restName = substr(get_class($entity), strlen($this->_em->getConfiguration()->getProxyNamespace()) +1);
227			$proxyFileName = $this->_em->getConfiguration()->getProxyDir() . DIRECTORY_SEPARATOR . str_replace("\\", "", $restName) . ".php";
228			$this->assertTrue(file_exists($proxyFileName), "Proxy file name cannot be found generically.");
229
230			$entity->initializeProxy();
			0 ignored issues – show Bug introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report The method `initializeProxy` does only exist in `ProxyManager\Proxy\GhostObjectInterface`, but not in `Doctrine\Tests\Models\ECommerce\ECommerceProduct`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
231			$this->assertTrue($entity->isProxyInitialized());
232			}
233			}
234

doctrine / orm

Pull Request — master (#1241)

ReferenceProxyTest A

Complexity

Size/Duplication

Coupling/Cohesion

14 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like