ProxyFactory - Code Metrics - Inspection of "[3.0] [POC] lazy-load on a per-property base" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1241)

by Marco

created 2016-01-30 14:32 UTC

ProxyFactory C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	258
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	19

Test Coverage

Coverage

97.73%

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
wmc	24
c	3
b	0
f	0
lcom	1
cbo	19
dl	0
loc	258
ccs	86
cts	88
cp	0.9773
rs	6.875

8 Methods

Rating	Name	Size	Complexity
A	__construct()	12	1
B	getProxy()	49	5
A	resetUninitializedProxy()	13	2
A	skipClass()	5	2
A	createProxyDefinition()	14	1
B	createInitializer()	34	4
B	createCloner()	30	6
A	getInternalReflectionPropertyName()	13	3

<?php
/*
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the MIT license. For more information, see
 * <http://www.doctrine-project.org>.
 */

namespace Doctrine\ORM\Proxy;

use Doctrine\Common\Persistence\Mapping\ClassMetadata;
use Doctrine\Common\Proxy\AbstractProxyFactory;
use Doctrine\Common\Proxy\Exception\InvalidArgumentException;
use Doctrine\Common\Proxy\Exception\OutOfBoundsException;
use Doctrine\Common\Proxy\ProxyDefinition;
use Doctrine\Common\Proxy\ProxyGenerator;
use Doctrine\Common\Util\ClassUtils;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\Persisters\Entity\EntityPersister;
use Doctrine\ORM\EntityNotFoundException;
use Doctrine\ORM\Utility\IdentifierFlattener;
use ProxyManager\Generator\ClassGenerator;
use ProxyManager\GeneratorStrategy\EvaluatingGeneratorStrategy;
use ProxyManager\Proxy\GhostObjectInterface;
use ProxyManager\ProxyGenerator\LazyLoadingGhostGenerator;
use ProxyManager\ProxyGenerator\Util\Properties;
use ReflectionClass;
use ReflectionProperty;

/**
 * This factory is used to create proxy objects for entities at runtime.
 *
 * @author Roman Borschel <[email protected]>
 * @author Giorgio Sironi <[email protected]>
 * @author Marco Pivetta  <[email protected]>
 * @since 2.0
 */
class ProxyFactory extends AbstractProxyFactory
{
    /**
     * @var EntityManagerInterface The EntityManager this factory is bound to.
     */
    private $em;

    /**
     * @var \Doctrine\ORM\UnitOfWork The UnitOfWork this factory uses to retrieve persisters
     */
    private $uow;

    /**
     * @var string
     */
    private $proxyNs;

    /**
     * The IdentifierFlattener used for manipulating identifiers
     *
     * @var \Doctrine\ORM\Utility\IdentifierFlattener
     */
    private $identifierFlattener;

    /**
     * Initializes a new instance of the <tt>ProxyFactory</tt> class that is
     * connected to the given <tt>EntityManager</tt>.
     *
     * @param EntityManagerInterface $em           The EntityManager the new factory works for.
     * @param string                 $proxyDir     The directory to use for the proxy classes. It must exist.
     * @param string                 $proxyNs      The namespace to use for the proxy classes.
     * @param boolean|int            $autoGenerate The strategy for automatically generating proxy classes. Possible
     *                                             values are constants of Doctrine\Common\Proxy\AbstractProxyFactory.
     */
    public function __construct(EntityManagerInterface $em, $proxyDir, $proxyNs, $autoGenerate = AbstractProxyFactory::AUTOGENERATE_NEVER)
    {
        $proxyGenerator = new ProxyGenerator($proxyDir, $proxyNs);

        $proxyGenerator->setPlaceholder('baseProxyInterface', Proxy::class);
        parent::__construct($proxyGenerator, $em->getMetadataFactory(), $autoGenerate);

        $this->em                  = $em;
        $this->uow                 = $em->getUnitOfWork();
        $this->proxyNs             = $proxyNs;
        $this->identifierFlattener = new IdentifierFlattener($this->uow, $em->getMetadataFactory());
    }

    /**
     * {@inheritDoc}
     *
     * @return GhostObjectInterface
     */
    public function getProxy($className, array $identifier)
    {
        $definition = $this->createProxyDefinition($className);
        $fqcn       = $definition->proxyClassName;

        if (! class_exists($fqcn, false)) {
            $generatorStrategy    = new EvaluatingGeneratorStrategy();
            $proxyGenerator       = new ClassGenerator();
            $skippedProperties    = array_filter(
                Properties::fromReflectionClass(new ReflectionClass($className))->getInstanceProperties(),
                function (ReflectionProperty $property) use ($definition) {
                    return ! in_array(
                            $property->getName(),
                            array_map(
                                function (ReflectionProperty $property) {
                                    return $property->getName();
                                },
                                $definition->reflectionFields
                            )
                        )
                        || in_array($property->getName(), $definition->identifierFields);
                }
            );

            $proxyGenerator->setName($fqcn);

            (new LazyLoadingGhostGenerator())->generate(
                $this->em->getClassMetadata($className)->getReflectionClass(),
                $proxyGenerator,
                [
                    'skippedProperties' => array_map([$this, 'getInternalReflectionPropertyName'], $skippedProperties)
                ]
            );

            $generatorStrategy->generate($proxyGenerator);
        }

        $proxy = $fqcn::staticProxyConstructor($definition->initializer/*, $definition->cloner*/);

        foreach ($definition->identifierFields as $idField) {
            if (! isset($identifier[$idField])) {
                throw OutOfBoundsException::missingPrimaryKeyValue($className, $idField);
            }

            $definition->reflectionFields[$idField]->setValue($proxy, $identifier[$idField]);
        }

        return $proxy;
    }

    /**
     * Reset initialization/cloning logic for an un-initialized proxy
     *
     * @param GhostObjectInterface $proxy
     *
     * @return GhostObjectInterface
     *
     * @throws \Doctrine\Common\Proxy\Exception\InvalidArgumentException
     */
    public function resetUninitializedProxy(GhostObjectInterface $proxy)
    {
        if ($proxy->isProxyInitialized()) {
            throw InvalidArgumentException::unitializedProxyExpected($proxy);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        $className  = ClassUtils::getClass($proxy);
        $definition = $this->createProxyDefinition($className);

        $proxy->setProxyInitializer($definition->initializer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $proxy;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * {@inheritDoc}
     */
    protected function skipClass(ClassMetadata $metadata)
    {
        /* @var $metadata \Doctrine\ORM\Mapping\ClassMetadataInfo */
        return $metadata->isMappedSuperclass || $metadata->getReflectionClass()->isAbstract();
    }

    /**
     * {@inheritDoc}
     */
    protected function createProxyDefinition($className)
    {
        $classMetadata   = $this->em->getClassMetadata($className);
        $entityPersister = $this->uow->getEntityPersister($className);
        $cloner          = $this->createCloner($classMetadata, $entityPersister);

        return new ProxyDefinition(
            ClassUtils::generateProxyClassName($className, $this->proxyNs),
            $classMetadata->getIdentifierFieldNames(),
            $classMetadata->getReflectionProperties(),
            $this->createInitializer($classMetadata, $entityPersister, $cloner),
            $this->createCloner($classMetadata, $entityPersister)
        );
    }

    /**
     * Creates a closure capable of initializing a proxy
     *
     * @param \Doctrine\Common\Persistence\Mapping\ClassMetadata $classMetadata
     * @param \Doctrine\ORM\Persisters\Entity\EntityPersister    $entityPersister
     * @param \Closure                                           $cloner
     *
     * @return \Closure
     *
     * @throws \Doctrine\ORM\EntityNotFoundException
     */
    private function createInitializer(ClassMetadata $classMetadata, EntityPersister $entityPersister, \Closure $cloner)
    {
        return function (
            GhostObjectInterface $proxy,
            $method,
            $parameters,
            & $initializer
        ) use (
            $entityPersister,
            $classMetadata,
            $cloner
        ) {
            if (! $initializer) {
                return false;
            }

            if ('__clone' === strtolower($method)) {
                $cloner($proxy, $initializer);

                return true;
            }

            $initializerBkp = $initializer;
            $initializer    = null;

            if (null === $entityPersister->loadById($classMetadata->getIdentifierValues($proxy), $proxy)) {
                $initializer = $initializerBkp;

                throw new EntityNotFoundException($classMetadata->getName());
            }

            return true;
        };
    }

    /**
     * Creates a closure capable of finalizing state a cloned proxy
     *
     * @param \Doctrine\Common\Persistence\Mapping\ClassMetadata $classMetadata
     * @param \Doctrine\ORM\Persisters\Entity\EntityPersister    $entityPersister
     *
     * @return \Closure
     *
     * @throws \Doctrine\ORM\EntityNotFoundException
     */
    private function createCloner(ClassMetadata $classMetadata, EntityPersister $entityPersister)
    {
        return function (GhostObjectInterface $proxy, & $initializer) use ($entityPersister, $classMetadata) {
            if ($proxy->isProxyInitialized()) {
                return;
            }

            $initializer = null;

            $class      = $entityPersister->getClassMetadata();
            $identifier = $classMetadata->getIdentifierValues($proxy);
            $original   = $entityPersister->loadById($identifier);

            if (null === $original) {
                throw EntityNotFoundException::fromClassNameAndIdentifier(
                    $classMetadata->getName(),
                    $this->identifierFlattener->flattenIdentifier($classMetadata, $identifier)

                );
            }

            foreach ($class->getReflectionClass()->getProperties() as $property) {
                if ( ! $class->hasField($property->name) && ! $class->hasAssociation($property->name)) {
                    continue;
                }

                $property->setAccessible(true);
                $property->setValue($proxy, $property->getValue($original));
            }
        };
    }

    /**
     * @param ReflectionProperty $reflectionProperty
     *
     * @return string
     */
    private function getInternalReflectionPropertyName(ReflectionProperty $reflectionProperty)
    {
        if ($reflectionProperty->isProtected()) {
            return "\0*\0" . $reflectionProperty->getName();
        }

        if ($reflectionProperty->isPrivate()) {
            return "\0" . $reflectionProperty->getDeclaringClass()->getName()

            . "\0" . $reflectionProperty->getName();
        }

        return $reflectionProperty->getName();
    }
}


1		<?php
2		/*
3		* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
4		* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
5		* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
6		* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
7		* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
8		* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
9		* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
10		* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
11		* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
12		* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
13		* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
14		*
15		* This software consists of voluntary contributions made by many individuals
16		* and is licensed under the MIT license. For more information, see
17		* <http://www.doctrine-project.org>.
18		*/
19
20		namespace Doctrine\ORM\Proxy;
21
22		use Doctrine\Common\Persistence\Mapping\ClassMetadata;
23		use Doctrine\Common\Proxy\AbstractProxyFactory;
24		use Doctrine\Common\Proxy\Exception\InvalidArgumentException;
25		use Doctrine\Common\Proxy\Exception\OutOfBoundsException;
26		use Doctrine\Common\Proxy\ProxyDefinition;
27		use Doctrine\Common\Proxy\ProxyGenerator;
28		use Doctrine\Common\Util\ClassUtils;
29		use Doctrine\ORM\EntityManagerInterface;
30		use Doctrine\ORM\Persisters\Entity\EntityPersister;
31		use Doctrine\ORM\EntityNotFoundException;
32		use Doctrine\ORM\Utility\IdentifierFlattener;
33		use ProxyManager\Generator\ClassGenerator;
34		use ProxyManager\GeneratorStrategy\EvaluatingGeneratorStrategy;
35		use ProxyManager\Proxy\GhostObjectInterface;
36		use ProxyManager\ProxyGenerator\LazyLoadingGhostGenerator;
37		use ProxyManager\ProxyGenerator\Util\Properties;
38		use ReflectionClass;
39		use ReflectionProperty;
40
41		/**
42		* This factory is used to create proxy objects for entities at runtime.
43		*
44		* @author Roman Borschel <[email protected]>
45		* @author Giorgio Sironi <[email protected]>
46		* @author Marco Pivetta <[email protected]>
47		* @since 2.0
48		*/
49		class ProxyFactory extends AbstractProxyFactory
50		{
51		/**
52		* @var EntityManagerInterface The EntityManager this factory is bound to.
53		*/
54		private $em;
55
56		/**
57		* @var \Doctrine\ORM\UnitOfWork The UnitOfWork this factory uses to retrieve persisters
58		*/
59		private $uow;
60
61		/**
62		* @var string
63		*/
64		private $proxyNs;
65
66		/**
67		* The IdentifierFlattener used for manipulating identifiers
68		*
69		* @var \Doctrine\ORM\Utility\IdentifierFlattener
70		*/
71		private $identifierFlattener;
72
73		/**
74		* Initializes a new instance of the <tt>ProxyFactory</tt> class that is
75		* connected to the given <tt>EntityManager</tt>.
76		*
77		* @param EntityManagerInterface $em The EntityManager the new factory works for.
78		* @param string $proxyDir The directory to use for the proxy classes. It must exist.
79		* @param string $proxyNs The namespace to use for the proxy classes.
80		* @param boolean\|int $autoGenerate The strategy for automatically generating proxy classes. Possible
81		* values are constants of Doctrine\Common\Proxy\AbstractProxyFactory.
82		*/
83	2314	public function __construct(EntityManagerInterface $em, $proxyDir, $proxyNs, $autoGenerate = AbstractProxyFactory::AUTOGENERATE_NEVER)
84		{
85	2314	$proxyGenerator = new ProxyGenerator($proxyDir, $proxyNs);
86
87	2314	$proxyGenerator->setPlaceholder('baseProxyInterface', Proxy::class);
88	2314	parent::__construct($proxyGenerator, $em->getMetadataFactory(), $autoGenerate);
89
90	2314	$this->em = $em;
91	2314	$this->uow = $em->getUnitOfWork();
92	2314	$this->proxyNs = $proxyNs;
93	2314	$this->identifierFlattener = new IdentifierFlattener($this->uow, $em->getMetadataFactory());
94	2314	}
95
96		/**
97		* {@inheritDoc}
98		*
99		* @return GhostObjectInterface
100		*/
101	219	public function getProxy($className, array $identifier)
102		{
103	219	$definition = $this->createProxyDefinition($className);
104	219	$fqcn = $definition->proxyClassName;
105
106	219	if (! class_exists($fqcn, false)) {
107	88	$generatorStrategy = new EvaluatingGeneratorStrategy();
108	88	$proxyGenerator = new ClassGenerator();
109	88	$skippedProperties = array_filter(
110	88	Properties::fromReflectionClass(new ReflectionClass($className))->getInstanceProperties(),
111		function (ReflectionProperty $property) use ($definition) {
112	88	return ! in_array(
113	88	$property->getName(),
114		array_map(
115		function (ReflectionProperty $property) {
116	88	return $property->getName();
117	88	},
118	88	$definition->reflectionFields
119		)
120		)
121	88	\|\| in_array($property->getName(), $definition->identifierFields);
122	88	}
123		);
124
125	88	$proxyGenerator->setName($fqcn);
126
127	88	(new LazyLoadingGhostGenerator())->generate(
128	88	$this->em->getClassMetadata($className)->getReflectionClass(),
129		$proxyGenerator,
130		[
131	88	'skippedProperties' => array_map([$this, 'getInternalReflectionPropertyName'], $skippedProperties)
132		]
133		);
134
135	88	$generatorStrategy->generate($proxyGenerator);
136		}
137
138	219	$proxy = $fqcn::staticProxyConstructor($definition->initializer/, $definition->cloner/);
139
140	219	foreach ($definition->identifierFields as $idField) {
141	219	if (! isset($identifier[$idField])) {
142		throw OutOfBoundsException::missingPrimaryKeyValue($className, $idField);
143		}
144
145	219	$definition->reflectionFields[$idField]->setValue($proxy, $identifier[$idField]);
146		}
147
148	219	return $proxy;
149		}
150
151		/**
152		* Reset initialization/cloning logic for an un-initialized proxy
153		*
154		* @param GhostObjectInterface $proxy
155		*
156		* @return GhostObjectInterface
157		*
158		* @throws \Doctrine\Common\Proxy\Exception\InvalidArgumentException
159		*/
160	6	public function resetUninitializedProxy(GhostObjectInterface $proxy)
161		{
162	6	if ($proxy->isProxyInitialized()) {
163		throw InvalidArgumentException::unitializedProxyExpected($proxy);
		0 ignored issues – show Documentation introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report `$proxy` is of type `object<ProxyManager\Proxy\GhostObjectInterface>`, but the function expects a `object<Doctrine\Common\Persistence\Proxy>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
164		}
165
166	6	$className = ClassUtils::getClass($proxy);
167	6	$definition = $this->createProxyDefinition($className);
168
169	6	$proxy->setProxyInitializer($definition->initializer);
		0 ignored issues – show Documentation introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report `$definition->initializer` is of type `callable`, but the function expects a `null\|object<Closure>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
170
171	6	return $proxy;
		0 ignored issues – show Bug Best Practice introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report The return type of `return $proxy;` (`ProxyManager\Proxy\GhostObjectInterface`) is incompatible with the return type of the parent method `Doctrine\Common\Proxy\Ab...resetUninitializedProxy` of type `Doctrine\Common\Proxy\Proxy`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
172		}
173
174		/**
175		* {@inheritDoc}
176		*/
177	1	protected function skipClass(ClassMetadata $metadata)
178		{
179		/* @var $metadata \Doctrine\ORM\Mapping\ClassMetadataInfo */
180	1	return $metadata->isMappedSuperclass \|\| $metadata->getReflectionClass()->isAbstract();
181		}
182
183		/**
184		* {@inheritDoc}
185		*/
186	219	protected function createProxyDefinition($className)
187		{
188	219	$classMetadata = $this->em->getClassMetadata($className);
189	219	$entityPersister = $this->uow->getEntityPersister($className);
190	219	$cloner = $this->createCloner($classMetadata, $entityPersister);
191
192	219	return new ProxyDefinition(
193	219	ClassUtils::generateProxyClassName($className, $this->proxyNs),
194	219	$classMetadata->getIdentifierFieldNames(),
195	219	$classMetadata->getReflectionProperties(),
196	219	$this->createInitializer($classMetadata, $entityPersister, $cloner),
197	219	$this->createCloner($classMetadata, $entityPersister)
198		);
199		}
200
201		/**
202		* Creates a closure capable of initializing a proxy
203		*
204		* @param \Doctrine\Common\Persistence\Mapping\ClassMetadata $classMetadata
205		* @param \Doctrine\ORM\Persisters\Entity\EntityPersister $entityPersister
206		* @param \Closure $cloner
207		*
208		* @return \Closure
209		*
210		* @throws \Doctrine\ORM\EntityNotFoundException
211		*/
212	219	private function createInitializer(ClassMetadata $classMetadata, EntityPersister $entityPersister, \Closure $cloner)
213		{
214		return function (
215		GhostObjectInterface $proxy,
216		$method,
217		$parameters,
218		& $initializer
219		) use (
220	103	$entityPersister,
221	103	$classMetadata,
222	103	$cloner
223		) {
224	103	if (! $initializer) {
225		return false;
226		}
227
228	103	if ('__clone' === strtolower($method)) {
229	2	$cloner($proxy, $initializer);
230
231	1	return true;
232		}
233
234	101	$initializerBkp = $initializer;
235	101	$initializer = null;
236
237	101	if (null === $entityPersister->loadById($classMetadata->getIdentifierValues($proxy), $proxy)) {
238	3	$initializer = $initializerBkp;
239
240	3	throw new EntityNotFoundException($classMetadata->getName());
241		}
242
243	98	return true;
244	219	};
245		}
246
247		/**
248		* Creates a closure capable of finalizing state a cloned proxy
249		*
250		* @param \Doctrine\Common\Persistence\Mapping\ClassMetadata $classMetadata
251		* @param \Doctrine\ORM\Persisters\Entity\EntityPersister $entityPersister
252		*
253		* @return \Closure
254		*
255		* @throws \Doctrine\ORM\EntityNotFoundException
256		*/
257		private function createCloner(ClassMetadata $classMetadata, EntityPersister $entityPersister)
258		{
259	219	return function (GhostObjectInterface $proxy, & $initializer) use ($entityPersister, $classMetadata) {
260	2	if ($proxy->isProxyInitialized()) {
261		return;
262		}
263
264	2	$initializer = null;
265
266	2	$class = $entityPersister->getClassMetadata();
267	2	$identifier = $classMetadata->getIdentifierValues($proxy);
268	2	$original = $entityPersister->loadById($identifier);
269
270	2	if (null === $original) {
271	1	throw EntityNotFoundException::fromClassNameAndIdentifier(
272	1	$classMetadata->getName(),
273	1	$this->identifierFlattener->flattenIdentifier($classMetadata, $identifier)
		0 ignored issues – show Compatibility introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report `$classMetadata` of type `object<Doctrine\Common\P...\Mapping\ClassMetadata>` is not a sub-type of `object<Doctrine\ORM\Mapping\ClassMetadata>`. It seems like you assume a concrete implementation of the interface `Doctrine\Common\Persistence\Mapping\ClassMetadata` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
274		);
275		}
276
277	1	foreach ($class->getReflectionClass()->getProperties() as $property) {
278		if ( ! $class->hasField($property->name) && ! $class->hasAssociation($property->name)) {
279		continue;
280		}
281
282		$property->setAccessible(true);
283		$property->setValue($proxy, $property->getValue($original));
284		}
285	219	};
286		}
287
288		/**
289		* @param ReflectionProperty $reflectionProperty
290		*
291		* @return string
292		*/
293	88	private function getInternalReflectionPropertyName(ReflectionProperty $reflectionProperty)
294		{
295	88	if ($reflectionProperty->isProtected()) {
296	14	return "\0*\0" . $reflectionProperty->getName();
297		}
298
299	75	if ($reflectionProperty->isPrivate()) {
300	23	return "\0" . $reflectionProperty->getDeclaringClass()->getName()
		0 ignored issues – show introduced 2016-01-30 14:44 UTC by Report Bug Copy Issue Report Consider using `$reflectionProperty->class`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
301	23	. "\0" . $reflectionProperty->getName();
302		}
303
304	55	return $reflectionProperty->getName();
305		}
306		}
307

doctrine / orm

Pull Request — master (#1241)

ProxyFactory C

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

Duplication Side-by-Side

Filter issues like