Doctrine\Tests\ORM\Functional\Ticket\GH7708Model

Complexity

Total Complexity

1

Size/Duplication

Total Lines	17
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1

<?php

declare(strict_types=1);

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\Common\Cache\ArrayCache;
use Doctrine\ORM\Annotation as ORM;
use Doctrine\ORM\Cache\{DefaultCacheFactory, RegionsConfiguration};

Use statements should be sorted alphabetically. The first wrong one is DefaultCacheFactory.

Group use declaration is disallowed, use single use for every import.

Multiple used types per use statement are forbidden.

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\Tools\{SchemaTool, Setup};

Group use declaration is disallowed, use single use for every import.

Multiple used types per use statement are forbidden.

use Doctrine\Tests\TestUtil;

use PHPUnit\Framework\TestCase;

Expected 0 lines between same types of use statement, found 1.

class GH7708Test extends TestCase
{
    protected $entityManager;

    protected function getEntityManager()
    {
        if (!$this->entityManager) {

Expected 1 space(s) after NOT operator; 0 found

            $regionsConfig = new RegionsConfiguration();

            $cacheDriver = new GH7708ArrayCacheMock();

            $cacheFactory = new DefaultCacheFactory($regionsConfig, $cacheDriver);

            $conn = TestUtil::getConnection();

            $config = Setup::createAnnotationMetadataConfiguration([]);

            $config->setMetadataCacheImpl($cacheDriver);
            $config->setQueryCacheImpl($cacheDriver);
            $config->setResultCacheImpl($cacheDriver);
            $config->setHydrationCacheImpl($cacheDriver);

            $config->setSecondLevelCacheEnabled();
            $secondLevelCacheConfig = $config->getSecondLevelCacheConfiguration();
            $secondLevelCacheConfig->setCacheFactory($cacheFactory);

            $this->entityManager = EntityManager::create($conn, $config);

            // Creating a schema

            $schemaTool = new SchemaTool($this->entityManager);
            $schemaTool->createSchema([
                $this->entityManager->getClassMetadata(GH7708Car::class),
                $this->entityManager->getClassMetadata(GH7708Model::class),
                $this->entityManager->getClassMetadata(GH7708Drive::class)

Multi-line arrays must have a trailing comma after the last element.

            ]);

            // Populating with data

            $frontDrive = new GH7708Drive('Front');
            $rearDrive = new GH7708Drive('Rear');

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

            $fullDrive = new GH7708Drive('Full');

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

            $this->entityManager->persist(new GH7708Car(new GH7708Model('Audi A4'), $rearDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('Audi A5'), $rearDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('Audi A6'), $rearDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('Audi A8'), $rearDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('Audi Q3'), $fullDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('Audi Q5'), $fullDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('Audi Q7'), $fullDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('BMW 1-series'), $rearDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('BMW 3-series'), $rearDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('BMW 5-series'), $rearDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('BMW 7-series'), $rearDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('BMW X1'), $fullDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('BMW X3'), $fullDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('BMW X5'), $fullDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('BMW X6'), $fullDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('Volkswagen Golf'), $frontDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('Volkswagen Jetta'), $frontDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('Volkswagen Passat'), $frontDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('Volkswagen Polo'), $frontDrive));
            $this->entityManager->persist(new GH7708Car(new GH7708Model('Volkswagen Tiguan'), $fullDrive));

            $this->entityManager->flush();
        }
        return $this->entityManager;

Expected 1 lines before "return", found 0.

    }

    protected function executeQuery(): array

There must be exactly 1 whitespace between closing parenthesis and return type colon.

    {
        return $this->getEntityManager()->getRepository(GH7708Car::class)->createQueryBuilder('ca')
            ->addSelect('mo')
            ->addSelect('dr')
            ->innerJoin('ca.model', 'mo')
            ->innerJoin('ca.drive', 'dr')
            ->getQuery()
            ->setMaxResults(20)
            ->useResultCache(true, 3600, 'result')
            ->setCacheable(true)
            ->getResult();
    }

    public function testSecondLevelCacheCartesianProduct() : void
    {
        // Executing the query for the first time to populate the cache
        $this->executeQuery();

        // Reseting the mock array
        GH7708ArrayCacheMock::$fetchRequests = [];

        // The second query execution for retreiving data from cache
        $result = $this->executeQuery();

        // I expect that cache requests count is less than query result (20 rows).
        $resultObjectsCount = count($result);

Function count() should not be referenced via a fallback global name, but via a use statement.

        $fetchRequestsCount = count(GH7708ArrayCacheMock::$fetchRequests);

Function count() should not be referenced via a fallback global name, but via a use statement.

        $this->assertLessThan($resultObjectsCount, $fetchRequestsCount);
    }
}

class GH7708ArrayCacheMock extends ArrayCache
{
    public static $fetchRequests = [];

    protected function doFetch($id)
    {
        self::$fetchRequests[] = [
            'id' => $id,
            'cacheDriverObject' => spl_object_hash($this)

Function spl_object_hash() should not be referenced via a fallback global name, but via a use statement.

Multi-line arrays must have a trailing comma after the last element.

        ];
        return parent::doFetch($id);

Expected 1 lines before "return", found 0.

    }
}

/**
 * @ORM\Entity
 * @ORM\Cache(usage="NONSTRICT_READ_WRITE")
 **/
class GH7708Car
{
    /**
     * @ORM\Id
     * @ORM\Column(type="integer")
     * @ORM\GeneratedValue
     **/
    protected $id;

    /**
     * @ORM\ManyToOne(targetEntity=GH7708Model::class, cascade={"persist"})
     * @ORM\Cache(usage="NONSTRICT_READ_WRITE")
     **/
    protected $model;

    /**
     * @ORM\ManyToOne(targetEntity=GH7708Drive::class, cascade={"persist"})
     * @ORM\Cache(usage="NONSTRICT_READ_WRITE")
     **/
    protected $drive;

    public function __construct(GH7708Model $model, GH7708Drive $drive)
    {
        $this->model = $model;
        $this->drive = $drive;
    }
}

/**
 * @ORM\Entity
 * @ORM\Cache(usage="NONSTRICT_READ_WRITE")
 **/
class GH7708Model
{
    /**
     * @ORM\Id
     * @ORM\Column(type="integer")
     * @ORM\GeneratedValue
     **/
    protected $id;

    /**

Found multi-line comment for property \Doctrine\Tests\ORM\Functional\Ticket\GH7708Model::$title with single line content, use one-line comment instead.

     * @ORM\Column(type="string", length=64)
     **/
    protected $title;

    public function __construct(string $title)
    {
        $this->title = $title;
    }
}

/**
 * @ORM\Entity
 * @ORM\Cache(usage="NONSTRICT_READ_WRITE")
 **/
class GH7708Drive
{
    /**
     * @ORM\Id
     * @ORM\Column(type="integer")
     * @ORM\GeneratedValue
     **/
    protected $id;

    /**

Found multi-line comment for property \Doctrine\Tests\ORM\Functional\Ticket\GH7708Drive::$title with single line content, use one-line comment instead.

     * @ORM\Column(type="string", length=64)
     **/
    protected $title;

    public function __construct(string $title)
    {
        $this->title = $title;
    }
}