GH6402Test - Code Metrics - Inspection of "fixed #5622 - mysql 5.7 ONLY_FULL_GROUP_BY" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#6143)

by Luís

created 2017-07-01 12:23 UTC

GH6402Test A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	81
Duplicated Lines	27.16 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	8
lcom	1
cbo	7
dl	22
loc	81
rs	10
c	1
b	0
f	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	testFindWithSubClass()	0	7	1
A	createFullAddress()	0	10	1
A	persistAddress()	0	10	1
A	setUp()	0	6	1
A	testFind()	0	7	1
A	testQuery()	11	11	1
A	testQueryWithSubClass()	11	11	1
A	createAddress()	0	9	1

How to fix Duplicated Code

<?php

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\Tests\Models\Quote\Address;
use Doctrine\Tests\Models\Quote\City;
use Doctrine\Tests\Models\Quote\FullAddress;
use Doctrine\Tests\Models\Quote\Group;
use Doctrine\Tests\Models\Quote\Phone;
use Doctrine\Tests\Models\Quote\User;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Doctrine\Tests\OrmFunctionalTestCase;

/**
 * @group 6402
 */
class GH6402Test extends OrmFunctionalTestCase
{
    protected function setUp()
    {
        $this->useModelSet('quote');

        parent::setUp();
    }

    public function testFind()
    {
        $id = $this->createAddress();

        $address = $this->_em->find(Address::class, $id);
        self::assertNotNull($address->user);
    }

    public function testQuery()
    {
        $id = $this->createAddress();

        $addresses = $this->_em->createQuery('SELECT a FROM ' . Address::class . ' a WHERE a.id = :id')
            ->setParameter('id', $id)
            ->getResult();

        self::assertCount(1, $addresses);
        self::assertNotNull($addresses[0]->user);
    }

    public function testFindWithSubClass()
    {
        $id = $this->createFullAddress();

        $address = $this->_em->find(FullAddress::class, $id);
        self::assertNotNull($address->user);
    }

    public function testQueryWithSubClass()
    {
        $id = $this->createFullAddress();

        $addresses = $this->_em->createQuery('SELECT a FROM ' . FullAddress::class . ' a WHERE a.id = :id')
            ->setParameter('id', $id)
            ->getResult();

        self::assertCount(1, $addresses);
        self::assertNotNull($addresses[0]->user);
    }

    private function createAddress()
    {
        $address = new Address();
        $address->zip = 'bar';

        $this->persistAddress($address);

        return $address->id;
    }

    private function createFullAddress()
    {
        $address = new FullAddress();
        $address->zip = 'bar';
        $address->city = new City('London');

        $this->persistAddress($address);

        return $address->id;
    }

    private function persistAddress(Address $address)
    {
        $user = new User();
        $user->name = "foo";
        $user->setAddress($address);

        $this->_em->persist($user);
        $this->_em->flush();
        $this->_em->clear();
    }
}


1		<?php
2
3		namespace Doctrine\Tests\ORM\Functional\Ticket;
4
5		use Doctrine\Tests\Models\Quote\Address;
6		use Doctrine\Tests\Models\Quote\City;
7		use Doctrine\Tests\Models\Quote\FullAddress;
8		use Doctrine\Tests\Models\Quote\Group;
9		use Doctrine\Tests\Models\Quote\Phone;
10		use Doctrine\Tests\Models\Quote\User;
		0 ignored issues – show Bug introduced 2017-06-20 08:13 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Doctrine\Tests\ORM\Functional\Ticket\User`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
11		use Doctrine\Tests\OrmFunctionalTestCase;
12
13		/**
14		* @group 6402
15		*/
16		class GH6402Test extends OrmFunctionalTestCase
17		{
18		protected function setUp()
19		{
20		$this->useModelSet('quote');
21
22		parent::setUp();
23		}
24
25		public function testFind()
26		{
27		$id = $this->createAddress();
28
29		$address = $this->_em->find(Address::class, $id);
30		self::assertNotNull($address->user);
31		}
32
33	View Code Duplication	public function testQuery()
34		{
35		$id = $this->createAddress();
36
37		$addresses = $this->_em->createQuery('SELECT a FROM ' . Address::class . ' a WHERE a.id = :id')
38		->setParameter('id', $id)
39		->getResult();
40
41		self::assertCount(1, $addresses);
42		self::assertNotNull($addresses[0]->user);
43		}
44
45		public function testFindWithSubClass()
46		{
47		$id = $this->createFullAddress();
48
49		$address = $this->_em->find(FullAddress::class, $id);
50		self::assertNotNull($address->user);
51		}
52
53	View Code Duplication	public function testQueryWithSubClass()
54		{
55		$id = $this->createFullAddress();
56
57		$addresses = $this->_em->createQuery('SELECT a FROM ' . FullAddress::class . ' a WHERE a.id = :id')
58		->setParameter('id', $id)
59		->getResult();
60
61		self::assertCount(1, $addresses);
62		self::assertNotNull($addresses[0]->user);
63		}
64
65		private function createAddress()
66		{
67		$address = new Address();
68		$address->zip = 'bar';
69
70		$this->persistAddress($address);
71
72		return $address->id;
73		}
74
75		private function createFullAddress()
76		{
77		$address = new FullAddress();
78		$address->zip = 'bar';
79		$address->city = new City('London');
80
81		$this->persistAddress($address);
82
83		return $address->id;
84		}
85
86		private function persistAddress(Address $address)
87		{
88		$user = new User();
89		$user->name = "foo";
90		$user->setAddress($address);
91
92		$this->_em->persist($user);
93		$this->_em->flush();
94		$this->_em->clear();
95		}
96		}
97

doctrine / orm

Pull Request — master (#6143)

GH6402Test A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like