GH7605Test::testCaseAsLeftOperandOfComparisonAndInExpression() - Code Metrics - Inspection of "CASE WHEN as left operand of an IN comparison. Clo..." - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#7607)

unknown

created 2019-02-12 20:30 UTC

testCaseAsLeftOperandOfComparisonAndInExpression() A

↳ Parent: GH7605Test

Complexity

Conditions	4
Paths	8

Size

Total Lines	64
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	40
nc	8
nop	0
dl	0
loc	64
rs	9.28
c	0
b	0
f	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\ORM\AbstractQuery;
use Doctrine\ORM\Annotation as ORM;
use Doctrine\Tests\OrmFunctionalTestCase;

class GH7605Test extends OrmFunctionalTestCase
{
    protected function setUp() : void
    {
        parent::setUp();

        $this->schemaTool->createSchema(
            [
                $this->em->getClassMetadata(GH7605Offer::class),
            ]
        );
    }

    /**
     * The intent of this test is to ensure that the ORM is capable
     * of generate queries using both ComparisonExpression and InExpression
     * when the left operand is a CASE statement
     *
     * @group 7605
     */
    public function testCaseAsLeftOperandOfComparisonAndInExpression() : void
    {
        // Rules to define offer status (the order matters):
        // 1 - active === false? INACTIVE
        // 2 - closed === true?  CLOSED
        // 3 - balance > 0?    ACTIVE
        // 4 - balance === 0?  FINISHED
        $offersInfo = array(

            // The fields order is: id, active, closed, balance
            array(1, true, false, 10), // ACTIVE

            array(2, true, false, 0), // FINISHED

            array(3, false, true, 30), // INACTIVE

            array(4, true, true, 20), // CLOSED

        );
        foreach ($offersInfo as $offerInfo) {
            $offer = new GH7605Offer($offerInfo[0], $offerInfo[1], $offerInfo[2], $offerInfo[3]);
            $this->em->persist($offer);
        }
        $this->em->flush();
        $this->em->clear();
        
        $dqlStatusLogic = "CASE 
            WHEN offer.active = FALSE THEN 'INACTIVE'
            WHEN offer.closed = TRUE THEN 'CLOSED'
            WHEN offer.balance > 0 THEN 'ACTIVE'
            ELSE 'FINISHED'
        END";
        
        // ComparisonExpression tests
        $query = $this->em->createQueryBuilder()
            ->select('offer')
            ->from(GH7605Offer::class, 'offer')
            ->where($dqlStatusLogic.' = :status')

            ->setMaxResults(1)
            ->getQuery();
        
        $query->setParameter('status', 'ACTIVE');
        $offer = $query->getOneOrNullResult(AbstractQuery::HYDRATE_OBJECT);
        self::assertEquals(1, $offer->id);
        
        $query->setParameter('status', 'INACTIVE');
        $offer = $query->getOneOrNullResult(AbstractQuery::HYDRATE_OBJECT);
        self::assertEquals(3, $offer->id);
        
        // InExpression tests
        $qb = $this->em->createQueryBuilder()
$a = "a";
$ab = "ab";
$abc = "abc";
            ->select('offer')
            ->from(GH7605Offer::class, 'offer')
            ->where($dqlStatusLogic.' IN (:status)')

            ->orderBy('offer.id', 'ASC');
        $query = $qb->getQuery();
        $query->setParameter('status', array('INACTIVE', 'CLOSED'));

        $offers = $query->getResult(AbstractQuery::HYDRATE_OBJECT);
$a = "a";
$ab = "ab";
$abc = "abc";
        $expectedIds = [3, 4];
        foreach ($offers as $i => $offer) {
            self::assertEquals($expectedIds[$i], $offer->id);
        }
        
        $query = $qb->where($dqlStatusLogic.' NOT IN (:status)')->getQuery();

        $query->setParameter('status', array('FINISHED', 'INACTIVE'));

        $offers = $query->getResult(AbstractQuery::HYDRATE_OBJECT);
$a = "a";
$ab = "ab";
$abc = "abc";
        $expectedIds = [1, 4];
        foreach ($offers as $i => $offer) {
            self::assertEquals($expectedIds[$i], $offer->id);
        }
    }
}

/**
 * @ORM\Entity
 */
class GH7605Offer
{
    /**
     * @ORM\Id
     * @ORM\Column(type="integer")
     * @ORM\GeneratedValue(strategy="NONE")
     */
    public $id;

    /** @ORM\Column(type="boolean", nullable=false) */
    public $active;

    /** @ORM\Column(type="boolean", nullable=false) */
    public $closed;

    /** @ORM\Column(type="integer", nullable=false) */
    public $balance;

    /**
     * @param string $name
     */
    public function __construct($id, $active, $closed, $balance)
    {
        $this->id = $id;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->active = $active;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->closed = $closed;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->balance = $balance;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Doctrine\Tests\ORM\Functional\Ticket;
6
7			use Doctrine\ORM\AbstractQuery;
8			use Doctrine\ORM\Annotation as ORM;
9			use Doctrine\Tests\OrmFunctionalTestCase;
10
11			class GH7605Test extends OrmFunctionalTestCase
12			{
13			protected function setUp() : void
14			{
15			parent::setUp();
16
17			$this->schemaTool->createSchema(
18			[
19			$this->em->getClassMetadata(GH7605Offer::class),
20			]
21			);
22			}
23
24			/**
25			* The intent of this test is to ensure that the ORM is capable
26			* of generate queries using both ComparisonExpression and InExpression
27			* when the left operand is a CASE statement
28			*
29			* @group 7605
30			*/
31			public function testCaseAsLeftOperandOfComparisonAndInExpression() : void
32			{
33			// Rules to define offer status (the order matters):
34			// 1 - active === false? INACTIVE
35			// 2 - closed === true? CLOSED
36			// 3 - balance > 0? ACTIVE
37			// 4 - balance === 0? FINISHED
38			$offersInfo = array(
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Short array syntax must be used to define arrays Loading history...
39			// The fields order is: id, active, closed, balance
40			array(1, true, false, 10), // ACTIVE
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Short array syntax must be used to define arrays Loading history...
41			array(2, true, false, 0), // FINISHED
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Short array syntax must be used to define arrays Loading history...
42			array(3, false, true, 30), // INACTIVE
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Short array syntax must be used to define arrays Loading history...
43			array(4, true, true, 20), // CLOSED
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Short array syntax must be used to define arrays Loading history...
44			);
45			foreach ($offersInfo as $offerInfo) {
46			$offer = new GH7605Offer($offerInfo[0], $offerInfo[1], $offerInfo[2], $offerInfo[3]);
47			$this->em->persist($offer);
48			}
49			$this->em->flush();
50			$this->em->clear();
51
52			$dqlStatusLogic = "CASE
53			WHEN offer.active = FALSE THEN 'INACTIVE'
54			WHEN offer.closed = TRUE THEN 'CLOSED'
55			WHEN offer.balance > 0 THEN 'ACTIVE'
56			ELSE 'FINISHED'
57			END";
58
59			// ComparisonExpression tests
60			$query = $this->em->createQueryBuilder()
61			->select('offer')
62			->from(GH7605Offer::class, 'offer')
63			->where($dqlStatusLogic.' = :status')
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Concat operator must be surrounded by a single space Loading history...
64			->setMaxResults(1)
65			->getQuery();
66
67			$query->setParameter('status', 'ACTIVE');
68			$offer = $query->getOneOrNullResult(AbstractQuery::HYDRATE_OBJECT);
69			self::assertEquals(1, $offer->id);
70
71			$query->setParameter('status', 'INACTIVE');
72			$offer = $query->getOneOrNullResult(AbstractQuery::HYDRATE_OBJECT);
73			self::assertEquals(3, $offer->id);
74
75			// InExpression tests
76			$qb = $this->em->createQueryBuilder()
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
77			->select('offer')
78			->from(GH7605Offer::class, 'offer')
79			->where($dqlStatusLogic.' IN (:status)')
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Concat operator must be surrounded by a single space Loading history...
80			->orderBy('offer.id', 'ASC');
81			$query = $qb->getQuery();
82			$query->setParameter('status', array('INACTIVE', 'CLOSED'));
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Short array syntax must be used to define arrays Loading history...
83			$offers = $query->getResult(AbstractQuery::HYDRATE_OBJECT);
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
84			$expectedIds = [3, 4];
85			foreach ($offers as $i => $offer) {
86			self::assertEquals($expectedIds[$i], $offer->id);
87			}
88
89			$query = $qb->where($dqlStatusLogic.' NOT IN (:status)')->getQuery();
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Concat operator must be surrounded by a single space Loading history...
90			$query->setParameter('status', array('FINISHED', 'INACTIVE'));
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Short array syntax must be used to define arrays Loading history...
91			$offers = $query->getResult(AbstractQuery::HYDRATE_OBJECT);
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
92			$expectedIds = [1, 4];
93			foreach ($offers as $i => $offer) {
94			self::assertEquals($expectedIds[$i], $offer->id);
95			}
96			}
97			}
98
99			/**
100			* @ORM\Entity
101			*/
102			class GH7605Offer
103			{
104			/**
105			* @ORM\Id
106			* @ORM\Column(type="integer")
107			* @ORM\GeneratedValue(strategy="NONE")
108			*/
109			public $id;
110
111			/** @ORM\Column(type="boolean", nullable=false) */
112			public $active;
113
114			/** @ORM\Column(type="boolean", nullable=false) */
115			public $closed;
116
117			/** @ORM\Column(type="integer", nullable=false) */
118			public $balance;
119
120			/**
121			* @param string $name
122			*/
123			public function __construct($id, $active, $closed, $balance)
124			{
125			$this->id = $id;
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
126			$this->active = $active;
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
127			$this->closed = $closed;
			0 ignored issues – show Coding Style introduced 2019-02-12 20:39 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
128			$this->balance = $balance;
129			}
130			}
131

doctrine / orm

Pull Request — master (#7607)

testCaseAsLeftOperandOfComparisonAndInExpression() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like