Failed Conditions
Pull Request — master (#7885)
by Šimon
09:31
created
lib/Doctrine/ORM/Internal/Hydration/AbstractHydrator.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -213,8 +213,8 @@
 block discarded – undo
213 213
         $this->metadataCache = [];
214 214
 
215 215
         $this->em
216
-             ->getEventManager()
217
-             ->removeEventListener([Events::onClear], $this);
216
+                ->getEventManager()
217
+                ->removeEventListener([Events::onClear], $this);
218 218
     }
219 219
 
220 220
     /**
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
                         : $value;
321 321
 
322 322
                     if ($cacheKeyInfo['isIdentifier'] && $value !== null) {
323
-                        $id[$dqlAlias]                .= '|' . $value;
323
+                        $id[$dqlAlias]                .= '|'.$value;
324 324
                         $nonemptyComponents[$dqlAlias] = true;
325 325
                     }
326 326
                     break;
@@ -356,10 +356,10 @@  discard block
 block discarded – undo
356 356
 
357 357
             // WARNING: BC break! We know this is the desired behavior to type convert values, but this
358 358
             // erroneous behavior exists since 2.0 and we're forced to keep compatibility.
359
-            if (! isset($cacheKeyInfo['isScalar'])) {
359
+            if ( ! isset($cacheKeyInfo['isScalar'])) {
360 360
                 $dqlAlias  = $cacheKeyInfo['dqlAlias'];
361 361
                 $type      = $cacheKeyInfo['type'];
362
-                $fieldName = $dqlAlias . '_' . $fieldName;
362
+                $fieldName = $dqlAlias.'_'.$fieldName;
363 363
                 $value     = $type
364 364
                     ? $type->convertToPHPValue($value, $this->platform)
365 365
                     : $value;
@@ -460,7 +460,7 @@  discard block
 block discarded – undo
460 460
     private function getDiscriminatorValues(ClassMetadata $classMetadata) : array
461 461
     {
462 462
         $values = array_map(
463
-            function (string $subClass) : string {
463
+            function(string $subClass) : string {
464 464
                 return (string) $this->getClassMetadata($subClass)->discriminatorValue;
465 465
             },
466 466
             $classMetadata->getSubClasses()
@@ -480,7 +480,7 @@  discard block
 block discarded – undo
480 480
      */
481 481
     protected function getClassMetadata($className)
482 482
     {
483
-        if (! isset($this->metadataCache[$className])) {
483
+        if ( ! isset($this->metadataCache[$className])) {
484 484
             $this->metadataCache[$className] = $this->em->getClassMetadata($className);
485 485
         }
486 486
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Tools/Console/Command/InfoCommandTest.php 1 patch
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -60,13 +60,13 @@  discard block
 block discarded – undo
60 60
         $em            = $this->createMock(EntityManagerInterface::class);
61 61
 
62 62
         $mappingDriver->method('getAllClassNames')
63
-                      ->willReturn([]);
63
+                        ->willReturn([]);
64 64
 
65 65
         $configuration->method('getMetadataDriverImpl')
66
-                      ->willReturn($mappingDriver);
66
+                        ->willReturn($mappingDriver);
67 67
 
68 68
         $em->method('getConfiguration')
69
-           ->willReturn($configuration);
69
+            ->willReturn($configuration);
70 70
 
71 71
         $application = new Application();
72 72
         $application->setHelperSet(new HelperSet(['em' => new EntityManagerHelper($em)]));
@@ -95,17 +95,17 @@  discard block
 block discarded – undo
95 95
         $em            = $this->createMock(EntityManagerInterface::class);
96 96
 
97 97
         $mappingDriver->method('getAllClassNames')
98
-                      ->willReturn(['InvalidEntity']);
98
+                        ->willReturn(['InvalidEntity']);
99 99
 
100 100
         $configuration->method('getMetadataDriverImpl')
101
-                      ->willReturn($mappingDriver);
101
+                        ->willReturn($mappingDriver);
102 102
 
103 103
         $em->method('getConfiguration')
104
-           ->willReturn($configuration);
104
+            ->willReturn($configuration);
105 105
 
106 106
         $em->method('getClassMetadata')
107
-           ->with('InvalidEntity')
108
-           ->willThrowException(new MappingException('exception message'));
107
+            ->with('InvalidEntity')
108
+            ->willThrowException(new MappingException('exception message'));
109 109
 
110 110
         $application = new Application();
111 111
         $application->setHelperSet(new HelperSet(['em' => new EntityManagerHelper($em)]));
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Tools/Console/Command/RunDqlCommandTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
             $this->tester->execute(
63 63
                 [
64 64
                     'command' => $this->command->getName(),
65
-                    'dql'     => 'SELECT e FROM ' . DateTimeModel::class . ' e',
65
+                    'dql'     => 'SELECT e FROM '.DateTimeModel::class.' e',
66 66
                 ]
67 67
             )
68 68
         );
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
             $this->tester->execute(
81 81
                 [
82 82
                     'command'    => $this->command->getName(),
83
-                    'dql'        => 'SELECT e FROM ' . DateTimeModel::class . ' e',
83
+                    'dql'        => 'SELECT e FROM '.DateTimeModel::class.' e',
84 84
                     '--show-sql' => 'true',
85 85
                 ]
86 86
             )
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Tools/Console/Command/ValidateSchemaCommand.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -45,10 +45,10 @@
 block discarded – undo
45 45
     protected function configure()
46 46
     {
47 47
         $this->setName('orm:validate-schema')
48
-             ->setDescription('Validate the mapping files')
49
-             ->addOption('skip-mapping', null, InputOption::VALUE_NONE, 'Skip the mapping validation check')
50
-             ->addOption('skip-sync', null, InputOption::VALUE_NONE, 'Skip checking if the mapping is in sync with the database')
51
-             ->setHelp('Validate that the mapping files are correct and in sync with the database.');
48
+                ->setDescription('Validate the mapping files')
49
+                ->addOption('skip-mapping', null, InputOption::VALUE_NONE, 'Skip the mapping validation check')
50
+                ->addOption('skip-sync', null, InputOption::VALUE_NONE, 'Skip checking if the mapping is in sync with the database')
51
+                ->setHelp('Validate that the mapping files are correct and in sync with the database.');
52 52
     }
53 53
 
54 54
     /**
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
             $ui->text('<comment>[SKIPPED] The mapping was not checked.</comment>');
47 47
         }
48 48
 
49
-        if (! $skipMapping) {
49
+        if ( ! $skipMapping) {
50 50
             $errors = $validator->validateMapping();
51 51
 
52 52
             if ($errors) {
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 
73 73
         if ($input->getOption('skip-sync')) {
74 74
             $ui->text('<comment>[SKIPPED] The database was not checked for synchronicity.</comment>');
75
-        } elseif (! $validator->schemaInSyncWithMetadata()) {
75
+        } elseif ( ! $validator->schemaInSyncWithMetadata()) {
76 76
             $ui->error('The database schema is not in sync with the current mapping file.');
77 77
             $exit += 2;
78 78
         } else {
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Tools/Console/Command/EnsureProductionSettingsCommand.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,9 +45,9 @@
 block discarded – undo
45 45
     protected function configure()
46 46
     {
47 47
         $this->setName('orm:ensure-production-settings')
48
-             ->setDescription('Verify that Doctrine is properly configured for a production environment')
49
-             ->addOption('complete', null, InputOption::VALUE_NONE, 'Flag to also inspect database connection existence.')
50
-             ->setHelp('Verify that Doctrine is properly configured for a production environment.');
48
+                ->setDescription('Verify that Doctrine is properly configured for a production environment')
49
+                ->addOption('complete', null, InputOption::VALUE_NONE, 'Flag to also inspect database connection existence.')
50
+                ->setHelp('Verify that Doctrine is properly configured for a production environment.');
51 51
     }
52 52
 
53 53
     /**
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Tools/Console/Command/GenerateProxiesCommand.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -46,11 +46,11 @@
 block discarded – undo
46 46
     protected function configure()
47 47
     {
48 48
         $this->setName('orm:generate-proxies')
49
-             ->setAliases(['orm:generate:proxies'])
50
-             ->setDescription('Generates proxy classes for entity classes')
51
-             ->addArgument('dest-path', InputArgument::OPTIONAL, 'The path to generate your proxy classes. If none is provided, it will attempt to grab from configuration.')
52
-             ->addOption('filter', null, InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY, 'A string pattern used to match entities that should be processed.')
53
-             ->setHelp('Generates proxy classes for entity classes.');
49
+                ->setAliases(['orm:generate:proxies'])
50
+                ->setDescription('Generates proxy classes for entity classes')
51
+                ->addArgument('dest-path', InputArgument::OPTIONAL, 'The path to generate your proxy classes. If none is provided, it will attempt to grab from configuration.')
52
+                ->addOption('filter', null, InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY, 'A string pattern used to match entities that should be processed.')
53
+                ->setHelp('Generates proxy classes for entity classes.');
54 54
     }
55 55
 
56 56
     /**
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -57,19 +57,19 @@
 block discarded – undo
57 57
             $destPath = $em->getConfiguration()->getProxyDir();
58 58
         }
59 59
 
60
-        if (! is_dir($destPath)) {
60
+        if ( ! is_dir($destPath)) {
61 61
             mkdir($destPath, 0775, true);
62 62
         }
63 63
 
64 64
         $destPath = realpath($destPath);
65 65
 
66
-        if (! file_exists($destPath)) {
66
+        if ( ! file_exists($destPath)) {
67 67
             throw new InvalidArgumentException(
68 68
                 sprintf("Proxies destination directory '<info>%s</info>' does not exist.", $em->getConfiguration()->getProxyDir())
69 69
             );
70 70
         }
71 71
 
72
-        if (! is_writable($destPath)) {
72
+        if ( ! is_writable($destPath)) {
73 73
             throw new InvalidArgumentException(
74 74
                 sprintf("Proxies destination directory '<info>%s</info>' does not have write permissions.", $destPath)
75 75
             );
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/ManyToManyBasicAssociationTest.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -268,8 +268,8 @@
 block discarded – undo
268 268
         $this->em->clear();
269 269
 
270 270
         $newUser = $this->em->createQuery('SELECT u, g FROM Doctrine\Tests\Models\CMS\CmsUser u LEFT JOIN u.groups g WHERE u.id = ?1')
271
-                             ->setParameter(1, $user->getId())
272
-                             ->getSingleResult();
271
+                                ->setParameter(1, $user->getId())
272
+                                ->getSingleResult();
273 273
         self::assertCount(0, $newUser->groups);
274 274
         self::assertInstanceOf(ManyToManyAssociationMetadata::class, $newUser->groups->getMapping());
275 275
 
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -294,9 +294,9 @@  discard block
 block discarded – undo
294 294
         $user->username = 'gblanco';
295 295
         $user->status   = 'developer';
296 296
 
297
-        for ($i=0; $i < $groupCount; ++$i) {
297
+        for ($i = 0; $i < $groupCount; ++$i) {
298 298
             $group       = new CmsGroup();
299
-            $group->name = 'Developers_' . $i;
299
+            $group->name = 'Developers_'.$i;
300 300
             $user->addGroup($group);
301 301
         }
302 302
 
@@ -428,7 +428,7 @@  discard block
 block discarded – undo
428 428
             $user
429 429
                 ->getGroups()
430 430
                 ->matching($criteria)
431
-                ->map(static function (CmsGroup $group) {
431
+                ->map(static function(CmsGroup $group) {
432 432
                     return $group->getName();
433 433
                 })
434 434
                 ->toArray()
@@ -472,7 +472,7 @@  discard block
 block discarded – undo
472 472
             $user
473 473
                 ->getTags()
474 474
                 ->matching($criteria)
475
-                ->map(static function (CmsTag $tag) {
475
+                ->map(static function(CmsTag $tag) {
476 476
                     return $tag->getName();
477 477
                 })
478 478
                 ->toArray()
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC1400Test.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -54,8 +54,8 @@
 block discarded – undo
54 54
         $user1 = $this->em->getReference(DDC1400User::class, $user1->id);
55 55
 
56 56
         $this->em->createQuery('SELECT a, s FROM ' . DDC1400Article::class . ' a JOIN a.userStates s WITH s.user = :activeUser')
57
-                  ->setParameter('activeUser', $user1)
58
-                  ->getResult();
57
+                    ->setParameter('activeUser', $user1)
58
+                    ->getResult();
59 59
 
60 60
         $queryCount = $this->getCurrentQueryCount();
61 61
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
 
55 55
         $user1 = $this->em->getReference(DDC1400User::class, $user1->id);
56 56
 
57
-        $this->em->createQuery('SELECT a, s FROM ' . DDC1400Article::class . ' a JOIN a.userStates s WITH s.user = :activeUser')
57
+        $this->em->createQuery('SELECT a, s FROM '.DDC1400Article::class.' a JOIN a.userStates s WITH s.user = :activeUser')
58 58
                   ->setParameter('activeUser', $user1)
59 59
                   ->getResult();
60 60
 
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Tools/Console/Command/SchemaTool/DropCommand.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -28,11 +28,11 @@  discard block
 block discarded – undo
28 28
     protected function configure()
29 29
     {
30 30
         $this->setName('orm:schema-tool:drop')
31
-             ->setDescription('Drop the complete database schema of EntityManager Storage Connection or generate the corresponding SQL output')
32
-             ->addOption('dump-sql', null, InputOption::VALUE_NONE, 'Instead of trying to apply generated SQLs into EntityManager Storage Connection, output them.')
33
-             ->addOption('force', 'f', InputOption::VALUE_NONE, "Don't ask for the deletion of the database, but force the operation to run.")
34
-             ->addOption('full-database', null, InputOption::VALUE_NONE, 'Instead of using the Class Metadata to detect the database table schema, drop ALL assets that the database contains.')
35
-             ->setHelp(<<<'EOT'
31
+                ->setDescription('Drop the complete database schema of EntityManager Storage Connection or generate the corresponding SQL output')
32
+                ->addOption('dump-sql', null, InputOption::VALUE_NONE, 'Instead of trying to apply generated SQLs into EntityManager Storage Connection, output them.')
33
+                ->addOption('force', 'f', InputOption::VALUE_NONE, "Don't ask for the deletion of the database, but force the operation to run.")
34
+                ->addOption('full-database', null, InputOption::VALUE_NONE, 'Instead of using the Class Metadata to detect the database table schema, drop ALL assets that the database contains.')
35
+                ->setHelp(<<<'EOT'
36 36
 Processes the schema and either drop the database schema of EntityManager Storage Connection or generate the SQL output.
37 37
 Beware that the complete database is dropped by this command, even tables that are not relevant to your metadata model.
38 38
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 
43 43
     $config->setFilterSchemaAssetsExpression($regexp);
44 44
 EOT
45
-             );
45
+                );
46 46
     }
47 47
 
48 48
     /**
Please login to merge, or discard this patch.