Category::removeProduct() - Code Metrics - Inspection of "[BUG] Incorrect handling of ManyToMany relation wi..." - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6185)

by Ilya

created 2016-12-21 09:29 UTC

Category::removeProduct() A

↳ Parent: Category

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	1

<?php

namespace Doctrine\Tests\Models\AivusTest;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;

/**
 * @Entity
 * @Table(name="categories")
 */
class Category
{
    /**
     * @Column(type="integer")
     * @Id
     * @GeneratedValue
     *
     * @var int
     */
    protected $id;

    /**
     * @ManyToMany(targetEntity="Product")
     * @JoinTable(name="category_to_products",
     *      joinColumns={@JoinColumn(name="category_id", referencedColumnName="id")},
     *      inverseJoinColumns={@JoinColumn(name="product_id", referencedColumnName="id", unique=true)}
     * )
     */
    protected $products;

    public function __construct()
    {
        $this->products = new ArrayCollection();
    }

    /**
     * @return int
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return Collection|Product[]
     */
    public function getProducts()
    {
        return $this->products;
    }

    /**
     * @param Product $product
     *
     * @return $this
     */
    public function addProduct(Product $product)
    {
        if (!$this->products->contains($product)) {
            $this->products->add($product);
        }

        return $this;
    }

    /**
     * @param Product $product
     *
     * @return $this
     */
    public function removeProduct(Product $product)
    {
        if ($this->products->contains($product)) {
            $this->products->removeElement($product);
        }

        return $this;
    }
}


1			<?php
2
3			namespace Doctrine\Tests\Models\AivusTest;
4
5			use Doctrine\Common\Collections\ArrayCollection;
6			use Doctrine\Common\Collections\Collection;
7
8			/**
9			* @Entity
10			* @Table(name="categories")
11			*/
12			class Category
13			{
14			/**
15			* @Column(type="integer")
16			* @Id
17			* @GeneratedValue
18			*
19			* @var int
20			*/
21			protected $id;
22
23			/**
24			* @ManyToMany(targetEntity="Product")
25			* @JoinTable(name="category_to_products",
26			* joinColumns={@JoinColumn(name="category_id", referencedColumnName="id")},
27			* inverseJoinColumns={@JoinColumn(name="product_id", referencedColumnName="id", unique=true)}
28			* )
29			*/
30			protected $products;
31
32			public function __construct()
33			{
34			$this->products = new ArrayCollection();
35			}
36
37			/**
38			* @return int
39			*/
40			public function getId()
41			{
42			return $this->id;
43			}
44
45			/**
46			* @return Collection\|Product[]
47			*/
48			public function getProducts()
49			{
50			return $this->products;
51			}
52
53			/**
54			* @param Product $product
55			*
56			* @return $this
57			*/
58			public function addProduct(Product $product)
59			{
60			if (!$this->products->contains($product)) {
61			$this->products->add($product);
62			}
63
64			return $this;
65			}
66
67			/**
68			* @param Product $product
69			*
70			* @return $this
71			*/
72			public function removeProduct(Product $product)
73			{
74			if ($this->products->contains($product)) {
75			$this->products->removeElement($product);
76			}
77
78			return $this;
79			}
80			}
81

doctrine / orm

Pull Request — master (#6185)

Category::removeProduct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like