MetadataCollection::get() - Code Metrics - Inspection of "Removing the metadata instantiation from the EM" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#7143)

by Mike

created 2018-03-23 15:20 UTC

MetadataCollection::get() A

↳ Parent: MetadataCollection

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	1
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Doctrine\ORM\Mapping;


class MetadataCollection
{


    /**

     * @var ClassMetadata[]
     */
    private $classMetadatas;

    private function __construct(array $classMetadatas)

    {
        $metadataByClassName = array_reduce (
$a = "a";
$ab = "ab";
$abc = "abc";
            $classMetadatas,
            function ( $carry, ClassMetadata $classMetadata )

            {

                $className = $classMetadata->getClassName();
                $carry[$className] = $classMetadata;
                return $carry;
            } ,

            []
        ) ;
        $this->classMetadatas = $metadataByClassName;
    }

    public function get($name)
    {
        if(!isset($this->classMetadatas[$name])){

            throw new \Exception('No metadata found for ' . $name);
        }
        return $this->classMetadatas[$name];
    }

    public static function fromClassMetadatas(array $classMetadatas)

    {
        return new self($classMetadatas);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Doctrine\ORM\Mapping;
6
7
8			class MetadataCollection
9			{
			0 ignored issues – show introduced 2018-03-23 15:29 UTC by Report Bug Copy Issue Report There must be exactly 0 empty lines after class opening brace. Loading history...
10
11			/**
			0 ignored issues – show introduced 2018-03-23 15:29 UTC by Report Bug Copy Issue Report Found multi-line comment for property \Doctrine\ORM\Mapping\MetadataCollection::$classMetadatas with single line content, use one-line comment instead. Loading history...
12			* @var ClassMetadata[]
13			*/
14			private $classMetadatas;
15
16			private function __construct(array $classMetadatas)
			0 ignored issues – show introduced 2018-03-23 15:29 UTC by Report Bug Copy Issue Report Method \Doctrine\ORM\Mapping\MetadataCollection::__construct() does not have @param annotation for its traversable parameter $classMetadatas. Loading history...
17			{
18			$metadataByClassName = array_reduce (
			0 ignored issues – show Coding Style introduced 2018-03-23 15:29 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... introduced 2018-03-23 15:29 UTC by Report Bug Copy Issue Report Function array_reduce() should not be referenced via a fallback global name, but via a use statement. Loading history... Coding Style introduced 2018-03-23 15:29 UTC by Report Bug Copy Issue Report Space before opening parenthesis of function call prohibited Loading history...
19			$classMetadatas,
20			function ( $carry, ClassMetadata $classMetadata )
			0 ignored issues – show Coding Style introduced 2018-03-23 15:29 UTC by Report Bug Copy Issue Report Expected 0 spaces between opening bracket and argument "$carry"; 1 found Loading history... Coding Style introduced 2018-03-23 15:29 UTC by Report Bug Copy Issue Report Expected 0 spaces between argument "$classMetadata" and closing bracket; 1 found Loading history...
21			{
			0 ignored issues – show Coding Style introduced 2018-03-23 15:29 UTC by Report Bug Copy Issue Report Opening brace should be on the same line as the declaration Loading history...
22			$className = $classMetadata->getClassName();
23			$carry[$className] = $classMetadata;
24			return $carry;
25			} ,
			0 ignored issues – show Coding Style introduced 2018-03-23 15:29 UTC by Report Bug Copy Issue Report Space found before comma in function call Loading history...
26			[]
27			) ;
28			$this->classMetadatas = $metadataByClassName;
29			}
30
31			public function get($name)
32			{
33			if(!isset($this->classMetadatas[$name])){
			0 ignored issues – show Coding Style introduced 2018-03-23 15:29 UTC by Report Bug Copy Issue Report Expected 1 space(s) after IF keyword; 0 found Loading history... Coding Style introduced 2018-03-23 15:29 UTC by Report Bug Copy Issue Report There must be a single space after a NOT operator; 0 found Loading history...
34			throw new \Exception('No metadata found for ' . $name);
35			}
36			return $this->classMetadatas[$name];
37			}
38
39			public static function fromClassMetadatas(array $classMetadatas)
			0 ignored issues – show introduced 2018-03-23 15:29 UTC by Report Bug Copy Issue Report Method \Doctrine\ORM\Mapping\MetadataCollection::fromClassMetadatas() does not have @param annotation for its traversable parameter $classMetadatas. Loading history...
40			{
41			return new self($classMetadatas);
42			}
43			}
44

doctrine / orm

Pull Request — master (#7143)

MetadataCollection::get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like