Issues in DDC6460Test.php - All Issues - Inspection of "Merge pull request #6749 from KonstantinKuklin/pat..." - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 2ade86...13f838 )

by Jonathan

created 2017-10-04 12:48 UTC

Tests/ORM/Functional/Ticket/DDC6460Test.php (3 issues)

Labels

Severity

Maciej Kosiedowski 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Doctrine\Tests\ORM\Functional\Ticket;

use Doctrine\DBAL\Schema\SchemaException;
use Doctrine\ORM\Mapping\Column;
use Doctrine\ORM\Mapping\Embeddable;
use Doctrine\ORM\Mapping\Entity;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Doctrine\ORM\Mapping\Id;
use Doctrine\ORM\Mapping\GeneratedValue;
use Doctrine\ORM\Mapping\ManyToOne;
use Doctrine\ORM\Proxy\Proxy;

class DDC6460Test extends \Doctrine\Tests\OrmFunctionalTestCase
{
    public function setUp()
    {
        parent::setUp();

        try {
            $this->setUpEntitySchema(
                [
                    DDC6460Entity::class,
                    DDC6460ParentEntity::class,
                ]
            );
        } catch (SchemaException $e) {

        }
    }

    /**
     * @group DDC-6460
     */
    public function testInlineEmbeddable()
    {
        $isFieldMapped = $this->_em
            ->getClassMetadata(DDC6460Entity::class)
            ->hasField('embedded');

        $this->assertTrue($isFieldMapped);
    }

    /**
     * @group DDC-6460
     */
    public function testInlineEmbeddableProxyInitialization()
    {
        $entity = new DDC6460Entity();
        $entity->id = 1;
        $entity->embedded = new DDC6460Embeddable();
        $entity->embedded->field = 'test';
        $this->_em->persist($entity);

        $second = new DDC6460ParentEntity();
        $second->id = 1;
        $second->lazyLoaded = $entity;
        $this->_em->persist($second);
        $this->_em->flush();

        $this->_em->clear();

        $secondEntityWithLazyParameter = $this->_em->getRepository(DDC6460ParentEntity::class)->findOneById(1);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $this->assertInstanceOf(Proxy::class, $secondEntityWithLazyParameter->lazyLoaded);
        $this->assertInstanceOf(DDC6460Entity::class, $secondEntityWithLazyParameter->lazyLoaded);
        $this->assertFalse($secondEntityWithLazyParameter->lazyLoaded->__isInitialized());
        $this->assertEquals($secondEntityWithLazyParameter->lazyLoaded->embedded, $entity->embedded);
        $this->assertTrue($secondEntityWithLazyParameter->lazyLoaded->__isInitialized());
    }
}

/**
 * @Embeddable()
 */
class DDC6460Embeddable
{
    /** @Column(type="string") */
    public $field;
}

/**
 * @Entity()
 */
class DDC6460Entity
{
    /**
     * @Id
     * @GeneratedValue(strategy = "NONE")
     * @Column(type = "integer")
     */
    public $id;

    /** @Embedded(class = "DDC6460Embeddable") */
    public $embedded;
}

/**
 * @Entity()
 */
class DDC6460ParentEntity
{
    /**
     * @Id
     * @GeneratedValue(strategy = "NONE")
     * @Column(type = "integer")
     */
    public $id;

    /** @ManyToOne(targetEntity = "DDC6460Entity", fetch="EXTRA_LAZY", cascade={"persist"}) */
    public $lazyLoaded;
}


1			<?php
2
3			namespace Doctrine\Tests\ORM\Functional\Ticket;
4
5			use Doctrine\DBAL\Schema\SchemaException;
6			use Doctrine\ORM\Mapping\Column;
7			use Doctrine\ORM\Mapping\Embeddable;
8			use Doctrine\ORM\Mapping\Entity;
			0 ignored issues – show Bug introduced 2017-06-20 08:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Doctrine\Tests\ORM\Functional\Ticket\Entity`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
9			use Doctrine\ORM\Mapping\Id;
10			use Doctrine\ORM\Mapping\GeneratedValue;
11			use Doctrine\ORM\Mapping\ManyToOne;
12			use Doctrine\ORM\Proxy\Proxy;
13
14			class DDC6460Test extends \Doctrine\Tests\OrmFunctionalTestCase
15			{
16			public function setUp()
17			{
18			parent::setUp();
19
20			try {
21			$this->setUpEntitySchema(
22			[
23			DDC6460Entity::class,
24			DDC6460ParentEntity::class,
25			]
26			);
27			} catch (SchemaException $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-06-20 08:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider adding a comment why this CATCH block is empty. Loading history...
28			}
29			}
30
31			/**
32			* @group DDC-6460
33			*/
34			public function testInlineEmbeddable()
35			{
36			$isFieldMapped = $this->_em
37			->getClassMetadata(DDC6460Entity::class)
38			->hasField('embedded');
39
40			$this->assertTrue($isFieldMapped);
41			}
42
43			/**
44			* @group DDC-6460
45			*/
46			public function testInlineEmbeddableProxyInitialization()
47			{
48			$entity = new DDC6460Entity();
49			$entity->id = 1;
50			$entity->embedded = new DDC6460Embeddable();
51			$entity->embedded->field = 'test';
52			$this->_em->persist($entity);
53
54			$second = new DDC6460ParentEntity();
55			$second->id = 1;
56			$second->lazyLoaded = $entity;
57			$this->_em->persist($second);
58			$this->_em->flush();
59
60			$this->_em->clear();
61
62			$secondEntityWithLazyParameter = $this->_em->getRepository(DDC6460ParentEntity::class)->findOneById(1);
			0 ignored issues – show Documentation Bug introduced 2017-06-20 08:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `findOneById` does not exist on `object<Doctrine\ORM\EntityRepository>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
63
64			$this->assertInstanceOf(Proxy::class, $secondEntityWithLazyParameter->lazyLoaded);
65			$this->assertInstanceOf(DDC6460Entity::class, $secondEntityWithLazyParameter->lazyLoaded);
66			$this->assertFalse($secondEntityWithLazyParameter->lazyLoaded->__isInitialized());
67			$this->assertEquals($secondEntityWithLazyParameter->lazyLoaded->embedded, $entity->embedded);
68			$this->assertTrue($secondEntityWithLazyParameter->lazyLoaded->__isInitialized());
69			}
70			}
71
72			/**
73			* @Embeddable()
74			*/
75			class DDC6460Embeddable
76			{
77			/** @Column(type="string") */
78			public $field;
79			}
80
81			/**
82			* @Entity()
83			*/
84			class DDC6460Entity
85			{
86			/**
87			* @Id
88			* @GeneratedValue(strategy = "NONE")
89			* @Column(type = "integer")
90			*/
91			public $id;
92
93			/** @Embedded(class = "DDC6460Embeddable") */
94			public $embedded;
95			}
96
97			/**
98			* @Entity()
99			*/
100			class DDC6460ParentEntity
101			{
102			/**
103			* @Id
104			* @GeneratedValue(strategy = "NONE")
105			* @Column(type = "integer")
106			*/
107			public $id;
108
109			/** @ManyToOne(targetEntity = "DDC6460Entity", fetch="EXTRA_LAZY", cascade={"persist"}) */
110			public $lazyLoaded;
111			}
112

doctrine / orm

Push — master ( 2ade86...13f838 )

Tests/ORM/Functional/Ticket/DDC6460Test.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like