doctrine / orm

tests/Doctrine/Tests/ORM/Functional/Ticket/DDC618Test.php

Doc Comments +6 added lines

@@ -155,6 +155,9 @@ 
         $this->books = new \Doctrine\Common\Collections\ArrayCollection;
     }
 
+    /**
+     * @param string $title
+     */
     public function addBook($title)
     {
         $book = new DDC618Book($title, $this);
@@ -179,6 +182,9 @@ 
     /** @ORM\ManyToOne(targetEntity="DDC618Author", inversedBy="books") */
     public $author;
 
+    /**
+     * @param DDC618Author $author
+     */
     function __construct($title, $author)
     {
         $this->title = $title;

Indentation +4 added lines, -4 removed lines

@@ -75,7 +75,7 @@ 
     public function testIndexByJoin()
     {
         $dql = 'SELECT A, B FROM Doctrine\Tests\ORM\Functional\Ticket\DDC618Author A '.
-               'INNER JOIN A.books B INDEX BY B.title ORDER BY A.name ASC';
+                'INNER JOIN A.books B INDEX BY B.title ORDER BY A.name ASC';
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_OBJECT);
 
         self::assertCount(3, $result[0]->books); // Alice, Joe doesn't appear because he has no books.
@@ -99,14 +99,14 @@ 
     public function testIndexByToOneJoinSilentlyIgnored()
     {
         $dql = 'SELECT B, A FROM Doctrine\Tests\ORM\Functional\Ticket\DDC618Book B '.
-               'INNER JOIN B.author A INDEX BY A.name ORDER BY A.name ASC';
+                'INNER JOIN B.author A INDEX BY A.name ORDER BY A.name ASC';
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_OBJECT);
 
         self::assertInstanceOf(DDC618Book::class, $result[0]);
         self::assertInstanceOf(DDC618Author::class, $result[0]->author);
 
         $dql = 'SELECT B, A FROM Doctrine\Tests\ORM\Functional\Ticket\DDC618Book B '.
-               'INNER JOIN B.author A INDEX BY A.name ORDER BY A.name ASC';
+                'INNER JOIN B.author A INDEX BY A.name ORDER BY A.name ASC';
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_ARRAY);
 
         self::assertEquals("Alice", $result[0]['author']['name']);
@@ -118,7 +118,7 @@ 
     public function testCombineIndexBy()
     {
         $dql = 'SELECT A, B FROM Doctrine\Tests\ORM\Functional\Ticket\DDC618Author A INDEX BY A.id '.
-               'INNER JOIN A.books B INDEX BY B.title ORDER BY A.name ASC';
+                'INNER JOIN A.books B INDEX BY B.title ORDER BY A.name ASC';
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_OBJECT);
 
         self::assertArrayHasKey(11, $result); // Alice

Spacing +11 added lines, -11 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Doctrine\Tests\ORM\Functional\Ticket;
 
@@ -40,7 +40,7 @@ 
 
             $this->em->flush();
             $this->em->clear();
-        } catch(\Exception $e) {
+        } catch (\Exception $e) {
 
         }
     }
@@ -80,17 +80,17 @@ 
 
         self::assertCount(3, $result[0]->books); // Alice, Joe doesn't appear because he has no books.
         self::assertEquals('Alice', $result[0]->name);
-        self::assertTrue( isset($result[0]->books["In Wonderland"] ), "Indexing by title should have books by title.");
-        self::assertTrue( isset($result[0]->books["Reloaded"] ), "Indexing by title should have books by title.");
-        self::assertTrue( isset($result[0]->books["Test"] ), "Indexing by title should have books by title.");
+        self::assertTrue(isset($result[0]->books["In Wonderland"]), "Indexing by title should have books by title.");
+        self::assertTrue(isset($result[0]->books["Reloaded"]), "Indexing by title should have books by title.");
+        self::assertTrue(isset($result[0]->books["Test"]), "Indexing by title should have books by title.");
 
         $result = $this->em->createQuery($dql)->getResult(\Doctrine\ORM\Query::HYDRATE_ARRAY);
 
         self::assertCount(3, $result[0]['books']); // Alice, Joe doesn't appear because he has no books.
         self::assertEquals('Alice', $result[0]['name']);
-        self::assertTrue( isset($result[0]['books']["In Wonderland"] ), "Indexing by title should have books by title.");
-        self::assertTrue( isset($result[0]['books']["Reloaded"] ), "Indexing by title should have books by title.");
-        self::assertTrue( isset($result[0]['books']["Test"] ), "Indexing by title should have books by title.");
+        self::assertTrue(isset($result[0]['books']["In Wonderland"]), "Indexing by title should have books by title.");
+        self::assertTrue(isset($result[0]['books']["Reloaded"]), "Indexing by title should have books by title.");
+        self::assertTrue(isset($result[0]['books']["Test"]), "Indexing by title should have books by title.");
     }
 
     /**
@@ -125,9 +125,9 @@ 
 
         self::assertCount(3, $result[11]->books); // Alice, Joe doesn't appear because he has no books.
         self::assertEquals('Alice', $result[11]->name);
-        self::assertTrue( isset($result[11]->books["In Wonderland"] ), "Indexing by title should have books by title.");
-        self::assertTrue( isset($result[11]->books["Reloaded"] ), "Indexing by title should have books by title.");
-        self::assertTrue( isset($result[11]->books["Test"] ), "Indexing by title should have books by title.");
+        self::assertTrue(isset($result[11]->books["In Wonderland"]), "Indexing by title should have books by title.");
+        self::assertTrue(isset($result[11]->books["Reloaded"]), "Indexing by title should have books by title.");
+        self::assertTrue(isset($result[11]->books["Test"]), "Indexing by title should have books by title.");
     }
 }
 

tests/Doctrine/Tests/ORM/Functional/Ticket/DDC832Test.php

Doc Comments +11 added lines

@@ -167,6 +167,9 @@ 
      */
     public $version;
 
+    /**
+     * @param string $word
+     */
     public function __construct($word)
     {
         $this->word = $word;
@@ -196,6 +199,9 @@ 
      */
     public $version;
 
+    /**
+     * @param string $name
+     */
     public function __construct($name)
     {
         $this->name = $name;
@@ -214,6 +220,11 @@ 
     /** @ORM\Column(type="integer") */
     public $rgt;
 
+    /**
+     * @param string $name
+     * @param integer $lft
+     * @param integer $rgt
+     */
     public function __construct($name, $lft, $rgt)
     {
         $this->name = $name;

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Doctrine\Tests\ORM\Functional\Ticket;
 
@@ -28,7 +28,7 @@ 
                     $this->em->getClassMetadata(DDC832Like::class),
                 ]
             );
-        } catch(\Exception $e) {
+        } catch (\Exception $e) {
         }
     }
 

tests/Doctrine/Tests/ORM/Functional/ValueObjectsTest.php

Doc Comments +11 added lines

@@ -353,6 +353,9 @@ 
     /** @ORM\Embedded(class = "DDC93Timestamps") */
     public $timestamps;
 
+    /**
+     * @param string $name
+     */
     public function __construct($name = null, DDC93Address $address = null)
     {
         $this->name = $name;
@@ -415,6 +418,9 @@ 
      */
     public $name;
 
+    /**
+     * @param string $name
+     */
     public function __construct($name = null)
     {
         $this->name = $name;
@@ -441,6 +447,11 @@ 
     /** @ORM\Embedded(class = "DDC93Country") */
     public $country;
 
+    /**
+     * @param string $street
+     * @param string $zip
+     * @param string $city
+     */
     public function __construct($street = null, $zip = null, $city = null, DDC93Country $country = null)
     {
         $this->street = $street;

Spacing +16 added lines, -16 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Doctrine\Tests\ORM\Functional;
 
@@ -32,7 +32,7 @@ 
                 $this->em->getClassMetadata(DDC3027Dog::class),
                 ]
             );
-        } catch(\Exception $e) {
+        } catch (\Exception $e) {
         }
     }
 
@@ -87,7 +87,7 @@ 
         self::assertEquals('United States of America', $person->address->country->name);
 
         // 4. check deleting works
-        $personId = $person->id;;
+        $personId = $person->id; ;
         $this->em->remove($person);
         $this->em->flush();
 
@@ -111,7 +111,7 @@ 
         $this->em->flush();
         $this->em->clear();
 
-        $dql = "SELECT p FROM " . __NAMESPACE__ . "\DDC93Person p";
+        $dql = "SELECT p FROM ".__NAMESPACE__."\DDC93Person p";
         $persons = $this->em->createQuery($dql)->getResult();
 
         self::assertCount(3, $persons);
@@ -124,7 +124,7 @@ 
             self::assertEquals('United States of America', $person->address->country->name);
         }
 
-        $dql = "SELECT p FROM " . __NAMESPACE__ . "\DDC93Person p";
+        $dql = "SELECT p FROM ".__NAMESPACE__."\DDC93Person p";
         $persons = $this->em->createQuery($dql)->getArrayResult();
 
         foreach ($persons as $person) {
@@ -149,7 +149,7 @@ 
         $this->em->flush();
 
         // SELECT
-        $selectDql = "SELECT p FROM " . __NAMESPACE__ ."\\DDC93Person p WHERE p.address.city = :city AND p.address.country.name = :country";
+        $selectDql = "SELECT p FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.address.city = :city AND p.address.country.name = :country";
         $loadedPerson = $this->em->createQuery($selectDql)
             ->setParameter('city', 'Karlsruhe')
             ->setParameter('country', 'Germany')
@@ -164,7 +164,7 @@ 
         );
 
         // UPDATE
-        $updateDql = "UPDATE " . __NAMESPACE__ . "\\DDC93Person p SET p.address.street = :street, p.address.country.name = :country WHERE p.address.city = :city";
+        $updateDql = "UPDATE ".__NAMESPACE__."\\DDC93Person p SET p.address.street = :street, p.address.country.name = :country WHERE p.address.city = :city";
         $this->em->createQuery($updateDql)
             ->setParameter('street', 'Boo')
             ->setParameter('country', 'DE')
@@ -176,7 +176,7 @@ 
         self::assertEquals('DE', $person->address->country->name);
 
         // DELETE
-        $this->em->createQuery("DELETE " . __NAMESPACE__ . "\\DDC93Person p WHERE p.address.city = :city AND p.address.country.name = :country")
+        $this->em->createQuery("DELETE ".__NAMESPACE__."\\DDC93Person p WHERE p.address.city = :city AND p.address.country.name = :country")
             ->setParameter('city', 'Karlsruhe')
             ->setParameter('country', 'DE')
             ->execute();
@@ -193,7 +193,7 @@ 
         $this->em->clear();
 
         // Prove that the entity was persisted correctly.
-        $dql = "SELECT p FROM " . __NAMESPACE__ ."\\DDC93Person p WHERE p.name = :name";
+        $dql = "SELECT p FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.name = :name";
 
         $person = $this->em->createQuery($dql)
             ->setParameter('name', 'Karl')
@@ -207,7 +207,7 @@ 
         // Clear the EM and prove that the embeddable can be the subject of a partial query.
         $this->em->clear();
 
-        $dql = "SELECT PARTIAL p.{id,address.city} FROM " . __NAMESPACE__ ."\\DDC93Person p WHERE p.name = :name";
+        $dql = "SELECT PARTIAL p.{id,address.city} FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.name = :name";
 
         $person = $this->em->createQuery($dql)
             ->setParameter('name', 'Karl')
@@ -223,7 +223,7 @@ 
         // Clear the EM and prove that the embeddable can be the subject of a partial query regardless of attributes positions.
         $this->em->clear();
 
-        $dql = "SELECT PARTIAL p.{address.city, id} FROM " . __NAMESPACE__ ."\\DDC93Person p WHERE p.name = :name";
+        $dql = "SELECT PARTIAL p.{address.city, id} FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.name = :name";
 
         $person = $this->em->createQuery($dql)
             ->setParameter('name', 'Karl')
@@ -242,7 +242,7 @@ 
         $this->expectException(QueryException::class);
         $this->expectExceptionMessage('no field or association named address.asdfasdf');
 
-        $this->em->createQuery("SELECT p FROM " . __NAMESPACE__ . "\\DDC93Person p WHERE p.address.asdfasdf IS NULL")
+        $this->em->createQuery("SELECT p FROM ".__NAMESPACE__."\\DDC93Person p WHERE p.address.asdfasdf IS NULL")
             ->execute();
     }
 
@@ -251,7 +251,7 @@ 
         $this->expectException(QueryException::class);
         $this->expectExceptionMessage("no mapped field named 'address.asdfasdf'");
 
-        $this->em->createQuery("SELECT PARTIAL p.{id,address.asdfasdf} FROM " . __NAMESPACE__ . "\\DDC93Person p")
+        $this->em->createQuery("SELECT PARTIAL p.{id,address.asdfasdf} FROM ".__NAMESPACE__."\\DDC93Person p")
             ->execute();
     }
 
@@ -313,15 +313,15 @@ 
         $this->expectException(MappingException::class);
         $this->expectExceptionMessage(
             sprintf(
-                'Infinite nesting detected for embedded property %s::nested. ' .
+                'Infinite nesting detected for embedded property %s::nested. '.
                 'You cannot embed an embeddable from the same type inside an embeddable.',
-                __NAMESPACE__ . '\\' . $declaredEmbeddableClassName
+                __NAMESPACE__.'\\'.$declaredEmbeddableClassName
             )
         );
 
         $this->schemaTool->createSchema(
             [
-            $this->em->getClassMetadata(__NAMESPACE__ . '\\' . $embeddableClassName),
+            $this->em->getClassMetadata(__NAMESPACE__.'\\'.$embeddableClassName),
             ]
         );
     }

tests/Doctrine/Tests/ORM/Performance/SecondLevelCacheTest.php

Doc Comments +12 added lines

@@ -127,6 +127,9 @@ 
         self::assertEquals(503, $this->countQuery($em));
     }
 
+    /**
+     * @param string $label
+     */
     private function queryEntity(EntityManagerInterface $em, $label)
     {
         $times        = 100;
@@ -158,6 +161,9 @@ 
         printf("\n%s\n", str_repeat('-', 50));
     }
 
+    /**
+     * @param string $label
+     */
     public function findEntityOneToMany(EntityManagerInterface $em, $label)
     {
         $times        = 50;
@@ -217,6 +223,9 @@ 
         printf("\n%s\n", str_repeat('-', 50));
     }
 
+    /**
+     * @param string $label
+     */
     private function findEntity(EntityManagerInterface $em, $label)
     {
         $times        = 10;
@@ -252,6 +261,9 @@ 
         printf("\n%s\n", str_repeat('-', 50));
     }
 
+    /**
+     * @param string $label
+     */
     private function findAllEntity(EntityManagerInterface $em, $label)
     {
         $times        = 100;

Spacing +9 added lines, -9 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Doctrine\Tests\ORM\Performance;
 
@@ -133,7 +133,7 @@ 
         $size         = 500;
         $startPersist = microtime(true);
 
-        echo PHP_EOL . $label;
+        echo PHP_EOL.$label;
 
         for ($i = 0; $i < $size; $i++) {
             $em->persist(new Country("Country $i"));
@@ -167,7 +167,7 @@ 
         $startPersist = microtime(true);
         $country      = new Country("Country");
 
-        echo PHP_EOL . $label;
+        echo PHP_EOL.$label;
 
         $em->persist($country);
         $em->flush();
@@ -197,9 +197,9 @@ 
         $em->flush();
         $em->clear();
 
-        printf("\n[%s] persist %s states and %s cities", number_format( microtime(true) - $startPersist, 6), count($states), count($cities));
+        printf("\n[%s] persist %s states and %s cities", number_format(microtime(true) - $startPersist, 6), count($states), count($cities));
 
-        $startFind  = microtime(true);
+        $startFind = microtime(true);
 
         for ($i = 0; $i < $times; $i++) {
 
@@ -224,7 +224,7 @@ 
         $countries    = [];
         $startPersist = microtime(true);
 
-        echo PHP_EOL . $label;
+        echo PHP_EOL.$label;
 
         for ($i = 0; $i < $size; $i++) {
             $country = new Country("Country $i");
@@ -239,7 +239,7 @@ 
 
         printf("\n[%s] persist %s countries", number_format(microtime(true) - $startPersist, 6), $size);
 
-        $startFind  = microtime(true);
+        $startFind = microtime(true);
 
         for ($i = 0; $i <= $times; $i++) {
             foreach ($countries as $country) {
@@ -259,7 +259,7 @@ 
         $startPersist = microtime(true);
         $rep          = $em->getRepository(Country::class);
 
-        echo PHP_EOL . $label;
+        echo PHP_EOL.$label;
 
         for ($i = 0; $i < $size; $i++) {
             $em->persist(new Country("Country $i"));
@@ -270,7 +270,7 @@ 
 
         printf("\n[%s] persist %s countries", number_format(microtime(true) - $startPersist, 6), $size);
 
-        $startFind  = microtime(true);
+        $startFind = microtime(true);
 
         for ($i = 0; $i <= $times; $i++) {
             $list = $rep->findAll();

tests/Doctrine/Tests/ORM/Persisters/BasicEntityPersisterTypeValueSqlTest.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use Doctrine\ORM\Mapping\OneToOneAssociationMetadata;
 use Doctrine\ORM\Persisters\Entity\BasicEntityPersister;
 use Doctrine\Tests\Models\CustomType\CustomTypeChild;
-use Doctrine\Tests\Models\CustomType\CustomTypeFriend;
 use Doctrine\Tests\Models\CustomType\CustomTypeParent;
 use Doctrine\Tests\Models\Generic\NonAlphaColumnsEntity;
 use Doctrine\Tests\OrmTestCase;

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Doctrine\Tests\ORM\Persisters;
 
@@ -93,7 +93,7 @@ 
         $method = new \ReflectionMethod($this->persister, 'getSelectConditionSQL');
         $method->setAccessible(true);
 
-        $sql = $method->invoke($this->persister,  ['customInteger' => 1, 'child' => 1]);
+        $sql = $method->invoke($this->persister, ['customInteger' => 1, 'child' => 1]);
 
         self::assertEquals('t0."customInteger" = ABS(?) AND t0."child_id" = ?', $sql);
     }

tests/Doctrine/Tests/ORM/Query/CustomTreeWalkersJoinTest.php

Doc Comments +4 added lines

@@ -25,6 +25,10 @@
         $this->em = $this->getTestEntityManager();
     }
 
+    /**
+     * @param string $dqlToBeTested
+     * @param string $sqlToBeConfirmed
+     */
     public function assertSqlGeneration($dqlToBeTested, $sqlToBeConfirmed)
     {
         try {

Indentation +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
         try {
             $query = $this->em->createQuery($dqlToBeTested);
             $query->setHint(Query::HINT_CUSTOM_TREE_WALKERS, [CustomTreeWalkerJoin::class])
-                  ->useQueryCache(false);
+                    ->useQueryCache(false);
 
             $sqlGenerated = $query->getSql();
 

Spacing +5 added lines, -5 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Doctrine\Tests\ORM\Query;
 
@@ -36,7 +36,7 @@ 
 
             $query->free();
         } catch (\Exception $e) {
-            $this->fail($e->getMessage() . ' at "' . $e->getFile() . '" on line ' . $e->getLine());
+            $this->fail($e->getMessage().' at "'.$e->getFile().'" on line '.$e->getLine());
         }
 
         self::assertEquals($sqlToBeConfirmed, $sqlGenerated);
@@ -78,9 +78,9 @@ 
     {
         $rangeVariableDecl       = $identificationVariableDecl->rangeVariableDeclaration;
         $joinAssocPathExpression = new Query\AST\JoinAssociationPathExpression($rangeVariableDecl->aliasIdentificationVariable, 'address');
-        $joinAssocDeclaration    = new Query\AST\JoinAssociationDeclaration($joinAssocPathExpression, $rangeVariableDecl->aliasIdentificationVariable . 'a', null);
+        $joinAssocDeclaration    = new Query\AST\JoinAssociationDeclaration($joinAssocPathExpression, $rangeVariableDecl->aliasIdentificationVariable.'a', null);
         $join                    = new Query\AST\Join(Query\AST\Join::JOIN_TYPE_LEFT, $joinAssocDeclaration);
-        $selectExpression        = new Query\AST\SelectExpression($rangeVariableDecl->aliasIdentificationVariable . 'a', null, false);
+        $selectExpression        = new Query\AST\SelectExpression($rangeVariableDecl->aliasIdentificationVariable.'a', null, false);
 
         $identificationVariableDecl->joins[]                = $join;
         $selectStatement->selectClause->selectExpressions[] = $selectExpression;
@@ -89,7 +89,7 @@ 
         $userMetadata    = $entityManager->getClassMetadata(CmsUser::class);
         $addressMetadata = $entityManager->getClassMetadata(CmsAddress::class);
 
-        $this->setQueryComponent($rangeVariableDecl->aliasIdentificationVariable . 'a',
+        $this->setQueryComponent($rangeVariableDecl->aliasIdentificationVariable.'a',
             [
                 'metadata'     => $addressMetadata,
                 'parent'       => $rangeVariableDecl->aliasIdentificationVariable,

tests/Doctrine/Tests/ORM/QueryBuilderTest.php

Doc Comments +3 added lines

@@ -37,6 +37,9 @@
         $this->em = $this->getTestEntityManager();
     }
 
+    /**
+     * @param string $expectedDql
+     */
     protected function assertValidQueryBuilder(QueryBuilder $qb, $expectedDql)
     {
         $dql = $qb->getDQL();

Indentation +37 added lines, -37 removed lines

@@ -274,12 +274,12 @@ 
     {
         $qb = $this->em->createQueryBuilder();
         $qb->select('u')
-           ->from(CmsUser::class, 'u')
-           ->where('u.id = :uid')
-           ->orWhere('u.id = :uid2')
-           ->andWhere('u.id = :uid3')
-           ->orWhere('u.name = :name1', 'u.name = :name2')
-           ->andWhere('u.name <> :noname');
+            ->from(CmsUser::class, 'u')
+            ->where('u.id = :uid')
+            ->orWhere('u.id = :uid2')
+            ->andWhere('u.id = :uid3')
+            ->orWhere('u.name = :name1', 'u.name = :name2')
+            ->andWhere('u.name <> :noname');
 
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE (((u.id = :uid OR u.id = :uid2) AND u.id = :uid3) OR u.name = :name1 OR u.name = :name2) AND u.name <> :noname');
     }
@@ -288,9 +288,9 @@ 
     {
         $qb = $this->em->createQueryBuilder();
         $qb->select('u')
-           ->from(CmsUser::class, 'u')
-           ->where('u.id = :uid')
-           ->andWhere($qb->expr()->in('u.id', [1, 2, 3]));
+            ->from(CmsUser::class, 'u')
+            ->where('u.id = :uid')
+            ->andWhere($qb->expr()->in('u.id', [1, 2, 3]));
 
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid AND u.id IN(1, 2, 3)');
     }
@@ -299,9 +299,9 @@ 
     {
         $qb = $this->em->createQueryBuilder();
         $qb->select('u')
-           ->from(CmsUser::class, 'u')
-           ->where('u.id = :uid')
-           ->orWhere($qb->expr()->in('u.id', [1, 2, 3]));
+            ->from(CmsUser::class, 'u')
+            ->where('u.id = :uid')
+            ->orWhere($qb->expr()->in('u.id', [1, 2, 3]));
 
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid OR u.id IN(1, 2, 3)');
     }
@@ -310,9 +310,9 @@ 
     {
         $qb = $this->em->createQueryBuilder();
         $qb->select('u')
-           ->from(CmsUser::class, 'u')
-           ->where('u.id = :uid')
-           ->andWhere($qb->expr()->notIn('u.id', [1, 2, 3]));
+            ->from(CmsUser::class, 'u')
+            ->where('u.id = :uid')
+            ->andWhere($qb->expr()->notIn('u.id', [1, 2, 3]));
 
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid AND u.id NOT IN(1, 2, 3)');
     }
@@ -321,9 +321,9 @@ 
     {
         $qb = $this->em->createQueryBuilder();
         $qb->select('u')
-           ->from(CmsUser::class, 'u')
-           ->where('u.id = :uid')
-           ->orWhere($qb->expr()->notIn('u.id', [1, 2, 3]));
+            ->from(CmsUser::class, 'u')
+            ->where('u.id = :uid')
+            ->orWhere($qb->expr()->notIn('u.id', [1, 2, 3]));
 
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid OR u.id NOT IN(1, 2, 3)');
     }
@@ -619,8 +619,8 @@ 
     {
         $qb = $this->em->createQueryBuilder();
         $qb->select('u')
-           ->from(CmsUser::class, 'u')
-           ->where($qb->expr()->orX('u.username = :username', 'u.username = :username2'));
+            ->from(CmsUser::class, 'u')
+            ->where($qb->expr()->orX('u.username = :username', 'u.username = :username2'));
 
         $parameters = new ArrayCollection();
         $parameters->add(new Parameter('username', 'jwage'));
@@ -636,8 +636,8 @@ 
     {
         $qb = $this->em->createQueryBuilder();
         $qb->select('u')
-           ->from(CmsUser::class, 'u')
-           ->where('u.id = :id');
+            ->from(CmsUser::class, 'u')
+            ->where('u.id = :id');
 
         $parameters = new ArrayCollection();
         $parameters->add(new Parameter('id', 1));
@@ -686,8 +686,8 @@ 
     {
         $qb = $this->em->createQueryBuilder();
         $qb->select('u')
-           ->from(CmsUser::class, 'u')
-           ->orWhere('u.id = :uid', $qb->expr()->eq('u.id', ':uid2'));
+            ->from(CmsUser::class, 'u')
+            ->orWhere('u.id = :uid', $qb->expr()->eq('u.id', ':uid2'));
 
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid OR u.id = :uid2');
     }
@@ -700,8 +700,8 @@ 
         $orExpr->add($qb->expr()->in('u.id', [1]));
 
         $qb->select('u')
-           ->from(CmsUser::class, 'u')
-           ->where($orExpr);
+            ->from(CmsUser::class, 'u')
+            ->where($orExpr);
 
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid3 OR u.id IN(1)');
     }
@@ -710,8 +710,8 @@ 
     {
         $qb = $this->em->createQueryBuilder();
         $qb->select('u')
-           ->from(CmsUser::class, 'u')
-           ->where($qb->expr()->in('u.name', ['one', 'two', 'three']));
+            ->from(CmsUser::class, 'u')
+            ->where($qb->expr()->in('u.name', ['one', 'two', 'three']));
 
         self::assertValidQueryBuilder($qb, "SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.name IN('one', 'two', 'three')");
 
@@ -725,8 +725,8 @@ 
         $qb = $this->em->createQueryBuilder();
         $expr = $this->em->getExpressionBuilder();
         $qb->select('u')
-           ->from(CmsUser::class, 'u')
-           ->where($expr->in('u.name', [$expr->literal('one'), $expr->literal('two'), $expr->literal('three')]));
+            ->from(CmsUser::class, 'u')
+            ->where($expr->in('u.name', [$expr->literal('one'), $expr->literal('two'), $expr->literal('three')]));
 
         self::assertValidQueryBuilder($qb, "SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.name IN('one', 'two', 'three')");
 
@@ -744,8 +744,8 @@ 
 
         $qb = $this->em->createQueryBuilder();
         $qb->select('u')
-           ->from(CmsUser::class, 'u')
-           ->where($orExpr);
+            ->from(CmsUser::class, 'u')
+            ->where($orExpr);
 
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id = :uid3 OR NOT(u.id IN(1))');
     }
@@ -756,8 +756,8 @@ 
         $expr = $this->em->getExpressionBuilder();
 
         $qb->select('u')
-           ->from(CmsUser::class, 'u')
-           ->where($expr->gt('u.id', $expr->all('select a.id from Doctrine\Tests\Models\CMS\CmsArticle a')));
+            ->from(CmsUser::class, 'u')
+            ->where($expr->gt('u.id', $expr->all('select a.id from Doctrine\Tests\Models\CMS\CmsArticle a')));
 
         self::assertValidQueryBuilder($qb, 'SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u WHERE u.id > ALL(select a.id from Doctrine\Tests\Models\CMS\CmsArticle a)');
 
@@ -1123,9 +1123,9 @@ 
     public function testRebuildsFromParts()
     {
         $qb = $this->em->createQueryBuilder()
-          ->select('u')
-          ->from(CmsUser::class, 'u')
-          ->join('u.article', 'a');
+            ->select('u')
+            ->from(CmsUser::class, 'u')
+            ->join('u.article', 'a');
 
         $dqlParts = $qb->getDQLParts();
         $dql = $qb->getDQL();

Spacing +7 added lines, -7 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Doctrine\Tests\ORM;
 
@@ -549,7 +549,7 @@ 
         $qb = $this->em->createQueryBuilder();
         $qb->select('u')
             ->from(CmsUser::class, 'u')
-            ->join('u.article','a');
+            ->join('u.article', 'a');
 
         $criteria = new Criteria();
         $criteria->orderBy(['a.field' => Criteria::DESC]);
@@ -826,7 +826,7 @@ 
             ->from(CmsUser::class, 'u')
             ->where('u.username = ?1')->orderBy('u.username');
 
-        self::assertEquals('u.username = ?1', (string)$qb->getDQLPart('where'));
+        self::assertEquals('u.username = ?1', (string) $qb->getDQLPart('where'));
         self::assertCount(1, $qb->getDQLPart('orderBy'));
 
         $qb->resetDQLPart('where')->resetDQLPart('orderBy');
@@ -890,7 +890,7 @@ 
     {
         $qb = $this->em->createQueryBuilder();
         $qb->select('alias1')->from(CmsUser::class, 'alias1');
-        $qb->join('alias1.articles','alias2');
+        $qb->join('alias1.articles', 'alias2');
 
         $criteria = new Criteria();
         $criteria->where($criteria->expr()->eq('field', 'value1'));
@@ -910,7 +910,7 @@ 
     {
         $qb = $this->em->createQueryBuilder();
         $qb->select('alias1')->from(CmsUser::class, 'alias1');
-        $qb->join('alias1.articles','alias2');
+        $qb->join('alias1.articles', 'alias2');
 
         $criteria = new Criteria();
         $criteria->where($criteria->expr()->eq('alias1.field', 'value1'));
@@ -930,7 +930,7 @@ 
     {
         $qb = $this->em->createQueryBuilder();
         $qb->select('alias1')->from(CmsUser::class, 'alias1');
-        $qb->join('alias1.articles','alias2');
+        $qb->join('alias1.articles', 'alias2');
 
         $criteria = new Criteria();
         $criteria->where($criteria->expr()->eq('alias1.field', 'value1'));
@@ -1046,7 +1046,7 @@ 
     {
         $qb = $this->em->createQueryBuilder()
             ->add('select', 'u')
-            ->add('from', CmsUser::class . ' u');
+            ->add('from', CmsUser::class.' u');
 
         self::assertEquals('SELECT u FROM Doctrine\Tests\Models\CMS\CmsUser u', $qb->getDQL());
     }

tests/Doctrine/Tests/ORM/UnitOfWorkTest.php

Doc Comments +12 added lines

@@ -654,6 +654,9 @@ 
         return $this->items;
     }
 
+    /**
+     * @param string $value
+     */
     public function setTransient($value) {
         if ($value != $this->transient) {
             $this->onPropertyChanged('transient', $this->transient, $value);
@@ -665,6 +668,9 @@ 
         return $this->data;
     }
 
+    /**
+     * @param string $data
+     */
     public function setData($data) {
         if ($data != $this->data) {
             $this->onPropertyChanged('data', $this->data, $data);
@@ -677,6 +683,9 @@ 
         $this->listeners[] = $listener;
     }
 
+    /**
+     * @param string $propName
+     */
     protected function onPropertyChanged($propName, $oldValue, $newValue) {
         if ($this->listeners) {
             foreach ($this->listeners as $listener) {
@@ -707,6 +716,9 @@ 
         return $this->owner;
     }
 
+    /**
+     * @param NotifyChangedEntity|null $owner
+     */
     public function setOwner($owner) {
         $this->owner = $owner;
     }

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Doctrine\Tests\ORM;
 
@@ -450,7 +450,7 @@ 
             'empty string, single field'     => [$emptyString, ''],
             'non-empty string, single field' => [$nonEmptyString, $nonEmptyString->id],
             'empty strings, two fields'      => [$emptyStrings, ' '],
-            'non-empty strings, two fields'  => [$nonEmptyStrings, $nonEmptyStrings->id1 . ' ' . $nonEmptyStrings->id2],
+            'non-empty strings, two fields'  => [$nonEmptyStrings, $nonEmptyStrings->id1.' '.$nonEmptyStrings->id2],
             'boolean true'                   => [$booleanTrue, '1'],
             'boolean false'                  => [$booleanFalse, ''],
         ];
@@ -481,7 +481,7 @@ 
 
     public function entitiesWithInvalidIdentifiersProvider()
     {
-        $firstNullString  = new EntityWithCompositeStringIdentifier();
+        $firstNullString = new EntityWithCompositeStringIdentifier();
 
         $firstNullString->id2 = uniqid('id2', true);
 

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use Doctrine\Common\NotifyPropertyChanged;
 use Doctrine\Common\PropertyChangedListener;
 use Doctrine\ORM\Annotation as ORM;
-use Doctrine\ORM\Events;
 use Doctrine\ORM\Mapping\ClassMetadata;
 use Doctrine\ORM\Mapping\ClassMetadataBuildingContext;
 use Doctrine\ORM\Mapping\ClassMetadataFactory;

tests/Doctrine/Tests/OrmTestCase.php

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
     protected $secondLevelCacheDriverImpl = null;
 
     /**
-     * @param array $paths
+     * @param string[] $paths
      *
      * @return \Doctrine\ORM\Mapping\Driver\AnnotationDriver
      */

Spacing +3 added lines, -3 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Doctrine\Tests;
 
@@ -67,7 +67,7 @@ 
     {
         $reader = new Annotations\CachedReader(new Annotations\AnnotationReader(), new ArrayCache());
 
-        Annotations\AnnotationRegistry::registerFile(__DIR__ . "/../../../lib/Doctrine/ORM/Annotation/DoctrineAnnotations.php");
+        Annotations\AnnotationRegistry::registerFile(__DIR__."/../../../lib/Doctrine/ORM/Annotation/DoctrineAnnotations.php");
 
         return new AnnotationDriver($reader, (array) $paths);
     }
@@ -106,7 +106,7 @@ 
         $config->setAutoGenerateProxyClasses(ProxyFactory::AUTOGENERATE_EVAL);
         $config->setMetadataDriverImpl(
             $config->newDefaultAnnotationDriver([
-                realpath(__DIR__ . '/Models/Cache')
+                realpath(__DIR__.'/Models/Cache')
             ])
         );