Test Failed
Pull Request — master (#6771)
by Yannick de
62:53
created

UnknownTicketTest   A

Complexity

Total Complexity 1

Size/Duplication

Total Lines 31
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 5

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 1
c 1
b 0
f 0
lcom 1
cbo 5
dl 0
loc 31
rs 10

1 Method

Rating   Name   Duplication   Size   Complexity  
B testCompleteOriginalData() 0 28 1
1
<?php
2
3
namespace Doctrine\Tests\ORM\Functional\Ticket;
4
5
use Doctrine\Tests\Models\Tweet\Tweet;
6
use Doctrine\Tests\Models\Tweet\User;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Doctrine\Tests\ORM\Functional\Ticket\User.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
7
8
class UnknownTicketTest extends \Doctrine\Tests\OrmFunctionalTestCase
9
{
10
    public function testCompleteOriginalData()
11
    {
12
        $this->useModelSet('tweet');
13
        parent::setUp();
0 ignored issues
show
Comprehensibility Bug introduced by
It seems like you call parent on a different method (setUp() instead of testCompleteOriginalData()). Are you sure this is correct? If so, you might want to change this to $this->setUp().

This check looks for a call to a parent method whose name is different than the method from which it is called.

Consider the following code:

class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}

The getFirstName() method in the Son calls the wrong method in the parent class.

Loading history...
14
15
        $tweet1 = new Tweet();
16
        $tweet1->content = 'foobar';
17
18
        $user = new User();
19
        $user->name = 'Marco';
20
        $user->addTweet($tweet1);
21
22
        $this->_em->persist($user);
23
        $this->_em->flush();
24
25
        // This should contain all fields now
26
        $originalData1 = $this->_em->getUnitOfWork()->getOriginalEntityData($user);
27
28
        // Change only one of the non-associating fields
29
        $user->name = 'Polo';
30
31
        $this->_em->flush();
32
33
        // This should still contain all fields
34
        $originalData2 = $this->_em->getUnitOfWork()->getOriginalEntityData($user);
35
36
        $this->assertSame(array_keys($originalData1), array_keys($originalData2));
37
    }
38
}
39