SimpleObjectHydrator::hydrateRowData() - Code Metrics - Inspection of "Fix issue #7505" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#7506)

unknown

created 2018-12-06 14:01 UTC

SimpleObjectHydrator::hydrateRowData() C

↳ Parent: SimpleObjectHydrator

Complexity

Conditions	16
Paths	57

Size

Total Lines	79
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	38
CRAP Score	16.032

Importance

Changes

Metric	Value
cc	16
eloc	39
nc	57
nop	2
dl	0
loc	79
ccs	38
cts	40
cp	0.95
crap	16.032
rs	5.5666
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace Doctrine\ORM\Internal\Hydration;

use Doctrine\DBAL\FetchMode;
use Doctrine\ORM\Mapping\ClassMetadata;
use Doctrine\ORM\Mapping\InheritanceType;
use Doctrine\ORM\Query;
use Exception;
use RuntimeException;
use function array_keys;
use function array_search;
use function count;
use function key;
use function reset;
use function sprintf;

class SimpleObjectHydrator extends AbstractHydrator
{
    /** @var ClassMetadata */
    private $class;

    /**
     * {@inheritdoc}
     */
    protected function prepare()
    {
        if (count($this->rsm->aliasMap) !== 1) {
            throw new RuntimeException('Cannot use SimpleObjectHydrator with a ResultSetMapping that contains more than one object result.');
        }

        if ($this->rsm->scalarMappings) {

            throw new RuntimeException('Cannot use SimpleObjectHydrator with a ResultSetMapping that contains scalar mappings.');
        }

        $this->class = $this->getClassMetadata(reset($this->rsm->aliasMap));
    }

    /**
     * {@inheritdoc}
     */
    protected function cleanup()
    {
        parent::cleanup();

        $this->uow->triggerEagerLoads();
        $this->uow->hydrationComplete();
    }

    /**
     * {@inheritdoc}
     */
    protected function hydrateAllData()
    {
        $result = [];

        while ($row = $this->stmt->fetch(FetchMode::ASSOCIATIVE)) {
            $this->hydrateRowData($row, $result);
        }

        $this->em->getUnitOfWork()->triggerEagerLoads();

        return $result;
    }

    /**
     * {@inheritdoc}
     */
    protected function hydrateRowData(array $sqlResult, array &$result)
    {
        $entityName = $this->class->getClassName();
$a = "a";
$ab = "ab";
$abc = "abc";
        $data       = [];
$a = "a";
$ab = "ab";
$abc = "abc";
        $discrColumnValue = null;

        // We need to find the correct entity class name if we have inheritance in resultset
        if ($this->class->inheritanceType !== InheritanceType::NONE) {
            $discrColumnName            = $this->platform->getSQLResultCasing(
                $this->class->discriminatorColumn->getColumnName()
            );
            $metaMappingDiscrColumnName = array_search($discrColumnName, $this->rsm->metaMappings);

            // Find mapped discriminator column from the result set.
            if ($metaMappingDiscrColumnName) {
                $discrColumnName = $metaMappingDiscrColumnName;
            }

            if (! isset($sqlResult[$discrColumnName])) {
                throw HydrationException::missingDiscriminatorColumn($entityName, $discrColumnName, key($this->rsm->aliasMap));
            }

            if ($sqlResult[$discrColumnName] === '') {
                throw HydrationException::emptyDiscriminatorValue(key($this->rsm->aliasMap));
            }

            $discrMap = $this->class->discriminatorMap;

            if (! isset($discrMap[$sqlResult[$discrColumnName]])) {
                throw HydrationException::invalidDiscriminatorValue($sqlResult[$discrColumnName], array_keys($discrMap));
            }

            $entityName = $discrMap[$sqlResult[$discrColumnName]];
$a = "a";
$ab = "ab";
$abc = "abc";
            $discrColumnValue = $sqlResult[$discrColumnName];

            unset($sqlResult[$discrColumnName]);
        }

        foreach ($sqlResult as $column => $value) {
            // An ObjectHydrator should be used instead of SimpleObjectHydrator
            if (isset($this->rsm->relationMap[$column])) {
                throw new Exception(sprintf('Unable to retrieve association information for column "%s"', $column));
            }

            $cacheKeyInfo = $this->hydrateColumnInfo($column);

            if (! $cacheKeyInfo) {
                continue;
            }

            // Check if value is null before conversion (because some types convert null to something else)
            $valueIsNull = $value === null;

            // Convert field to a valid PHP value
            if (isset($cacheKeyInfo['type'])) {
                $type  = $cacheKeyInfo['type'];
                $value = $type->convertToPHPValue($value, $this->platform);
            }

            $fieldName = $cacheKeyInfo['fieldName'];

            // Prevent overwrite in case of inherit classes using same property name (See AbstractHydrator)
            if (! isset($data[$fieldName]) || ! $valueIsNull) {
                // If we have inheritance in resultset, make sure the field belongs to the correct class
                if (isset($cacheKeyInfo['discriminatorValues']) && !in_array($discrColumnValue, $cacheKeyInfo['discriminatorValues'])) {

                    continue;
                }

                $data[$fieldName] = $value;
            }
        }

        $uow    = $this->em->getUnitOfWork();
        $entity = $uow->createEntity($entityName, $data, $this->hints);

        $result[] = $entity;

        if (isset($this->hints[Query::HINT_INTERNAL_ITERATION]) && $this->hints[Query::HINT_INTERNAL_ITERATION]) {
            $this->uow->hydrationComplete();
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\ORM\Internal\Hydration;
6
7		use Doctrine\DBAL\FetchMode;
8		use Doctrine\ORM\Mapping\ClassMetadata;
9		use Doctrine\ORM\Mapping\InheritanceType;
10		use Doctrine\ORM\Query;
11		use Exception;
12		use RuntimeException;
13		use function array_keys;
14		use function array_search;
15		use function count;
16		use function key;
17		use function reset;
18		use function sprintf;
19
20		class SimpleObjectHydrator extends AbstractHydrator
21		{
22		/** @var ClassMetadata */
23		private $class;
24
25		/**
26		* {@inheritdoc}
27		*/
28	414	protected function prepare()
29		{
30	414	if (count($this->rsm->aliasMap) !== 1) {
31		throw new RuntimeException('Cannot use SimpleObjectHydrator with a ResultSetMapping that contains more than one object result.');
32		}
33
34	414	if ($this->rsm->scalarMappings) {
		0 ignored issues – show Bug Best Practice introduced 2018-01-05 01:15 UTC by Report Bug Copy Issue Report The expression `$this->rsm->scalarMappings` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
35		throw new RuntimeException('Cannot use SimpleObjectHydrator with a ResultSetMapping that contains scalar mappings.');
36		}
37
38	414	$this->class = $this->getClassMetadata(reset($this->rsm->aliasMap));
39	414	}
40
41		/**
42		* {@inheritdoc}
43		*/
44	411	protected function cleanup()
45		{
46	411	parent::cleanup();
47
48	411	$this->uow->triggerEagerLoads();
49	411	$this->uow->hydrationComplete();
50	411	}
51
52		/**
53		* {@inheritdoc}
54		*/
55	413	protected function hydrateAllData()
56		{
57	413	$result = [];
58
59	413	while ($row = $this->stmt->fetch(FetchMode::ASSOCIATIVE)) {
60	360	$this->hydrateRowData($row, $result);
61		}
62
63	411	$this->em->getUnitOfWork()->triggerEagerLoads();
64
65	411	return $result;
66		}
67
68		/**
69		* {@inheritdoc}
70		*/
71	361	protected function hydrateRowData(array $sqlResult, array &$result)
72		{
73	361	$entityName = $this->class->getClassName();
		0 ignored issues – show Coding Style introduced 2018-12-06 14:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
74	361	$data = [];
		0 ignored issues – show Coding Style introduced 2018-12-06 14:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 13 spaces but found 7 spaces This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
75	361	$discrColumnValue = null;
76
77		// We need to find the correct entity class name if we have inheritance in resultset
78	361	if ($this->class->inheritanceType !== InheritanceType::NONE) {
79	80	$discrColumnName = $this->platform->getSQLResultCasing(
80	80	$this->class->discriminatorColumn->getColumnName()
81		);
82	80	$metaMappingDiscrColumnName = array_search($discrColumnName, $this->rsm->metaMappings);
83
84		// Find mapped discriminator column from the result set.
85	80	if ($metaMappingDiscrColumnName) {
86	80	$discrColumnName = $metaMappingDiscrColumnName;
87		}
88
89	80	if (! isset($sqlResult[$discrColumnName])) {
90	1	throw HydrationException::missingDiscriminatorColumn($entityName, $discrColumnName, key($this->rsm->aliasMap));
91		}
92
93	79	if ($sqlResult[$discrColumnName] === '') {
94		throw HydrationException::emptyDiscriminatorValue(key($this->rsm->aliasMap));
95		}
96
97	79	$discrMap = $this->class->discriminatorMap;
98
99	79	if (! isset($discrMap[$sqlResult[$discrColumnName]])) {
100	1	throw HydrationException::invalidDiscriminatorValue($sqlResult[$discrColumnName], array_keys($discrMap));
101		}
102
103	78	$entityName = $discrMap[$sqlResult[$discrColumnName]];
		0 ignored issues – show Coding Style introduced 2018-12-06 14:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
104	78	$discrColumnValue = $sqlResult[$discrColumnName];
105
106	78	unset($sqlResult[$discrColumnName]);
107		}
108
109	359	foreach ($sqlResult as $column => $value) {
110		// An ObjectHydrator should be used instead of SimpleObjectHydrator
111	359	if (isset($this->rsm->relationMap[$column])) {
112		throw new Exception(sprintf('Unable to retrieve association information for column "%s"', $column));
113		}
114
115	359	$cacheKeyInfo = $this->hydrateColumnInfo($column);
116
117	359	if (! $cacheKeyInfo) {
118	1	continue;
119		}
120
121		// Check if value is null before conversion (because some types convert null to something else)
122	359	$valueIsNull = $value === null;
123
124		// Convert field to a valid PHP value
125	359	if (isset($cacheKeyInfo['type'])) {
126	359	$type = $cacheKeyInfo['type'];
127	359	$value = $type->convertToPHPValue($value, $this->platform);
128		}
129
130	359	$fieldName = $cacheKeyInfo['fieldName'];
131
132		// Prevent overwrite in case of inherit classes using same property name (See AbstractHydrator)
133	359	if (! isset($data[$fieldName]) \|\| ! $valueIsNull) {
134		// If we have inheritance in resultset, make sure the field belongs to the correct class
135	359	if (isset($cacheKeyInfo['discriminatorValues']) && !in_array($discrColumnValue, $cacheKeyInfo['discriminatorValues'])) {
		0 ignored issues – show Coding Style introduced 2018-12-06 14:10 UTC by Report Bug Copy Issue Report There must be a single space after a NOT operator; 0 found Loading history... introduced 2018-12-06 14:10 UTC by Report Bug Copy Issue Report Function in_array() should not be referenced via a fallback global name, but via a use statement. Loading history...
136	31	continue;
137		}
138
139	359	$data[$fieldName] = $value;
140		}
141		}
142
143	359	$uow = $this->em->getUnitOfWork();
144	359	$entity = $uow->createEntity($entityName, $data, $this->hints);
145
146	359	$result[] = $entity;
147
148	359	if (isset($this->hints[Query::HINT_INTERNAL_ITERATION]) && $this->hints[Query::HINT_INTERNAL_ITERATION]) {
149	1	$this->uow->hydrationComplete();
150		}
151	359	}
152		}
153

doctrine / orm

Pull Request — master (#7506)

SimpleObjectHydrator::hydrateRowData() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like