NewOperatorTest - Code Metrics - Inspection of "Allows use of nested new operators" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions
Pull Request — master (#6709)

by Sergey
created 2017-09-19 14:21 UTC
NewOperatorTest A

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	1146
Duplicated Lines	55.5 %
Coupling/Cohesion

Components	1
Dependencies	8
Importance

Changes
Metric	Value
wmc	28
lcom	1
cbo	8
dl	636
loc	1146
rs	9.2173
c	0
b	0
f	0
28 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	7	1
A	provideDataForHydrationMode()	0	7	1
A	loadFixtures()	0	60	1
A	testShouldAssumeFromEntityNamespaceWhenNotGiven()	0	23	1
A	testShouldSupportLiteralExpression()	0	49	1
B	testShouldSupportCaseExpression()	0	39	1
A	testShouldSupportSimpleArithmeticExpression()	0	59	1
A	testShouldSupportAggregateFunctions()	0	59	1
A	testShouldSupportArithmeticExpression()	0	59	1
A	testInvalidClassException()	0	5	1
A	testInvalidClassConstructorException()	0	5	1
A	testInvalidClassWithoutConstructorException()	0	5	1
A	testClassCantBeInstantiatedException()	0	5	1
B	testShouldSupportsBasicUsage()	39	39	1
B	testShouldIgnoreAliasesForSingleObject()	39	39	1
B	testShouldSupportFromEntityNamespaceAlias()	27	27	1
B	testShouldSupportValueObjectNamespaceAlias()	27	27	1
A	testShouldSupportMultipleNewOperators()	51	51	1
A	testShouldSupportMultipleNewOperatorsWithAliases()	51	51	1
A	testShouldSupportMultipleNewOperatorsWithAndWithoutAliases()	51	51	1
A	testShouldSupportMultipleNewOperatorsAndSingleScalar()	56	56	1
A	testShouldSupportMultipleNewOperatorsAndSingleScalarWithAliases()	56	56	1
A	testShouldSupportMultipleNewOperatorsAndSingleScalarWithAndWithoutAliases()	56	56	1
A	testShouldSupportMultipleNewOperatorsAndMultipleScalars()	61	61	1
A	testShouldSupportMultipleNewOperatorsAndMultipleScalarsWithAliases()	61	61	1
A	testShouldSupportMultipleNewOperatorsAndMultipleScalarsWithAndWithoutAliases()	61	61	1
A	testShouldSupportNestedNewOperators()	0	64	1
A	dumpResultSetMapping()	0	7	1
How to fix Duplicated Code

<?php

namespace Doctrine\Tests\ORM\Functional;

use Doctrine\ORM\Query;
use Doctrine\Tests\Models\CMS\CmsAddressDTO;
use Doctrine\Tests\Models\CMS\CmsUser;
use Doctrine\Tests\Models\CMS\CmsEmail;
use Doctrine\Tests\Models\CMS\CmsAddress;
use Doctrine\Tests\Models\CMS\CmsPhonenumber;
use Doctrine\Tests\Models\CMS\CmsUserDTO;
use Doctrine\Tests\OrmFunctionalTestCase;

/**
 * @group DDC-1574
 */
class NewOperatorTest extends OrmFunctionalTestCase
{
    /**
     * @var array
     */
    private $fixtures;

    protected function setUp()
    {
        $this->useModelSet('cms');
        parent::setUp();

        $this->loadFixtures();
    }

    public function provideDataForHydrationMode()
    {
        return [
            [Query::HYDRATE_ARRAY],
            [Query::HYDRATE_OBJECT],
        ];
    }

    private function loadFixtures()
    {
        $u1 = new CmsUser;
        $u2 = new CmsUser;
        $u3 = new CmsUser;

        $u1->setEmail(new CmsEmail());
        $u1->setAddress(new CmsAddress());
        $u1->addPhonenumber(new CmsPhonenumber());

        $u2->setEmail(new CmsEmail());
        $u2->setAddress(new CmsAddress());
        $u2->addPhonenumber(new CmsPhonenumber());
        $u2->addPhonenumber(new CmsPhonenumber());

        $u3->setEmail(new CmsEmail());
        $u3->setAddress(new CmsAddress());
        $u3->addPhonenumber(new CmsPhonenumber());
        $u3->addPhonenumber(new CmsPhonenumber());
        $u3->addPhonenumber(new CmsPhonenumber());

        $u1->name               = 'Test 1';
        $u1->username           = '1test';
        $u1->status             = 'developer';
        $u1->email->email       = '[email protected]';
        $u1->address->zip       = '111111111';
        $u1->address->city      = 'Some City 1';
        $u1->address->country   = 'Some Country 2';
        $u1->phonenumbers[0]->phonenumber = "(11) 1111-1111";

        $u2->name               = 'Test 2';
        $u2->username           = '2test';
        $u2->status             = 'developer';
        $u2->email->email       = '[email protected]';
        $u2->address->zip       = '222222222';
        $u2->address->city      = 'Some City 2';
        $u2->address->country   = 'Some Country 2';
        $u2->phonenumbers[0]->phonenumber = "(22) 1111-1111";
        $u2->phonenumbers[1]->phonenumber = "(22) 2222-2222";

        $u3->name               = 'Test 3';
        $u3->username           = '3test';
        $u3->status             = 'developer';
        $u3->email->email       = '[email protected]';
        $u3->address->zip       = '33333333';
        $u3->address->city      = 'Some City 3';
        $u3->address->country   = 'Some Country 3';
        $u3->phonenumbers[0]->phonenumber = "(33) 1111-1111";
        $u3->phonenumbers[1]->phonenumber = "(33) 2222-2222";
        $u3->phonenumbers[2]->phonenumber = "(33) 3333-3333";

        $this->_em->persist($u1);
        $this->_em->persist($u2);
        $this->_em->persist($u3);

        $this->_em->flush();
        $this->_em->clear();

        $this->fixtures = [$u1, $u2, $u3];
    }

    /**
     * @dataProvider provideDataForHydrationMode
     */
    public function testShouldSupportsBasicUsage($hydrationMode)
    {
        $dql = "
            SELECT
                new Doctrine\Tests\Models\CMS\CmsUserDTO(
                    u.name,
                    e.email,
                    a.city
                )
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult($hydrationMode);

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]);

        $this->assertEquals($this->fixtures[0]->name, $result[0]->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0]->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1]->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2]->email);

        $this->assertEquals($this->fixtures[0]->address->city, $result[0]->address);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1]->address);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2]->address);
    }

    /**
     * @dataProvider provideDataForHydrationMode
     */
    public function testShouldIgnoreAliasesForSingleObject($hydrationMode)
    {
        $dql = "
            SELECT
                new Doctrine\Tests\Models\CMS\CmsUserDTO(
                    u.name,
                    e.email,
                    a.city
                ) as cmsUser
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult($hydrationMode);

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]);

        $this->assertEquals($this->fixtures[0]->name, $result[0]->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0]->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1]->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2]->email);

        $this->assertEquals($this->fixtures[0]->address->city, $result[0]->address);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1]->address);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2]->address);
    }

    public function testShouldAssumeFromEntityNamespaceWhenNotGiven()
    {
        $dql = "
            SELECT
                new CmsUserDTO(u.name, e.email, a.city)
            FROM 
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]);
    }

    public function testShouldSupportFromEntityNamespaceAlias()
    {
        $dql = "
            SELECT
                new CmsUserDTO(u.name, e.email, a.city)
            FROM
                cms:CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";


        $this->_em->getConfiguration()
            ->addEntityNamespace('cms', 'Doctrine\Tests\Models\CMS');

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]);
    }

    public function testShouldSupportValueObjectNamespaceAlias()
    {
        $dql = "
            SELECT
                new cms:CmsUserDTO(u.name, e.email, a.city)
            FROM
                cms:CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";


        $this->_em->getConfiguration()
            ->addEntityNamespace('cms', 'Doctrine\Tests\Models\CMS');

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]);
    }

    public function testShouldSupportLiteralExpression()
    {
        $dql = "
            SELECT
                new Doctrine\Tests\Models\CMS\CmsUserDTO(
                    u.name,
                    '[email protected]',
                    FALSE,
                    123
                )
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            JOIN
                u.phonenumbers p
            GROUP BY
                u, e, a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]);


        $this->assertEquals($this->fixtures[0]->name, $result[0]->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]->name);

        $this->assertEquals('[email protected]', $result[0]->email);
        $this->assertEquals('[email protected]', $result[1]->email);
        $this->assertEquals('[email protected]', $result[2]->email);

        $this->assertEquals(false, $result[0]->address);
        $this->assertEquals(false, $result[1]->address);
        $this->assertEquals(false, $result[2]->address);

        $this->assertEquals(123, $result[0]->phonenumbers);
        $this->assertEquals(123, $result[1]->phonenumbers);
        $this->assertEquals(123, $result[2]->phonenumbers);
    }

    public function testShouldSupportCaseExpression()
    {
        $dql = "
            SELECT
                new Doctrine\Tests\Models\CMS\CmsUserDTO(
                    u.name,
                    CASE WHEN (e.email = '[email protected]') THEN 'TEST1' ELSE 'OTHER_TEST' END
                )
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            JOIN
                u.phonenumbers p
            GROUP BY
                u, e, a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]);


        $this->assertEquals($this->fixtures[0]->name, $result[0]->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]->name);

        $this->assertEquals('TEST1', $result[0]->email);
        $this->assertEquals('OTHER_TEST', $result[1]->email);
        $this->assertEquals('OTHER_TEST', $result[2]->email);
    }

    public function testShouldSupportSimpleArithmeticExpression()
    {
        $dql = "
            SELECT
                new Doctrine\Tests\Models\CMS\CmsUserDTO(
                    u.name,
                    e.email,
                    a.city,
                    a.id + u.id
                )
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            JOIN
                u.phonenumbers p
            GROUP BY
                u, e, a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]);

        $this->assertEquals($this->fixtures[0]->name, $result[0]->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0]->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1]->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2]->email);

        $this->assertEquals($this->fixtures[0]->address->city, $result[0]->address);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1]->address);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2]->address);

        $this->assertEquals(
            ($this->fixtures[0]->address->id + $this->fixtures[0]->id),
            $result[0]->phonenumbers
        );

        $this->assertEquals(
            ($this->fixtures[1]->address->id + $this->fixtures[1]->id),
            $result[1]->phonenumbers
        );

        $this->assertEquals(
            ($this->fixtures[2]->address->id + $this->fixtures[2]->id),
            $result[2]->phonenumbers
        );
    }

    public function testShouldSupportAggregateFunctions()
    {
        $dql = "
            SELECT
                new Doctrine\Tests\Models\CMS\CmsUserDTO(
                    u.name,
                    e.email,
                    a.city,
                    COUNT(p)
                )
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            JOIN
                u.phonenumbers p
            GROUP BY
                u, e, a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]);

        $this->assertEquals($this->fixtures[0]->name, $result[0]->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0]->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1]->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2]->email);

        $this->assertEquals($this->fixtures[0]->address->city, $result[0]->address);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1]->address);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2]->address);

        $this->assertEquals(
            (count($this->fixtures[0]->phonenumbers)),
            $result[0]->phonenumbers
        );

        $this->assertEquals(
            (count($this->fixtures[1]->phonenumbers)),
            $result[1]->phonenumbers
        );

        $this->assertEquals(
            (count($this->fixtures[2]->phonenumbers)),
            $result[2]->phonenumbers
        );
    }

    public function testShouldSupportArithmeticExpression()
    {
        $dql = "
            SELECT
                new Doctrine\Tests\Models\CMS\CmsUserDTO(
                    u.name,
                    e.email,
                    a.city,
                    COUNT(p) + u.id
                )
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            JOIN
                u.phonenumbers p
            GROUP BY
                u, e, a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]);

        $this->assertEquals($this->fixtures[0]->name, $result[0]->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0]->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1]->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2]->email);

        $this->assertEquals($this->fixtures[0]->address->city, $result[0]->address);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1]->address);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2]->address);

        $this->assertEquals(
            (count($this->fixtures[0]->phonenumbers) + $this->fixtures[0]->id),
            $result[0]->phonenumbers
        );

        $this->assertEquals(
            (count($this->fixtures[1]->phonenumbers) + $this->fixtures[1]->id),
            $result[1]->phonenumbers
        );

        $this->assertEquals(
            (count($this->fixtures[2]->phonenumbers) + $this->fixtures[2]->id),
            $result[2]->phonenumbers
        );
    }

    public function testShouldSupportMultipleNewOperators()
    {
        $dql = "
            SELECT
                new CmsUserDTO(
                    u.name,
                    e.email
                ),
                new CmsAddressDTO(
                    a.country,
                    a.city
                )
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0][0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1][0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2][0]);

        $this->assertInstanceOf(CmsAddressDTO::class, $result[0][1]);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[1][1]);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[2][1]);

        $this->assertEquals($this->fixtures[0]->name, $result[0][0]->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1][0]->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2][0]->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0][0]->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1][0]->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2][0]->email);


        $this->assertEquals($this->fixtures[0]->address->city, $result[0][1]->city);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1][1]->city);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2][1]->city);

        $this->assertEquals($this->fixtures[0]->address->country, $result[0][1]->country);
        $this->assertEquals($this->fixtures[1]->address->country, $result[1][1]->country);
        $this->assertEquals($this->fixtures[2]->address->country, $result[2][1]->country);
    }

    public function testShouldSupportMultipleNewOperatorsWithAliases()
    {
        $dql = "
            SELECT
                new CmsUserDTO(
                    u.name,
                    e.email
                ) as cmsUser,
                new CmsAddressDTO(
                    a.country,
                    a.city
                ) as cmsAddress
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]['cmsUser']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]['cmsUser']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]['cmsUser']);

        $this->assertInstanceOf(CmsAddressDTO::class, $result[0]['cmsAddress']);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[1]['cmsAddress']);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[2]['cmsAddress']);

        $this->assertEquals($this->fixtures[0]->name, $result[0]['cmsUser']->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]['cmsUser']->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]['cmsUser']->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0]['cmsUser']->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1]['cmsUser']->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2]['cmsUser']->email);


        $this->assertEquals($this->fixtures[0]->address->city, $result[0]['cmsAddress']->city);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1]['cmsAddress']->city);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2]['cmsAddress']->city);

        $this->assertEquals($this->fixtures[0]->address->country, $result[0]['cmsAddress']->country);
        $this->assertEquals($this->fixtures[1]->address->country, $result[1]['cmsAddress']->country);
        $this->assertEquals($this->fixtures[2]->address->country, $result[2]['cmsAddress']->country);
    }

    public function testShouldSupportMultipleNewOperatorsWithAndWithoutAliases()
    {
        $dql = "
            SELECT
                new CmsUserDTO(
                    u.name,
                    e.email
                ) as cmsUser,
                new CmsAddressDTO(
                    a.country,
                    a.city
                )
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]['cmsUser']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]['cmsUser']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]['cmsUser']);

        $this->assertInstanceOf(CmsAddressDTO::class, $result[0][0]);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[1][0]);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[2][0]);

        $this->assertEquals($this->fixtures[0]->name, $result[0]['cmsUser']->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]['cmsUser']->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]['cmsUser']->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0]['cmsUser']->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1]['cmsUser']->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2]['cmsUser']->email);


        $this->assertEquals($this->fixtures[0]->address->city, $result[0][0]->city);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1][0]->city);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2][0]->city);

        $this->assertEquals($this->fixtures[0]->address->country, $result[0][0]->country);
        $this->assertEquals($this->fixtures[1]->address->country, $result[1][0]->country);
        $this->assertEquals($this->fixtures[2]->address->country, $result[2][0]->country);
    }

    public function testShouldSupportMultipleNewOperatorsAndSingleScalar()
    {
        $dql = "
            SELECT
                new CmsUserDTO(
                    u.name,
                    e.email
                ),
                new CmsAddressDTO(
                    a.country,
                    a.city
                ),
                u.status
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0][0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1][0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2][0]);

        $this->assertInstanceOf(CmsAddressDTO::class, $result[0][1]);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[1][1]);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[2][1]);

        $this->assertEquals($this->fixtures[0]->name, $result[0][0]->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1][0]->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2][0]->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0][0]->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1][0]->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2][0]->email);


        $this->assertEquals($this->fixtures[0]->address->city, $result[0][1]->city);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1][1]->city);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2][1]->city);

        $this->assertEquals($this->fixtures[0]->address->country, $result[0][1]->country);
        $this->assertEquals($this->fixtures[1]->address->country, $result[1][1]->country);
        $this->assertEquals($this->fixtures[2]->address->country, $result[2][1]->country);

        $this->assertEquals($this->fixtures[0]->status,$result[0]['status']);
        $this->assertEquals($this->fixtures[1]->status,$result[1]['status']);
        $this->assertEquals($this->fixtures[2]->status,$result[2]['status']);
    }

    public function testShouldSupportMultipleNewOperatorsAndSingleScalarWithAliases()
    {
        $dql = "
            SELECT
                new CmsUserDTO(
                    u.name,
                    e.email
                ) as cmsUser,
                new CmsAddressDTO(
                    a.country,
                    a.city
                ) as cmsAddress,
                u.status as cmsUserStatus
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]['cmsUser']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]['cmsUser']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]['cmsUser']);

        $this->assertInstanceOf(CmsAddressDTO::class, $result[0]['cmsAddress']);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[1]['cmsAddress']);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[2]['cmsAddress']);

        $this->assertEquals($this->fixtures[0]->name, $result[0]['cmsUser']->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]['cmsUser']->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]['cmsUser']->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0]['cmsUser']->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1]['cmsUser']->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2]['cmsUser']->email);


        $this->assertEquals($this->fixtures[0]->address->city, $result[0]['cmsAddress']->city);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1]['cmsAddress']->city);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2]['cmsAddress']->city);

        $this->assertEquals($this->fixtures[0]->address->country, $result[0]['cmsAddress']->country);
        $this->assertEquals($this->fixtures[1]->address->country, $result[1]['cmsAddress']->country);
        $this->assertEquals($this->fixtures[2]->address->country, $result[2]['cmsAddress']->country);

        $this->assertEquals($this->fixtures[0]->status,$result[0]['cmsUserStatus']);
        $this->assertEquals($this->fixtures[1]->status,$result[1]['cmsUserStatus']);
        $this->assertEquals($this->fixtures[2]->status,$result[2]['cmsUserStatus']);
    }

    public function testShouldSupportMultipleNewOperatorsAndSingleScalarWithAndWithoutAliases()
    {
        $dql = "
            SELECT
                new CmsUserDTO(
                    u.name,
                    e.email
                ) as cmsUser,
                new CmsAddressDTO(
                    a.country,
                    a.city
                ),
                u.status
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]['cmsUser']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]['cmsUser']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]['cmsUser']);

        $this->assertInstanceOf(CmsAddressDTO::class, $result[0][0]);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[1][0]);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[2][0]);

        $this->assertEquals($this->fixtures[0]->name, $result[0]['cmsUser']->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]['cmsUser']->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]['cmsUser']->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0]['cmsUser']->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1]['cmsUser']->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2]['cmsUser']->email);


        $this->assertEquals($this->fixtures[0]->address->city, $result[0][0]->city);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1][0]->city);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2][0]->city);

        $this->assertEquals($this->fixtures[0]->address->country, $result[0][0]->country);
        $this->assertEquals($this->fixtures[1]->address->country, $result[1][0]->country);
        $this->assertEquals($this->fixtures[2]->address->country, $result[2][0]->country);

        $this->assertEquals($this->fixtures[0]->status,$result[0]['status']);
        $this->assertEquals($this->fixtures[1]->status,$result[1]['status']);
        $this->assertEquals($this->fixtures[2]->status,$result[2]['status']);
    }

    public function testShouldSupportMultipleNewOperatorsAndMultipleScalars()
    {
        $dql = "
            SELECT
                new CmsUserDTO(
                    u.name,
                    e.email
                ),
                new CmsAddressDTO(
                    a.country,
                    a.city
                ),
                u.status,
                u.username
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0][0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1][0]);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2][0]);

        $this->assertInstanceOf(CmsAddressDTO::class, $result[0][1]);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[1][1]);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[2][1]);

        $this->assertEquals($this->fixtures[0]->name, $result[0][0]->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1][0]->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2][0]->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0][0]->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1][0]->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2][0]->email);


        $this->assertEquals($this->fixtures[0]->address->city, $result[0][1]->city);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1][1]->city);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2][1]->city);

        $this->assertEquals($this->fixtures[0]->address->country, $result[0][1]->country);
        $this->assertEquals($this->fixtures[1]->address->country, $result[1][1]->country);
        $this->assertEquals($this->fixtures[2]->address->country, $result[2][1]->country);

        $this->assertEquals($this->fixtures[0]->status,$result[0]['status']);
        $this->assertEquals($this->fixtures[1]->status,$result[1]['status']);
        $this->assertEquals($this->fixtures[2]->status,$result[2]['status']);

        $this->assertEquals($this->fixtures[0]->username,$result[0]['username']);
        $this->assertEquals($this->fixtures[1]->username,$result[1]['username']);
        $this->assertEquals($this->fixtures[2]->username,$result[2]['username']);
    }

    public function testShouldSupportMultipleNewOperatorsAndMultipleScalarsWithAliases()
    {
        $dql = "
            SELECT
                new CmsUserDTO(
                    u.name,
                    e.email
                ) as cmsUser,
                new CmsAddressDTO(
                    a.country,
                    a.city
                ) as cmsAddress,
                u.status as cmsUserStatus,
                u.username as cmsUserUsername
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]['cmsUser']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]['cmsUser']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]['cmsUser']);

        $this->assertInstanceOf(CmsAddressDTO::class, $result[0]['cmsAddress']);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[1]['cmsAddress']);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[2]['cmsAddress']);

        $this->assertEquals($this->fixtures[0]->name, $result[0]['cmsUser']->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]['cmsUser']->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]['cmsUser']->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0]['cmsUser']->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1]['cmsUser']->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2]['cmsUser']->email);


        $this->assertEquals($this->fixtures[0]->address->city, $result[0]['cmsAddress']->city);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1]['cmsAddress']->city);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2]['cmsAddress']->city);

        $this->assertEquals($this->fixtures[0]->address->country, $result[0]['cmsAddress']->country);
        $this->assertEquals($this->fixtures[1]->address->country, $result[1]['cmsAddress']->country);
        $this->assertEquals($this->fixtures[2]->address->country, $result[2]['cmsAddress']->country);

        $this->assertEquals($this->fixtures[0]->status,$result[0]['cmsUserStatus']);
        $this->assertEquals($this->fixtures[1]->status,$result[1]['cmsUserStatus']);
        $this->assertEquals($this->fixtures[2]->status,$result[2]['cmsUserStatus']);

        $this->assertEquals($this->fixtures[0]->username,$result[0]['cmsUserUsername']);
        $this->assertEquals($this->fixtures[1]->username,$result[1]['cmsUserUsername']);
        $this->assertEquals($this->fixtures[2]->username,$result[2]['cmsUserUsername']);
    }

    public function testShouldSupportMultipleNewOperatorsAndMultipleScalarsWithAndWithoutAliases()
    {
        $dql = "
            SELECT
                new CmsUserDTO(
                    u.name,
                    e.email
                ) as cmsUser,
                new CmsAddressDTO(
                    a.country,
                    a.city
                ),
                u.status,
                u.username as cmsUserUsername
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]['cmsUser']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]['cmsUser']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]['cmsUser']);

        $this->assertInstanceOf(CmsAddressDTO::class, $result[0][0]);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[1][0]);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[2][0]);

        $this->assertEquals($this->fixtures[0]->name, $result[0]['cmsUser']->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]['cmsUser']->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]['cmsUser']->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0]['cmsUser']->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1]['cmsUser']->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2]['cmsUser']->email);


        $this->assertEquals($this->fixtures[0]->address->city, $result[0][0]->city);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1][0]->city);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2][0]->city);

        $this->assertEquals($this->fixtures[0]->address->country, $result[0][0]->country);
        $this->assertEquals($this->fixtures[1]->address->country, $result[1][0]->country);
        $this->assertEquals($this->fixtures[2]->address->country, $result[2][0]->country);

        $this->assertEquals($this->fixtures[0]->status,$result[0]['status']);
        $this->assertEquals($this->fixtures[1]->status,$result[1]['status']);
        $this->assertEquals($this->fixtures[2]->status,$result[2]['status']);

        $this->assertEquals($this->fixtures[0]->username,$result[0]['cmsUserUsername']);
        $this->assertEquals($this->fixtures[1]->username,$result[1]['cmsUserUsername']);
        $this->assertEquals($this->fixtures[2]->username,$result[2]['cmsUserUsername']);
    }

    /**
     * @expectedException Doctrine\ORM\Query\QueryException
     * @expectedExceptionMessage [Semantical Error] line 0, col 11 near '\InvalidClass(u.name)': Error: Class "\InvalidClass" is not defined.
     */
    public function testInvalidClassException()
    {
        $dql = "SELECT new \InvalidClass(u.name) FROM Doctrine\Tests\Models\CMS\CmsUser u";
        $this->_em->createQuery($dql)->getResult();
    }

    /**
     * @expectedException Doctrine\ORM\Query\QueryException
     * @expectedExceptionMessage [Semantical Error] line 0, col 11 near '\stdClass(u.name)': Error: Class "\stdClass" has not a valid constructor.
     */
    public function testInvalidClassConstructorException()
    {
        $dql = "SELECT new \stdClass(u.name) FROM Doctrine\Tests\Models\CMS\CmsUser u";
        $this->_em->createQuery($dql)->getResult();
    }

    /**
     * @expectedException Doctrine\ORM\Query\QueryException
     * @expectedExceptionMessage [Semantical Error] line 0, col 11 near 'Doctrine\Tests\ORM\Functional\ClassWithTooMuchArgs(u.name)': Error: Number of arguments does not match with "Doctrine\Tests\ORM\Functional\ClassWithTooMuchArgs" constructor declaration.
     */
    public function testInvalidClassWithoutConstructorException()
    {
        $dql = "SELECT new Doctrine\Tests\ORM\Functional\ClassWithTooMuchArgs(u.name) FROM Doctrine\Tests\Models\CMS\CmsUser u";
        $this->_em->createQuery($dql)->getResult();
    }

    /**
     * @expectedException Doctrine\ORM\Query\QueryException
     * @expectedExceptionMessage [Semantical Error] line 0, col 11 near 'Doctrine\Tests\ORM\Functional\ClassWithPrivateConstructor(u.name)': Error: Class "Doctrine\Tests\ORM\Functional\ClassWithPrivateConstructor" can not be instantiated.
     */
    public function testClassCantBeInstantiatedException()
    {
        $dql = "SELECT new Doctrine\Tests\ORM\Functional\ClassWithPrivateConstructor(u.name) FROM Doctrine\Tests\Models\CMS\CmsUser u";
        $this->_em->createQuery($dql)->getResult();
    }

    public function testShouldSupportNestedNewOperators()
    {
        $dql = "
            SELECT
                new CmsUserDTO(
                    u.name,
                    e.email,
                    new CmsAddressDTO(
                        a.country,
                        a.city,
                        new CmsAddressDTO(
                            a.country,
                            a.city
                        )
                    )
                ) as user,
                u.status,
                u.username as cmsUserUsername
            FROM
                Doctrine\Tests\Models\CMS\CmsUser u
            JOIN
                u.email e
            JOIN
                u.address a
            ORDER BY
                u.name";

        $query  = $this->_em->createQuery($dql);
        $result = $query->getResult();

        $this->assertCount(3, $result);

        $this->assertInstanceOf(CmsUserDTO::class, $result[0]['user']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[1]['user']);
        $this->assertInstanceOf(CmsUserDTO::class, $result[2]['user']);

        $this->assertInstanceOf(CmsAddressDTO::class, $result[0]['user']->address);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[1]['user']->address);
        $this->assertInstanceOf(CmsAddressDTO::class, $result[2]['user']->address);

        $this->assertEquals($this->fixtures[0]->name, $result[0]['user']->name);
        $this->assertEquals($this->fixtures[1]->name, $result[1]['user']->name);
        $this->assertEquals($this->fixtures[2]->name, $result[2]['user']->name);

        $this->assertEquals($this->fixtures[0]->email->email, $result[0]['user']->email);
        $this->assertEquals($this->fixtures[1]->email->email, $result[1]['user']->email);
        $this->assertEquals($this->fixtures[2]->email->email, $result[2]['user']->email);

        $this->assertEquals($this->fixtures[0]->address->city, $result[0]['user']->address->city);
        $this->assertEquals($this->fixtures[1]->address->city, $result[1]['user']->address->city);
        $this->assertEquals($this->fixtures[2]->address->city, $result[2]['user']->address->city);

        $this->assertEquals($this->fixtures[0]->address->country, $result[0]['user']->address->country);
        $this->assertEquals($this->fixtures[1]->address->country, $result[1]['user']->address->country);
        $this->assertEquals($this->fixtures[2]->address->country, $result[2]['user']->address->country);

        $this->assertEquals($this->fixtures[0]->status,$result[0]['status']);
        $this->assertEquals($this->fixtures[1]->status,$result[1]['status']);
        $this->assertEquals($this->fixtures[2]->status,$result[2]['status']);

        $this->assertEquals($this->fixtures[0]->username,$result[0]['cmsUserUsername']);
        $this->assertEquals($this->fixtures[1]->username,$result[1]['cmsUserUsername']);
        $this->assertEquals($this->fixtures[2]->username,$result[2]['cmsUserUsername']);
    }

    private function dumpResultSetMapping(Query $query)
    {
        $rsm = (\Closure::bind(function ($q) {
            return $q->getResultSetMapping();
        }, null, Query::class))($query);
        echo json_encode(get_object_vars($rsm), JSON_PRETTY_PRINT);
    }
}

class ClassWithTooMuchArgs
{
    public function __construct($foo, $bar)
    {
        $this->foo = $foo;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->bor = $bar;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}

class ClassWithPrivateConstructor
{
    private function __construct($foo)
    {
        $this->foo = $foo;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}

doctrine / orm

Pull Request — master (#6709)

NewOperatorTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

28 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like
