Between::__toString() - Code Metrics - Inspection of "Add BETWEEN() expr." - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#7184)

unknown

created 2018-04-10 09:50 UTC

Between::__toString() A

↳ Parent: Between

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0
ccs	2
cts	2
cp	1
crap	1

<?php

declare(strict_types=1);

namespace Doctrine\ORM\Query\Expr;

final class Between
{
    public const NOT_BETWEEN = 'NOT BETWEEN';

    public const BETWEEN = 'BETWEEN';

    /**

     * @var string
     */
    private $operator;

    /**

     * @var int|string
     */
    private $key;

    /**

     * @var int|string
     */
    private $min;

    /**

     * @var int|string
     */
    private $max;

    /**
     * @param string     $operator

     * @param int|string $key
     * @param int|string $min
     * @param int|string $max
     */
    public function __construct(string $operator, $key, $min, $max)
    {
        $this->operator = $operator;
        $this->key = $key;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->min = $min;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->max = $max;
$a = "a";
$ab = "ab";
$abc = "abc";
    }

    public function __toString() : string
    {
        return sprintf('%s %s %s AND %s', $this->key, $this->operator, $this->min, $this->max);

    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\ORM\Query\Expr;
6
7		final class Between
8		{
9		public const NOT_BETWEEN = 'NOT BETWEEN';
10
11		public const BETWEEN = 'BETWEEN';
12
13		/**
		0 ignored issues – show introduced 2018-04-10 10:06 UTC by Report Bug Copy Issue Report Found multi-line comment for property \Doctrine\ORM\Query\Expr\Between::$operator with single line content, use one-line comment instead. Loading history...
14		* @var string
15		*/
16		private $operator;
17
18		/**
		0 ignored issues – show introduced 2018-04-10 10:06 UTC by Report Bug Copy Issue Report Found multi-line comment for property \Doctrine\ORM\Query\Expr\Between::$key with single line content, use one-line comment instead. Loading history...
19		* @var int\|string
20		*/
21		private $key;
22
23		/**
		0 ignored issues – show introduced 2018-04-10 10:06 UTC by Report Bug Copy Issue Report Found multi-line comment for property \Doctrine\ORM\Query\Expr\Between::$min with single line content, use one-line comment instead. Loading history...
24		* @var int\|string
25		*/
26		private $min;
27
28		/**
		0 ignored issues – show introduced 2018-04-10 10:06 UTC by Report Bug Copy Issue Report Found multi-line comment for property \Doctrine\ORM\Query\Expr\Between::$max with single line content, use one-line comment instead. Loading history...
29		* @var int\|string
30		*/
31		private $max;
32
33		/**
34		* @param string $operator
		0 ignored issues – show introduced 2018-04-10 10:06 UTC by Report Bug Copy Issue Report Method \Doctrine\ORM\Query\Expr\Between::__construct() has useless @param annotation for parameter $operator. Loading history...
35		* @param int\|string $key
36		* @param int\|string $min
37		* @param int\|string $max
38		*/
39	2	public function __construct(string $operator, $key, $min, $max)
40		{
41	2	$this->operator = $operator;
42	2	$this->key = $key;
		0 ignored issues – show Coding Style introduced 2018-04-10 10:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
43	2	$this->min = $min;
		0 ignored issues – show Coding Style introduced 2018-04-10 10:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
44	2	$this->max = $max;
		0 ignored issues – show Coding Style introduced 2018-04-10 10:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
45	2	}
46
47	2	public function __toString() : string
48		{
49	2	return sprintf('%s %s %s AND %s', $this->key, $this->operator, $this->min, $this->max);
		0 ignored issues – show introduced 2018-04-10 10:06 UTC by Report Bug Copy Issue Report Function sprintf() should not be referenced via a fallback global name, but via a use statement. Loading history...
50		}
51		}
52

doctrine / orm

Pull Request — master (#7184)

Between::__toString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like