Failed Conditions
Pull Request — develop (#6947)
by Filippo
10:01
created
tests/Doctrine/Tests/ORM/Query/LanguageRecognitionTest.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Query;
6 6
 
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
             $this->addToAssertionCount(1);
31 31
         } catch (QueryException $e) {
32 32
             if ($debug) {
33
-                echo $e->getTraceAsString() . PHP_EOL;
33
+                echo $e->getTraceAsString().PHP_EOL;
34 34
             }
35 35
 
36 36
             $this->fail($e->getMessage());
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
45 45
             $this->fail('No syntax errors were detected, when syntax errors were expected');
46 46
         } catch (QueryException $e) {
47 47
             if ($debug) {
48
-                echo $e->getMessage() . PHP_EOL;
49
-                echo $e->getTraceAsString() . PHP_EOL;
48
+                echo $e->getMessage().PHP_EOL;
49
+                echo $e->getTraceAsString().PHP_EOL;
50 50
             }
51 51
             $this->addToAssertionCount(1);
52 52
         }
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
             ['SELECT foo: FROM Doctrine\Tests\Models\CMS\CmsUser foo:'],
116 116
 
117 117
             /* Checks for invalid AbstractSchemaName */
118
-            ['SELECT u FROM UnknownClass u'],  // unknown
118
+            ['SELECT u FROM UnknownClass u'], // unknown
119 119
             ['SELECT u FROM Unknown\Class u'], // unknown with namespace
120 120
             ['SELECT u FROM \Unknown\Class u'], // unknown, leading backslash
121 121
             ['SELECT u FROM Unknown\\\\Class u'], // unknown, syntactically bogus (duplicate \\)
@@ -588,7 +588,7 @@  discard block
 block discarded – undo
588 588
      */
589 589
     public function testDQLKeywordInJoinIsAllowed()
590 590
     {
591
-        self::assertValidDQL('SELECT u FROM ' . __NAMESPACE__ . '\DQLKeywordsModelUser u JOIN u.group g');
591
+        self::assertValidDQL('SELECT u FROM '.__NAMESPACE__.'\DQLKeywordsModelUser u JOIN u.group g');
592 592
     }
593 593
 
594 594
     /**
@@ -596,7 +596,7 @@  discard block
 block discarded – undo
596 596
      */
597 597
     public function testDQLKeywordInConditionIsAllowed()
598 598
     {
599
-        self::assertValidDQL('SELECT g FROM ' . __NAMESPACE__ . '\DQLKeywordsModelGroup g WHERE g.from=0');
599
+        self::assertValidDQL('SELECT g FROM '.__NAMESPACE__.'\DQLKeywordsModelGroup g WHERE g.from=0');
600 600
     }
601 601
 
602 602
     /* The exception is currently thrown in the SQLWalker, not earlier.
@@ -701,7 +701,7 @@  discard block
 block discarded – undo
701 701
      */
702 702
     public function testNewLiteralExpression()
703 703
     {
704
-        self::assertValidDQL("SELECT new " . __NAMESPACE__ . "\\DummyStruct(u.id, 'foo', 1, true) FROM Doctrine\Tests\Models\CMS\CmsUser u");
704
+        self::assertValidDQL("SELECT new ".__NAMESPACE__."\\DummyStruct(u.id, 'foo', 1, true) FROM Doctrine\Tests\Models\CMS\CmsUser u");
705 705
     }
706 706
 
707 707
     /**
@@ -709,7 +709,7 @@  discard block
 block discarded – undo
709 709
      */
710 710
     public function testNewLiteralWithSubselectExpression()
711 711
     {
712
-        self::assertValidDQL("SELECT new " . __NAMESPACE__ . "\\DummyStruct(u.id, 'foo', (SELECT 1 FROM Doctrine\Tests\Models\CMS\CmsUser su), true) FROM Doctrine\Tests\Models\CMS\CmsUser u");
712
+        self::assertValidDQL("SELECT new ".__NAMESPACE__."\\DummyStruct(u.id, 'foo', (SELECT 1 FROM Doctrine\Tests\Models\CMS\CmsUser su), true) FROM Doctrine\Tests\Models\CMS\CmsUser u");
713 713
     }
714 714
 }
715 715
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Query/CustomTreeWalkersTest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional;
6 6
 
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
         try {
46 46
             $sqlGenerated = $this->generateSql($dqlToBeTested, $treeWalkers, $outputWalker);
47 47
         } catch (\Exception $e) {
48
-            $this->fail($e->getMessage() . ' at "' . $e->getFile() . '" on line ' . $e->getLine());
48
+            $this->fail($e->getMessage().' at "'.$e->getFile().'" on line '.$e->getLine());
49 49
         }
50 50
 
51 51
         self::assertEquals($sqlToBeConfirmed, $sqlGenerated);
@@ -205,9 +205,9 @@  discard block
 block discarded – undo
205 205
     {
206 206
         $rangeVariableDecl       = $identificationVariableDecl->rangeVariableDeclaration;
207 207
         $joinAssocPathExpression = new Query\AST\JoinAssociationPathExpression($rangeVariableDecl->aliasIdentificationVariable, 'address');
208
-        $joinAssocDeclaration    = new Query\AST\JoinAssociationDeclaration($joinAssocPathExpression, $rangeVariableDecl->aliasIdentificationVariable . 'a', null);
208
+        $joinAssocDeclaration    = new Query\AST\JoinAssociationDeclaration($joinAssocPathExpression, $rangeVariableDecl->aliasIdentificationVariable.'a', null);
209 209
         $join                    = new Query\AST\Join(Query\AST\Join::JOIN_TYPE_LEFT, $joinAssocDeclaration);
210
-        $selectExpression        = new Query\AST\SelectExpression($rangeVariableDecl->aliasIdentificationVariable . 'a', null, false);
210
+        $selectExpression        = new Query\AST\SelectExpression($rangeVariableDecl->aliasIdentificationVariable.'a', null, false);
211 211
 
212 212
         $identificationVariableDecl->joins[]                = $join;
213 213
         $selectStatement->selectClause->selectExpressions[] = $selectExpression;
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
         $userMetadata    = $entityManager->getClassMetadata(CmsUser::class);
217 217
         $addressMetadata = $entityManager->getClassMetadata(CmsAddress::class);
218 218
 
219
-        $this->setQueryComponent($rangeVariableDecl->aliasIdentificationVariable . 'a',
219
+        $this->setQueryComponent($rangeVariableDecl->aliasIdentificationVariable.'a',
220 220
             [
221 221
                 'metadata'     => $addressMetadata,
222 222
                 'parent'       => $rangeVariableDecl->aliasIdentificationVariable,
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Query/FilterCollectionTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Query;
6 6
 
@@ -88,6 +88,6 @@  discard block
 block discarded – undo
88 88
     public function addFilterConstraint(ClassMetadata $targetEntity, $targetTableAlias)
89 89
     {
90 90
         // getParameter applies quoting automatically
91
-        return $targetTableAlias . '.id = ' . $this->getParameter('id');
91
+        return $targetTableAlias.'.id = '.$this->getParameter('id');
92 92
     }
93 93
 }
Please login to merge, or discard this patch.
Doctrine/Tests/ORM/Persisters/BasicEntityPersisterTypeValueSqlTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Persisters;
6 6
 
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
         $method = new \ReflectionMethod($this->persister, 'getSelectConditionSQL');
94 94
         $method->setAccessible(true);
95 95
 
96
-        $sql = $method->invoke($this->persister,  ['customInteger' => 1, 'child' => 1]);
96
+        $sql = $method->invoke($this->persister, ['customInteger' => 1, 'child' => 1]);
97 97
 
98 98
         self::assertEquals('t0."customInteger" = ABS(?) AND t0."child_id" = ?', $sql);
99 99
     }
Please login to merge, or discard this patch.
Doctrine/Tests/ORM/Persisters/BasicEntityPersisterCompositeTypeSqlTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Persisters;
6 6
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/SchemaTool/PostgreSqlSchemaToolTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional\SchemaTool;
6 6
 
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
         parent::setUp();
17 17
 
18 18
         if ($this->em->getConnection()->getDatabasePlatform()->getName() !== 'postgresql') {
19
-            $this->markTestSkipped('The ' . __CLASS__ .' requires the use of postgresql.');
19
+            $this->markTestSkipped('The '.__CLASS__.' requires the use of postgresql.');
20 20
         }
21 21
     }
22 22
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/SchemaTool/CompanySchemaTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional\SchemaTool;
6 6
 
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
      */
59 59
     public function testDropPartSchemaWithForeignKeys()
60 60
     {
61
-        if (!$this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
61
+        if ( ! $this->em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
62 62
             $this->markTestSkipped("Foreign Key test");
63 63
         }
64 64
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/SchemaTool/DBAL483Test.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional\SchemaTool;
6 6
 
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 
31 31
         $updateSql = $this->schemaTool->getUpdateSchemaSql([$class]);
32 32
 
33
-        $updateSql = array_filter($updateSql, function ($sql) {
33
+        $updateSql = array_filter($updateSql, function($sql) {
34 34
             return strpos($sql, 'DBAL483') !== false;
35 35
         });
36 36
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/NewOperatorTest.php 1 patch
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Doctrine\Tests\ORM\Functional;
6 6
 
@@ -744,9 +744,9 @@  discard block
 block discarded – undo
744 744
         self::assertEquals($this->fixtures[1]->address->country, $result[1][1]->country);
745 745
         self::assertEquals($this->fixtures[2]->address->country, $result[2][1]->country);
746 746
 
747
-        self::assertEquals($this->fixtures[0]->status,$result[0]['status']);
748
-        self::assertEquals($this->fixtures[1]->status,$result[1]['status']);
749
-        self::assertEquals($this->fixtures[2]->status,$result[2]['status']);
747
+        self::assertEquals($this->fixtures[0]->status, $result[0]['status']);
748
+        self::assertEquals($this->fixtures[1]->status, $result[1]['status']);
749
+        self::assertEquals($this->fixtures[2]->status, $result[2]['status']);
750 750
     }
751 751
 
752 752
     public function testShouldSupportMultipleNewOperatorsAndSingleScalarWithAliases()
@@ -801,9 +801,9 @@  discard block
 block discarded – undo
801 801
         self::assertEquals($this->fixtures[1]->address->country, $result[1]['cmsAddress']->country);
802 802
         self::assertEquals($this->fixtures[2]->address->country, $result[2]['cmsAddress']->country);
803 803
 
804
-        self::assertEquals($this->fixtures[0]->status,$result[0]['cmsUserStatus']);
805
-        self::assertEquals($this->fixtures[1]->status,$result[1]['cmsUserStatus']);
806
-        self::assertEquals($this->fixtures[2]->status,$result[2]['cmsUserStatus']);
804
+        self::assertEquals($this->fixtures[0]->status, $result[0]['cmsUserStatus']);
805
+        self::assertEquals($this->fixtures[1]->status, $result[1]['cmsUserStatus']);
806
+        self::assertEquals($this->fixtures[2]->status, $result[2]['cmsUserStatus']);
807 807
     }
808 808
 
809 809
     public function testShouldSupportMultipleNewOperatorsAndSingleScalarWithAndWithoutAliases()
@@ -858,9 +858,9 @@  discard block
 block discarded – undo
858 858
         self::assertEquals($this->fixtures[1]->address->country, $result[1][0]->country);
859 859
         self::assertEquals($this->fixtures[2]->address->country, $result[2][0]->country);
860 860
 
861
-        self::assertEquals($this->fixtures[0]->status,$result[0]['status']);
862
-        self::assertEquals($this->fixtures[1]->status,$result[1]['status']);
863
-        self::assertEquals($this->fixtures[2]->status,$result[2]['status']);
861
+        self::assertEquals($this->fixtures[0]->status, $result[0]['status']);
862
+        self::assertEquals($this->fixtures[1]->status, $result[1]['status']);
863
+        self::assertEquals($this->fixtures[2]->status, $result[2]['status']);
864 864
     }
865 865
 
866 866
     public function testShouldSupportMultipleNewOperatorsAndMultipleScalars()
@@ -916,13 +916,13 @@  discard block
 block discarded – undo
916 916
         self::assertEquals($this->fixtures[1]->address->country, $result[1][1]->country);
917 917
         self::assertEquals($this->fixtures[2]->address->country, $result[2][1]->country);
918 918
 
919
-        self::assertEquals($this->fixtures[0]->status,$result[0]['status']);
920
-        self::assertEquals($this->fixtures[1]->status,$result[1]['status']);
921
-        self::assertEquals($this->fixtures[2]->status,$result[2]['status']);
919
+        self::assertEquals($this->fixtures[0]->status, $result[0]['status']);
920
+        self::assertEquals($this->fixtures[1]->status, $result[1]['status']);
921
+        self::assertEquals($this->fixtures[2]->status, $result[2]['status']);
922 922
 
923
-        self::assertEquals($this->fixtures[0]->username,$result[0]['username']);
924
-        self::assertEquals($this->fixtures[1]->username,$result[1]['username']);
925
-        self::assertEquals($this->fixtures[2]->username,$result[2]['username']);
923
+        self::assertEquals($this->fixtures[0]->username, $result[0]['username']);
924
+        self::assertEquals($this->fixtures[1]->username, $result[1]['username']);
925
+        self::assertEquals($this->fixtures[2]->username, $result[2]['username']);
926 926
     }
927 927
 
928 928
     public function testShouldSupportMultipleNewOperatorsAndMultipleScalarsWithAliases()
@@ -978,13 +978,13 @@  discard block
 block discarded – undo
978 978
         self::assertEquals($this->fixtures[1]->address->country, $result[1]['cmsAddress']->country);
979 979
         self::assertEquals($this->fixtures[2]->address->country, $result[2]['cmsAddress']->country);
980 980
 
981
-        self::assertEquals($this->fixtures[0]->status,$result[0]['cmsUserStatus']);
982
-        self::assertEquals($this->fixtures[1]->status,$result[1]['cmsUserStatus']);
983
-        self::assertEquals($this->fixtures[2]->status,$result[2]['cmsUserStatus']);
981
+        self::assertEquals($this->fixtures[0]->status, $result[0]['cmsUserStatus']);
982
+        self::assertEquals($this->fixtures[1]->status, $result[1]['cmsUserStatus']);
983
+        self::assertEquals($this->fixtures[2]->status, $result[2]['cmsUserStatus']);
984 984
 
985
-        self::assertEquals($this->fixtures[0]->username,$result[0]['cmsUserUsername']);
986
-        self::assertEquals($this->fixtures[1]->username,$result[1]['cmsUserUsername']);
987
-        self::assertEquals($this->fixtures[2]->username,$result[2]['cmsUserUsername']);
985
+        self::assertEquals($this->fixtures[0]->username, $result[0]['cmsUserUsername']);
986
+        self::assertEquals($this->fixtures[1]->username, $result[1]['cmsUserUsername']);
987
+        self::assertEquals($this->fixtures[2]->username, $result[2]['cmsUserUsername']);
988 988
     }
989 989
 
990 990
     public function testShouldSupportMultipleNewOperatorsAndMultipleScalarsWithAndWithoutAliases()
@@ -1040,13 +1040,13 @@  discard block
 block discarded – undo
1040 1040
         self::assertEquals($this->fixtures[1]->address->country, $result[1][0]->country);
1041 1041
         self::assertEquals($this->fixtures[2]->address->country, $result[2][0]->country);
1042 1042
 
1043
-        self::assertEquals($this->fixtures[0]->status,$result[0]['status']);
1044
-        self::assertEquals($this->fixtures[1]->status,$result[1]['status']);
1045
-        self::assertEquals($this->fixtures[2]->status,$result[2]['status']);
1043
+        self::assertEquals($this->fixtures[0]->status, $result[0]['status']);
1044
+        self::assertEquals($this->fixtures[1]->status, $result[1]['status']);
1045
+        self::assertEquals($this->fixtures[2]->status, $result[2]['status']);
1046 1046
 
1047
-        self::assertEquals($this->fixtures[0]->username,$result[0]['cmsUserUsername']);
1048
-        self::assertEquals($this->fixtures[1]->username,$result[1]['cmsUserUsername']);
1049
-        self::assertEquals($this->fixtures[2]->username,$result[2]['cmsUserUsername']);
1047
+        self::assertEquals($this->fixtures[0]->username, $result[0]['cmsUserUsername']);
1048
+        self::assertEquals($this->fixtures[1]->username, $result[1]['cmsUserUsername']);
1049
+        self::assertEquals($this->fixtures[2]->username, $result[2]['cmsUserUsername']);
1050 1050
     }
1051 1051
 
1052 1052
     /**
Please login to merge, or discard this patch.