BigIntegerIdentityGenerator::generate() - Code Metrics - Inspection of "[CS] Require explicit visibility" - doctrine/orm - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — develop (#6947)

by Filippo

created 2018-01-02 07:51 UTC

BigIntegerIdentityGenerator::generate() A

↳ Parent: BigIntegerIdentityGenerator

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	2
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Doctrine\ORM\Sequencing;

use Doctrine\ORM\EntityManagerInterface;

/**
 * Id generator that obtains IDs from special "identity" columns. These are columns
 * that automatically get a database-generated, auto-incremented identifier on INSERT.
 * This generator obtains the last insert id after such an insert.
 */
class BigIntegerIdentityGenerator implements Generator
{
    /**
     * The name of the sequence to pass to lastInsertId(), if any.
     *
     * @var string
     */
    private $sequenceName;

    /**
     * Constructor.
     *
     * @param string|null $sequenceName The name of the sequence to pass to lastInsertId()
     *                                  to obtain the last generated identifier within the current
     *                                  database session/connection, if any.
     */
    public function __construct($sequenceName = null)
    {
        $this->sequenceName = $sequenceName;
    }

    /**
     * {@inheritdoc}
     */
    public function generate(EntityManagerInterface $em, $entity)
    {
        return (string) $em->getConnection()->lastInsertId($this->sequenceName);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    /**
     * {@inheritdoc}
     */
    public function isPostInsertGenerator()
    {
        return true;
    }
}



1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\ORM\Sequencing;
6
7		use Doctrine\ORM\EntityManagerInterface;
8
9		/**
10		* Id generator that obtains IDs from special "identity" columns. These are columns
11		* that automatically get a database-generated, auto-incremented identifier on INSERT.
12		* This generator obtains the last insert id after such an insert.
13		*/
14		class BigIntegerIdentityGenerator implements Generator
15		{
16		/**
17		* The name of the sequence to pass to lastInsertId(), if any.
18		*
19		* @var string
20		*/
21		private $sequenceName;
22
23		/**
24		* Constructor.
25		*
26		* @param string\|null $sequenceName The name of the sequence to pass to lastInsertId()
27		* to obtain the last generated identifier within the current
28		* database session/connection, if any.
29		*/
30	1	public function __construct($sequenceName = null)
31		{
32	1	$this->sequenceName = $sequenceName;
33	1	}
34
35		/**
36		* {@inheritdoc}
37		*/
38	3	public function generate(EntityManagerInterface $em, $entity)
39		{
40	3	return (string) $em->getConnection()->lastInsertId($this->sequenceName);
		0 ignored issues – show Bug Best Practice introduced 2017-12-10 07:24 UTC by Report Bug Copy Issue Report The expression `return (string)$em->getC...Id($this->sequenceName)` returns the type `string` which is incompatible with the return type mandated by `Doctrine\ORM\Sequencing\Generator::generate()` of `Generator`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
41		}
42
43		/**
44		* {@inheritdoc}
45		*/
46	3	public function isPostInsertGenerator()
47		{
48	3	return true;
49		}
50		}
51
52

doctrine / orm

Pull Request — develop (#6947)

BigIntegerIdentityGenerator::generate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like