Doctrine\ODM\MongoDB\Repository\AbstractRepositoryFactory

Complexity

Total Complexity

12

Size/Duplication

Total Lines	78
Duplicated Lines	11.54 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

90%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getRepository()	0	15	2
B	createRepository()	9	39	10
	instantiateRepository()	0	1	?

<?php

declare(strict_types=1);

namespace Doctrine\ODM\MongoDB\Repository;

use Doctrine\ODM\MongoDB\DocumentManager;
use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
use Doctrine\ODM\MongoDB\Mapping\MappingException;
use Doctrine\ODM\MongoDB\MongoDBException;
use Doctrine\Persistence\ObjectRepository;
use function is_a;
use function ltrim;
use function spl_object_hash;

/**
 * Abstract factory for creating document repositories.
 */
abstract class AbstractRepositoryFactory implements RepositoryFactory
{
    /**
     * The list of DocumentRepository instances.
     *
     * @var ObjectRepository[]
     */
    private $repositoryList = [];

    /**
     * {@inheritdoc}
     */
    public function getRepository(DocumentManager $documentManager, string $documentName) : ObjectRepository
    {
        $metadata = $documentManager->getClassMetadata($documentName);
        $hashKey  = $metadata->getName() . spl_object_hash($documentManager);

Consider using $metadata->name. There is an issue with getName() and APC-enabled PHP versions.

        if (isset($this->repositoryList[$hashKey])) {
            return $this->repositoryList[$hashKey];
        }

        $repository = $this->createRepository($documentManager, ltrim($documentName, '\\'));

        $this->repositoryList[$hashKey] = $repository;

        return $repository;
    }

    /**
     * Create a new repository instance for a document class.
     *
     * @return ObjectRepository|GridFSRepository|ViewRepository
     */
    protected function createRepository(DocumentManager $documentManager, string $documentName) : ObjectRepository
    {
        $metadata = $documentManager->getClassMetadata($documentName);

        $repositoryClassName = $metadata->isFile
            ? $documentManager->getConfiguration()->getDefaultGridFSRepositoryClassName()
            : $documentManager->getConfiguration()->getDefaultDocumentRepositoryClassName();

        if ($metadata->customRepositoryClassName) {

The expression $metadata->customRepositoryClassName of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $repositoryClassName = $metadata->customRepositoryClassName;
        }

        switch (true) {
            case $metadata->isFile:
                if (! is_a($repositoryClassName, GridFSRepository::class, true)) {

This code seems to be duplicated across your project.

                    throw MappingException::invalidRepositoryClass($documentName, $repositoryClassName, GridFSRepository::class);
                }
                break;

            case $metadata->isView():
                if (! is_a($repositoryClassName, ViewRepository::class, true)) {

This code seems to be duplicated across your project.

                    throw MappingException::invalidRepositoryClass($documentName, $repositoryClassName, ViewRepository::class);
                }
                break;

            case $metadata->isEmbeddedDocument:
                throw MongoDBException::cannotCreateRepository($documentName);
                break;

break; does not seem to be reachable.

            case $metadata->isMappedSuperclass:
            default:
                if (! is_a($repositoryClassName, DocumentRepository::class, true)) {

This code seems to be duplicated across your project.

                    throw MappingException::invalidRepositoryClass($documentName, $repositoryClassName, DocumentRepository::class);
                }
                break;
        }

        return $this->instantiateRepository($repositoryClassName, $documentManager, $metadata);
    }

    /**
     * Instantiates requested repository.
     */
    abstract protected function instantiateRepository(string $repositoryClassName, DocumentManager $documentManager, ClassMetadata $metadata) : ObjectRepository;
}