Issues in PreFlushEventArgs.php - New Issues - Inspection of "Merge branch '1.3.x'" - doctrine/mongodb-odm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 09b86b...ba0798 )

by Andreas

created 2019-04-15 11:30 UTC

Doctrine/ODM/MongoDB/Event/PreFlushEventArgs.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace Doctrine\ODM\MongoDB\Event;

use Doctrine\Common\Persistence\ObjectManager;
use const E_USER_DEPRECATED;
use function sprintf;
use function trigger_error;

/**
 * Provides event arguments for the preFlush event.
 *
 * @final
 */
class PreFlushEventArgs extends ManagerEventArgs

{
    public function __construct(ObjectManager $objectManager)
    {
        if (self::class !== static::class) {
            @trigger_error(sprintf('The class "%s" extends "%s" which will be final in MongoDB ODM 2.0.', static::class, self::class), E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
        parent::__construct($objectManager);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Doctrine\ODM\MongoDB\Event;
6
7			use Doctrine\Common\Persistence\ObjectManager;
8			use const E_USER_DEPRECATED;
9			use function sprintf;
10			use function trigger_error;
11
12			/**
13			* Provides event arguments for the preFlush event.
14			*
15			* @final
16			*/
17		View Code Duplication	class PreFlushEventArgs extends ManagerEventArgs
			0 ignored issues – show Duplication introduced 2019-04-15 11:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18			{
19	11		public function __construct(ObjectManager $objectManager)
20			{
21	11		if (self::class !== static::class) {
22			@trigger_error(sprintf('The class "%s" extends "%s" which will be final in MongoDB ODM 2.0.', static::class, self::class), E_USER_DEPRECATED);
			0 ignored issues – show Security Best Practice introduced 2019-04-15 11:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
23			}
24	11		parent::__construct($objectManager);
25	11		}
26			}
27

doctrine / mongodb-odm

Push — master ( 09b86b...ba0798 )

Doctrine/ODM/MongoDB/Event/PreFlushEventArgs.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like