DocumentNotFoundException::__construct() - Code Metrics - Inspection of "Merge branch '1.3.x'" - doctrine/mongodb-odm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 09b86b...ba0798 )

by Andreas

created 2019-04-15 11:30 UTC

DocumentNotFoundException::__construct() A

↳ Parent: DocumentNotFoundException

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2.032

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	4
cts	5
cp	0.8
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	3
crap	2.032

<?php

declare(strict_types=1);

namespace Doctrine\ODM\MongoDB;

use Throwable;
use const E_USER_DEPRECATED;
use function json_encode;
use function sprintf;
use function trigger_error;

/**
 * Class for exception when encountering proxy object that has
 * an identifier that does not exist in the database.
 *
 * @final
 */
class DocumentNotFoundException extends MongoDBException
{
    public function __construct($message = '', $code = 0, ?Throwable $previous = null)
    {
        if (self::class !== static::class) {
            @trigger_error(sprintf('The class "%s" extends "%s" which will be final in MongoDB ODM 2.0.', static::class, self::class), E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
        parent::__construct($message, $code, $previous);
    }

    public static function documentNotFound(string $className, $identifier) : self
    {
        return new self(sprintf(
            'The "%s" document with identifier %s could not be found.',
            $className,
            json_encode($identifier)
        ));
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\ODM\MongoDB;
6
7		use Throwable;
8		use const E_USER_DEPRECATED;
9		use function json_encode;
10		use function sprintf;
11		use function trigger_error;
12
13		/**
14		* Class for exception when encountering proxy object that has
15		* an identifier that does not exist in the database.
16		*
17		* @final
18		*/
19		class DocumentNotFoundException extends MongoDBException
20		{
21	8	public function __construct($message = '', $code = 0, ?Throwable $previous = null)
22		{
23	8	if (self::class !== static::class) {
24		@trigger_error(sprintf('The class "%s" extends "%s" which will be final in MongoDB ODM 2.0.', static::class, self::class), E_USER_DEPRECATED);
		0 ignored issues – show Security Best Practice introduced 2019-04-15 11:50 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
25		}
26	8	parent::__construct($message, $code, $previous);
27	8	}
28
29	8	public static function documentNotFound(string $className, $identifier) : self
30		{
31	8	return new self(sprintf(
32	8	'The "%s" document with identifier %s could not be found.',
33	8	$className,
34	8	json_encode($identifier)
35		));
36		}
37		}
38

doctrine / mongodb-odm

Push — master ( 09b86b...ba0798 )

DocumentNotFoundException::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like