Expr - Code Metrics - Inspection of "Expr::references should go through discriminator m..." - doctrine/mongodb-odm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1333)

by Maciej

created 2016-01-07 17:39 UTC

Expr A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	116
Duplicated Lines	18.97 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

91.8%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	22
c	1
b	0
f	0
lcom	1
cbo	6
dl	22
loc	116
ccs	56
cts	61
cp	0.918
rs	10

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	setClassMetadata()	0	4	1
B	includesReferenceTo()	11	26	6
A	getQuery()	0	6	1
A	getNewObj()	0	6	1
C	references()	11	42	12

How to fix Duplicated Code

<?php
/*
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the MIT license. For more information, see
 * <http://www.doctrine-project.org>.
 */

namespace Doctrine\ODM\MongoDB\Query;

use Doctrine\ODM\MongoDB\DocumentManager;
use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
use Doctrine\ODM\MongoDB\Mapping\MappingException;

/**
 * Query expression builder for ODM.
 *
 * @since       1.0
 * @author      Jonathan H. Wage <[email protected]>
 */
class Expr extends \Doctrine\MongoDB\Query\Expr
{
    /**
     * The DocumentManager instance for this query
     *
     * @var DocumentManager
     */
    private $dm;

    /**
     * The ClassMetadata instance for the document being queried
     *
     * @var ClassMetadata
     */
    private $class;

    public function __construct(DocumentManager $dm)
    {
        $this->dm = $dm;
    }

    public function setClassMetadata(ClassMetadata $class)
    {
        $this->class = $class;
    }

    /**
     * Checks that the value of the current field is a reference to the supplied document.
     */
    public function references($document)
    {
        if ($this->currentField) {
            try {
                $mapping = $this->class->getFieldMapping($this->currentField);
            } catch (MappingException $e) {
                if (empty($this->class->discriminatorMap)) {
                    throw $e;
                }
                foreach ($this->class->discriminatorMap as $child) {
                    $childClass = $this->dm->getClassMetadata($child);
                    if ($childClass->hasAssociation($this->currentField)) {
                        $mapping = $childClass->getFieldMapping($this->currentField);
                        break;
                    }
                }
                if ( ! isset($mapping) || $mapping === null) {
                    throw MappingException::mappingNotFoundInClassNorDescendants($this->class->name, $this->currentField);
                }
            }
            $dbRef = $this->dm->createDBRef($document, $mapping);

            if (isset($mapping['simple']) && $mapping['simple']) {
                $this->query[$mapping['name']] = $dbRef;
            } else {

                $keys = array('ref' => true, 'id' => true, 'db' => true);

                if (isset($mapping['targetDocument'])) {
                    unset($keys['ref'], $keys['db']);
                }

                foreach ($keys as $key => $value) {
                    $this->query[$this->currentField . '.$' . $key] = $dbRef['$' . $key];
                }
            }
        } else {
            $dbRef = $this->dm->createDBRef($document);
            $this->query = $dbRef;

        }

        return $this;
    }

    /**
     * Checks that the current field includes a reference to the supplied document.
     */
    public function includesReferenceTo($document)
    {
        if ($this->currentField) {
            $mapping = $this->class->getFieldMapping($this->currentField);
            $dbRef = $this->dm->createDBRef($document, $mapping);

            if (isset($mapping['simple']) && $mapping['simple']) {
                $this->query[$mapping['name']]['$elemMatch'] = $dbRef;
            } else {

                $keys = array('ref' => true, 'id' => true, 'db' => true);

                if (isset($mapping['targetDocument'])) {
                    unset($keys['ref'], $keys['db']);
                }

                foreach ($keys as $key => $value) {
                    $this->query[$this->currentField]['$elemMatch']['$' . $key] = $dbRef['$' . $key];
                }
            }
        } else {
            $dbRef = $this->dm->createDBRef($document);
            $this->query['$elemMatch'] = $dbRef;
        }

        return $this;
    }

    public function getQuery()
    {
        return $this->dm->getUnitOfWork()
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            ->getDocumentPersister($this->class->name)
            ->prepareQueryOrNewObj($this->query);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function getNewObj()
    {
        return $this->dm->getUnitOfWork()
            ->getDocumentPersister($this->class->name)
            ->prepareQueryOrNewObj($this->newObj);
    }
}


1			<?php
2			/*
3			* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
4			* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
5			* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
6			* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
7			* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
8			* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
9			* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
10			* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
11			* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
12			* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
13			* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
14			*
15			* This software consists of voluntary contributions made by many individuals
16			* and is licensed under the MIT license. For more information, see
17			* <http://www.doctrine-project.org>.
18			*/
19
20			namespace Doctrine\ODM\MongoDB\Query;
21
22			use Doctrine\ODM\MongoDB\DocumentManager;
23			use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
24			use Doctrine\ODM\MongoDB\Mapping\MappingException;
25
26			/**
27			* Query expression builder for ODM.
28			*
29			* @since 1.0
30			* @author Jonathan H. Wage <[email protected]>
31			*/
32			class Expr extends \Doctrine\MongoDB\Query\Expr
33			{
34			/**
35			* The DocumentManager instance for this query
36			*
37			* @var DocumentManager
38			*/
39			private $dm;
40
41			/**
42			* The ClassMetadata instance for the document being queried
43			*
44			* @var ClassMetadata
45			*/
46			private $class;
47
48	213		public function __construct(DocumentManager $dm)
49			{
50	213		$this->dm = $dm;
51	213		}
52
53	211		public function setClassMetadata(ClassMetadata $class)
54			{
55	211		$this->class = $class;
56	211		}
57
58			/**
59			* Checks that the value of the current field is a reference to the supplied document.
60			*/
61	9		public function references($document)
62			{
63	9		if ($this->currentField) {
64			try {
65	9		$mapping = $this->class->getFieldMapping($this->currentField);
66	9		} catch (MappingException $e) {
67	2		if (empty($this->class->discriminatorMap)) {
68			throw $e;
69			}
70	2		foreach ($this->class->discriminatorMap as $child) {
71	2		$childClass = $this->dm->getClassMetadata($child);
72	2		if ($childClass->hasAssociation($this->currentField)) {
73	1		$mapping = $childClass->getFieldMapping($this->currentField);
74	1		break;
75			}
76	2		}
77	2		if ( ! isset($mapping) \|\| $mapping === null) {
78	1		throw MappingException::mappingNotFoundInClassNorDescendants($this->class->name, $this->currentField);
79			}
80			}
81	8		$dbRef = $this->dm->createDBRef($document, $mapping);
82
83	8		if (isset($mapping['simple']) && $mapping['simple']) {
84	4		$this->query[$mapping['name']] = $dbRef;
85	4	View Code Duplication	} else {
			0 ignored issues – show Duplication introduced 2016-01-07 14:09 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86	6		$keys = array('ref' => true, 'id' => true, 'db' => true);
87
88	6		if (isset($mapping['targetDocument'])) {
89	4		unset($keys['ref'], $keys['db']);
90	4		}
91
92	6		foreach ($keys as $key => $value) {
93	6		$this->query[$this->currentField . '.$' . $key] = $dbRef['$' . $key];
94	6		}
95			}
96	8		} else {
97			$dbRef = $this->dm->createDBRef($document);
98			$this->query = $dbRef;
			0 ignored issues – show Documentation Bug introduced 2015-11-24 10:15 UTC by Report Bug Copy Issue Report It seems like `$dbRef` of type `array` is incompatible with the declared type `string` of property `$query`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
99			}
100
101	8		return $this;
102			}
103
104			/**
105			* Checks that the current field includes a reference to the supplied document.
106			*/
107	2		public function includesReferenceTo($document)
108			{
109	2		if ($this->currentField) {
110	2		$mapping = $this->class->getFieldMapping($this->currentField);
111	2		$dbRef = $this->dm->createDBRef($document, $mapping);
112
113	2		if (isset($mapping['simple']) && $mapping['simple']) {
114	1		$this->query[$mapping['name']]['$elemMatch'] = $dbRef;
115	1	View Code Duplication	} else {
			0 ignored issues – show Duplication introduced 2016-01-07 14:09 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
116	2		$keys = array('ref' => true, 'id' => true, 'db' => true);
117
118	2		if (isset($mapping['targetDocument'])) {
119	1		unset($keys['ref'], $keys['db']);
120	1		}
121
122	2		foreach ($keys as $key => $value) {
123	2		$this->query[$this->currentField]['$elemMatch']['$' . $key] = $dbRef['$' . $key];
124	2		}
125			}
126	2		} else {
127			$dbRef = $this->dm->createDBRef($document);
128			$this->query['$elemMatch'] = $dbRef;
129			}
130
131	2		return $this;
132			}
133
134	202		public function getQuery()
135			{
136	202		return $this->dm->getUnitOfWork()
			0 ignored issues – show Bug Best Practice introduced 2015-11-24 10:15 UTC by Report Bug Copy Issue Report The return type of `return $this->dm->getUni...OrNewObj($this->query);` (`array`) is incompatible with the return type of the parent method `Doctrine\MongoDB\Query\Expr::getQuery` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
137	202		->getDocumentPersister($this->class->name)
138	202		->prepareQueryOrNewObj($this->query);
			0 ignored issues – show Documentation introduced 2015-11-24 10:15 UTC by Report Bug Copy Issue Report `$this->query` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
139			}
140
141	185		public function getNewObj()
142			{
143	185		return $this->dm->getUnitOfWork()
144	185		->getDocumentPersister($this->class->name)
145	185		->prepareQueryOrNewObj($this->newObj);
146			}
147			}
148

doctrine / mongodb-odm

Pull Request — master (#1333)

Expr A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like