Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like DocumentPersister often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DocumentPersister, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 45 | class DocumentPersister |
||
| 46 | { |
||
| 47 | /** |
||
| 48 | * The PersistenceBuilder instance. |
||
| 49 | * |
||
| 50 | * @var PersistenceBuilder |
||
| 51 | */ |
||
| 52 | private $pb; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * The DocumentManager instance. |
||
| 56 | * |
||
| 57 | * @var DocumentManager |
||
| 58 | */ |
||
| 59 | private $dm; |
||
| 60 | |||
| 61 | /** |
||
| 62 | * The EventManager instance |
||
| 63 | * |
||
| 64 | * @var EventManager |
||
| 65 | */ |
||
| 66 | private $evm; |
||
| 67 | |||
| 68 | /** |
||
| 69 | * The UnitOfWork instance. |
||
| 70 | * |
||
| 71 | * @var UnitOfWork |
||
| 72 | */ |
||
| 73 | private $uow; |
||
| 74 | |||
| 75 | /** |
||
| 76 | * The ClassMetadata instance for the document type being persisted. |
||
| 77 | * |
||
| 78 | * @var ClassMetadata |
||
| 79 | */ |
||
| 80 | private $class; |
||
| 81 | |||
| 82 | /** |
||
| 83 | * The MongoCollection instance for this document. |
||
| 84 | * |
||
| 85 | * @var \MongoCollection |
||
| 86 | */ |
||
| 87 | private $collection; |
||
| 88 | |||
| 89 | /** |
||
| 90 | * Array of queued inserts for the persister to insert. |
||
| 91 | * |
||
| 92 | * @var array |
||
| 93 | */ |
||
| 94 | private $queuedInserts = array(); |
||
| 95 | |||
| 96 | /** |
||
| 97 | * Array of queued inserts for the persister to insert. |
||
| 98 | * |
||
| 99 | * @var array |
||
| 100 | */ |
||
| 101 | private $queuedUpserts = array(); |
||
| 102 | |||
| 103 | /** |
||
| 104 | * The CriteriaMerger instance. |
||
| 105 | * |
||
| 106 | * @var CriteriaMerger |
||
| 107 | */ |
||
| 108 | private $cm; |
||
| 109 | |||
| 110 | /** |
||
| 111 | * The CollectionPersister instance. |
||
| 112 | * |
||
| 113 | * @var CollectionPersister |
||
| 114 | */ |
||
| 115 | private $cp; |
||
| 116 | |||
| 117 | /** |
||
| 118 | * Initializes a new DocumentPersister instance. |
||
| 119 | * |
||
| 120 | * @param PersistenceBuilder $pb |
||
| 121 | * @param DocumentManager $dm |
||
| 122 | * @param EventManager $evm |
||
| 123 | * @param UnitOfWork $uow |
||
| 124 | * @param HydratorFactory $hydratorFactory |
||
| 125 | * @param ClassMetadata $class |
||
| 126 | */ |
||
| 127 | 673 | public function __construct(PersistenceBuilder $pb, DocumentManager $dm, EventManager $evm, UnitOfWork $uow, HydratorFactory $hydratorFactory, ClassMetadata $class, CriteriaMerger $cm = null) |
|
| 128 | { |
||
| 129 | 673 | $this->pb = $pb; |
|
| 130 | 673 | $this->dm = $dm; |
|
| 131 | 673 | $this->evm = $evm; |
|
| 132 | 673 | $this->cm = $cm ?: new CriteriaMerger(); |
|
| 133 | 673 | $this->uow = $uow; |
|
| 134 | 673 | $this->hydratorFactory = $hydratorFactory; |
|
|
|
|||
| 135 | 673 | $this->class = $class; |
|
| 136 | 673 | $this->collection = $dm->getDocumentCollection($class->name); |
|
| 137 | 673 | $this->cp = $this->uow->getCollectionPersister(); |
|
| 138 | 673 | } |
|
| 139 | |||
| 140 | /** |
||
| 141 | * @return array |
||
| 142 | */ |
||
| 143 | public function getInserts() |
||
| 147 | |||
| 148 | /** |
||
| 149 | * @param object $document |
||
| 150 | * @return bool |
||
| 151 | */ |
||
| 152 | public function isQueuedForInsert($document) |
||
| 156 | |||
| 157 | /** |
||
| 158 | * Adds a document to the queued insertions. |
||
| 159 | * The document remains queued until {@link executeInserts} is invoked. |
||
| 160 | * |
||
| 161 | * @param object $document The document to queue for insertion. |
||
| 162 | */ |
||
| 163 | 476 | public function addInsert($document) |
|
| 167 | |||
| 168 | /** |
||
| 169 | * @return array |
||
| 170 | */ |
||
| 171 | public function getUpserts() |
||
| 175 | |||
| 176 | /** |
||
| 177 | * @param object $document |
||
| 178 | * @return boolean |
||
| 179 | */ |
||
| 180 | public function isQueuedForUpsert($document) |
||
| 184 | |||
| 185 | /** |
||
| 186 | * Adds a document to the queued upserts. |
||
| 187 | * The document remains queued until {@link executeUpserts} is invoked. |
||
| 188 | * |
||
| 189 | * @param object $document The document to queue for insertion. |
||
| 190 | */ |
||
| 191 | 76 | public function addUpsert($document) |
|
| 195 | |||
| 196 | /** |
||
| 197 | * Gets the ClassMetadata instance of the document class this persister is used for. |
||
| 198 | * |
||
| 199 | * @return ClassMetadata |
||
| 200 | */ |
||
| 201 | public function getClassMetadata() |
||
| 205 | |||
| 206 | /** |
||
| 207 | * Executes all queued document insertions. |
||
| 208 | * |
||
| 209 | * Queued documents without an ID will inserted in a batch and queued |
||
| 210 | * documents with an ID will be upserted individually. |
||
| 211 | * |
||
| 212 | * If no inserts are queued, invoking this method is a NOOP. |
||
| 213 | * |
||
| 214 | * @param array $options Options for batchInsert() and update() driver methods |
||
| 215 | */ |
||
| 216 | 476 | public function executeInserts(array $options = array()) |
|
| 217 | { |
||
| 218 | 476 | if ( ! $this->queuedInserts) { |
|
| 219 | return; |
||
| 220 | } |
||
| 221 | |||
| 222 | 476 | $inserts = array(); |
|
| 223 | 476 | foreach ($this->queuedInserts as $oid => $document) { |
|
| 224 | 476 | $data = $this->pb->prepareInsertData($document); |
|
| 225 | |||
| 226 | // Set the initial version for each insert |
||
| 227 | 475 | View Code Duplication | if ($this->class->isVersioned) { |
| 228 | 38 | $versionMapping = $this->class->fieldMappings[$this->class->versionField]; |
|
| 229 | 38 | if ($versionMapping['type'] === 'int') { |
|
| 230 | 36 | $nextVersion = max(1, (int) $this->class->reflFields[$this->class->versionField]->getValue($document)); |
|
| 231 | 36 | $this->class->reflFields[$this->class->versionField]->setValue($document, $nextVersion); |
|
| 232 | 38 | } elseif ($versionMapping['type'] === 'date') { |
|
| 233 | 2 | $nextVersionDateTime = new \DateTime(); |
|
| 234 | 2 | $nextVersion = new \MongoDate($nextVersionDateTime->getTimestamp()); |
|
| 235 | 2 | $this->class->reflFields[$this->class->versionField]->setValue($document, $nextVersionDateTime); |
|
| 236 | 2 | } |
|
| 237 | 38 | $data[$versionMapping['name']] = $nextVersion; |
|
| 238 | 38 | } |
|
| 239 | |||
| 240 | 475 | $inserts[$oid] = $data; |
|
| 241 | 475 | } |
|
| 242 | |||
| 243 | 475 | if ($inserts) { |
|
| 244 | try { |
||
| 245 | 475 | $this->collection->batchInsert($inserts, $options); |
|
| 246 | 475 | } catch (\MongoException $e) { |
|
| 247 | 7 | $this->queuedInserts = array(); |
|
| 248 | 7 | throw $e; |
|
| 249 | } |
||
| 250 | 475 | } |
|
| 251 | |||
| 252 | /* All collections except for ones using addToSet have already been |
||
| 253 | * saved. We have left these to be handled separately to avoid checking |
||
| 254 | * collection for uniqueness on PHP side. |
||
| 255 | */ |
||
| 256 | 475 | foreach ($this->queuedInserts as $document) { |
|
| 257 | 475 | $this->handleCollections($document, $options); |
|
| 258 | 475 | } |
|
| 259 | |||
| 260 | 475 | $this->queuedInserts = array(); |
|
| 261 | 475 | } |
|
| 262 | |||
| 263 | /** |
||
| 264 | * Executes all queued document upserts. |
||
| 265 | * |
||
| 266 | * Queued documents with an ID are upserted individually. |
||
| 267 | * |
||
| 268 | * If no upserts are queued, invoking this method is a NOOP. |
||
| 269 | * |
||
| 270 | * @param array $options Options for batchInsert() and update() driver methods |
||
| 271 | */ |
||
| 272 | 76 | public function executeUpserts(array $options = array()) |
|
| 273 | { |
||
| 274 | 76 | if ( ! $this->queuedUpserts) { |
|
| 275 | return; |
||
| 276 | } |
||
| 277 | |||
| 278 | 76 | foreach ($this->queuedUpserts as $oid => $document) { |
|
| 279 | 76 | $data = $this->pb->prepareUpsertData($document); |
|
| 280 | |||
| 281 | // Set the initial version for each upsert |
||
| 282 | 76 | View Code Duplication | if ($this->class->isVersioned) { |
| 283 | 3 | $versionMapping = $this->class->fieldMappings[$this->class->versionField]; |
|
| 284 | 3 | if ($versionMapping['type'] === 'int') { |
|
| 285 | 2 | $nextVersion = max(1, (int) $this->class->reflFields[$this->class->versionField]->getValue($document)); |
|
| 286 | 2 | $this->class->reflFields[$this->class->versionField]->setValue($document, $nextVersion); |
|
| 287 | 3 | } elseif ($versionMapping['type'] === 'date') { |
|
| 288 | 1 | $nextVersionDateTime = new \DateTime(); |
|
| 289 | 1 | $nextVersion = new \MongoDate($nextVersionDateTime->getTimestamp()); |
|
| 290 | 1 | $this->class->reflFields[$this->class->versionField]->setValue($document, $nextVersionDateTime); |
|
| 291 | 1 | } |
|
| 292 | 3 | $data['$set'][$versionMapping['name']] = $nextVersion; |
|
| 293 | 3 | } |
|
| 294 | |||
| 295 | try { |
||
| 296 | 76 | $this->executeUpsert($data, $options); |
|
| 297 | 76 | $this->handleCollections($document, $options); |
|
| 298 | 76 | unset($this->queuedUpserts[$oid]); |
|
| 299 | 76 | } catch (\MongoException $e) { |
|
| 300 | unset($this->queuedUpserts[$oid]); |
||
| 301 | throw $e; |
||
| 302 | } |
||
| 303 | 76 | } |
|
| 304 | 76 | } |
|
| 305 | |||
| 306 | /** |
||
| 307 | * Executes a single upsert in {@link executeInserts} |
||
| 308 | * |
||
| 309 | * @param array $data |
||
| 310 | * @param array $options |
||
| 311 | */ |
||
| 312 | 76 | private function executeUpsert(array $data, array $options) |
|
| 352 | |||
| 353 | /** |
||
| 354 | * Updates the already persisted document if it has any new changesets. |
||
| 355 | * |
||
| 356 | * @param object $document |
||
| 357 | * @param array $options Array of options to be used with update() |
||
| 358 | * @throws \Doctrine\ODM\MongoDB\LockException |
||
| 359 | */ |
||
| 360 | 208 | public function update($document, array $options = array()) |
|
| 361 | { |
||
| 362 | 208 | $id = $this->uow->getDocumentIdentifier($document); |
|
| 363 | 208 | $update = $this->pb->prepareUpdateData($document); |
|
| 364 | |||
| 365 | 208 | $id = $this->class->getDatabaseIdentifierValue($id); |
|
| 366 | 208 | $query = array('_id' => $id); |
|
| 367 | |||
| 368 | // Include versioning logic to set the new version value in the database |
||
| 369 | // and to ensure the version has not changed since this document object instance |
||
| 370 | // was fetched from the database |
||
| 371 | 208 | if ($this->class->isVersioned) { |
|
| 372 | 30 | $versionMapping = $this->class->fieldMappings[$this->class->versionField]; |
|
| 373 | 30 | $currentVersion = $this->class->reflFields[$this->class->versionField]->getValue($document); |
|
| 374 | 30 | if ($versionMapping['type'] === 'int') { |
|
| 375 | 27 | $nextVersion = $currentVersion + 1; |
|
| 376 | 27 | $update['$inc'][$versionMapping['name']] = 1; |
|
| 377 | 27 | $query[$versionMapping['name']] = $currentVersion; |
|
| 378 | 27 | $this->class->reflFields[$this->class->versionField]->setValue($document, $nextVersion); |
|
| 379 | 30 | } elseif ($versionMapping['type'] === 'date') { |
|
| 380 | 3 | $nextVersion = new \DateTime(); |
|
| 381 | 3 | $update['$set'][$versionMapping['name']] = new \MongoDate($nextVersion->getTimestamp()); |
|
| 382 | 3 | $query[$versionMapping['name']] = new \MongoDate($currentVersion->getTimestamp()); |
|
| 383 | 3 | $this->class->reflFields[$this->class->versionField]->setValue($document, $nextVersion); |
|
| 384 | 3 | } |
|
| 385 | 30 | } |
|
| 386 | |||
| 387 | 208 | if ( ! empty($update)) { |
|
| 388 | // Include locking logic so that if the document object in memory is currently |
||
| 389 | // locked then it will remove it, otherwise it ensures the document is not locked. |
||
| 390 | 148 | if ($this->class->isLockable) { |
|
| 391 | 11 | $isLocked = $this->class->reflFields[$this->class->lockField]->getValue($document); |
|
| 392 | 11 | $lockMapping = $this->class->fieldMappings[$this->class->lockField]; |
|
| 393 | 11 | if ($isLocked) { |
|
| 394 | 2 | $update['$unset'] = array($lockMapping['name'] => true); |
|
| 395 | 2 | } else { |
|
| 396 | 9 | $query[$lockMapping['name']] = array('$exists' => false); |
|
| 397 | } |
||
| 398 | 11 | } |
|
| 399 | |||
| 400 | 148 | $result = $this->collection->update($query, $update, $options); |
|
| 401 | |||
| 402 | 148 | View Code Duplication | if (($this->class->isVersioned || $this->class->isLockable) && ! $result['n']) { |
| 403 | 5 | throw LockException::lockFailed($document); |
|
| 404 | } |
||
| 405 | 144 | } |
|
| 406 | |||
| 407 | 204 | $this->handleCollections($document, $options); |
|
| 408 | 204 | } |
|
| 409 | |||
| 410 | /** |
||
| 411 | * Removes document from mongo |
||
| 412 | * |
||
| 413 | * @param mixed $document |
||
| 414 | * @param array $options Array of options to be used with remove() |
||
| 415 | * @throws \Doctrine\ODM\MongoDB\LockException |
||
| 416 | */ |
||
| 417 | 28 | public function delete($document, array $options = array()) |
|
| 432 | |||
| 433 | /** |
||
| 434 | * Refreshes a managed document. |
||
| 435 | * |
||
| 436 | * @param array $id The identifier of the document. |
||
| 437 | * @param object $document The document to refresh. |
||
| 438 | */ |
||
| 439 | 20 | public function refresh($id, $document) |
|
| 445 | |||
| 446 | /** |
||
| 447 | * Finds a document by a set of criteria. |
||
| 448 | * |
||
| 449 | * If a scalar or MongoId is provided for $criteria, it will be used to |
||
| 450 | * match an _id value. |
||
| 451 | * |
||
| 452 | * @param mixed $criteria Query criteria |
||
| 453 | * @param object $document Document to load the data into. If not specified, a new document is created. |
||
| 454 | * @param array $hints Hints for document creation |
||
| 455 | * @param integer $lockMode |
||
| 456 | * @param array $sort Sort array for Cursor::sort() |
||
| 457 | * @throws \Doctrine\ODM\MongoDB\LockException |
||
| 458 | * @return object|null The loaded and managed document instance or null if no document was found |
||
| 459 | * @todo Check identity map? loadById method? Try to guess whether $criteria is the id? |
||
| 460 | */ |
||
| 461 | 348 | public function load($criteria, $document = null, array $hints = array(), $lockMode = 0, array $sort = null) |
|
| 489 | |||
| 490 | /** |
||
| 491 | * Finds documents by a set of criteria. |
||
| 492 | * |
||
| 493 | * @param array $criteria Query criteria |
||
| 494 | * @param array $sort Sort array for Cursor::sort() |
||
| 495 | * @param integer|null $limit Limit for Cursor::limit() |
||
| 496 | * @param integer|null $skip Skip for Cursor::skip() |
||
| 497 | * @return Cursor |
||
| 498 | */ |
||
| 499 | 22 | public function loadAll(array $criteria = array(), array $sort = null, $limit = null, $skip = null) |
|
| 522 | |||
| 523 | /** |
||
| 524 | * Wraps the supplied base cursor in the corresponding ODM class. |
||
| 525 | * |
||
| 526 | * @param CursorInterface $baseCursor |
||
| 527 | * @return Cursor |
||
| 528 | */ |
||
| 529 | 22 | private function wrapCursor(CursorInterface $baseCursor) |
|
| 533 | |||
| 534 | /** |
||
| 535 | * Checks whether the given managed document exists in the database. |
||
| 536 | * |
||
| 537 | * @param object $document |
||
| 538 | * @return boolean TRUE if the document exists in the database, FALSE otherwise. |
||
| 539 | */ |
||
| 540 | 3 | public function exists($document) |
|
| 545 | |||
| 546 | /** |
||
| 547 | * Locks document by storing the lock mode on the mapped lock field. |
||
| 548 | * |
||
| 549 | * @param object $document |
||
| 550 | * @param int $lockMode |
||
| 551 | */ |
||
| 552 | 5 | public function lock($document, $lockMode) |
|
| 560 | |||
| 561 | /** |
||
| 562 | * Releases any lock that exists on this document. |
||
| 563 | * |
||
| 564 | * @param object $document |
||
| 565 | */ |
||
| 566 | 1 | public function unlock($document) |
|
| 574 | |||
| 575 | /** |
||
| 576 | * Creates or fills a single document object from an query result. |
||
| 577 | * |
||
| 578 | * @param object $result The query result. |
||
| 579 | * @param object $document The document object to fill, if any. |
||
| 580 | * @param array $hints Hints for document creation. |
||
| 581 | * @return object The filled and managed document object or NULL, if the query result is empty. |
||
| 582 | */ |
||
| 583 | 347 | private function createDocument($result, $document = null, array $hints = array()) |
|
| 597 | |||
| 598 | /** |
||
| 599 | * Loads a PersistentCollection data. Used in the initialize() method. |
||
| 600 | * |
||
| 601 | * @param PersistentCollection $collection |
||
| 602 | */ |
||
| 603 | 157 | public function loadCollection(PersistentCollection $collection) |
|
| 624 | |||
| 625 | 111 | private function loadEmbedManyCollection(PersistentCollection $collection) |
|
| 652 | |||
| 653 | 49 | private function loadReferenceManyCollectionOwningSide(PersistentCollection $collection) |
|
| 725 | |||
| 726 | 14 | private function loadReferenceManyCollectionInverseSide(PersistentCollection $collection) |
|
| 734 | |||
| 735 | /** |
||
| 736 | * @param PersistentCollection $collection |
||
| 737 | * |
||
| 738 | * @return Query |
||
| 739 | */ |
||
| 740 | 16 | public function createReferenceManyInverseSideQuery(PersistentCollection $collection) |
|
| 776 | |||
| 777 | 3 | private function loadReferenceManyWithRepositoryMethod(PersistentCollection $collection) |
|
| 790 | |||
| 791 | /** |
||
| 792 | * @param PersistentCollection $collection |
||
| 793 | * |
||
| 794 | * @return CursorInterface |
||
| 795 | */ |
||
| 796 | 3 | public function createReferenceManyWithRepositoryMethodCursor(PersistentCollection $collection) |
|
| 825 | |||
| 826 | /** |
||
| 827 | * Prepare a sort or projection array by converting keys, which are PHP |
||
| 828 | * property names, to MongoDB field names. |
||
| 829 | * |
||
| 830 | * @param array $fields |
||
| 831 | * @return array |
||
| 832 | */ |
||
| 833 | 137 | public function prepareSortOrProjection(array $fields) |
|
| 843 | |||
| 844 | /** |
||
| 845 | * Prepare a mongodb field name and convert the PHP property names to MongoDB field names. |
||
| 846 | * |
||
| 847 | * @param string $fieldName |
||
| 848 | * @return string |
||
| 849 | */ |
||
| 850 | 85 | public function prepareFieldName($fieldName) |
|
| 856 | |||
| 857 | /** |
||
| 858 | * Adds discriminator criteria to an already-prepared query. |
||
| 859 | * |
||
| 860 | * This method should be used once for query criteria and not be used for |
||
| 861 | * nested expressions. It should be called before |
||
| 862 | * {@link DocumentPerister::addFilterToPreparedQuery()}. |
||
| 863 | * |
||
| 864 | * @param array $preparedQuery |
||
| 865 | * @return array |
||
| 866 | */ |
||
| 867 | 470 | public function addDiscriminatorToPreparedQuery(array $preparedQuery) |
|
| 883 | |||
| 884 | /** |
||
| 885 | * Adds filter criteria to an already-prepared query. |
||
| 886 | * |
||
| 887 | * This method should be used once for query criteria and not be used for |
||
| 888 | * nested expressions. It should be called after |
||
| 889 | * {@link DocumentPerister::addDiscriminatorToPreparedQuery()}. |
||
| 890 | * |
||
| 891 | * @param array $preparedQuery |
||
| 892 | * @return array |
||
| 893 | */ |
||
| 894 | 471 | public function addFilterToPreparedQuery(array $preparedQuery) |
|
| 908 | |||
| 909 | /** |
||
| 910 | * Prepares the query criteria or new document object. |
||
| 911 | * |
||
| 912 | * PHP field names and types will be converted to those used by MongoDB. |
||
| 913 | * |
||
| 914 | * @param array $query |
||
| 915 | * @return array |
||
| 916 | */ |
||
| 917 | 504 | public function prepareQueryOrNewObj(array $query) |
|
| 944 | |||
| 945 | /** |
||
| 946 | * Prepares a query value and converts the PHP value to the database value |
||
| 947 | * if it is an identifier. |
||
| 948 | * |
||
| 949 | * It also handles converting $fieldName to the database name if they are different. |
||
| 950 | * |
||
| 951 | * @param string $fieldName |
||
| 952 | * @param mixed $value |
||
| 953 | * @param ClassMetadata $class Defaults to $this->class |
||
| 954 | * @param boolean $prepareValue Whether or not to prepare the value |
||
| 955 | * @return array Prepared field name and value |
||
| 956 | */ |
||
| 957 | 497 | private function prepareQueryElement($fieldName, $value = null, $class = null, $prepareValue = true) |
|
| 1132 | |||
| 1133 | /** |
||
| 1134 | * Prepares a query expression. |
||
| 1135 | * |
||
| 1136 | * @param array|object $expression |
||
| 1137 | * @param ClassMetadata $class |
||
| 1138 | * @return array |
||
| 1139 | */ |
||
| 1140 | 65 | private function prepareQueryExpression($expression, $class) |
|
| 1167 | |||
| 1168 | /** |
||
| 1169 | * Checks whether the value has DBRef fields. |
||
| 1170 | * |
||
| 1171 | * This method doesn't check if the the value is a complete DBRef object, |
||
| 1172 | * although it should return true for a DBRef. Rather, we're checking that |
||
| 1173 | * the value has one or more fields for a DBref. In practice, this could be |
||
| 1174 | * $elemMatch criteria for matching a DBRef. |
||
| 1175 | * |
||
| 1176 | * @param mixed $value |
||
| 1177 | * @return boolean |
||
| 1178 | */ |
||
| 1179 | 66 | private function hasDBRefFields($value) |
|
| 1197 | |||
| 1198 | /** |
||
| 1199 | * Checks whether the value has query operators. |
||
| 1200 | * |
||
| 1201 | * @param mixed $value |
||
| 1202 | * @return boolean |
||
| 1203 | */ |
||
| 1204 | 70 | private function hasQueryOperators($value) |
|
| 1222 | |||
| 1223 | /** |
||
| 1224 | * Gets the array of discriminator values for the given ClassMetadata |
||
| 1225 | * |
||
| 1226 | * @param ClassMetadata $metadata |
||
| 1227 | * @return array |
||
| 1228 | */ |
||
| 1229 | 21 | private function getClassDiscriminatorValues(ClassMetadata $metadata) |
|
| 1245 | |||
| 1246 | 539 | private function handleCollections($document, $options) |
|
| 1265 | } |
||
| 1266 |
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: