Completed
Pull Request — master (#1422)
by
unknown
11:20
created

ClassMetadataFactory   C

Complexity

Total Complexity 60

Size/Duplication

Total Lines 317
Duplicated Lines 3.15 %

Coupling/Cohesion

Components 1
Dependencies 14

Test Coverage

Coverage 88.28%

Importance

Changes 2
Bugs 0 Features 1
Metric Value
wmc 60
c 2
b 0
f 1
lcom 1
cbo 14
dl 10
loc 317
ccs 128
cts 145
cp 0.8828
rs 5.6363

16 Methods

Rating   Name   Duplication   Size   Complexity  
C doLoadMetadata() 4 61 13
A setInheritedShardKey() 0 9 2
A setDocumentManager() 0 4 1
A setConfiguration() 0 4 1
A initialize() 0 6 1
A getFqcnFromAlias() 0 4 1
A getDriver() 0 4 1
A wakeupReflection() 0 3 1
A initializeReflection() 0 3 1
A isEntity() 0 4 2
A validateIdentifier() 0 6 4
A newClassMetadataInstance() 0 4 1
B addInheritedFields() 3 15 6
B addInheritedRelations() 3 16 6
A addInheritedIndexes() 0 6 2
C completeIdGeneratorMapping() 0 63 17

How to fix   Duplicated Code    Complexity   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

Complex Class

 Tip:   Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like ClassMetadataFactory often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use ClassMetadataFactory, and based on these observations, apply Extract Interface, too.

1
<?php
2
/*
3
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
4
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
5
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
6
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
7
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
8
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
9
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
10
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
11
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
12
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
13
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
14
 *
15
 * This software consists of voluntary contributions made by many individuals
16
 * and is licensed under the MIT license. For more information, see
17
 * <http://www.doctrine-project.org>.
18
 */
19
20
namespace Doctrine\ODM\MongoDB\Mapping;
21
22
use Doctrine\Common\Persistence\Mapping\AbstractClassMetadataFactory;
23
use Doctrine\Common\Persistence\Mapping\ClassMetadata as ClassMetadataInterface;
24
use Doctrine\Common\Persistence\Mapping\ReflectionService;
25
use Doctrine\ODM\MongoDB\Configuration;
26
use Doctrine\ODM\MongoDB\DocumentManager;
27
use Doctrine\ODM\MongoDB\Event\LoadClassMetadataEventArgs;
28
use Doctrine\ODM\MongoDB\Events;
29
use Doctrine\ODM\MongoDB\Id\AbstractIdGenerator;
30
use Doctrine\ODM\MongoDB\Id\AlnumGenerator;
31
use Doctrine\ODM\MongoDB\Id\AutoGenerator;
32
use Doctrine\ODM\MongoDB\Id\IncrementGenerator;
33
use Doctrine\ODM\MongoDB\Id\UuidGenerator;
34
35
/**
36
 * The ClassMetadataFactory is used to create ClassMetadata objects that contain all the
37
 * metadata mapping informations of a class which describes how a class should be mapped
38
 * to a document database.
39
 *
40
 * @since       1.0
41
 */
42
class ClassMetadataFactory extends AbstractClassMetadataFactory
43
{
44
    protected $cacheSalt = "\$MONGODBODMCLASSMETADATA";
45
46
    /** @var DocumentManager The DocumentManager instance */
47
    private $dm;
48
49
    /** @var Configuration The Configuration instance */
50
    private $config;
51
52
    /** @var \Doctrine\Common\Persistence\Mapping\Driver\MappingDriver The used metadata driver. */
53
    private $driver;
54
55
    /** @var \Doctrine\Common\EventManager The event manager instance */
56
    private $evm;
57
58
    /**
59
     * Sets the DocumentManager instance for this class.
60
     *
61
     * @param DocumentManager $dm The DocumentManager instance
62
     */
63 1074
    public function setDocumentManager(DocumentManager $dm)
64
    {
65 1074
        $this->dm = $dm;
66 1074
    }
67
68
    /**
69
     * Sets the Configuration instance
70
     *
71
     * @param Configuration $config
72
     */
73 1074
    public function setConfiguration(Configuration $config)
74
    {
75 1074
        $this->config = $config;
76 1074
    }
77
78
    /**
79
     * Lazy initialization of this stuff, especially the metadata driver,
80
     * since these are not needed at all when a metadata cache is active.
81
     */
82 852
    protected function initialize()
83
    {
84 852
        $this->driver = $this->config->getMetadataDriverImpl();
85 852
        $this->evm = $this->dm->getEventManager();
86 852
        $this->initialized = true;
87 852
    }
88
89
    /**
90
     * {@inheritDoc}
91
     */
92
    protected function getFqcnFromAlias($namespaceAlias, $simpleClassName)
93
    {
94
        return $this->config->getDocumentNamespace($namespaceAlias) . '\\' . $simpleClassName;
95
    }
96
97
    /**
98
     * {@inheritDoc}
99
     */
100 349
    protected function getDriver()
101
    {
102 349
        return $this->driver;
103
    }
104
105
    /**
106
     * {@inheritDoc}
107
     */
108 848
    protected function wakeupReflection(ClassMetadataInterface $class, ReflectionService $reflService)
109
    {
110 848
    }
111
112
    /**
113
     * {@inheritDoc}
114
     */
115 852
    protected function initializeReflection(ClassMetadataInterface $class, ReflectionService $reflService)
116
    {
117 852
    }
118
119
    /**
120
     * {@inheritDoc}
121
     */
122 848
    protected function isEntity(ClassMetadataInterface $class)
123
    {
124 848
        return ! $class->isMappedSuperclass && ! $class->isEmbeddedDocument;
0 ignored issues
show
Bug introduced by
Accessing isMappedSuperclass on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
Bug introduced by
Accessing isEmbeddedDocument on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
125
    }
126
127
    /**
128
     * {@inheritDoc}
129
     */
130 852
    protected function doLoadMetadata($class, $parent, $rootEntityFound, array $nonSuperclassParents = array())
131
    {
132
        /** @var $class ClassMetadata */
133
        /** @var $parent ClassMetadata */
134 852
        if ($parent) {
135 347
            $class->setInheritanceType($parent->inheritanceType);
136 347
            $class->setDiscriminatorField($parent->discriminatorField);
137 347
            $class->setDiscriminatorMap($parent->discriminatorMap);
138 347
            $class->setDefaultDiscriminatorValue($parent->defaultDiscriminatorValue);
139 347
            $class->setIdGeneratorType($parent->generatorType);
140 347
            $this->addInheritedFields($class, $parent);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ODM\Mong...\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
141 347
            $this->addInheritedRelations($class, $parent);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ODM\Mong...\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
142 347
            $this->addInheritedIndexes($class, $parent);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ODM\Mong...\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
143 347
            $this->setInheritedShardKey($class, $parent);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ODM\Mong...\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
144 347
            $class->setIdentifier($parent->identifier);
145 347
            $class->setVersioned($parent->isVersioned);
146 347
            $class->setVersionField($parent->versionField);
147 347
            $class->setLifecycleCallbacks($parent->lifecycleCallbacks);
148 347
            $class->setAlsoLoadMethods($parent->alsoLoadMethods);
149 347
            $class->setChangeTrackingPolicy($parent->changeTrackingPolicy);
150 347
            $class->setFile($parent->getFile());
151 347
            if ($parent->isMappedSuperclass) {
152 290
                $class->setCustomRepositoryClass($parent->customRepositoryClassName);
153
            }
154
        }
155
156
        // Invoke driver
157
        try {
158 852
            $this->driver->loadMetadataForClass($class->getName(), $class);
159 6
        } catch (\ReflectionException $e) {
160
            throw MappingException::reflectionFailure($class->getName(), $e);
161
        }
162
163 848
        $this->validateIdentifier($class);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ODM\Mong...\Mapping\ClassMetadata>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
164
165 848
        if ($parent && $rootEntityFound && $parent->generatorType === $class->generatorType) {
0 ignored issues
show
Bug introduced by
Accessing generatorType on the interface Doctrine\Common\Persistence\Mapping\ClassMetadata suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
166 102
            if ($parent->generatorType) {
167 102
                $class->setIdGeneratorType($parent->generatorType);
168
            }
169 102
            if ($parent->generatorOptions) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $parent->generatorOptions of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
170
                $class->setIdGeneratorOptions($parent->generatorOptions);
171
            }
172 102
            if ($parent->idGenerator) {
173 102
                $class->setIdGenerator($parent->idGenerator);
174
            }
175
        } else {
176 848
            $this->completeIdGeneratorMapping($class);
0 ignored issues
show
Compatibility introduced by
$class of type object<Doctrine\Common\P...\Mapping\ClassMetadata> is not a sub-type of object<Doctrine\ODM\Mong...ping\ClassMetadataInfo>. It seems like you assume a concrete implementation of the interface Doctrine\Common\Persistence\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
177
        }
178
179 848
        if ($parent && $parent->isInheritanceTypeSingleCollection()) {
180 87
            $class->setDatabase($parent->getDatabase());
181 87
            $class->setCollection($parent->getCollection());
182
        }
183
184 848
        $class->setParentClasses($nonSuperclassParents);
185
186 848 View Code Duplication
        if ($this->evm->hasListeners(Events::loadClassMetadata)) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
187 2
            $eventArgs = new LoadClassMetadataEventArgs($class, $this->dm);
188 2
            $this->evm->dispatchEvent(Events::loadClassMetadata, $eventArgs);
189
        }
190 848
    }
191
192
    /**
193
     * Validates the identifier mapping.
194
     *
195
     * @param ClassMetadata $class
196
     * @throws MappingException
197
     */
198 848
    protected function validateIdentifier($class)
199
    {
200 848
        if ( ! $class->identifier && ! $class->isMappedSuperclass && ! $class->isEmbeddedDocument) {
201
            throw MappingException::identifierRequired($class->name);
202
        }
203 848
    }
204
205
    /**
206
     * Creates a new ClassMetadata instance for the given class name.
207
     *
208
     * @param string $className
209
     * @return \Doctrine\ODM\MongoDB\Mapping\ClassMetadata
210
     */
211 852
    protected function newClassMetadataInstance($className)
212
    {
213 852
        return new ClassMetadata($className);
214
    }
215
216 848
    private function completeIdGeneratorMapping(ClassMetadataInfo $class)
217
    {
218 848
        $idGenOptions = $class->generatorOptions;
219 848
        switch ($class->generatorType) {
220 848
            case ClassMetadata::GENERATOR_TYPE_AUTO:
221 783
                $class->setIdGenerator(new AutoGenerator());
222 783
                break;
223 145
            case ClassMetadata::GENERATOR_TYPE_INCREMENT:
224 6
                $incrementGenerator = new IncrementGenerator();
225 6
                if (isset($idGenOptions['key'])) {
226
                    $incrementGenerator->setKey($idGenOptions['key']);
227
                }
228 6
                if (isset($idGenOptions['collection'])) {
229
                    $incrementGenerator->setCollection($idGenOptions['collection']);
230
                }
231 6
                $class->setIdGenerator($incrementGenerator);
232 6
                break;
233 139
            case ClassMetadata::GENERATOR_TYPE_UUID:
234 4
                $uuidGenerator = new UuidGenerator();
235 4
                isset($idGenOptions['salt']) && $uuidGenerator->setSalt($idGenOptions['salt']);
236 4
                $class->setIdGenerator($uuidGenerator);
237 4
                break;
238 135
            case ClassMetadata::GENERATOR_TYPE_ALNUM:
239 1
                $alnumGenerator = new AlnumGenerator();
240 1
                if (isset($idGenOptions['pad'])) {
241
                    $alnumGenerator->setPad($idGenOptions['pad']);
242
                }
243 1
                if (isset($idGenOptions['chars'])) {
244 1
                    $alnumGenerator->setChars($idGenOptions['chars']);
245
                } elseif (isset($idGenOptions['awkwardSafe'])) {
246
                    $alnumGenerator->setAwkwardSafeMode($idGenOptions['awkwardSafe']);
247
                }
248
249 1
                $class->setIdGenerator($alnumGenerator);
250 1
                break;
251 134
            case ClassMetadata::GENERATOR_TYPE_CUSTOM:
252 53
                if (empty($idGenOptions['class'])) {
253
                    throw MappingException::missingIdGeneratorClass($class->name);
254
                }
255
256 53
                $customGenerator = new $idGenOptions['class'];
257 53
                unset($idGenOptions['class']);
258 53
                if ( ! $customGenerator instanceof AbstractIdGenerator) {
259
                    throw MappingException::classIsNotAValidGenerator(get_class($customGenerator));
260
                }
261
262 53
                $methods = get_class_methods($customGenerator);
263 53
                foreach ($idGenOptions as $name => $value) {
264
                    $method = 'set' . ucfirst($name);
265
                    if ( ! in_array($method, $methods)) {
266
                        throw MappingException::missingGeneratorSetter(get_class($customGenerator), $name);
267
                    }
268
269
                    $customGenerator->$method($value);
270
                }
271 53
                $class->setIdGenerator($customGenerator);
272 53
                break;
273 132
            case ClassMetadata::GENERATOR_TYPE_NONE;
274 132
                break;
275
            default:
276
                throw new MappingException('Unknown generator type: ' . $class->generatorType);
277
        }
278 848
    }
279
280
    /**
281
     * Adds inherited fields to the subclass mapping.
282
     *
283
     * @param ClassMetadata $subClass
284
     * @param ClassMetadata $parentClass
285
     */
286 347
    private function addInheritedFields(ClassMetadata $subClass, ClassMetadata $parentClass)
287
    {
288 347
        foreach ($parentClass->fieldMappings as $fieldName => $mapping) {
289 120 View Code Duplication
            if ( ! isset($mapping['inherited']) && ! $parentClass->isMappedSuperclass) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
290 114
                $mapping['inherited'] = $parentClass->name;
291
            }
292 120
            if ( ! isset($mapping['declared'])) {
293 120
                $mapping['declared'] = $parentClass->name;
294
            }
295 120
            $subClass->addInheritedFieldMapping($mapping);
296
        }
297 347
        foreach ($parentClass->reflFields as $name => $field) {
298 120
            $subClass->reflFields[$name] = $field;
299
        }
300 347
    }
301
302
303
    /**
304
     * Adds inherited association mappings to the subclass mapping.
305
     *
306
     * @param \Doctrine\ODM\MongoDB\Mapping\ClassMetadata $subClass
307
     * @param \Doctrine\ODM\MongoDB\Mapping\ClassMetadata $parentClass
308
     *
309
     * @return void
310
     *
311
     * @throws MappingException
312
     */
313 347
    private function addInheritedRelations(ClassMetadata $subClass, ClassMetadata $parentClass)
314
    {
315 347
        foreach ($parentClass->associationMappings as $field => $mapping) {
316 76
            if ($parentClass->isMappedSuperclass) {
317 3
                $mapping['sourceDocument'] = $subClass->name;
318
            }
319
320 76 View Code Duplication
            if ( ! isset($mapping['inherited']) && ! $parentClass->isMappedSuperclass) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
321 73
                $mapping['inherited'] = $parentClass->name;
322
            }
323 76
            if ( ! isset($mapping['declared'])) {
324 76
                $mapping['declared'] = $parentClass->name;
325
            }
326 76
            $subClass->addInheritedAssociationMapping($mapping);
327
        }
328 347
    }
329
330
    /**
331
     * Adds inherited indexes to the subclass mapping.
332
     *
333
     * @param ClassMetadata $subClass
334
     * @param ClassMetadata $parentClass
335
     */
336 347
    private function addInheritedIndexes(ClassMetadata $subClass, ClassMetadata $parentClass)
337
    {
338 347
        foreach ($parentClass->indexes as $index) {
339 53
            $subClass->addIndex($index['keys'], $index['options']);
340
        }
341 347
    }
342
343
    /**
344
     * Adds inherited shard key to the subclass mapping.
345
     *
346
     * @param ClassMetadata $subClass
347
     * @param ClassMetadata $parentClass
348
     */
349 347
    private function setInheritedShardKey(ClassMetadata $subClass, ClassMetadata $parentClass)
350
    {
351 347
        if ($parentClass->isSharded()) {
352 5
            $subClass->setShardKey(
353 5
                $parentClass->shardKey['keys'],
354 5
                $parentClass->shardKey['options']
355
            );
356
        }
357 347
    }
358
}
359