Issues in IncrementType.php - New Issues - Inspection of "Merge pull request #1606 from malarzm/deprecation-..." - doctrine/mongodb-odm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 80e8df...60de96 )

by Maciej

created 2017-06-16 11:47 UTC

lib/Doctrine/ODM/MongoDB/Types/IncrementType.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the MIT license. For more information, see
 * <http://www.doctrine-project.org>.
 */

namespace Doctrine\ODM\MongoDB\Types;

/**
 * The Increment type.
 *
 * @since       1.0
 * @deprecated This type will be removed in ODM 2.0. Please use int or float instead
 */
class IncrementType extends Type
{
    public function convertToDatabaseValue($value)

    {
        @trigger_error(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            'Increment type was deprecated in version 1.1 - use int or float with increment storage strategy instead.',
            E_USER_DEPRECATED
        );
        return $value !== null ? (is_float($value) ? (float) $value : (int) $value) : null;
    }

    public function convertToPHPValue($value)

    {
        @trigger_error(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            'Increment type was deprecated in version 1.1 - use int or float with increment storage strategy instead.',
            E_USER_DEPRECATED
        );
        return $value !== null ? (is_float($value) ? (float) $value : (int) $value) : null;
    }

    public function closureToMongo()
    {
        return '$return = is_float($value) ? (float) $value : (int) $value;';
    }

    public function closureToPHP()
    {
        return '$return = is_float($value) ? (float) $value : (int) $value;';
    }
}


1			<?php
2			/*
3			* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
4			* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
5			* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
6			* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
7			* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
8			* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
9			* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
10			* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
11			* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
12			* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
13			* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
14			*
15			* This software consists of voluntary contributions made by many individuals
16			* and is licensed under the MIT license. For more information, see
17			* <http://www.doctrine-project.org>.
18			*/
19
20			namespace Doctrine\ODM\MongoDB\Types;
21
22			/**
23			* The Increment type.
24			*
25			* @since 1.0
26			* @deprecated This type will be removed in ODM 2.0. Please use int or float instead
27			*/
28			class IncrementType extends Type
29			{
30	2	View Code Duplication	public function convertToDatabaseValue($value)
			0 ignored issues – show Duplication introduced 2017-06-14 13:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31			{
32	2		@trigger_error(
			0 ignored issues – show Security Best Practice introduced 2017-06-14 13:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
33	2		'Increment type was deprecated in version 1.1 - use int or float with increment storage strategy instead.',
34	2		E_USER_DEPRECATED
35			);
36	2		return $value !== null ? (is_float($value) ? (float) $value : (int) $value) : null;
37			}
38
39	2	View Code Duplication	public function convertToPHPValue($value)
			0 ignored issues – show Duplication introduced 2017-06-14 13:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40			{
41	2		@trigger_error(
			0 ignored issues – show Security Best Practice introduced 2017-06-14 13:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
42	2		'Increment type was deprecated in version 1.1 - use int or float with increment storage strategy instead.',
43	2		E_USER_DEPRECATED
44			);
45	2		return $value !== null ? (is_float($value) ? (float) $value : (int) $value) : null;
46			}
47
48			public function closureToMongo()
49			{
50			return '$return = is_float($value) ? (float) $value : (int) $value;';
51			}
52
53			public function closureToPHP()
54			{
55			return '$return = is_float($value) ? (float) $value : (int) $value;';
56			}
57			}
58

doctrine / mongodb-odm

Push — master ( 80e8df...60de96 )

lib/Doctrine/ODM/MongoDB/Types/IncrementType.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like