Completed
Pull Request — master (#1654)
by Andreas
10:38
created

Bucket   A

Complexity

Total Complexity 6

Size/Duplication

Total Lines 39
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 6

Test Coverage

Coverage 84.62%

Importance

Changes 0
Metric Value
wmc 6
c 0
b 0
f 0
lcom 1
cbo 6
dl 39
loc 39
ccs 11
cts 13
cp 0.8462
rs 10

3 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 7 7 1
A convertExpression() 10 10 4
A getDocumentPersister() 4 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/*
3
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
4
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
5
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
6
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
7
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
8
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
9
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
10
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
11
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
12
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
13
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
14
 *
15
 * This software consists of voluntary contributions made by many individuals
16
 * and is licensed under the MIT license. For more information, see
17
 * <http://www.doctrine-project.org>.
18
 */
19
20
namespace Doctrine\ODM\MongoDB\Aggregation\Stage;
21
22
use Doctrine\MongoDB\Aggregation\Builder;
23
use Doctrine\MongoDB\Aggregation\Stage as BaseStage;
24
use Doctrine\ODM\MongoDB\DocumentManager;
25
use Doctrine\ODM\MongoDB\Mapping\ClassMetadata;
26
use Doctrine\ODM\MongoDB\Types\Type;
27
28 View Code Duplication
class Bucket extends BaseStage\Bucket
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
29
{
30
    /**
31
     * @var DocumentManager
32
     */
33
    private $dm;
34
35
    /**
36
     * @var ClassMetadata
37
     */
38
    private $class;
39
40 1
    public function __construct(Builder $builder, DocumentManager $documentManager, ClassMetadata $class)
41
    {
42 1
        $this->dm = $documentManager;
43 1
        $this->class = $class;
44
45 1
        parent::__construct($builder);
46 1
    }
47
48 1
    protected function convertExpression($expression)
49
    {
50 1
        if (is_array($expression)) {
51
            return array_map([$this, 'convertExpression'], $expression);
52 1
        } elseif (is_string($expression) && substr($expression, 0, 1) === '$') {
53 1
            return '$' . $this->getDocumentPersister()->prepareFieldName(substr($expression, 1));
54
        } else {
55
            return Type::convertPHPToDatabaseValue(parent::convertExpression($expression));
56
        }
57
    }
58
59
    /**
60
     * @return \Doctrine\ODM\MongoDB\Persisters\DocumentPersister
61
     */
62 1
    private function getDocumentPersister()
63
    {
64 1
        return $this->dm->getUnitOfWork()->getDocumentPersister($this->class->name);
65
    }
66
}
67