Completed
Pull Request — master (#2019)
by Andreas
13:36 queued 07:34
created
lib/Doctrine/ODM/MongoDB/Query/Builder.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,6 @@
 block discarded – undo
20 20
 namespace Doctrine\ODM\MongoDB\Query;
21 21
 
22 22
 use Doctrine\ODM\MongoDB\DocumentManager;
23
-use Doctrine\ODM\MongoDB\Hydrator;
24 23
 use Doctrine\ODM\MongoDB\Mapping\ClassMetadataInfo;
25 24
 
26 25
 /**
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
      * Construct a Builder
92 92
      *
93 93
      * @param DocumentManager $dm
94
-     * @param string[]|string|null $documentName (optional) an array of document names, the document name, or none
94
+     * @param string|null $documentName (optional) an array of document names, the document name, or none
95 95
      */
96 96
     public function __construct(DocumentManager $dm, $documentName = null)
97 97
     {
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
      * If a custom callable is used, its signature should conform to the default
145 145
      * Closure defined in {@link ReferencePrimer::__construct()}.
146 146
      *
147
-     * @param boolean|callable $primer
147
+     * @param boolean $primer
148 148
      * @return $this
149 149
      * @throws \InvalidArgumentException If $primer is not boolean or callable
150 150
      */
Please login to merge, or discard this patch.
lib/Doctrine/ODM/MongoDB/UnitOfWork.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2631,7 +2631,7 @@
 block discarded – undo
2631 2631
      * @param array $data The data for the document.
2632 2632
      * @param array $hints Any hints to account for during reconstitution/lookup of the document.
2633 2633
      * @param object $document The document to be hydrated into in case of creation
2634
-     * @return object The document instance.
2634
+     * @return callable|null The document instance.
2635 2635
      * @internal Highly performance-sensitive method.
2636 2636
      */
2637 2637
     public function getOrCreateDocument($className, $data, &$hints = array(), $document = null)
Please login to merge, or discard this patch.
lib/Doctrine/ODM/MongoDB/Persisters/DocumentPersister.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,6 @@
 block discarded – undo
22 22
 use Doctrine\Common\EventManager;
23 23
 use Doctrine\Common\Persistence\Mapping\MappingException;
24 24
 use Doctrine\MongoDB\CursorInterface;
25
-use Doctrine\MongoDB\EagerCursor;
26 25
 use Doctrine\ODM\MongoDB\Cursor;
27 26
 use Doctrine\ODM\MongoDB\DocumentManager;
28 27
 use Doctrine\ODM\MongoDB\Mapping\ClassMetadataInfo;
Please login to merge, or discard this patch.
lib/Doctrine/ODM/MongoDB/DocumentManager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -606,7 +606,7 @@
 block discarded – undo
606 606
      * This is just a convenient shortcut for getRepository($documentName)->find($id).
607 607
      *
608 608
      * @param string $documentName
609
-     * @param mixed $identifier
609
+     * @param \MongoId $identifier
610 610
      * @param int $lockMode
611 611
      * @param int $lockVersion
612 612
      * @return object $document
Please login to merge, or discard this patch.
lib/Doctrine/ODM/MongoDB/Aggregation/Stage/GraphLookup.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -89,6 +89,9 @@  discard block
 block discarded – undo
89 89
         return parent::from($this->targetClass->getCollection());
90 90
     }
91 91
 
92
+    /**
93
+     * @param string|null $connectFromField
94
+     */
92 95
     public function connectFromField($connectFromField)
93 96
     {
94 97
         // No targetClass mapping - simply use field name as is
@@ -110,6 +113,9 @@  discard block
 block discarded – undo
110 113
         return parent::connectFromField($this->getReferencedFieldName($connectFromField, $referenceMapping));
111 114
     }
112 115
 
116
+    /**
117
+     * @param string $connectToField
118
+     */
113 119
     public function connectToField($connectToField)
114 120
     {
115 121
         return parent::connectToField($this->convertTargetFieldName($connectToField));
@@ -165,6 +171,9 @@  discard block
 block discarded – undo
165 171
         }
166 172
     }
167 173
 
174
+    /**
175
+     * @return string
176
+     */
168 177
     protected function convertTargetFieldName($fieldName)
169 178
     {
170 179
         if (is_array($fieldName)) {
Please login to merge, or discard this patch.
lib/Doctrine/ODM/MongoDB/Aggregation/Stage/Lookup.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -149,6 +149,7 @@  discard block
 block discarded – undo
149 149
 
150 150
     /**
151 151
      * {@inheritdoc}
152
+     * @param string $localField
152 153
      */
153 154
     public function localField($localField)
154 155
     {
@@ -157,12 +158,16 @@  discard block
 block discarded – undo
157 158
 
158 159
     /**
159 160
      * {@inheritdoc}
161
+     * @param string $foreignField
160 162
      */
161 163
     public function foreignField($foreignField)
162 164
     {
163 165
         return parent::foreignField($this->prepareFieldName($foreignField, $this->targetClass));
164 166
     }
165 167
 
168
+    /**
169
+     * @return string
170
+     */
166 171
     protected function prepareFieldName($fieldName, ClassMetadata $class = null)
167 172
     {
168 173
         if ( ! $class) {
Please login to merge, or discard this patch.
lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadataInfo.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1085,7 +1085,7 @@  discard block
 block discarded – undo
1085 1085
     /**
1086 1086
      * Gets the ReflectionProperties of the mapped class.
1087 1087
      *
1088
-     * @return array An array of ReflectionProperty instances.
1088
+     * @return \ReflectionProperty[] An array of ReflectionProperty instances.
1089 1089
      */
1090 1090
     public function getReflectionProperties()
1091 1091
     {
@@ -1900,7 +1900,7 @@  discard block
 block discarded – undo
1900 1900
      *
1901 1901
      * @param string $dbFieldName
1902 1902
      *
1903
-     * @return array
1903
+     * @return string
1904 1904
      * @throws MappingException
1905 1905
      */
1906 1906
     public function getFieldMappingByDbFieldName($dbFieldName)
Please login to merge, or discard this patch.
lib/Doctrine/ODM/MongoDB/Tools/DocumentGenerator.php 1 patch
Doc Comments   +13 added lines patch added patch discarded remove patch
@@ -774,6 +774,10 @@  discard block
 block discarded – undo
774 774
         return implode("\n", $lines);
775 775
     }
776 776
 
777
+    /**
778
+     * @param string $type
779
+     * @param string $defaultValue
780
+     */
777 781
     private function generateDocumentStubMethod(ClassMetadataInfo $metadata, $type, $fieldName, $typeHint = null, $defaultValue = null)
778 782
     {
779 783
         // Add/remove methods should use the singular form of the field name
@@ -958,6 +962,9 @@  discard block
 block discarded – undo
958 962
         return implode("\n", $lines);
959 963
     }
960 964
 
965
+    /**
966
+     * @param integer $type
967
+     */
961 968
     private function getInheritanceTypeString($type)
962 969
     {
963 970
         switch ($type) {
@@ -975,6 +982,9 @@  discard block
 block discarded – undo
975 982
         }
976 983
     }
977 984
 
985
+    /**
986
+     * @param integer $policy
987
+     */
978 988
     private function getChangeTrackingPolicyString($policy)
979 989
     {
980 990
         switch ($policy) {
@@ -992,6 +1002,9 @@  discard block
 block discarded – undo
992 1002
         }
993 1003
     }
994 1004
 
1005
+    /**
1006
+     * @param integer $type
1007
+     */
995 1008
     private function getIdGeneratorTypeString($type)
996 1009
     {
997 1010
         switch ($type) {
Please login to merge, or discard this patch.