doctrine /
mongodb-odm
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like XmlDriver often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use XmlDriver, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 33 | class XmlDriver extends FileDriver |
||
| 34 | { |
||
| 35 | const DEFAULT_FILE_EXTENSION = '.dcm.xml'; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * {@inheritDoc} |
||
| 39 | */ |
||
| 40 | 13 | public function __construct($locator, $fileExtension = self::DEFAULT_FILE_EXTENSION) |
|
| 44 | |||
| 45 | /** |
||
| 46 | * {@inheritDoc} |
||
| 47 | */ |
||
| 48 | 8 | public function loadMetadataForClass($className, ClassMetadata $class) |
|
| 49 | { |
||
| 50 | /* @var $class ClassMetadataInfo */ |
||
| 51 | /* @var $xmlRoot \SimpleXMLElement */ |
||
| 52 | 8 | $xmlRoot = $this->getElement($className); |
|
| 53 | 8 | if ( ! $xmlRoot) { |
|
| 54 | return; |
||
| 55 | } |
||
| 56 | |||
| 57 | 8 | if ($xmlRoot->getName() == 'document') { |
|
| 58 | 8 | if (isset($xmlRoot['repository-class'])) { |
|
| 59 | 8 | $class->setCustomRepositoryClass((string) $xmlRoot['repository-class']); |
|
| 60 | } |
||
| 61 | 3 | } elseif ($xmlRoot->getName() == 'mapped-superclass') { |
|
| 62 | 2 | $class->setCustomRepositoryClass( |
|
| 63 | 2 | isset($xmlRoot['repository-class']) ? (string) $xmlRoot['repository-class'] : null |
|
| 64 | ); |
||
| 65 | 2 | $class->isMappedSuperclass = true; |
|
|
|
|||
| 66 | 1 | } elseif ($xmlRoot->getName() == 'embedded-document') { |
|
| 67 | 1 | $class->isEmbeddedDocument = true; |
|
| 68 | } |
||
| 69 | 8 | if (isset($xmlRoot['db'])) { |
|
| 70 | 4 | $class->setDatabase((string) $xmlRoot['db']); |
|
| 71 | } |
||
| 72 | 8 | if (isset($xmlRoot['collection'])) { |
|
| 73 | 7 | if (isset($xmlRoot['capped-collection'])) { |
|
| 74 | $config = array('name' => (string) $xmlRoot['collection']); |
||
| 75 | $config['capped'] = (bool) $xmlRoot['capped-collection']; |
||
| 76 | if (isset($xmlRoot['capped-collection-max'])) { |
||
| 77 | $config['max'] = (int) $xmlRoot['capped-collection-max']; |
||
| 78 | } |
||
| 79 | if (isset($xmlRoot['capped-collection-size'])) { |
||
| 80 | $config['size'] = (int) $xmlRoot['capped-collection-size']; |
||
| 81 | } |
||
| 82 | $class->setCollection($config); |
||
| 83 | } else { |
||
| 84 | 7 | $class->setCollection((string) $xmlRoot['collection']); |
|
| 85 | } |
||
| 86 | } |
||
| 87 | 8 | if (isset($xmlRoot['writeConcern'])) { |
|
| 88 | 1 | $class->setWriteConcern((string) $xmlRoot['writeConcern']); |
|
| 89 | } |
||
| 90 | 8 | if (isset($xmlRoot['inheritance-type'])) { |
|
| 91 | $inheritanceType = (string) $xmlRoot['inheritance-type']; |
||
| 92 | $class->setInheritanceType(constant(MappingClassMetadata::class . '::INHERITANCE_TYPE_' . $inheritanceType)); |
||
| 93 | } |
||
| 94 | 8 | View Code Duplication | if (isset($xmlRoot['change-tracking-policy'])) { |
| 95 | 2 | $class->setChangeTrackingPolicy(constant(MappingClassMetadata::class . '::CHANGETRACKING_' . strtoupper((string) $xmlRoot['change-tracking-policy']))); |
|
| 96 | } |
||
| 97 | 8 | if (isset($xmlRoot->{'discriminator-field'})) { |
|
| 98 | 1 | $discrField = $xmlRoot->{'discriminator-field'}; |
|
| 99 | /* XSD only allows for "name", which is consistent with association |
||
| 100 | * configurations, but fall back to "fieldName" for BC. |
||
| 101 | */ |
||
| 102 | 1 | $class->setDiscriminatorField( |
|
| 103 | 1 | isset($discrField['name']) ? (string) $discrField['name'] : (string) $discrField['fieldName'] |
|
| 104 | ); |
||
| 105 | } |
||
| 106 | 8 | View Code Duplication | if (isset($xmlRoot->{'discriminator-map'})) { |
| 107 | 1 | $map = array(); |
|
| 108 | 1 | foreach ($xmlRoot->{'discriminator-map'}->{'discriminator-mapping'} AS $discrMapElement) { |
|
| 109 | 1 | $map[(string) $discrMapElement['value']] = (string) $discrMapElement['class']; |
|
| 110 | } |
||
| 111 | 1 | $class->setDiscriminatorMap($map); |
|
| 112 | } |
||
| 113 | 8 | if (isset($xmlRoot->{'default-discriminator-value'})) { |
|
| 114 | 1 | $class->setDefaultDiscriminatorValue((string) $xmlRoot->{'default-discriminator-value'}['value']); |
|
| 115 | } |
||
| 116 | 8 | if (isset($xmlRoot->{'indexes'})) { |
|
| 117 | 3 | foreach ($xmlRoot->{'indexes'}->{'index'} as $index) { |
|
| 118 | 3 | $this->addIndex($class, $index); |
|
| 119 | } |
||
| 120 | } |
||
| 121 | 8 | if (isset($xmlRoot->{'shard-key'})) { |
|
| 122 | 1 | $this->setShardKey($class, $xmlRoot->{'shard-key'}[0]); |
|
| 123 | } |
||
| 124 | 8 | if (isset($xmlRoot['require-indexes'])) { |
|
| 125 | 1 | $class->setRequireIndexes('true' === (string) $xmlRoot['require-indexes']); |
|
| 126 | } |
||
| 127 | 8 | if (isset($xmlRoot['slave-okay'])) { |
|
| 128 | 1 | $class->setSlaveOkay('true' === (string) $xmlRoot['slave-okay']); |
|
| 129 | } |
||
| 130 | 8 | if (isset($xmlRoot->field)) { |
|
| 131 | 8 | foreach ($xmlRoot->field as $field) { |
|
| 132 | 8 | $mapping = array(); |
|
| 133 | 8 | $attributes = $field->attributes(); |
|
| 134 | 8 | foreach ($attributes as $key => $value) { |
|
| 135 | 8 | $mapping[$key] = (string) $value; |
|
| 136 | 8 | $booleanAttributes = array('id', 'reference', 'embed', 'unique', 'sparse', 'file', 'distance'); |
|
| 137 | 8 | if (in_array($key, $booleanAttributes)) { |
|
| 138 | 8 | $mapping[$key] = ('true' === $mapping[$key]); |
|
| 139 | } |
||
| 140 | } |
||
| 141 | 8 | if (isset($mapping['id']) && $mapping['id'] === true && isset($mapping['strategy'])) { |
|
| 142 | 3 | $mapping['options'] = array(); |
|
| 143 | 3 | if (isset($field->{'id-generator-option'})) { |
|
| 144 | 1 | foreach ($field->{'id-generator-option'} as $generatorOptions) { |
|
| 145 | 1 | $attributesGenerator = iterator_to_array($generatorOptions->attributes()); |
|
| 146 | 1 | if (isset($attributesGenerator['name']) && isset($attributesGenerator['value'])) { |
|
| 147 | 1 | $mapping['options'][(string) $attributesGenerator['name']] = (string) $attributesGenerator['value']; |
|
| 148 | } |
||
| 149 | } |
||
| 150 | } |
||
| 151 | } |
||
| 152 | |||
| 153 | 8 | if (isset($attributes['not-saved'])) { |
|
| 154 | $mapping['notSaved'] = ('true' === (string) $attributes['not-saved']); |
||
| 155 | } |
||
| 156 | |||
| 157 | 8 | if (isset($attributes['also-load'])) { |
|
| 158 | $mapping['alsoLoadFields'] = explode(',', $attributes['also-load']); |
||
| 159 | 8 | } elseif (isset($attributes['version'])) { |
|
| 160 | 1 | $mapping['version'] = ('true' === (string) $attributes['version']); |
|
| 161 | 8 | } elseif (isset($attributes['lock'])) { |
|
| 162 | 1 | $mapping['lock'] = ('true' === (string) $attributes['lock']); |
|
| 163 | } |
||
| 164 | |||
| 165 | 8 | $this->addFieldMapping($class, $mapping); |
|
| 166 | } |
||
| 167 | } |
||
| 168 | 8 | if (isset($xmlRoot->{'embed-one'})) { |
|
| 169 | 2 | foreach ($xmlRoot->{'embed-one'} as $embed) { |
|
| 170 | 2 | $this->addEmbedMapping($class, $embed, 'one'); |
|
| 171 | } |
||
| 172 | } |
||
| 173 | 8 | if (isset($xmlRoot->{'embed-many'})) { |
|
| 174 | 2 | foreach ($xmlRoot->{'embed-many'} as $embed) { |
|
| 175 | 2 | $this->addEmbedMapping($class, $embed, 'many'); |
|
| 176 | } |
||
| 177 | } |
||
| 178 | 8 | if (isset($xmlRoot->{'reference-many'})) { |
|
| 179 | 3 | foreach ($xmlRoot->{'reference-many'} as $reference) { |
|
| 180 | 3 | $this->addReferenceMapping($class, $reference, 'many'); |
|
| 181 | } |
||
| 182 | } |
||
| 183 | 8 | if (isset($xmlRoot->{'reference-one'})) { |
|
| 184 | 3 | foreach ($xmlRoot->{'reference-one'} as $reference) { |
|
| 185 | 3 | $this->addReferenceMapping($class, $reference, 'one'); |
|
| 186 | } |
||
| 187 | } |
||
| 188 | 8 | if (isset($xmlRoot->{'lifecycle-callbacks'})) { |
|
| 189 | 2 | foreach ($xmlRoot->{'lifecycle-callbacks'}->{'lifecycle-callback'} as $lifecycleCallback) { |
|
| 190 | 2 | $class->addLifecycleCallback((string) $lifecycleCallback['method'], constant('Doctrine\ODM\MongoDB\Events::' . (string) $lifecycleCallback['type'])); |
|
| 191 | } |
||
| 192 | } |
||
| 193 | 8 | if (isset($xmlRoot->{'also-load-methods'})) { |
|
| 194 | 1 | foreach ($xmlRoot->{'also-load-methods'}->{'also-load-method'} as $alsoLoadMethod) { |
|
| 195 | 1 | $class->registerAlsoLoadMethod((string) $alsoLoadMethod['method'], (string) $alsoLoadMethod['field']); |
|
| 196 | } |
||
| 197 | } |
||
| 198 | 8 | } |
|
| 199 | |||
| 200 | 8 | private function addFieldMapping(ClassMetadataInfo $class, $mapping) |
|
| 241 | |||
| 242 | 2 | private function addEmbedMapping(ClassMetadataInfo $class, $embed, $type) |
|
| 243 | { |
||
| 244 | 2 | $attributes = $embed->attributes(); |
|
| 245 | 2 | $defaultStrategy = $type == 'one' ? ClassMetadataInfo::STORAGE_STRATEGY_SET : CollectionHelper::DEFAULT_STRATEGY; |
|
| 246 | $mapping = array( |
||
| 247 | 2 | 'type' => $type, |
|
| 248 | 'embedded' => true, |
||
| 249 | 2 | 'targetDocument' => isset($attributes['target-document']) ? (string) $attributes['target-document'] : null, |
|
| 250 | 2 | 'name' => (string) $attributes['field'], |
|
| 251 | 2 | 'strategy' => isset($attributes['strategy']) ? (string) $attributes['strategy'] : $defaultStrategy, |
|
| 252 | ); |
||
| 253 | 2 | if (isset($attributes['fieldName'])) { |
|
| 254 | 1 | $mapping['fieldName'] = (string) $attributes['fieldName']; |
|
| 255 | } |
||
| 256 | 2 | View Code Duplication | if (isset($embed->{'discriminator-field'})) { |
| 257 | 1 | $attr = $embed->{'discriminator-field'}; |
|
| 258 | 1 | $mapping['discriminatorField'] = (string) $attr['name']; |
|
| 259 | } |
||
| 260 | 2 | View Code Duplication | if (isset($embed->{'discriminator-map'})) { |
| 261 | 1 | foreach ($embed->{'discriminator-map'}->{'discriminator-mapping'} as $discriminatorMapping) { |
|
| 262 | 1 | $attr = $discriminatorMapping->attributes(); |
|
| 263 | 1 | $mapping['discriminatorMap'][(string) $attr['value']] = (string) $attr['class']; |
|
| 264 | } |
||
| 265 | } |
||
| 266 | 2 | if (isset($embed->{'default-discriminator-value'})) { |
|
| 267 | 1 | $mapping['defaultDiscriminatorValue'] = (string) $embed->{'default-discriminator-value'}['value']; |
|
| 268 | } |
||
| 269 | 2 | if (isset($attributes['not-saved'])) { |
|
| 270 | $mapping['notSaved'] = ('true' === (string) $attributes['not-saved']); |
||
| 271 | } |
||
| 272 | 2 | if (isset($attributes['also-load'])) { |
|
| 273 | $mapping['alsoLoadFields'] = explode(',', $attributes['also-load']); |
||
| 274 | } |
||
| 275 | 2 | $this->addFieldMapping($class, $mapping); |
|
| 276 | 2 | } |
|
| 277 | |||
| 278 | 3 | private function addReferenceMapping(ClassMetadataInfo $class, $reference, $type) |
|
| 279 | { |
||
| 280 | 3 | $cascade = array_keys((array) $reference->cascade); |
|
| 281 | 3 | if (1 === count($cascade)) { |
|
| 282 | 2 | $cascade = current($cascade) ?: next($cascade); |
|
| 283 | } |
||
| 284 | 3 | $attributes = $reference->attributes(); |
|
| 285 | 3 | $defaultStrategy = $type == 'one' ? ClassMetadataInfo::STORAGE_STRATEGY_SET : CollectionHelper::DEFAULT_STRATEGY; |
|
| 286 | $mapping = array( |
||
| 287 | 3 | 'cascade' => $cascade, |
|
| 288 | 3 | 'orphanRemoval' => isset($attributes['orphan-removal']) ? ('true' === (string) $attributes['orphan-removal']) : false, |
|
| 289 | 3 | 'type' => $type, |
|
| 290 | 'reference' => true, |
||
| 291 | 3 | 'simple' => isset($attributes['simple']) ? ('true' === (string) $attributes['simple']) : false, // deprecated |
|
| 292 | 3 | 'storeAs' => isset($attributes['store-as']) ? (string) $attributes['store-as'] : ClassMetadataInfo::REFERENCE_STORE_AS_DB_REF_WITH_DB, |
|
| 293 | 3 | 'targetDocument' => isset($attributes['target-document']) ? (string) $attributes['target-document'] : null, |
|
| 294 | 3 | 'name' => (string) $attributes['field'], |
|
| 295 | 3 | 'strategy' => isset($attributes['strategy']) ? (string) $attributes['strategy'] : $defaultStrategy, |
|
| 296 | 3 | 'inversedBy' => isset($attributes['inversed-by']) ? (string) $attributes['inversed-by'] : null, |
|
| 297 | 3 | 'mappedBy' => isset($attributes['mapped-by']) ? (string) $attributes['mapped-by'] : null, |
|
| 298 | 3 | 'repositoryMethod' => isset($attributes['repository-method']) ? (string) $attributes['repository-method'] : null, |
|
| 299 | 3 | 'limit' => isset($attributes['limit']) ? (integer) $attributes['limit'] : null, |
|
| 300 | 3 | 'skip' => isset($attributes['skip']) ? (integer) $attributes['skip'] : null, |
|
| 301 | ); |
||
| 302 | |||
| 303 | 3 | if (isset($attributes['fieldName'])) { |
|
| 304 | 1 | $mapping['fieldName'] = (string) $attributes['fieldName']; |
|
| 305 | } |
||
| 306 | 3 | View Code Duplication | if (isset($reference->{'discriminator-field'})) { |
| 307 | 1 | $attr = $reference->{'discriminator-field'}; |
|
| 308 | 1 | $mapping['discriminatorField'] = (string) $attr['name']; |
|
| 309 | } |
||
| 310 | 3 | View Code Duplication | if (isset($reference->{'discriminator-map'})) { |
| 311 | 1 | foreach ($reference->{'discriminator-map'}->{'discriminator-mapping'} as $discriminatorMapping) { |
|
| 312 | 1 | $attr = $discriminatorMapping->attributes(); |
|
| 313 | 1 | $mapping['discriminatorMap'][(string) $attr['value']] = (string) $attr['class']; |
|
| 314 | } |
||
| 315 | } |
||
| 316 | 3 | if (isset($reference->{'default-discriminator-value'})) { |
|
| 317 | 1 | $mapping['defaultDiscriminatorValue'] = (string) $reference->{'default-discriminator-value'}['value']; |
|
| 318 | } |
||
| 319 | 3 | if (isset($reference->{'sort'})) { |
|
| 320 | View Code Duplication | foreach ($reference->{'sort'}->{'sort'} as $sort) { |
|
| 321 | $attr = $sort->attributes(); |
||
| 322 | $mapping['sort'][(string) $attr['field']] = isset($attr['order']) ? (string) $attr['order'] : 'asc'; |
||
| 323 | } |
||
| 324 | } |
||
| 325 | 3 | if (isset($reference->{'criteria'})) { |
|
| 326 | View Code Duplication | foreach ($reference->{'criteria'}->{'criteria'} as $criteria) { |
|
| 327 | $attr = $criteria->attributes(); |
||
| 328 | $mapping['criteria'][(string) $attr['field']] = (string) $attr['value']; |
||
| 329 | } |
||
| 330 | } |
||
| 331 | 3 | if (isset($attributes['not-saved'])) { |
|
| 332 | $mapping['notSaved'] = ('true' === (string) $attributes['not-saved']); |
||
| 333 | } |
||
| 334 | 3 | if (isset($attributes['also-load'])) { |
|
| 335 | $mapping['alsoLoadFields'] = explode(',', $attributes['also-load']); |
||
| 336 | } |
||
| 337 | 3 | $this->addFieldMapping($class, $mapping); |
|
| 338 | 3 | } |
|
| 339 | |||
| 340 | 3 | private function addIndex(ClassMetadataInfo $class, \SimpleXmlElement $xmlIndex) |
|
| 341 | { |
||
| 342 | 3 | $attributes = $xmlIndex->attributes(); |
|
| 343 | |||
| 344 | 3 | $keys = array(); |
|
| 345 | |||
| 346 | 3 | View Code Duplication | foreach ($xmlIndex->{'key'} as $key) { |
| 347 | 3 | $keys[(string) $key['name']] = isset($key['order']) ? (string) $key['order'] : 'asc'; |
|
| 348 | } |
||
| 349 | |||
| 350 | 3 | $options = array(); |
|
| 351 | |||
| 352 | 3 | if (isset($attributes['background'])) { |
|
| 353 | $options['background'] = ('true' === (string) $attributes['background']); |
||
| 354 | } |
||
| 355 | 3 | if (isset($attributes['drop-dups'])) { |
|
| 356 | $options['dropDups'] = ('true' === (string) $attributes['drop-dups']); |
||
| 357 | } |
||
| 358 | 3 | if (isset($attributes['name'])) { |
|
| 359 | $options['name'] = (string) $attributes['name']; |
||
| 360 | } |
||
| 361 | 3 | if (isset($attributes['safe'])) { |
|
| 362 | $options['safe'] = ('true' === (string) $attributes['safe']); |
||
| 363 | } |
||
| 364 | 3 | if (isset($attributes['sparse'])) { |
|
| 365 | $options['sparse'] = ('true' === (string) $attributes['sparse']); |
||
| 366 | } |
||
| 367 | 3 | if (isset($attributes['unique'])) { |
|
| 368 | 1 | $options['unique'] = ('true' === (string) $attributes['unique']); |
|
| 369 | } |
||
| 370 | |||
| 371 | 3 | View Code Duplication | if (isset($xmlIndex->{'option'})) { |
| 372 | 1 | foreach ($xmlIndex->{'option'} as $option) { |
|
| 373 | 1 | $value = (string) $option['value']; |
|
| 374 | 1 | if ($value === 'true') { |
|
| 375 | $value = true; |
||
| 376 | 1 | } elseif ($value === 'false') { |
|
| 377 | 1 | $value = false; |
|
| 378 | 1 | } elseif (is_numeric($value)) { |
|
| 379 | 1 | $value = preg_match('/^[-]?\d+$/', $value) ? (integer) $value : (float) $value; |
|
| 380 | } |
||
| 381 | 1 | $options[(string) $option['name']] = $value; |
|
| 382 | } |
||
| 383 | } |
||
| 384 | |||
| 385 | 3 | if (isset($xmlIndex->{'partial-filter-expression'})) { |
|
| 386 | 3 | $partialFilterExpressionMapping = $xmlIndex->{'partial-filter-expression'}; |
|
| 387 | |||
| 388 | 3 | if (isset($partialFilterExpressionMapping->and)) { |
|
| 389 | 2 | foreach ($partialFilterExpressionMapping->and as $and) { |
|
| 390 | 2 | if (! isset($and->field)) { |
|
| 391 | 1 | continue; |
|
| 392 | } |
||
| 393 | |||
| 394 | 2 | $partialFilterExpression = $this->getPartialFilterExpression($and->field); |
|
| 395 | 2 | if (! $partialFilterExpression) { |
|
| 396 | continue; |
||
| 397 | } |
||
| 398 | |||
| 399 | 2 | $options['partialFilterExpression']['$and'][] = $partialFilterExpression; |
|
| 400 | } |
||
| 401 | } elseif (isset($partialFilterExpressionMapping->field)) { |
||
| 402 | 2 | $partialFilterExpression = $this->getPartialFilterExpression($partialFilterExpressionMapping->field); |
|
| 403 | |||
| 404 | 2 | if ($partialFilterExpression) { |
|
| 405 | 2 | $options['partialFilterExpression'] = $partialFilterExpression; |
|
| 406 | } |
||
| 407 | } |
||
| 408 | } |
||
| 409 | |||
| 410 | 3 | $class->addIndex($keys, $options); |
|
| 411 | 3 | } |
|
| 412 | |||
| 413 | 3 | private function getPartialFilterExpression(\SimpleXMLElement $fields) |
|
| 414 | { |
||
| 415 | 3 | $partialFilterExpression = []; |
|
| 416 | 3 | foreach ($fields as $field) { |
|
| 417 | 3 | $operator = (string) $field['operator'] ?: null; |
|
| 418 | |||
| 419 | 3 | if (! isset($field['value'])) { |
|
| 420 | 1 | if (! isset($field->field)) { |
|
| 421 | continue; |
||
| 422 | } |
||
| 423 | |||
| 424 | 1 | $nestedExpression = $this->getPartialFilterExpression($field->field); |
|
| 425 | 1 | if (! $nestedExpression) { |
|
| 426 | continue; |
||
| 427 | } |
||
| 428 | |||
| 429 | 1 | $value = $nestedExpression; |
|
| 430 | } else { |
||
| 431 | 3 | $value = trim((string) $field['value']); |
|
| 432 | } |
||
| 433 | |||
| 434 | 3 | if ($value === 'true') { |
|
| 435 | $value = true; |
||
| 436 | 3 | } elseif ($value === 'false') { |
|
| 437 | $value = false; |
||
| 438 | 3 | } elseif (is_numeric($value)) { |
|
| 439 | 2 | $value = preg_match('/^[-]?\d+$/', $value) ? (integer) $value : (float) $value; |
|
| 440 | } |
||
| 441 | |||
| 442 | 3 | $partialFilterExpression[(string) $field['name']] = $operator ? ['$' . $operator => $value] : $value; |
|
| 443 | } |
||
| 444 | |||
| 445 | 3 | return $partialFilterExpression; |
|
| 446 | } |
||
| 447 | |||
| 448 | 2 | private function setShardKey(ClassMetadataInfo $class, \SimpleXmlElement $xmlShardkey) |
|
| 449 | { |
||
| 450 | 2 | $attributes = $xmlShardkey->attributes(); |
|
| 451 | |||
| 452 | 2 | $keys = array(); |
|
| 453 | 2 | $options = array(); |
|
| 454 | 2 | View Code Duplication | foreach ($xmlShardkey->{'key'} as $key) { |
| 455 | 2 | $keys[(string) $key['name']] = isset($key['order']) ? (string)$key['order'] : 'asc'; |
|
| 456 | } |
||
| 457 | |||
| 458 | 2 | if (isset($attributes['unique'])) { |
|
| 459 | 1 | $options['unique'] = ('true' === (string) $attributes['unique']); |
|
| 460 | } |
||
| 461 | |||
| 462 | 2 | if (isset($attributes['numInitialChunks'])) { |
|
| 463 | 1 | $options['numInitialChunks'] = (int) $attributes['numInitialChunks']; |
|
| 464 | } |
||
| 465 | |||
| 466 | 2 | View Code Duplication | if (isset($xmlShardkey->{'option'})) { |
| 467 | 1 | foreach ($xmlShardkey->{'option'} as $option) { |
|
| 468 | 1 | $value = (string) $option['value']; |
|
| 469 | 1 | if ($value === 'true') { |
|
| 470 | 1 | $value = true; |
|
| 471 | 1 | } elseif ($value === 'false') { |
|
| 472 | $value = false; |
||
| 473 | 1 | } elseif (is_numeric($value)) { |
|
| 474 | 1 | $value = preg_match('/^[-]?\d+$/', $value) ? (integer) $value : (float) $value; |
|
| 475 | } |
||
| 476 | 1 | $options[(string) $option['name']] = $value; |
|
| 477 | } |
||
| 478 | } |
||
| 479 | |||
| 480 | 2 | $class->setShardKey($keys, $options); |
|
| 481 | 2 | } |
|
| 482 | |||
| 483 | /** |
||
| 484 | * {@inheritDoc} |
||
| 485 | */ |
||
| 486 | 8 | protected function loadMappingFile($file) |
|
| 502 | } |
||
| 503 |
Loading history...
If you access a property on an interface, you most likely code against a concrete implementation of the interface.
Available Fixes
Adding an additional type check:
Changing the type hint: