TableStatus::isUpToDate() - Code Metrics - Inspection of "Reorganize classes for 2.0" - doctrine/migrations - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#707)

by Jonathan

created 2018-05-31 14:56 UTC

TableStatus::isUpToDate() A

↳ Parent: TableStatus

Complexity

Conditions	4
Paths	4

Size

Total Lines	20
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	10
nc	4
nop	0
dl	0
loc	20
ccs	11
cts	11
cp	1
crap	4
rs	9.2
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Doctrine\Migrations\Tracking;

use Doctrine\DBAL\Schema\AbstractSchemaManager;

class TableStatus
{
    /** @var AbstractSchemaManager */
    private $schemaManager;

    /** @var TableDefinition */
    private $migrationTable;

    /** @var bool|null */
    private $created;

    /** @var bool|null */
    private $upToDate;

    public function __construct(
        AbstractSchemaManager $schemaManager,
        TableDefinition $migrationTable
    ) {
        $this->schemaManager  = $schemaManager;
        $this->migrationTable = $migrationTable;
    }

    public function setCreated(bool $created) : void
    {
        $this->created = $created;
    }

    public function isCreated() : bool
    {
        if ($this->created !== null) {
            return $this->created;
        }

        $this->created = $this->schemaManager->tablesExist([$this->migrationTable->getName()]);

        return $this->created;
    }

    public function setUpToDate(bool $upToDate) : void
    {
        $this->upToDate = $upToDate;
    }

    public function isUpToDate() : bool
    {
        if ($this->upToDate !== null) {
            return $this->upToDate;
        }

        $table = $this->schemaManager->listTableDetails($this->migrationTable->getName());

        $this->upToDate = true;

        foreach ($this->migrationTable->getColumnNames() as $columnName) {
            if ($table->hasColumn($columnName)) {
                continue;
            }

            $this->upToDate = false;
            break;
        }

        return $this->upToDate;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\Migrations\Tracking;
6
7		use Doctrine\DBAL\Schema\AbstractSchemaManager;
8
9		class TableStatus
10		{
11		/** @var AbstractSchemaManager */
12		private $schemaManager;
13
14		/** @var TableDefinition */
15		private $migrationTable;
16
17		/** @var bool\|null */
18		private $created;
19
20		/** @var bool\|null */
21		private $upToDate;
22
23	82	public function __construct(
24		AbstractSchemaManager $schemaManager,
25		TableDefinition $migrationTable
26		) {
27	82	$this->schemaManager = $schemaManager;
28	82	$this->migrationTable = $migrationTable;
29	82	}
30
31	76	public function setCreated(bool $created) : void
32		{
33	76	$this->created = $created;
34	76	}
35
36	79	public function isCreated() : bool
37		{
38	79	if ($this->created !== null) {
39	65	return $this->created;
40		}
41
42	78	$this->created = $this->schemaManager->tablesExist([$this->migrationTable->getName()]);
43
44	78	return $this->created;
45		}
46
47	2	public function setUpToDate(bool $upToDate) : void
48		{
49	2	$this->upToDate = $upToDate;
50	2	}
51
52	62	public function isUpToDate() : bool
53		{
54	62	if ($this->upToDate !== null) {
55	53	return $this->upToDate;
56		}
57
58	61	$table = $this->schemaManager->listTableDetails($this->migrationTable->getName());
59
60	61	$this->upToDate = true;
61
62	61	foreach ($this->migrationTable->getColumnNames() as $columnName) {
63	61	if ($table->hasColumn($columnName)) {
64	61	continue;
65		}
66
67	2	$this->upToDate = false;
68	2	break;
69		}
70
71	61	return $this->upToDate;
72		}
73		}
74

doctrine / migrations

Pull Request — master (#707)

TableStatus::isUpToDate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like