Finder::loadMigrations() - Code Metrics - Inspection of "Doctrine Migrations 2.0" - doctrine/migrations - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#617)

by Jonathan

created 2018-05-05 22:29 UTC

Finder::loadMigrations() A

↳ Parent: Finder

Complexity

Conditions	3
Paths	3

Size

Total Lines	23
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	13
nc	3
nop	2
dl	0
loc	23
ccs	13
cts	13
cp	1
crap	3
rs	9.0856
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Doctrine\DBAL\Migrations\Finder;

use InvalidArgumentException;
use const PHP_EOL;
use function basename;
use function is_dir;
use function realpath;
use function sprintf;
use function substr;
use function uasort;

abstract class Finder implements MigrationFinder
{
    protected static function requireOnce(string $path) : void
    {
        require_once $path;
    }

    protected function getRealPath(string $directory) : string
    {
        $dir = realpath($directory);

        if ($dir === false || ! is_dir($dir)) {
            throw new InvalidArgumentException(sprintf(
                'Cannot load migrations from "%s" because it is not a valid directory',
                $directory
            ));
        }

        return $dir;
    }

    /**
     * @param string[] $files
     *
     * @return string[]
     */
    protected function loadMigrations(array $files, ?string $namespace) : array
    {
        $migrations = [];

        uasort($files, $this->getFileSortCallback());

        foreach ($files as $file) {
            static::requireOnce($file);
            $className = basename($file, '.php');
            $version   = (string) substr($className, 7);

            if ($version === '0') {
                throw new InvalidArgumentException(sprintf(
                    'Cannot load a migrations with the name "%s" because it is a reserved number by doctrine migrations' . PHP_EOL .
                    'It\'s used to revert all migrations including the first one.',
                    $version
                ));
            }

            $migrations[$version] = sprintf('%s\\%s', $namespace, $className);
        }

        return $migrations;
    }

    protected function getFileSortCallback() : callable
    {
        return function (string $a, string $b) {
            return (basename($a) < basename($b)) ? -1 : 1;
        };
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\DBAL\Migrations\Finder;
6
7		use InvalidArgumentException;
8		use const PHP_EOL;
9		use function basename;
10		use function is_dir;
11		use function realpath;
12		use function sprintf;
13		use function substr;
14		use function uasort;
15
16		abstract class Finder implements MigrationFinder
17		{
18	35	protected static function requireOnce(string $path) : void
19		{
20	35	require_once $path;
21	35	}
22
23	95	protected function getRealPath(string $directory) : string
24		{
25	95	$dir = realpath($directory);
26
27	95	if ($dir === false \|\| ! is_dir($dir)) {
28	4	throw new InvalidArgumentException(sprintf(
29	4	'Cannot load migrations from "%s" because it is not a valid directory',
30	4	$directory
31		));
32		}
33
34	91	return $dir;
35		}
36
37		/**
38		* @param string[] $files
39		*
40		* @return string[]
41		*/
42	91	protected function loadMigrations(array $files, ?string $namespace) : array
43		{
44	91	$migrations = [];
45
46	91	uasort($files, $this->getFileSortCallback());
47
48	91	foreach ($files as $file) {
49	35	static::requireOnce($file);
50	35	$className = basename($file, '.php');
51	35	$version = (string) substr($className, 7);
52
53	35	if ($version === '0') {
54	1	throw new InvalidArgumentException(sprintf(
55		'Cannot load a migrations with the name "%s" because it is a reserved number by doctrine migrations' . PHP_EOL .
56	1	'It\'s used to revert all migrations including the first one.',
57	1	$version
58		));
59		}
60
61	34	$migrations[$version] = sprintf('%s\\%s', $namespace, $className);
62		}
63
64	90	return $migrations;
65		}
66
67	91	protected function getFileSortCallback() : callable
68		{
69		return function (string $a, string $b) {
70	26	return (basename($a) < basename($b)) ? -1 : 1;
71	91	};
72		}
73		}
74

doctrine / migrations

Pull Request — master (#617)

Finder::loadMigrations() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like