Version::getExecutedAt() - Code Metrics - Inspection of "Record when a migration was executed." - doctrine/migrations - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#675)

by Jonathan

created 2018-05-16 16:20 UTC

Version::getExecutedAt() A

↳ Parent: Version

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	0
dl	0
loc	8
ccs	6
cts	6
cp	1
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Doctrine\Migrations;

use DateTimeImmutable;
use Doctrine\DBAL\Connection;
use Doctrine\DBAL\Types\Type;
use Doctrine\Migrations\Configuration\Configuration;
use Doctrine\Migrations\Exception\MigrationNotConvertibleToSql;
use function assert;
use function count;
use function in_array;
use function str_replace;

class Version implements VersionInterface
{
    /** @var Configuration */
    private $configuration;

    /** @var OutputWriter */
    private $outputWriter;

    /** @var string */
    private $version;

    /** @var AbstractMigration */
    private $migration;

    /** @var Connection */
    private $connection;

    /** @var string */
    private $class;

    /** @var int */
    private $state = VersionState::NONE;

    /** @var VersionExecutorInterface */
    private $versionExecutor;

    public function __construct(
        Configuration $configuration,
        string $version,
        string $class,
        VersionExecutorInterface $versionExecutor
    ) {
        $this->configuration   = $configuration;
        $this->outputWriter    = $configuration->getOutputWriter();
        $this->class           = $class;
        $this->connection      = $configuration->getConnection();
        $this->migration       = new $class($this);
        $this->version         = $version;
        $this->versionExecutor = $versionExecutor;
    }

    public function __toString() : string
    {
        return $this->version;
    }

    public function getVersion() : string
    {
        return $this->version;
    }

    public function getDateTime() : string
    {
        $datetime = str_replace('Version', '', $this->version);
        $datetime = DateTimeImmutable::createFromFormat('YmdHis', $datetime);

        if ($datetime === false) {
            return '';
        }

        return $datetime->format('Y-m-d H:i:s');
    }

    public function getConfiguration() : Configuration
    {
        return $this->configuration;
    }

    public function getMigration() : AbstractMigration
    {
        return $this->migration;
    }

    public function isMigrated() : bool
    {
        return $this->configuration->hasVersionMigrated($this);
    }

    public function getExecutedAt() : ?DateTimeImmutable
    {
        $versionData          = $this->configuration->getVersionData($this);
        $executedAtColumnName = $this->configuration->getMigrationsExecutedAtColumnName();

        return isset($versionData[$executedAtColumnName])
            ? new DateTimeImmutable($versionData[$executedAtColumnName])
            : null;
    }

    public function setState(int $state) : void
    {
        assert(in_array($state, VersionState::STATES, true));

        $this->state = $state;
    }

    public function getExecutionState() : string
    {
        switch ($this->state) {
            case VersionState::PRE:
                return 'Pre-Checks';

            case VersionState::POST:
                return 'Post-Checks';

            case VersionState::EXEC:
                return 'Execution';

            default:
                return 'No State';
        }
    }

    /**
     * @param mixed[] $params
     * @param mixed[] $types
     */
    public function addSql(string $sql, array $params = [], array $types = []) : void
    {
        $this->versionExecutor->addSql($sql, $params, $types);
    }

    public function writeSqlFile(
        string $path,
        string $direction = VersionDirection::UP
    ) : bool {
        $versionExecutionResult = $this->execute($direction, true);

        if (count($versionExecutionResult->getParams()) !== 0) {
            throw MigrationNotConvertibleToSql::new($this->class);
        }

        $this->outputWriter->write("\n-- Version " . $this->version . "\n");

        $sqlQueries = [$this->version => $versionExecutionResult->getSql()];

        /*
         * Since the configuration object changes during the creation we cannot inject things
         * properly, so I had to violate LoD here (so please, let's find a way to solve it on v2).
         */
        return $this->configuration
            ->getQueryWriter()
            ->write($path, $direction, $sqlQueries);
    }

    public function execute(
        string $direction,
        bool $dryRun = false,
        bool $timeAllQueries = false
    ) : VersionExecutionResult {
        return $this->versionExecutor->execute(
            $this,
            $this->migration,
            $direction,
            $dryRun,
            $timeAllQueries
        );
    }

    public function markMigrated() : void
    {
        $this->markVersion(VersionDirection::UP);
    }

    public function markNotMigrated() : void
    {
        $this->markVersion(VersionDirection::DOWN);
    }

    public function markVersion(string $direction) : void
    {
        $this->configuration->createMigrationTable();

        $migrationsColumnName = $this->configuration
            ->getQuotedMigrationsColumnName();

        $migrationsExecutedAtColumnName = $this->configuration
            ->getQuotedMigrationsExecutedAtColumnName();

        if ($direction === VersionDirection::UP) {
            $this->connection->insert(
                $this->configuration->getMigrationsTableName(),
                [
                    $migrationsColumnName => $this->version,
                    $migrationsExecutedAtColumnName => $this->getExecutedAtDatabaseValue(),
                ]
            );
        } else {
            $this->connection->delete(
                $this->configuration->getMigrationsTableName(),
                [
                    $migrationsColumnName => $this->version,
                ]
            );
        }
    }

    private function getExecutedAtDatabaseValue() : string
    {
        return Type::getType(MigrationTable::MIGRATION_EXECUTED_AT_COLUMN_TYPE)->convertToDatabaseValue(

            new DateTimeImmutable(),
            $this->connection->getDatabasePlatform()
        );
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\Migrations;
6
7		use DateTimeImmutable;
8		use Doctrine\DBAL\Connection;
9		use Doctrine\DBAL\Types\Type;
10		use Doctrine\Migrations\Configuration\Configuration;
11		use Doctrine\Migrations\Exception\MigrationNotConvertibleToSql;
12		use function assert;
13		use function count;
14		use function in_array;
15		use function str_replace;
16
17		class Version implements VersionInterface
18		{
19		/** @var Configuration */
20		private $configuration;
21
22		/** @var OutputWriter */
23		private $outputWriter;
24
25		/** @var string */
26		private $version;
27
28		/** @var AbstractMigration */
29		private $migration;
30
31		/** @var Connection */
32		private $connection;
33
34		/** @var string */
35		private $class;
36
37		/** @var int */
38		private $state = VersionState::NONE;
39
40		/** @var VersionExecutorInterface */
41		private $versionExecutor;
42
43	125	public function __construct(
44		Configuration $configuration,
45		string $version,
46		string $class,
47		VersionExecutorInterface $versionExecutor
48		) {
49	125	$this->configuration = $configuration;
50	125	$this->outputWriter = $configuration->getOutputWriter();
51	125	$this->class = $class;
52	125	$this->connection = $configuration->getConnection();
53	125	$this->migration = new $class($this);
54	125	$this->version = $version;
55	125	$this->versionExecutor = $versionExecutor;
56	125	}
57
58	54	public function __toString() : string
59		{
60	54	return $this->version;
61		}
62
63	79	public function getVersion() : string
64		{
65	79	return $this->version;
66		}
67
68	1	public function getDateTime() : string
69		{
70	1	$datetime = str_replace('Version', '', $this->version);
71	1	$datetime = DateTimeImmutable::createFromFormat('YmdHis', $datetime);
72
73	1	if ($datetime === false) {
74	1	return '';
75		}
76
77	1	return $datetime->format('Y-m-d H:i:s');
78		}
79
80	125	public function getConfiguration() : Configuration
81		{
82	125	return $this->configuration;
83		}
84
85	14	public function getMigration() : AbstractMigration
86		{
87	14	return $this->migration;
88		}
89
90	16	public function isMigrated() : bool
91		{
92	16	return $this->configuration->hasVersionMigrated($this);
93		}
94
95	1	public function getExecutedAt() : ?DateTimeImmutable
96		{
97	1	$versionData = $this->configuration->getVersionData($this);
98	1	$executedAtColumnName = $this->configuration->getMigrationsExecutedAtColumnName();
99
100	1	return isset($versionData[$executedAtColumnName])
101	1	? new DateTimeImmutable($versionData[$executedAtColumnName])
102	1	: null;
103		}
104
105	54	public function setState(int $state) : void
106		{
107	54	assert(in_array($state, VersionState::STATES, true));
108
109	54	$this->state = $state;
110	54	}
111
112	10	public function getExecutionState() : string
113		{
114	10	switch ($this->state) {
115	10	case VersionState::PRE:
116	1	return 'Pre-Checks';
117
118	9	case VersionState::POST:
119	1	return 'Post-Checks';
120
121	8	case VersionState::EXEC:
122	2	return 'Execution';
123
124		default:
125	6	return 'No State';
126		}
127		}
128
129		/**
130		* @param mixed[] $params
131		* @param mixed[] $types
132		*/
133	32	public function addSql(string $sql, array $params = [], array $types = []) : void
134		{
135	32	$this->versionExecutor->addSql($sql, $params, $types);
136	32	}
137
138	9	public function writeSqlFile(
139		string $path,
140		string $direction = VersionDirection::UP
141		) : bool {
142	9	$versionExecutionResult = $this->execute($direction, true);
143
144	9	if (count($versionExecutionResult->getParams()) !== 0) {
145	1	throw MigrationNotConvertibleToSql::new($this->class);
146		}
147
148	8	$this->outputWriter->write("\n-- Version " . $this->version . "\n");
149
150	8	$sqlQueries = [$this->version => $versionExecutionResult->getSql()];
151
152		/*
153		* Since the configuration object changes during the creation we cannot inject things
154		* properly, so I had to violate LoD here (so please, let's find a way to solve it on v2).
155		*/
156	8	return $this->configuration
157	8	->getQueryWriter()
158	8	->write($path, $direction, $sqlQueries);
159		}
160
161	52	public function execute(
162		string $direction,
163		bool $dryRun = false,
164		bool $timeAllQueries = false
165		) : VersionExecutionResult {
166	52	return $this->versionExecutor->execute(
167	52	$this,
168	52	$this->migration,
169	52	$direction,
170	52	$dryRun,
171	52	$timeAllQueries
172		);
173		}
174
175	11	public function markMigrated() : void
176		{
177	11	$this->markVersion(VersionDirection::UP);
178	11	}
179
180	3	public function markNotMigrated() : void
181		{
182	3	$this->markVersion(VersionDirection::DOWN);
183	3	}
184
185	46	public function markVersion(string $direction) : void
186		{
187	46	$this->configuration->createMigrationTable();
188
189	46	$migrationsColumnName = $this->configuration
190	46	->getQuotedMigrationsColumnName();
191
192	46	$migrationsExecutedAtColumnName = $this->configuration
193	46	->getQuotedMigrationsExecutedAtColumnName();
194
195	46	if ($direction === VersionDirection::UP) {
196	45	$this->connection->insert(
197	45	$this->configuration->getMigrationsTableName(),
198		[
199	45	$migrationsColumnName => $this->version,
200	45	$migrationsExecutedAtColumnName => $this->getExecutedAtDatabaseValue(),
201		]
202		);
203		} else {
204	10	$this->connection->delete(
205	10	$this->configuration->getMigrationsTableName(),
206		[
207	10	$migrationsColumnName => $this->version,
208		]
209		);
210		}
211	46	}
212
213	45	private function getExecutedAtDatabaseValue() : string
214		{
215	45	return Type::getType(MigrationTable::MIGRATION_EXECUTED_AT_COLUMN_TYPE)->convertToDatabaseValue(
		0 ignored issues – show Bug Best Practice introduced 2018-05-15 23:27 UTC by Report Bug Copy Issue Report The expression `return Doctrine\DBAL\Typ...>getDatabasePlatform())` returns the type `DateTimeImmutable` which is incompatible with the type-hinted return `string`. Loading history...
216	45	new DateTimeImmutable(),
217	45	$this->connection->getDatabasePlatform()
218		);
219		}
220		}
221

doctrine / migrations

Pull Request — master (#675)

Version::getExecutedAt() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like