Passed
Pull Request — master (#555)
by Alexander
06:10
created
lib/Doctrine/DBAL/Migrations/MigrationsVersion.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,6 +42,6 @@
 block discarded – undo
42 42
      */
43 43
     private static function isACustomPharBuild($gitversion)
44 44
     {
45
-        return $gitversion !== '@' . 'git-version@';
45
+        return $gitversion !== '@'.'git-version@';
46 46
     }
47 47
 }
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Migrations/Provider/OrmSchemaProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
 
38 38
     public function __construct($em)
39 39
     {
40
-        if ( ! $this->isEntityManager($em)) {
40
+        if (!$this->isEntityManager($em)) {
41 41
             throw new \InvalidArgumentException(sprintf(
42 42
                 '$em is not a valid Doctrine ORM Entity Manager, got "%s"',
43 43
                 is_object($em) ? get_class($em) : gettype($em)
Please login to merge, or discard this patch.
Doctrine/DBAL/Migrations/Tools/Console/Helper/MigrationDirectoryHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
         $dir = $dir ? $dir : getcwd();
47 47
         $dir = rtrim($dir, '/');
48 48
 
49
-        if ( ! file_exists($dir)) {
49
+        if (!file_exists($dir)) {
50 50
             throw new \InvalidArgumentException(sprintf('Migrations directory "%s" does not exist.', $dir));
51 51
         }
52 52
 
@@ -64,12 +64,12 @@  discard block
 block discarded – undo
64 64
 
65 65
     private function appendDir($dir)
66 66
     {
67
-        return DIRECTORY_SEPARATOR . $dir;
67
+        return DIRECTORY_SEPARATOR.$dir;
68 68
     }
69 69
 
70 70
     private function createDirIfNotExists($dir)
71 71
     {
72
-        if ( ! file_exists($dir)) {
72
+        if (!file_exists($dir)) {
73 73
             mkdir($dir, 0755, true);
74 74
         }
75 75
     }
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Migrations/Tools/Console/Command/AbstractCommand.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -77,10 +77,10 @@  discard block
 block discarded – undo
77 77
     {
78 78
         $name = $configuration->getName();
79 79
         $name = $name ? $name : 'Doctrine Database Migrations';
80
-        $name = str_repeat(' ', 20) . $name . str_repeat(' ', 20);
81
-        $output->writeln('<question>' . str_repeat(' ', strlen($name)) . '</question>');
82
-        $output->writeln('<question>' . $name . '</question>');
83
-        $output->writeln('<question>' . str_repeat(' ', strlen($name)) . '</question>');
80
+        $name = str_repeat(' ', 20).$name.str_repeat(' ', 20);
81
+        $output->writeln('<question>'.str_repeat(' ', strlen($name)).'</question>');
82
+        $output->writeln('<question>'.$name.'</question>');
83
+        $output->writeln('<question>'.str_repeat(' ', strlen($name)).'</question>');
84 84
         $output->writeln('');
85 85
     }
86 86
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      */
104 104
     protected function getMigrationConfiguration(InputInterface $input, OutputInterface $output)
105 105
     {
106
-        if ( ! $this->migrationConfiguration) {
106
+        if (!$this->migrationConfiguration) {
107 107
             if ($this->getHelperSet()->has('configuration')
108 108
                 && $this->getHelperSet()->get('configuration') instanceof ConfigurationHelper) {
109 109
                 $configHelper = $this->getHelperSet()->get('configuration');
@@ -134,8 +134,8 @@  discard block
 block discarded – undo
134 134
      */
135 135
     private function getOutputWriter(OutputInterface $output)
136 136
     {
137
-        if ( ! $this->outputWriter) {
138
-            $this->outputWriter = new OutputWriter(function ($message) use ($output) {
137
+        if (!$this->outputWriter) {
138
+            $this->outputWriter = new OutputWriter(function($message) use ($output) {
139 139
                 return $output->writeln($message);
140 140
             });
141 141
         }
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
                 new ConnectionConfigurationLoader($this->configuration),
164 164
             ]
165 165
         );
166
-        $connection  = $chainLoader->chosen();
166
+        $connection = $chainLoader->chosen();
167 167
 
168 168
         if ($connection) {
169 169
             return $this->connection = $connection;
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Migrations/Tools/Console/Command/VersionCommand.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
     {
93 93
         $this->configuration = $this->getMigrationConfiguration($input, $output);
94 94
 
95
-        if ( ! $input->getOption('add') && ! $input->getOption('delete')) {
95
+        if (!$input->getOption('add') && !$input->getOption('delete')) {
96 96
             throw new \InvalidArgumentException('You must specify whether you want to --add or --delete the specified version.');
97 97
         }
98 98
 
@@ -148,26 +148,26 @@  discard block
 block discarded – undo
148 148
 
149 149
     private function mark($version, $all = false)
150 150
     {
151
-        if ( ! $this->configuration->hasVersion($version)) {
151
+        if (!$this->configuration->hasVersion($version)) {
152 152
             throw MigrationException::unknownMigrationVersion($version);
153 153
         }
154 154
 
155 155
         $version = $this->configuration->getVersion($version);
156 156
         if ($this->markMigrated && $this->configuration->hasVersionMigrated($version)) {
157
-            if ( ! $all) {
157
+            if (!$all) {
158 158
                 throw new \InvalidArgumentException(sprintf('The version "%s" already exists in the version table.', $version));
159 159
             }
160 160
             $marked = true;
161 161
         }
162 162
 
163
-        if ( ! $this->markMigrated && ! $this->configuration->hasVersionMigrated($version)) {
164
-            if ( ! $all) {
163
+        if (!$this->markMigrated && !$this->configuration->hasVersionMigrated($version)) {
164
+            if (!$all) {
165 165
                 throw new \InvalidArgumentException(sprintf('The version "%s" does not exists in the version table.', $version));
166 166
             }
167 167
             $marked = false;
168 168
         }
169 169
 
170
-        if ( ! isset($marked)) {
170
+        if (!isset($marked)) {
171 171
             if ($this->markMigrated) {
172 172
                 $version->markMigrated();
173 173
             } else {
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Migrations/Tools/Console/Command/DiffCommand.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -93,16 +93,16 @@  discard block
 block discarded – undo
93 93
         $toSchema   = $this->getSchemaProvider()->createSchema();
94 94
 
95 95
         //Not using value from options, because filters can be set from config.yml
96
-        if ( ! $isDbalOld && $filterExpr = $conn->getConfiguration()->getFilterSchemaAssetsExpression()) {
96
+        if (!$isDbalOld && $filterExpr = $conn->getConfiguration()->getFilterSchemaAssetsExpression()) {
97 97
             foreach ($toSchema->getTables() as $table) {
98 98
                 $tableName = $table->getName();
99
-                if ( ! preg_match($filterExpr, $this->resolveTableName($tableName))) {
99
+                if (!preg_match($filterExpr, $this->resolveTableName($tableName))) {
100 100
                     $toSchema->dropTable($tableName);
101 101
                 }
102 102
             }
103 103
         }
104 104
 
105
-        $up   = $this->buildCodeFromSql(
105
+        $up = $this->buildCodeFromSql(
106 106
             $configuration,
107 107
             $fromSchema->getMigrateToSql($toSchema, $platform),
108 108
             $input->getOption('formatted'),
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
             $input->getOption('line-length')
116 116
         );
117 117
 
118
-        if ( ! $up && ! $down) {
118
+        if (!$up && !$down) {
119 119
             $output->writeln('No changes detected in your mapping information.');
120 120
 
121 121
             return;
@@ -138,9 +138,9 @@  discard block
 block discarded – undo
138 138
             }
139 139
 
140 140
             if ($formatted) {
141
-                if ( ! class_exists('\SqlFormatter')) {
141
+                if (!class_exists('\SqlFormatter')) {
142 142
                     throw new \InvalidArgumentException(
143
-                        'The "--formatted" option can only be used if the sql formatter is installed.' .
143
+                        'The "--formatted" option can only be used if the sql formatter is installed.'.
144 144
                         'Please run "composer require jdorn/sql-formatter".'
145 145
                     );
146 146
                 }
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
             $code[] = sprintf("\$this->addSql(%s);", var_export($query, true));
156 156
         }
157 157
 
158
-        if ( ! empty($code)) {
158
+        if (!empty($code)) {
159 159
             array_unshift(
160 160
                 $code,
161 161
                 sprintf(
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
 
173 173
     private function getSchemaProvider()
174 174
     {
175
-        if ( ! $this->schemaProvider) {
175
+        if (!$this->schemaProvider) {
176 176
             $this->schemaProvider = new OrmSchemaProvider($this->getHelper('entityManager')->getEntityManager());
177 177
         }
178 178
 
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Migrations/Tools/Console/Command/StatusCommand.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -64,10 +64,10 @@  discard block
 block discarded – undo
64 64
         $output->writeln("\n <info>==</info> Configuration\n");
65 65
         foreach ($infos->getMigrationsInfos() as $name => $value) {
66 66
             if ($name == 'New Migrations') {
67
-                $value = $value > 0 ? '<question>' . $value . '</question>' : 0;
67
+                $value = $value > 0 ? '<question>'.$value.'</question>' : 0;
68 68
             }
69 69
             if ($name == 'Executed Unavailable Migrations') {
70
-                $value = $value > 0 ? '<error>' . $value . '</error>' : 0;
70
+                $value = $value > 0 ? '<error>'.$value.'</error>' : 0;
71 71
             }
72 72
             $this->writeStatusInfosLineAligned($output, $name, $value);
73 73
         }
@@ -82,8 +82,8 @@  discard block
 block discarded – undo
82 82
             if (count($infos->getExecutedUnavailableMigrations())) {
83 83
                 $output->writeln("\n <info>==</info> Previously Executed Unavailable Migration Versions\n");
84 84
                 foreach ($infos->getExecutedUnavailableMigrations() as $executedUnavailableMigration) {
85
-                    $output->writeln('    <comment>>></comment> ' . $configuration->getDateTime($executedUnavailableMigration) .
86
-                        ' (<comment>' . $executedUnavailableMigration . '</comment>)');
85
+                    $output->writeln('    <comment>>></comment> '.$configuration->getDateTime($executedUnavailableMigration).
86
+                        ' (<comment>'.$executedUnavailableMigration.'</comment>)');
87 87
                 }
88 88
             }
89 89
         }
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 
92 92
     private function writeStatusInfosLineAligned(OutputInterface $output, $title, $value)
93 93
     {
94
-        $output->writeln('    <comment>>></comment> ' . $title . ': ' . str_repeat(' ', 50 - strlen($title)) . $value);
94
+        $output->writeln('    <comment>>></comment> '.$title.': '.str_repeat(' ', 50 - strlen($title)).$value);
95 95
     }
96 96
 
97 97
     private function showVersions($migrations, Configuration $configuration, OutputInterface $output)
@@ -103,15 +103,15 @@  discard block
 block discarded – undo
103 103
             $status     = $isMigrated ? '<info>migrated</info>' : '<error>not migrated</error>';
104 104
 
105 105
             $migrationDescription = $version->getMigration()->getDescription()
106
-                ? str_repeat(' ', 5) . $version->getMigration()->getDescription()
106
+                ? str_repeat(' ', 5).$version->getMigration()->getDescription()
107 107
                 : '';
108 108
 
109 109
             $formattedVersion = $configuration->getDateTime($version->getVersion());
110 110
 
111
-            $output->writeln('    <comment>>></comment> ' . $formattedVersion .
112
-                ' (<comment>' . $version->getVersion() . '</comment>)' .
113
-                str_repeat(' ', max(1, 49 - strlen($formattedVersion) - strlen($version->getVersion()))) .
114
-                $status . $migrationDescription);
111
+            $output->writeln('    <comment>>></comment> '.$formattedVersion.
112
+                ' (<comment>'.$version->getVersion().'</comment>)'.
113
+                str_repeat(' ', max(1, 49 - strlen($formattedVersion) - strlen($version->getVersion()))).
114
+                $status.$migrationDescription);
115 115
         }
116 116
     }
117 117
 }
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Migrations/Finder/AbstractFinder.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
     protected function getRealPath($directory)
35 35
     {
36 36
         $dir = realpath($directory);
37
-        if (false === $dir || ! is_dir($dir)) {
37
+        if (false === $dir || !is_dir($dir)) {
38 38
             throw new \InvalidArgumentException(sprintf(
39 39
                 'Cannot load migrations from "%s" because it is not a valid directory',
40 40
                 $directory
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
             $version   = (string) substr($className, 7);
63 63
             if ($version === '0') {
64 64
                 throw new \InvalidArgumentException(sprintf(
65
-                    'Cannot load a migrations with the name "%s" because it is a reserved number by doctrine migrations' . PHP_EOL .
65
+                    'Cannot load a migrations with the name "%s" because it is a reserved number by doctrine migrations'.PHP_EOL.
66 66
                     'It\'s used to revert all migrations including the first one.',
67 67
                     $version
68 68
                 ));
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      */
81 81
     protected function getFileSortCallback()
82 82
     {
83
-        return function ($a, $b) {
83
+        return function($a, $b) {
84 84
             return (basename($a) < basename($b)) ? -1 : 1;
85 85
         };
86 86
     }
Please login to merge, or discard this patch.
lib/Doctrine/DBAL/Migrations/Configuration/AbstractFileConfiguration.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     protected function setConfiguration(array $config)
63 63
     {
64 64
         foreach ($config as $configurationKey => $configurationValue) {
65
-            if ( ! isset($this->configurationProperties[$configurationKey])) {
65
+            if (!isset($this->configurationProperties[$configurationKey])) {
66 66
                 $msg = sprintf('Migrations configuration key "%s" does not exists.', $configurationKey);
67 67
                 throw MigrationException::configurationNotValid($msg);
68 68
             }
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
         } elseif (strcasecmp($migrationOrganisation, static::VERSIONS_ORGANIZATION_BY_YEAR_AND_MONTH) == 0) {
97 97
             $this->setMigrationsAreOrganizedByYearAndMonth();
98 98
         } else {
99
-            $msg = 'Unknown ' . var_export($migrationOrganisation, true) . ' for configuration "organize_migrations".';
99
+            $msg = 'Unknown '.var_export($migrationOrganisation, true).' for configuration "organize_migrations".';
100 100
             throw MigrationException::configurationNotValid($msg);
101 101
         }
102 102
     }
@@ -113,12 +113,12 @@  discard block
 block discarded – undo
113 113
         if ($this->loaded) {
114 114
             throw MigrationException::configurationFileAlreadyLoaded();
115 115
         }
116
-        if (file_exists($path = getcwd() . '/' . $file)) {
116
+        if (file_exists($path = getcwd().'/'.$file)) {
117 117
             $file = $path;
118 118
         }
119 119
         $this->file = $file;
120 120
 
121
-        if ( ! file_exists($file)) {
121
+        if (!file_exists($file)) {
122 122
             throw new \InvalidArgumentException('Given config file does not exist');
123 123
         }
124 124
 
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 
129 129
     protected function getDirectoryRelativeToFile($file, $input)
130 130
     {
131
-        $path = realpath(dirname($file) . '/' . $input);
131
+        $path = realpath(dirname($file).'/'.$input);
132 132
 
133 133
         return ($path !== false) ? $path : $input;
134 134
     }
Please login to merge, or discard this patch.